Re: Add TRACEs to NtCreateFile returns (second try)

2008-08-24 Thread James Hawkins
2008/8/24 Markus Hitter <[EMAIL PROTECTED]>: > +if (!attr || !attr->ObjectName) +{ +TRACE("returning STATUS_INVALID_PARAMETER\n"); +return STATUS_INVALID_PARAMETER; +} These are all very useless TRACES, except for possibly the returned handle value. You should be abl

Re: New steam survey statistics?

2008-08-24 Thread Evil Jay
I too would be interested in seeing the numbers, but I'm not sure you're going to see the correlation you expect, Scott. While Linux adoption may have grown, Valve has probably been selling just as many, if not more games to customers who already owned Windows but had never used Steam. I suppose

Re: d3dx9: Add stubs for D3DXCreateEffectxx and D3DXCreateEffectFromFilexx

2008-08-24 Thread tony . wasserka
Hi, There were quite a number of minor issues in you code: In Makefile.in: > C_SRCS = \ > d3dx9_36_main.c \ >+effect.c \ > font.c \ Use tabs here, please, as the intendation switches here on other computers. In effect.c: + * modify it under the terms of the GNU Lesser General

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-24 Thread James Hawkins
On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > Something else... I sometimes reply to patches, and right now that > seems to cause patchwatcher to complain that my mail doesn't contain a > patch. Would it be possible to do something about that? I suppose > patchwatcher

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-24 Thread Henri Verbeet
Something else... I sometimes reply to patches, and right now that seems to cause patchwatcher to complain that my mail doesn't contain a patch. Would it be possible to do something about that? I suppose patchwatcher could ignore replies without patch.

Re: Summer of code evaluations

2008-08-24 Thread Ismael Barros
On Wed, Aug 20, 2008 at 1:14 AM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > I would like to request from the mentors to fill in the final evaluation > form and from the students to give a final write up: What went well? Did > you meet the goals you set? Did you have fun? Is there anything we ca

New steam survey statistics?

2008-08-24 Thread Scott Ritchie
When we last heard from Valve a year ago, Wine had about a .4% share of the steam user base. It would be interesting to see how this has changed since then - in that time, we've both released Wine 1.0 and likely seen Linux adoption increase a great deal. Linux had doubled its desktop marketshare

Re: d3dx9: Add stubs for D3DXCreateEffectxx and D3DXCreateEffectFromFilexx

2008-08-24 Thread Henri Verbeet
2008/8/24 Busquets Pérez Luis C. <[EMAIL PROTECTED]>: > Why are you adding stubs for these? I don't think having a stub implementation is useful here.

Drawprim

2008-08-24 Thread Chris Ahrendt
>Hmm. Does the application use a fixed function texture coordinate >specified with D3DECLUSAGE_FLOAT4? > It should be simple to support this. Essentially the "int coordsToUse > = sd->u.s.texCoords[coordIdx].dwType + 1" is wrong, this needs a > better mapping: > decltype:

RE: [10/10] WineD3D: Sort out some limit confusion

2008-08-24 Thread Stefan Dösinger
> Sure, but there should be no reason to make that call either. In > pretty much every place GL_LIMITS(textures) is used, it would either > need to be replaced with the fragment pipe implementation based limit > or not be executed at all (eg. code that calls glTexEnvf or creates > dummy textures re

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-24 Thread Henri Verbeet
2008/8/24 Dan Kegel <[EMAIL PROTECTED]>: > On Sun, Aug 24, 2008 at 9:38 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> The script now forwards patches that pass all tests to the mailing list >> http://groups.google.com/group/wine-patches-filtered >> so potentially Alexandre could start looking only at

Re: [10/10] WineD3D: Sort out some limit confusion

2008-08-24 Thread Henri Verbeet
2008/8/24 Stefan Dösinger <[EMAIL PROTECTED]>: >> Ok, I wasn't sure. Wrt arbfp though, it should report 8 for >> max_textures in that case, because that's how much simultaneous >> textures d3d can address. max_textures, max_texture_stages, etc. are >> the limits for what our d3d implementation can

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-24 Thread Dan Kegel
On Sun, Aug 24, 2008 at 9:38 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > The script now forwards patches that pass all tests to the mailing list > http://groups.google.com/group/wine-patches-filtered > so potentially Alexandre could start looking only at that > list Hmm. At the moment, patchwatche

RE: [10/10] WineD3D: Sort out some limit confusion

2008-08-24 Thread Stefan Dösinger
> Ok, I wasn't sure. Wrt arbfp though, it should report 8 for > max_textures in that case, because that's how much simultaneous > textures d3d can address. max_textures, max_texture_stages, etc. are > the limits for what our d3d implementation can do, not GL. No, I don't think so. Even if we're usi

Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-24 Thread Dan Kegel
Patchwatcher now regenerates configure and makefiles after each patch, so it can handle patches that change configure.ac. I have enabled email notification to authors of patches that don't build. The script now forwards patches that pass all tests to the mailing list http://groups.google.com/grou

Re: [try 2][2/2]wined3d: Support first clipplane with ARB shaders

2008-08-24 Thread Henri Verbeet
2008/8/24 Fabian Bieler <[EMAIL PROTECTED]>: > +if (use_vs(stateblock->wineD3DDevice) && (enable ^ > supported_by_shader_backend) & enable) { Did you mean to write if (use_vs(stateblock->wineD3DDevice) && (enable & ~supported_by_shader_backend)) { there?

Re: ddraw_test crashes on windows xp sp3 (blue screen)

2008-08-24 Thread Alexander Dorofeyev
Rico Schüller wrote: > Hi, > > the attached patch solves a hard crash on my ati mobility 9600/9700 > card. The code behind the c style comments let the application crash. > The code between /* */ crash the hole system. Probably there have to be > another check for supported cards/extensions. T

Re: [Take 2] winex11.drv: Fix buffer overflow bug in X11DRV_KeyEvent()and X11DRV_ToUnicodeEx()

2008-08-24 Thread Dmitry Timoshkov
"Muneyuki Noguchi" <[EMAIL PROTECTED]> wrote: > Changes from the previous patch: > - Add a new variable STRSIZE. A define would be better IMO, or just use 64 directly, 2 places don't justify the introduction of it. > - Use HeapAlloc() and HeapFree() instead of malloc() and free(). I'd suggest t

Re: [10/10] WineD3D: Sort out some limit confusion

2008-08-24 Thread Henri Verbeet
2008/8/24 Stefan Dösinger <[EMAIL PROTECTED]>: > No, I meant to clamp it by the constant MAX_TEXTURES(=8). > gl_info->max_textures is wrong here because gl_info->max_textures could be 4, > GL_MAX_TEXTURE_COORDS could be 8. If the application uses fixed function > vertex processing and pixel shad

How should I name the Traditional Chinese resource file ?

2008-08-24 Thread Hongbo Ni
Hi, For Chinese language, there are simplified Chinese (zh_CN) and traditional Chinese (zh_TW) sublanguage. Currently all the dlls have Chinese resource named with xxx_Cn.rc for simplified, and xxx_Zh.rc for traditional Chinese. For all the programs such as notepage, simplified Chinese resourc