"Muneyuki Noguchi" <[EMAIL PROTECTED]> wrote:
> winex11.drv: Fix buffer overflow bug in X11DRV_KeyEvent() and
> X11DRV_ToUnicodeEx()
> +Str = (char *)malloc(64);
> +if (Str == NULL)
> +ERR("Failed to allocate memory!\n");
Please don't use malloc() in Wine, use win32 Heap*** APIs
"Vladimir Pankratov" <[EMAIL PROTECTED]> wrote:
> Added Russian translation.
>
> Changed files:
> dlls/kernel32/nls/winerr_rus.mc
> dlls/kernel32/kernel.rc
> dlls/kernel32/Makefile.in
Is there a reason you've used cp866 encoding instead of cp1251?
Also, this doesn't look like a translation, mess
> 2008/8/22 Stefan Dösinger <[EMAIL PROTECTED]>:
> > +glGetIntegerv(GL_MAX_TEXTURE_COORDS, &gl_max);
> > +gl_info->max_texture_coords = min(MAX_TEXTURES, gl_max);
> > +TRACE_(d3d_caps)("Max texture coords: %d\n", gl_info-
> >max_texture_coords);
> I don't know if
> Intel's windows vista graphics drivers are pretty terrible, and some
> older directdraw games won't run at all with them. I know that there
> was
> talk before about using wine's opengl-based direct3d implementation on
> windows, so I was curious if it was at all possible to do the same with
> di
On Sat, Aug 23, 2008 at 2:14 PM, Nikolay Sivov <[EMAIL PROTECTED]> wrote:
> Dan, am I right that Patchwatcher now runs a whole test suite for every
> patch?
Yes.
> I know that this situation is rather rare but still I think it make sense to
> run only tests changed by patch if this patch contains
> @@ -248,11 +248,12 @@ typedef struct {
> void (*shader_generate_vshader)(IWineD3DVertexShader *iface,
> SHADER_BUFFER *buffer);
> void (*shader_get_caps)(WINED3DDEVTYPE devtype, WineD3D_GL_Info
> *gl_info, struct shader_caps *caps);
> BOOL (*shader_conv_supported)(WINED3DFORMAT c
Dan, am I right that Patchwatcher now runs a whole test suite for every
patch?
I know that this situation is rather rare but still I think it make
sense to run only
tests changed by patch if this patch contains only test changes. I could
save some time
without any side effect.
Since all test s
You can't just declare a patch series for
the last patch, as you seem to have done here:
d3dx8, test [patch 3/3] test the relative error instead of the
absolute one to avoid rounded errors
That confuses patchwatcher (and maybe even humans).
That patch should have come first, to avoid having the
2008/8/23 Stefan Dösinger <[EMAIL PROTECTED]>:
> Does "WINED3DSURFACE_DESC desc = {0};" set all the pointers in
> WINED3DSURFACEDESC to NULL? I am not sure about this. (At some point we may
> also want to de-pointerize WINED3DSURFACEDESC like we've done with the other
> structures)
>
It initiali
I think you don't have to test a 2nd swapchain here. The initial scissor
rectangle is set in CreateDevice, so an extra call to CreateAdditionalSwapchain
afterwards shouldn't have any effect on this. I am mainly concerned by the open
source drivers here which do not always like messing with OpenG
Hi,
the attached patch solves a hard crash on my ati mobility 9600/9700
card. The code behind the c style comments let the application crash.
The code between /* */ crash the hole system. Probably there have to be
another check for supported cards/extensions.
Cheers
Rico
diff --git a/dlls/dd
Intel's windows vista graphics drivers are pretty terrible, and some
older directdraw games won't run at all with them. I know that there was
talk before about using wine's opengl-based direct3d implementation on
windows, so I was curious if it was at all possible to do the same with
directdraw
Am Samstag, 23. August 2008 18:06:20 schrieb Dan Kegel:
[snip]
> > Okay. Shall I offer a new patch? How to do this then? Is this the only
> > problem with the patch (syntactically)? To mention ... I am a git rookie
> > ...
>
> The subject line should have said something like
> winscard: implement
On Sat, Aug 23, 2008 at 8:45 AM, frechdachs69 <[EMAIL PROTECTED]>
> I am trying to prepare the winscard.dll stuff for an application written by
> me. Probably I can extract some smartcard-using code (after my application
> works) as a conformance test.
It's a common misconception that tests should
Am Samstag, 23. August 2008 16:50:46 schrieb Dan Kegel:
> Heiko wrote:
> > This is my first patch using git and also for wine.
> >
> > Please check it and let me know which things can be made better.
>
> Hi! Welcome to Wine!
>
> You probably need to include a better description,
> and some conform
On Sat, Aug 23, 2008 at 8:05 AM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> Patchwatcher notes that the conformance test fails here:
> Also: did you benchmark this change to verify it actually made
> things faster? Unrolling loops is no longer as sure-fire a win as
> it used to be. I'm inclined to p
On Sat, Aug 23, 2008 at 7:50 AM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> You can avoid the particular problem by not including a diff for 'configure'
> in the patch; the diff for configure.ac suffices.
>
> We have lots of pages (way too many) of advice for how to send
> patches at winehq.org, but th
On Mo, 2008-08-18 at 13:11 -0400, Steven Edwards wrote:
> +load_ie6() {
Nice Idea.
> +# Installing Core Fonts"
> +load_corefonts
Which Font is required (please fill bug reports)
Which Font is optional?
> +# Installing Richedit 2.0 Library"
> +load_riched20
What is needed in the b
Heiko wrote:
> This is my first patch using git and also for wine.
>
> Please check it and let me know which things can be made better.
Hi! Welcome to Wine!
You probably need to include a better description,
and some conformance tests would help, too.
(They should do basic error checking at leas
Andrew Fenn schrieb:
> I'm alittle confused, are you suggesting that if SetScissorRect
> receives a null value that if should default to the window size? or do
> you mean that perhaps GetScissorRect should call SetScissorRect and
> return a correct value instead of null?
>
No. {0,0,0,0} is a val
Just a bunch of little updates and fixes. Thanks to everyone who
pointed out the issues.
Online as always at
http://kegel.com/wine/winetricks
or
http://winezeug.googlecode.com
Changes since 20080710:
r164:
divx updated, change path and sha1sum to match.
Thanks to Graham Inggs for the nudge.
Stefan Leichter wrote:
> Am Saturday 23 August 2008 15:28 schrieb Nikolay Sivov:
>
>> I have a problem building crosstest for GDI+ call GdipFillClosedCurve2.
>>
>> I've got the following:
>>
>> graphics.cross.o: In function
>> `func_graphics':/home/mrlarch/wine/dlls/gdiplus/tests/graphics.c:593:
Am Saturday 23 August 2008 15:28 schrieb Nikolay Sivov:
> I have a problem building crosstest for GDI+ call GdipFillClosedCurve2.
>
> I've got the following:
>
> graphics.cross.o: In function
> `func_graphics':/home/mrlarch/wine/dlls/gdiplus/tests/graphics.c:593:
> undefined reference to [EMAIL PRO
I have a problem building crosstest for GDI+ call GdipFillClosedCurve2.
I've got the following:
graphics.cross.o: In function
`func_graphics':/home/mrlarch/wine/dlls/gdiplus/tests/graphics.c:593:
undefined reference to [EMAIL PROTECTED]'
collect2: ld returned 1 exit status
make[2]: *** [gdiplus
I'm alittle confused, are you suggesting that if SetScissorRect
receives a null value that if should default to the window size? or do
you mean that perhaps GetScissorRect should call SetScissorRect and
return a correct value instead of null?
If I understand you correctly it sounds like another pr
Henri Verbeet schrieb:
> 2008/8/23 Rico Schüller <[EMAIL PROTECTED]>:
>
>> Here is the patch which checks the default scissorrect. I don't know if the
>> resolutions are to big (1024x768). And I don't know if the stuff with the
>> second swapchain (swapchain1) is correct. It produces this error
Patchwatcher notes that the conformance test fails here:
../../../tools/runtest -q -P wine -M d3dx8.dll -T ../../.. -p
d3dx8_test.exe.so math.c && touch math.ok
math.c:442: Test failed: Expected matrix=
(-0.214800,1.311600,0.475200,0.00
0.950400,-0.883600,0.924400,0.00
1.021200,0.193600,
2008/8/23 Rico Schüller <[EMAIL PROTECTED]>:
> Here is the patch which checks the default scissorrect. I don't know if the
> resolutions are to big (1024x768). And I don't know if the stuff with the
> second swapchain (swapchain1) is correct. It produces this error in wine:
> "err:d3d:IWineD3DDevic
2008/8/23 Henri Verbeet <[EMAIL PROTECTED]>:
> 2008/8/22 Stefan Dösinger <[EMAIL PROTECTED]>:
>> +glGetIntegerv(GL_MAX_TEXTURE_COORDS, &gl_max);
>> +gl_info->max_texture_coords = min(MAX_TEXTURES, gl_max);
>> +TRACE_(d3d_caps)("Max texture coords: %d\n",
>> gl_i
2008/8/22 Stefan Dösinger <[EMAIL PROTECTED]>:
> +glGetIntegerv(GL_MAX_TEXTURE_COORDS, &gl_max);
> +gl_info->max_texture_coords = min(MAX_TEXTURES, gl_max);
> +TRACE_(d3d_caps)("Max texture coords: %d\n",
> gl_info->max_texture_coords);
I don't know if this is i
Stefan Dösinger schrieb:
Are you sure you shouldn't be using the primary swapchain's
backbuffer
dimensions?
I'm not sure what exactly you mean.
Something like this:
IWineD3DSwapChain *swapchain;
IWineD3DSurface *backbuffer;
D3DSURFACE_DESC desc;
IWineD3DDevice_GetSwa
31 matches
Mail list logo
