>
>This patch fixes Bug 14784.
>
>As requested by Dmitry Timoshkov, I have created a standalone test case
>for DLL injection via SetWindowHookEx. It has been attached in Bug 14784
>with MSVC source code and compiled exe and dll.
>
>With LoadLibraryExW(module, NULL, LOAD_WITH_ALTERED_SEARCH_PATH)
At 03:25 AM 2008-08-20, Dan Kegel wrote:
>Hongbo, it looks like your patch failed to apply because you did not
>preserve whitespace exactly. Your patch uses all spaces
>for the context, but the file contains tabs, so it does not match,
>and patch fails.
Thank you Dan, and thanks to Patchwatcher.
2008/8/19 Markus Hitter <[EMAIL PROTECTED]>:
>
> Am 19.08.2008 um 00:41 schrieb James Hawkins:
>
>> when the patch doesn't get committed, you should look back at it
>> and really think
>> outside the box about what could possibly be wrong with the patch.
>
> Essentially, you ask to change code on u
"Louis. Lenders" <[EMAIL PROTECTED]> wrote:
> @@ -1613,6 +1613,7 @@ HWND WINAPI FindWindowExW( HWND parent, HWND child,
> LPCWSTR className, LPCWSTR t
> done:
> HeapFree( GetProcessHeap(), 0, list );
> HeapFree( GetProcessHeap(), 0, buffer );
> +if(!retvalue) SetLastError(ERROR_FI
"Scott Lindeneau" <[EMAIL PROTECTED]> wrote:
> I would like to submit the following AcceptEx conformance test to
> wine-patches, but I don't have a windows box (and i haven't got qemu
> setup(correctly) yet). Would someone run this and let me know how/if
> it failes (or succeeds... it should succe
On Mon, Aug 18, 2008 at 4:08 PM, Lei Zhang <[EMAIL PROTECTED]> wrote:
> Hi,
>
> This should fix bug 14908.
>
Any problems with this patch?
På Onsdag 20 august 2008 , 20:09:40 skrev du:
> Alexander Nicolaysen Sørnes a écrit :
> > På Onsdag 20 august 2008 , 19:30:44 skrev Eric Pouech:
> >> Alexandre Julliard a écrit :
> >>> Module: wine
> >>> Branch: master
> >>> Commit: 5cb8bccf462790338677dac3bfb394df8f4da020
> >>> URL:
> >>> http://s
Hi Scott. A few notes about your patch series.
There should be no forward references in the patches;
you can't have patch 1 depend on patch 2.
Also, don't send two versions of tests, one for Wine and
one for Windows; the same code has to work in both places.
You can't even use an ifdef, since th
On Thu, Aug 21, 2008 at 05:54:07AM +0900, Scott Lindeneau wrote:
> Guh. Ill figure it out eventually I guess. Which tabs are you talking
> about in particular? All of them?
Yes, just stick with spaces, and it seems the convention is four spaces
per indentation level.
Guh. Ill figure it out eventually I guess. Which tabs are you talking
about in particular? All of them?
On Thu, Aug 21, 2008 at 5:48 AM, Dan Hipschman <[EMAIL PROTECTED]> wrote:
> On Thu, Aug 21, 2008 at 04:25:07AM +0900, Scott Lindeneau wrote:
>> Sorry about not knowing how to cross compile befor
On Thu, Aug 21, 2008 at 04:25:07AM +0900, Scott Lindeneau wrote:
> Sorry about not knowing how to cross compile before. Here is the
> patch(gmail doesn't let me attach exe's... I will look into this).
> Please try this. Tell me if I am doing something wrong (again).
Thanks for working on this. Be
Thanks. I'll typecast the warnings out or write a new macro for wsa_ok
-Scott
On Thu, Aug 21, 2008 at 4:42 AM, Austin English <[EMAIL PROTECTED]> wrote:
> On Wed, Aug 20, 2008 at 2:25 PM, Scott Lindeneau <[EMAIL PROTECTED]> wrote:
>> Sorry about not knowing how to cross compile before. Here is th
On Wed, Aug 20, 2008 at 2:25 PM, Scott Lindeneau <[EMAIL PROTECTED]> wrote:
> Sorry about not knowing how to cross compile before. Here is the
> patch(gmail doesn't let me attach exe's... I will look into this).
> Please try this. Tell me if I am doing something wrong (again).
>
> -Scott
>
Got som
Sorry about not knowing how to cross compile before. Here is the
patch(gmail doesn't let me attach exe's... I will look into this).
Please try this. Tell me if I am doing something wrong (again).
-Scott
From 3a7d296ed2184fd22b70d96880afc86927801ab7 Mon Sep 17 00:00:00 2001
From: Scott Lindeneau <[
http://kegel.com/wine/patchwatcher/results/ says you
forgot to include the new file
include/d3dx9mesh.h
this time; you included it in
http://www.winehq.org/pipermail/wine-patches/2008-August/059261.html
but some how dropped it when you resent?
Alexander Nicolaysen Sørnes a écrit :
> På Onsdag 20 august 2008 , 19:30:44 skrev Eric Pouech:
>
>> Alexandre Julliard a écrit :
>>
>>> Module: wine
>>> Branch: master
>>> Commit: 5cb8bccf462790338677dac3bfb394df8f4da020
>>> URL:
>>> http://source.winehq.org/git/wine.git/?a=commit;h=5cb8
Am Mittwoch, den 20.08.2008, 19:55 +0200 schrieb Alexander Nicolaysen
Sørnes:
> > > +const WCHAR empty = 0;
> > > +PrintRegistryHive(hWnd, empty);
>
> to send an empty string?
It is. This sends a NULL pointer (empty is 0, converted to a pointer is
a NULL pointer). You mean "&empty
På Onsdag 20 august 2008 , 19:30:44 skrev Eric Pouech:
> Alexandre Julliard a écrit :
> > Module: wine
> > Branch: master
> > Commit: 5cb8bccf462790338677dac3bfb394df8f4da020
> > URL:
> > http://source.winehq.org/git/wine.git/?a=commit;h=5cb8bccf462790338677dac
> >3bfb394df8f4da020
> >
> > Autho
It did. I wrote the test using a different set of patches which let it
compile with wine. I will look up how to cross compile it and do that
next time. Sorry for the inconvenience.
On Thu, Aug 21, 2008 at 2:36 AM, Austin English <[EMAIL PROTECTED]> wrote:
> On Wed, Aug 20, 2008 at 12:34 PM, Scott
Hi Eric,
>> +ok(!memcmp(got->SignerId.IssuerSerialNumber.Issuer.pbData,
>> + got->SignerId.IssuerSerialNumber.Issuer.pbData,
> shouldn't it be expected->SignerId.IssuerSerialNumber.Issuer.pbData,
Yes, certainly. Thanks for spotting these, I sent a new patch.
--Juan
Juan Lang a écrit :
> --Juan
>
>
> From 7eaf8a741cc4ff2035491f36ba9b8f7c5d650458 Mon Sep 17 00:00:00 2001
> From: Juan Lang <[EMAIL PROTECTED]>
> Date: Mon, 18 Aug 2008 13:09:24 -0700
> Subject: [PATCH] Add tests for CMSG_CMS
Alexandre Julliard a écrit :
> Module: wine
> Branch: master
> Commit: 5cb8bccf462790338677dac3bfb394df8f4da020
> URL:
> http://source.winehq.org/git/wine.git/?a=commit;h=5cb8bccf462790338677dac3bfb394df8f4da020
>
> Author: Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]>
> Date: Sun Aug 10 12
On Wed, Aug 20, 2008 at 12:23 PM, Scott Lindeneau <[EMAIL PROTECTED]> wrote:
> I would like to submit the following AcceptEx conformance test to
> wine-patches, but I don't have a windows box (and i haven't got qemu
> setup(correctly) yet). Would someone run this and let me know how/if
> it failes
I would like to submit the following AcceptEx conformance test to
wine-patches, but I don't have a windows box (and i haven't got qemu
setup(correctly) yet). Would someone run this and let me know how/if
it failes (or succeeds... it should succeed).
Thanks
- Scott
From 00a1b8b04f99cfae3b77f6362068
The async bug was revealed as I was writing the acceptex tests. The
only observable effect was a thread hanging because it never gets
notified. I don't know how/where to write conformance tests for the
wineserver core.
> If you can write a conformance test to expose the bug,
> then please send that
Scott Lindeneau <[EMAIL PROTECTED]> wrote:
> The problem was related to a bug in the
> wineserver async implementation that appeared when a file descriptor
> handled its own polling events (like sockets) and garbage collection.
> Fixing the bug fixes the problem i was having earlier. Should I
> inc
> Ah. My apologies. My question was related to writing the
> implementation of acceptex. I have recently solved the problem and the
> question is now moot. The problem was related to a bug in the
> wineserver async implementation that appeared when a file descriptor
> handled its own polling events
> ?? Not sure what you're talking about there. Your tests
> should not try to get at any hidden Wine info. They
> should simply use plain old Windows networking calls
> that should not complicate the wineserver.
> - Dan
Ah. My apologies. My question was related to writing the
implementation of
Scott Lindeneau <[EMAIL PROTECTED]> wrote:
> Is an emulated environment using qemu good enough?
Yes, for networking stuff it'd be just fine.
>>>If anyone can tell me how to check to see if there are connections
>>>pending on a sockets listen backlog (in the wineserver) and how to
>>>post that in
On Wed, Aug 20, 2008 at 7:48 AM, Scott Lindeneau <[EMAIL PROTECTED]> wrote:
> On Tue, Aug 19, 2008 at 9:15 AM, Dan Kegel <[EMAIL PROTECTED]> wrote:
>> Scott Lindeneau <[EMAIL PROTECTED]> wrote:
>>> i Don't have any windows machines to test the code on
>>
>> That's a real problem. You can't be sur
> > +static BOOL recursive = FALSE;
>
> That static looks very suspicious. It should either be stored in the
> object or use some sort of locking.
Well, there is locking, it is done by the client library(ddraw, d3d8, d3d9).
Still storing this in the object is a good idea I think
Hi all,
> I would like to request from the mentors to fill in the final evaluation
> form and from the students to give a final write up: What went well? Did
> you meet the goals you set? Did you have fun? Is there anything we can
> do to make wines summer of code better and do you feel like you'v
Thanks for the review! I've sent a new patch
På Onsdag 20 august 2008 , 12:46:38 skrev du:
> Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes:
> > +static HRESULT WINAPI IDirectPlay8PeerImpl_Initialize(PDIRECTPLAY8PEER
> > iface, PVOID CONST pvUserContext, CONST PFNDPNMESSAGEHANDLER pfn, CO
Stefan Dösinger <[EMAIL PROTECTED]> writes:
> @@ -4550,13 +4558,22 @@ static WINED3DSURFTYPE WINAPI
> IWineD3DSurfaceImpl_GetImplType(IWineD3DSurface *i
> static HRESULT WINAPI IWineD3DSurfaceImpl_DrawOverlay(IWineD3DSurface
> *iface) {
> IWineD3DSurfaceImpl *This = (IWineD3DSurfaceImpl *)
On Tue, Aug 19, 2008 at 9:15 AM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> Scott Lindeneau <[EMAIL PROTECTED]> wrote:
>> i Don't have any windows machines to test the code on
>
> That's a real problem. You can't be sure the tests you're
> writing are good unless they pass on a windows machine.
Is a
Michael Karcher <[EMAIL PROTECTED]> writes:
> In commit 48bb687dfb00b00f789b688459ad5d0ec77a617b, win9x detection was
> changed to use the desktop window instead of a private EDIT window as
> target for GetWindowLongW. GetWindowLongW(GetDesktopWindow(),GWLP_WNDPROC)
> fails on wine (and probably o
Piotr Caban <[EMAIL PROTECTED]> writes:
> @@ -117,6 +120,29 @@ static inline saxattributes *impl_from_ISAXAttributes(
> ISAXAttributes *iface )
> }
>
>
> +static HRESULT namespacePush(saxlocator *locator, int ns)
> +{
> +if(locator->nsStackLast>=locator->nsStackSize)
> +{
> +
Hello Dan,
Dan Kegel wrote:
> Even longer story:
>
> So, what character set is the Wine source tree encoded with?
> It looks like a mixture:
>
> 1. in general, .c and .h files are encoded in Latin-1 aka iso8859-1.
>
> 2. include/*.h are encoded in ASCII and are not allowed to have
> non-ascii c
Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes:
> +static HRESULT WINAPI IDirectPlay8PeerImpl_Initialize(PDIRECTPLAY8PEER
> iface, PVOID CONST pvUserContext, CONST PFNDPNMESSAGEHANDLER pfn, CONST DWORD
> dwFlags)
> +{
> +FIXME("(%p)->(%p,%p,%x): stub\n", iface, pvUserContext, pfn, dw
Roy Shea <[EMAIL PROTECTED]> writes:
> @@ -323,16 +324,62 @@ static HRESULT WINAPI MSTASK_ITask_SetApplicationName(
> ITask* iface,
> LPCWSTR pwszApplicationName)
> {
> -FIXME("(%p, %s): stub\n", iface, debugstr_w(pwszApplicationName));
> -return E_NOTIMPL;
> +DWORD
Hi everyone,
I'm glad to say that my project to implement PrintDlgEx* went very
well, as I've implemented almost everything by the deadline, and have
test cases for every meaningful non-interactive scenario, AFAICT. The
only feature that I have not had time to implement and test is the
lpCallbac
41 matches
Mail list logo
