2008/8/18 Michael Martin <[EMAIL PROTECTED]>:
>
> In widl code generated for services an
> exception is raised for null string with RPC_X_NULL_REF_POINTER
> In windows calls made to for example CreateService with all NULL's
> checks are made on the handle being null and its checked first before nul
On Tuesday 19 August 2008 02:36:02 Dan Kegel wrote:
> >> Btw, how does patchwatcher handle that?
> > Not at all.
>
> Patches gratefully accepted.
Whoops, I just realized this came across rather rude. Sorry for that. I'm
currently trying to get the basic features of the patchwatcher to work in
bu
"James Hawkins" <[EMAIL PROTECTED]> wrote:
> -{ FALSE, ERROR_SHARING_VIOLATION, FALSE },
> -{ TRUE, ERROR_SUCCESS, TRUE }
> +{ TRUE, ERROR_SUCCESS },
> +{ TRUE, ERROR_SUCCESS },
> +{ TRUE, ERROR_SUCCESS },
> +{ TRUE, ERROR_SUCCESS },
> +{ FALSE, ERROR_SHARING_VIOLATION
On Mon, Aug 18, 2008 at 11:04 PM, Dmitry Timoshkov
<[EMAIL PROTECTED]> wrote:
> "James Hawkins" <[EMAIL PROTECTED]> wrote:
>
>> Changelog:
>> * Test the file access and share modes of CreateFile.
>
> Of course, the more tests - the better, but isn't that a duplicate of
> existing test_file_sharing(
"James Hawkins" <[EMAIL PROTECTED]> wrote:
> Changelog:
> * Test the file access and share modes of CreateFile.
Of course, the more tests - the better, but isn't that a duplicate of
existing test_file_sharing()? Besides win9x will require fixing it
all over the place...
--
Dmitry.
Hello All,
I am adding tests to test the unicodeness of builtin class window created
after the class is globally
subclassed. http://www.winehq.org/pipermail/wine-patches/2008-August/059354.html
It tests the following builtin classes:
Edit, Button, Static, ComboBox, ComboLBox, ListBox, #32770
Hi, Can anyone please tell me what's wrong with my one line patch to problem:
http://www.winehq.org/pipermail/wine-patches/2008-August/059294.html
I have created bug #14784 and have attached stand alone window test program
http://bugs.winehq.org/attachment.cgi?id=15327
Juan Lang has confirm the
>> Btw, how does patchwatcher handle that?
>> Does it detect that in the case of changing config.h.in,
>> dlls/Makefile.in, server/protocol.def it needs
>> to regenerate the files by running autoconf,
>> tools/make_requests, or tools/make_makefiles?
>
> Not at all.
Patches gratefully accepted.
St
Scott Lindeneau <[EMAIL PROTECTED]> wrote:
> i Don't have any windows machines to test the code on
That's a real problem. You can't be sure the tests you're
writing are good unless they pass on a windows machine.
That said, simple tests are better than no tests,
and if you can find somebody to
On Mon, Aug 18, 2008 at 5:31 PM, Markus Hitter <[EMAIL PROTECTED]> wrote:
>
> Am 18.08.2008 um 19:53 schrieb James Hawkins:
>
>> Why can't a developer review his own patch? If your patch is not
>> committed, the first thing you should do is look the patch over for obvious
>> mistakes.
>
> Obviously
Am 18.08.2008 um 19:53 schrieb James Hawkins:
> Why can't a developer review his own patch? If your patch is not
> committed, the first thing you should do is look the patch over for
> obvious mistakes.
Obviously, some people here are used to receive more random diffs
instead of carefully
Am Montag, den 18.08.2008, 20:31 +0200 schrieb Michael Karcher:
> Am Montag, den 18.08.2008, 08:46 + schrieb Louis. Lenders:
> > hi, tests show that UrlUnEscape still converts the url-string if the
> > bufferpointer is set to NULL, and the
> > URL_UNESCAPE_INPLACE is set. Test passes fine with
Date: Mon, 4 Aug 2008 05:20:43 -0700
From: "Dan Kegel" <[EMAIL PROTECTED]>
>2) port some existing accept() conformance tests from ws2_32/tests/sock.c
>to use AcceptEx(), add a bit to check the special new features,
>and make sure they pass on Windows.
On Sun, Aug 10, 2008 at 4:16 PM, Kai Blin <[EM
On Monday 18 August 2008 09:50:05 Dmitry Timoshkov wrote:
> "Detlef Riekenberg" [EMAIL PROTECTED] wrote:
> > On So, 2008-08-17 at 19:03 +0200, Michael Karcher wrote:
> >> ---
> >> configure | 303
> >> +++
> >
> > You should never include a
Am Montag, den 18.08.2008, 08:46 + schrieb Louis. Lenders:
> hi, tests show that UrlUnEscape still converts the url-string if the
> bufferpointer is set to NULL, and the
> URL_UNESCAPE_INPLACE is set. Test passes fine with native shlwapi, and
> in wine after applying the previous sent patch :
On Mon, Aug 18, 2008 at 7:40 AM, Markus Hitter <[EMAIL PROTECTED]> wrote:
>
> Am 18.08.2008 um 11:25 schrieb Michael Stefaniuc:
>
>> He [Alexandre] doesn't scale at replying to trivially "wrong"
>> patches but everybody
>> can reply to those and actually they should do that.
>
>
> Unfortunately, a
This might be of use to someone wanting to compare Wine IE gecko
rendering to IE6 without having to use a bigger hack like ies4linux. I
am sending here rather than privately to Dan as I don't expect it to
be merged to winetricks mainline
Changelog: Add ie6 verb and support IE6
I doubt Dan will m
2008/8/18 Michael Karcher <[EMAIL PROTECTED]>:
> Another review.
>
> Am Sonntag, den 20.07.2008, 22:42 +0200 schrieb Markus Hitter:
>> Similar to NtReadFile and NtWriteFile, NtCreateFile should trace
>> return values on request. Providing the file handle allows to map
>> read/write requests to the
Another review.
Am Sonntag, den 20.07.2008, 22:42 +0200 schrieb Markus Hitter:
> Similar to NtReadFile and NtWriteFile, NtCreateFile should trace
> return values on request. Providing the file handle allows to map
> read/write requests to the corresponding file name.
Seems very sensible. Your
You indirectly asked for review of your patches. The comments below
might be reasons your patch did not get accepted. Best way to handle
ignored patches is to look over the patch again, and if one does not see
something that can be improved, just ask on wine-devel or (even better)
the IRC channel w
Am 18.08.2008 um 11:25 schrieb Michael Stefaniuc:
> He [Alexandre] doesn't scale at replying to trivially "wrong"
> patches but everybody
> can reply to those and actually they should do that.
Unfortunately, a developer can't review his patches himself and if
the patch reviewing group is to
Adam Petaccia wrote:
> ---
> dlls/gdiplus/font.c | 18 ++
> dlls/gdiplus/gdiplus.spec |2 +-
> include/gdiplusflat.h |2 ++
> 3 files changed, 21 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c
> index 0c78bd5..5e1a14e 10
On Sat, Aug 16, 2008 at 11:26:42PM -0400, Adam Petaccia wrote:
> This seems like the right thing to do, but OleLoadImage fails.
> Comments welcome.
> ---
> dlls/gdiplus/image.c | 42 --
> dlls/gdiplus/tests/image.c |2 +-
> 2 files changed, 41 in
Markus Hitter wrote:
> Am 18.08.2008 um 06:57 schrieb James Hawkins:
>
>> Also, Julliard hasn't had trouble scaling with the pace of
>> development so far.
>
> I'd be not so sure about this. So far I've filed four bugs and sent
> two patches. Bugs get little or no attention, patches obviously
Am 18.08.2008 um 06:57 schrieb James Hawkins:
> Also, Julliard hasn't had trouble scaling with the pace of
> development so far.
I'd be not so sure about this. So far I've filed four bugs and sent
two patches. Bugs get little or no attention, patches obviously
rushed through unnoticed.
Go
"Detlef Riekenberg" [EMAIL PROTECTED] wrote:
> On So, 2008-08-17 at 19:03 +0200, Michael Karcher wrote:
>> ---
>> configure | 303
>> +++
>
> You should never include autogenerated code in a Patch.
> This will reduce the risk, that your P
Am Montag, den 18.08.2008, 09:30 +0200 schrieb Detlef Riekenberg:
> On So, 2008-08-17 at 19:03 +0200, Michael Karcher wrote:
> > ---
> > configure | 303
> > +++
>
> You should never include autogenerated code in a Patch.
> This will reduc
Adam Petaccia wrote:
> ---
> dlls/gdiplus/tests/font.c | 81
> +
> 1 files changed, 81 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/gdiplus/tests/font.c b/dlls/gdiplus/tests/font.c
> index 3d30a86..b19f0aa 100644
> --- a/dlls/gdiplus/tests/font
On So, 2008-08-17 at 19:03 +0200, Michael Karcher wrote:
> ---
> configure | 303
> +++
You should never include autogenerated code in a Patch.
This will reduce the risk, that your Patch does not apply
after a different Patch was commited.
29 matches
Mail list logo
