re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 2)

2008-08-16 Thread Dan Kegel
"Louis. Lenders" <[EMAIL PROTECTED]> wrote: > i'm sure that if this function ever gets implemented all these checks and > tests are needed, but as i said, a bit of google for fixme:GetVolumePath > shows the common way (the very few) apps call this function is with > filename="c:\blabla\bla", so

Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 2)

2008-08-16 Thread Michael Karcher
Am Samstag, den 16.08.2008, 19:09 + schrieb Louis. Lenders: > Hi Michael, thanks for your comments. I've added some simple sanity > checks from your first suggestions. It looks much better now, but you still access filename[1] before you even know that filename is not an empty string. In that

Re: [winmm] Implement stub for midiConnect and midiDisconnect.

2008-08-16 Thread Christian Costa
I did some more testing and returning an error seems ok. I will send an updated patch. Nikolay Sivov a écrit : > Christian Costa wrote: > >> Hi, >> >> This fixes bug 11142 & 11182. >> >> Bye, >> Christian >> >> Changelog: >> Implement stub for midiConnect and midiDisconnect. >> >> > Usuall

Re: kernel32: Tiny improvement to the GetVolumePathNameW stub

2008-08-16 Thread Michael Karcher
Am Samstag, den 16.08.2008, 17:12 + schrieb Louis. Lenders: > Hi, this fixes Adobe Lightroom 2.0 start up bug, mentioned in > http://bugs.winehq.org/show_bug.cgi?id=8224#c4 > > as long wine doesn't handle with volume mount points, it's probably > safe to satisfy most apps. The idea of your

re: winmm: remove misleading message

2008-08-16 Thread Dan Kegel
Jeff wrote: > Remove a message suggesting that Wine should be pointed at a windows > installation. > > - FIXME("Couldn't load driver for type %s.\n" > - "If you don't have a windows installation accessible from > Wine,\n" > - "you perhaps forgot to create a [mc

Re: [1/2] mshtml: Changed get_typeinfo to help support IDispatch

2008-08-16 Thread leslie_alistair
-- From: "Jacek Caban" <[EMAIL PROTECTED]> Sent: Saturday, August 16, 2008 8:18 PM To: Cc: "Alistair Leslie-Hughes" <[EMAIL PROTECTED]> Subject: Re: [1/2] mshtml: Changed get_typeinfo to help support IDispatch > Alistair Leslie-Hughes wrote: >> Hi,

Re: [2/2] mshtml: Implement IDispatch for IHTMLElement

2008-08-16 Thread Jacek Caban
Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IDispatch for IHTMLElement You should forward these calls to IDispatchEx implementation. See htmlselect.c for example. Jacek

Re: [1/2] mshtml: Changed get_typeinfo to help support IDispatch

2008-08-16 Thread Jacek Caban
Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Changed get_typeinfo to help support IDispatch > Subject: [PATCH] Changed get_typeinfo to AddRef the COM pointer get_typeinfo is an internal function so it's fine to not AddRef as long as we guarantee that we hold the reference (a