Re: [TRY2]user32/tests: add tests for creating subclassed builtinclass windows

2008-08-06 Thread Dmitry Timoshkov
"Hongbo Ni" <[EMAIL PROTECTED]> wrote: > +static void test_builtin_class_subclassed(char *classA, WCHAR *classW); It is possible to avoid forward declarations by a proper function rearranging. Also please add 'const' to classA/W. > + > +static void test_all_builtin_classes_subclassed(void) > +{

Re: advapi32: Implement GetSecurityInfo. [take 2]

2008-08-06 Thread Juan Lang
> Any API may fail in some way, but that would be ridiculous to pollute > the whole Wine source tree with asserts. As I've said, IMO it's better > to have a test case for the API which will detect broken behaviour > instead. I agree that we shouldn't have asserts across DLLs. While we may "know"

Re: advapi32: Implement GetSecurityInfo. [take 2]

2008-08-06 Thread Dmitry Timoshkov
"Dan Hipschman" <[EMAIL PROTECTED]> wrote: > But I like the assert. You haven't really given me a reason to take it > out. Why is it inappropriate? It's use here seems perfectly reasonable > to me. I'm calling NtQuerySecurityObject in such a way that I'm > expecting it to fail, and if it doesn

Re: winex11.drv: recognize WGL_SWAP_METHOD_ARB wgl pixel format attribute.

2008-08-06 Thread Alexander Sabourenkov
Stefan Dösinger wrote: There's GLX_OML_swap_method. It is supported on fglrx, and I think it is supported on the open source drivers as well Hmm. Did not found that one. Is supported on r300/mesa7-7.1.0~git20080728. Modified patch attached. It would be better to actually convert the attribut

Re: advapi32: Implement GetSecurityInfo. [take 2]

2008-08-06 Thread Dan Hipschman
On Wed, Aug 06, 2008 at 02:21:44PM +0900, Dmitry Timoshkov wrote: > "Dan Hipschman" <[EMAIL PROTECTED]> wrote: > > >+#include > ... > >DWORD WINAPI GetSecurityInfo( > >HANDLE hObject, SE_OBJECT_TYPE ObjectType, > >@@ -2718,8 +2735,44 @@ DWORD WINAPI GetSecurityInfo( > >PSECURITY_DESCRIPTO

Re: DIB engine status

2008-08-06 Thread Sergey Novosyolov
> I will > likely download his tree and play around with it before school starts > again. Which functions will you work on? It is necessary for us to plan our further development.

RE: winex11.drv: recognize WGL_SWAP_METHOD_ARB wgl pixel format attribute.

2008-08-06 Thread Stefan Dösinger
> WGL_SWAP_METHOD attribute is not handled. Explicitly skip it in > ConvertAttribWGLtoGLX and always return WGL_SWAP_UNDEFINED_ARB in > X11DRV_wglGetPixelFormatAttribivARB, because buffers are always in > undefined state after swap in GLX. There's GLX_OML_swap_method. It is supported on fglrx, and

RE: winex11.drv: recognize WGL_SWAP_METHOD_ARB wgl pixel format attribute.

2008-08-06 Thread Stefan Dösinger
> WGL_SWAP_METHOD attribute is not handled. Explicitly skip it in > ConvertAttribWGLtoGLX and always return WGL_SWAP_UNDEFINED_ARB in > X11DRV_wglGetPixelFormatAttribivARB, because buffers are always in > undefined state after swap in GLX. There's GLX_OML_swap_method. It is supported on fglrx, and

Re: user32: Add test and fix for the error with edit control whose parentis desktop.

2008-08-06 Thread Dmitry Timoshkov
"Ilya Shpigor" <[EMAIL PROTECTED]> wrote: > +static void test_edit_parent_desktop_1(void) > +{ > +HWND hwEdit; > +HDC hdc; > + > +hwEdit = CreateWindowEx( 0, "EDIT", NULL, WS_CHILD | WS_OVERLAPPEDWINDOW > | > WS_VISIBLE, 10, 10, 300, 300, > GetDesktop

Re: d3dx9: Implementation of D3DXGetDeclLength

2008-08-06 Thread Luis Busquets
Certainly +static const D3DVERTEXELEMENT9 lc={0xFF,0,D3DDECLTYPE_UNUSED,0,0,0}; is not used. I will take it out. However, I do not understand why pdecl needs to be incremented. Actually, the tests respond correctly. Why do you think pdecl has to be incremented? We are actually returning i. pd

Re: taskmgr [try 2]: Converted some functions and variables to Unicode [1/12]

2008-08-06 Thread Nikolay Sivov
Vladimir Pankratov wrote: > -TCHAR strErrorText[260]; > +WCHAR wstrErrorText[0x400]; Why do you use word format for size constant? Btw, is it normal that it's changed 260 -> 1024? > -GetLastErrorText(strErrorText, 260); > +GetLastErrorText(wstrErrorText,