RE: ntdll: import dll from dir of referring dll if not found instandard locations

2008-08-02 Thread Hongbo Ni
"Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote:> > This patch fixes bug 14699. It should fix all failed applications> > which try to load a dll from specific folder, and the dll is link> > another dll in the same folder.> > Please add a test case for this behaviour to confirm that your patch> is

Re: [1/2] mlang: Add implementation offnIMLangFontLink_GetCharCodePages

2008-08-02 Thread Dmitry Timoshkov
"Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > It doesn't really matter what code pages Windows supports, it does > matter though what code pages are valid. You need to use Win32 APIs > EnumSystemCodePages/GetCPInfo/MultiByteToWideChar instead of accessing > Wine internals directly. ... or rathe

Re: ntdll: import dll from dir of referring dll if not found instandard locations

2008-08-02 Thread Dmitry Timoshkov
"Hongbo Ni" <[EMAIL PROTECTED]> wrote: > This patch fixes bug 14699. It should fix all failed applications > which try to load a dll from specific folder, and the dll is link > another dll in the same folder. Please add a test case for this behaviour to confirm that your patch is doing a correct

Re: [2/2] mlang/tests: add test for fnIMLangFontLink_GetCharCodePages

2008-08-02 Thread Dmitry Timoshkov
"Vitaly Perov" <[EMAIL PROTECTED]> wrote: > +/* Tests for GetCharCodePages */ > +/* Latin 1 */ > +ok(IMLangFontLink_GetCharCodePages(iMLFL, 'd', &dwCodePages) == S_OK, > +"IMLangFontLink_GetCharCodePages failed\n"); > +ok(dwCodePages == 2032127, "Incorrect CodePages returne

Re: [1/2] mlang: Add implementation of fnIMLangFontLink_GetCharCodePages

2008-08-02 Thread Dmitry Timoshkov
"Vitaly Perov" <[EMAIL PROTECTED]> wrote: > @@ -1855,8 +1855,56 @@ static HRESULT WINAPI > fnIMLangFontLink_GetCharCodePages( > WCHAR chSrc, > DWORD* pdwCodePages) > { > -FIXME("\n"); > -return E_NOTIMPL; > +/* codepages, supported by Windows */ > +static const

Re: Patch checking robot coming

2008-08-02 Thread Dan Kegel
On Sat, Aug 2, 2008 at 7:25 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > Its really ironic that you post this today as just yesterday I was > contemplating the same thing, and not only doing a compile check but > also a run of the test suite and valgrind. Yeah, that's the end goal. Gotta wal

Re: DIB engine status

2008-08-02 Thread Jesse Allen
On Fri, Aug 1, 2008 at 8:23 AM, Сергей Новосёлов <[EMAIL PROTECTED]> wrote: > > Did you hear anything about Jesse Allen's version of DIB Engine: > http://article.gmane.org/gmane.comp.emulators.wine.devel/53234 (His version - > http://repo.or.cz/w/wine/dibdrv.git ) > Do you know why it was neccesary

Re: Patch checking robot coming

2008-08-02 Thread Zachary Goldberg
On Sat, Aug 2, 2008 at 8:24 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Ambroz wrote: >> To me, a script that builds just >> every patch is a serious security flaw; I suppose it wouldn't >> be very hard for someone to send a naughty patch >> that would take control of your machine. > > True. > >> I

re: Patch checking robot coming

2008-08-02 Thread Dan Kegel
Ambroz wrote: > To me, a script that builds just > every patch is a serious security flaw; I suppose it wouldn't > be very hard for someone to send a naughty patch > that would take control of your machine. True. > I suggest you make it build patches in a chroot > as a regular user, and copy ove

rsaenh: Test and correct the maximum allowable salt length

2008-08-02 Thread Louis. Lenders
Usually i don't feel the need to respond to messages on wine-devel, but now i do: > What in the hell does this patch do? Why is it needed? What does it > fix/implement? Doees this change affect any Bugzilla issues? Where is > the Changelog? > This is what I have been trying to get you to do.

Re: Patch checking robot coming

2008-08-02 Thread Ambroz Bizjak
Dan Kegel wrote: > What I have so far is a script that watches wine-patches > and applies each patch to current git, then builds, Just where are you going to run that? To me, a script that builds just every patch is a serious security flaw; I suppose it wouldn't be very hard for someone to send a

Re: fusion: Use proper function pointer

2008-08-02 Thread James Hawkins
On Sat, Aug 2, 2008 at 4:09 PM, Andrew Talbot <[EMAIL PROTECTED]> wrote: > Changelog: >fusion: Use proper function pointer. > > diff --git a/dlls/fusion/fusion.c b/dlls/fusion/fusion.c > index ac01cf4..637346c 100644 > --- a/dlls/fusion/fusion.c > +++ b/dlls/fusion/fusion.c > @@ -32,6 +32,9 @@

Patch checking robot coming

2008-08-02 Thread Dan Kegel
After some discussion with Jeremy and Alexandre about how nice it would be to have some automated way to check patches before Alexandre commits them, I decided to have a go at creating one. What I have so far is a script that watches wine-patches and applies each patch to current git, then builds,

Re: rsaenh: Test and correct the maximum allowable salt length

2008-08-02 Thread Juan Lang
James, please show a little more courtesy. > Who is this and why is this so important? Karsten wrote a patch to address an issue he had with Eve Online. It's important because of attribution: I wanted people to realize that I was indebted to him for thinking of it. I didn't use his code, though

Re: rsaenh: Test and correct the maximum allowable salt length

2008-08-02 Thread James McKenzie
Juan Lang wrote: > Inspired by a patch by Karsten Elfenbein. > Who is this and why is this so important? > --Juan > Per: http://winehq.org/site/sending_patches What in the hell does this patch do? Why is it needed? What does it fix/implement? Doees this change affect any Bugzilla issues?

Re: kernal32: change if...if to if...'else if' in get_module_path_end()

2008-08-02 Thread Jacek Caban
Hongbo Ni wrote: > If '\\' is found, there is no point to find '/'. > There is, think about path like c:\dir1\dir2/file.dll Jacek

Re: DLL loading prolem when injecting into another process

2008-08-02 Thread Juan Lang
> What do I have to do to get this patch accepted ? Write a regression test that shows the problem, marked with todo_wine. --Juan

Re: [2/2] netapi32: Added partial implementation of NetShareGetInfo

2008-08-02 Thread Juan Lang
Hi again Vitaliy, +// +WCHAR *ParseParam(WCHAR **paramStr, const WCHAR *name) This should be static. The name of the function also shouldn't be capitalized like this, to make it clear that it isn't a Win32 function. Looking at other so

Re: [1/2] netapi32: Added partial implementation of NetShareAdd

2008-08-02 Thread Juan Lang
Hi Vitaliy, overall your patch looks pretty good. A few minor points: +FIXME("(%s %d %p) partially implemented\n", debugstr_w(servername), level, buf); Because you add a more specific FIXME for every unimplemented path, it seems to me this would be better as a TRACE. +result = RegCreateK

Re: DIB engine status

2008-08-02 Thread Сергей Новосёлов
Friday 01 August 2008 15:56:48 Huw Davies wrote: > Hi folks, > > Here's an update on the DIB engine that I've been working on for the > last few months. This work has been made possible by the generosity > of Google - so thanks go to them and of course to Dan. > > You can find the code at http://

Re: mono progress on mixed-mode assemblies...

2008-08-02 Thread Kornél Pál
Hi, Mono 2.0 (Preview 1) is available for download on http://mono.ximian.com/monobuild/preview/download-preview/ This includes a lot of improvements over version 1.9 including my work on supporting mixed-mode assemblies. Please try it. Feedback is welcome, version 2.0 has not been released yet.

Re: one liner patch to stop crash, everquest2.exe

2008-08-02 Thread H. Verbeet
2008/8/2 Andrew Fenn <[EMAIL PROTECTED]>: > After doing a recent git pull I noticed that it now crashes at a different > place in the code. Here's the backtrace (I haven't had a look yet, this is > more of a heads up).. > > Backtrace: > =>1 0x7e49089b hash_table_destroy+0xb(table=0x17, free_value=0

Re: one liner patch to stop crash, everquest2.exe

2008-08-02 Thread Andrew Fenn
After doing a recent git pull I noticed that it now crashes at a different place in the code. Here's the backtrace (I haven't had a look yet, this is more of a heads up).. Backtrace: =>1 0x7e49089b hash_table_destroy+0xb(table=0x17, free_value=0x7e3e8dc0, cb=0x7e4c9a50) [/home/andrew/wine/wine/dll