Am Mittwoch, den 30.07.2008, 18:12 -0600 schrieb Vitaliy Margolen:
Disclaimer: I didn't thoroughly read the thread, but if I understood
the problem area correctly, the following comments apply:
> And even if Wine returns different DIKs on different keyboard layouts for
> some questionable keys.
hi everyone
I'd like to participate to wine improvement instead of always requesting
for new features
Maybe i'm wrong but i thaught xinput support lack for new games and its
implementation is maybe not the hardest thing to do
The fact is that i have lack of knowledge in msdn and c coding, may
[EMAIL PROTECTED] wrote:
> While looking at bug 13335 (
> http://bugs.winehq.org/show_bug.cgi?id=13335) which is An ATI and wine bug.
> I noticed something in one of the updates :
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462715
>
>
>
> Now this set me to searching as I really didn
This is all well and good but I don't see a problem. In dinput that is. Are
those scan codes match to what you are getting on windows? They should since
they are hardware dependent. But might not. However v_key should stay the same.
And even if Wine returns different DIKs on different keyboard l
> You probably need to specify ~0u otherwise the constant might be
> deemed to have the wrong type.
This results in a warning again:
../../../dlls/wined3d/utils.c:1796: warning: large integer implicitly
truncated to unsigned type
Had Stefan look over it before I submitted it this time.
thanks!
-aric
H. Verbeet wrote:
> 2008/7/30 Aric Stewart <[EMAIL PROTECTED]>:
>> ---
>> dlls/wined3d/surface_base.c | 122
>> +++
>> 1 files changed, 65 insertions(+), 57 deletions(-)
>>
> Looks rea
2008/7/30 Stefan Dösinger <[EMAIL PROTECTED]>:
> DeviceLoadTest is quite big, does splitting up make sense? Otherwise, what
> you say is fair enough - I do not care too much about code beauty in the
> tests as long as the tests work(since one hardly ever reads the test or does
> lots of work on it,
2008/7/30 Aric Stewart <[EMAIL PROTECTED]>:
> ---
> dlls/wined3d/surface_base.c | 122
> +++
> 1 files changed, 65 insertions(+), 57 deletions(-)
>
Looks reasonable to me, although you might want to wait for Stefan to
look it over as well.
On Wed, Jul 30, 2008 at 08:01:55AM -0500, Stefan D?singer wrote:
> > It's not very clean to store -1 into unsigned variables, the previous
> > code was better IMO.
> ok, I'll resend
You probably need to specify ~0u otherwise the constant might be
deemed to have the wrong type.
David
--
On Wed, 30 Jul 2008, Jeremy Newman wrote:
> The problem is that currently our news articles do not have separate
> pages like Slashdot does. So there is no page to actually link to. Also,
> linking to the actual WWN issue is done in the body of the news post. In
> order to have the WWN issue li
While looking at bug 13335 ( http://bugs.winehq.org/show_bug.cgi?id=13335)
which is An ATI and wine bug.
I noticed something in one of the updates :
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462715
Now this set me to searching as I really didn't like the idea of wrapping the
libGL call
Stefan Dösinger wrote:
> DeviceLoadTest is quite big, does splitting up make sense? Otherwise, what
> you say is fair enough - I do not care too much about code beauty in the
> tests as long as the tests work(since one hardly ever reads the test or does
> lots of work on it, and the Windows apps we
Hi,
>+ sei.fMask = SEE_MASK_FLAG_DDEWAIT|
>+ SEE_MASK_FLAG_NO_UI|
>+ SEE_MASK_NO_CONSOLE|
>+ SEE_MASK_NOCLOSEPROCESS;
Console apps must be executed using exiting console, not a new one.
--
Kirill
Hongbo Ni <[EMAIL PROTECTED]> writes:
> I think it should call load_library( "C:\DirA\C.dll ",
> LOAD_WITH_ALTERED_SEARCH_PATH)
> so C.dll can be loaded into C:\DirX\X.exe process.
>
> Alexandre, can you please comment ?
You should write test cases.
--
Alexandre Julliard
[EMAIL PROTECTED]
On Wednesday 30 July 2008 15:15:45 you wrote:
> Am Mittwoch, den 30.07.2008, 15:03 +0400 schrieb Victor:
> > > You also have to expand types properly, i.e. converting a
> > > component from 4-bit to 8-bit isn't just a shift.
> >
> > In all places where I saw pixel format conversion before, it was _
Maarten Lankhorst wrote:
> Hi Paul,
>
> 2008/7/30 Paul Vriens <[EMAIL PROTECTED]>:
>> Hi Maarten,
>>
>> NT4 doesn't have CreateToolhelp32Snapshot so none of the quartz tests will
>> run on NT4 currently.
>>
>> Should I just create a patch that checks for the existence of this function
>> and skip
Juan Lang wrote:
> Hi Paul, thanks very much for looking into the crypt32 tests.
>
> -/* Weird--bad add disposition leads to an access violation in Windows.
> - */
> (snip)
> +if (!on_win9x)
> +{
> +/* Weird--bad add disposition leads to an access violation in
> Windows.
>
Hi Paul, thanks very much for looking into the crypt32 tests.
-/* Weird--bad add disposition leads to an access violation in Windows.
- */
(snip)
+if (!on_win9x)
+{
+/* Weird--bad add disposition leads to an access violation in Windows.
+ * Both tests crash on win9x
Since the prototype for D3DXCreateSprite in d3dx9 and d3dx8 are not
compatible, it would be worth to do the implementation in parallel (that is
in the same patch), instead of duplicating the d3dx9 patch into the d3dx8
one.
David
"Maarten Lankhorst" <[EMAIL PROTECTED]> writes:
> I want to re-use the code in the videorenderer test. I have some
> patches for that but they should be part of a different patchset. If I
> didn't want to do that I would have put it in vmr9.c, if you really
> want to I can duplicate the files.
No
Hoi Henri,
2008/7/30 H. Verbeet <[EMAIL PROTECTED]>:
> I just looked the patch over quickly since you mentioned d3d9, but
> here are a few things I noticed:
>
>> +hr = IDirect3DSurface9_LockRect(info->lpSurf, &lock, NULL,
>> D3DLOCK_DISCARD);
>> +assert(hr == S_OK);
> ...
>> +hr = IDi
Hi Paul,
2008/7/30 Paul Vriens <[EMAIL PROTECTED]>:
> Hi Maarten,
>
> NT4 doesn't have CreateToolhelp32Snapshot so none of the quartz tests will
> run on NT4 currently.
>
> Should I just create a patch that checks for the existence of this function
> and skip some tests?
>
> Or do we have another
Hi Alexandre,
2008/7/30 Alexandre Julliard <[EMAIL PROTECTED]>:
> "Maarten Lankhorst" <[EMAIL PROTECTED]> writes:
>
>> From f3544f718dbebd3dca29d94dbbcbdd071884e5a6 Mon Sep 17 00:00:00 2001
>> From: Maarten Lankhorst <[EMAIL PROTECTED]>
>> Date: Mon, 28 Jul 2008 18:18:06 -0700
>> Subject: [PATCH]
On Tue, Jul 29, 2008 at 8:19 PM, Vitaliy Margolen
<[EMAIL PROTECTED]> wrote:
> Lei Zhang wrote:
>> Hi,
>>
>> On Windows, the Msi.Package action registry keys have the full path to
>> msiexec.exe.
>>
>>
>> +HKCR,Msi.Package\she
The problem is that currently our news articles do not have separate
pages like Slashdot does. So there is no page to actually link to. Also,
linking to the actual WWN issue is done in the body of the news post. In
order to have the WWN issue link properly, the news XML would need a
tag or som
Doing tests with shift show that the presence of the shift key does not
affect MapVirtualKey so SHIFT+2 still returns '2' since it is
scancode based i doubt that numlock would either. So I do not think we
need to worry about that.
-aric
Vitaliy Margolen wrote:
> Aric Stewart wrote:
>> It is
On Wed, 30 Jul 2008, Francois Gouget wrote:
> On Wed, 30 Jul 2008, Zachary Goldberg wrote:
> [...]
> > How then would people find the index of WWNs? I think having that box
> > on the side is really convenient actually and is the only way I
> > usually go to get to issues.
>
> With the 'More Iss
On Wed, 30 Jul 2008, Zachary Goldberg wrote:
[...]
> How then would people find the index of WWNs? I think having that box
> on the side is really convenient actually and is the only way I
> usually go to get to issues.
With the 'More Issues...' link which would be right below the index in
the n
Well the main problem is with Japanese keyboards I was testing with.
Often the scan codes, nor the vkey of the keyboards did not line up the
characters in the other keyboards. Yet dinput on windows correctly set
the DIK codes to represent the character being pressed.
An example is the key to t
On Wed, 30 Jul 2008, Jeremy Newman wrote:
> Not to mention, for people who subscribe to the RSS feed, it is a great
> way to let them know an Issue has been released.
I'm not using RSS for WineHQ so I just discovered that they are broken.
The behavior I'm expecting is the same as for Slashdot's
"Zachary Goldberg" <[EMAIL PROTECTED]> writes:
> How then would people find the index of WWNs? I think having that box
> on the side is really convenient actually and is the only way I
> usually go to get to issues.
There would be a link to a separate WWN index page (the existing back
issues pag
On Wed, Jul 30, 2008 at 10:56 AM, Alexandre Julliard
<[EMAIL PROTECTED]> wrote:
> "Zachary Goldberg" <[EMAIL PROTECTED]> writes:
>
>> As long as we are okay that for the for the duration of time in which
>> the news item is on the front page it will be redundant with the side
>> box I am alright wi
"Zachary Goldberg" <[EMAIL PROTECTED]> writes:
> As long as we are okay that for the for the duration of time in which
> the news item is on the front page it will be redundant with the side
> box I am alright with this as well (I think this is mitigated by the
> fact that in the RSS it won't be r
On Wed, Jul 30, 2008 at 10:38 AM, Alexandre Julliard
<[EMAIL PROTECTED]> wrote:
> Francois Gouget <[EMAIL PROTECTED]> writes:
>
>> On http://www.winehq.org/ we have the following news items:
>>
>>July 13, 2008: Wine Weekly News Issue 349
>>
>>WWN Issue 349 was released today.
>>
>>J
Francois Gouget <[EMAIL PROTECTED]> writes:
> On http://www.winehq.org/ we have the following news items:
>
>July 13, 2008: Wine Weekly News Issue 349
>
>WWN Issue 349 was released today.
>
>June 18, 2008: Wine Weekly News Issue 348
>
>WWN Issue 348 was released today.
>
Not to mention, for people who subscribe to the RSS feed, it is a great
way to let them know an Issue has been released.
I'm not opposed to adding more of a summary of the issue though.
While we are on this topic, I have thought about renaming WWN - Wine
Weekly News to:
* drum roll *
World Wine
> There are some tests after that block not related to cubemap which I
> don't want
> to skip. Other options are moving cubemap block of code to the end (so
> that I
> can return then) or skipping the block by goto, but none of this are
> really
> better IMO.
DeviceLoadTest is quite big, does split
Hi,
I have observed a DLL loading prolem when injecting into another process.
For example,
In folder C:\DirA\, I have A.exe which is linked to B.dll, and B.dll is linked
to C.dll.
B.dll and C.dll are in same folder as A.exe.
If I run A.exe, B.dll and C.dll will be loaded without problem
"Reece Dunn" <[EMAIL PROTECTED]> writes:
> -typedef void (*pfThemedPaint)(HTHEME theme, HWND hwnd, HDC hdc);
> +/* These are indices into a states array to determine the theme state for a
> given theme part. */
> +#define STATE_NORMAL 0
> +#define STATE_DISABLED 1
> +#define STATE_HOT 2
> +#defin
"Maarten Lankhorst" <[EMAIL PROTECTED]> writes:
> From f3544f718dbebd3dca29d94dbbcbdd071884e5a6 Mon Sep 17 00:00:00 2001
> From: Maarten Lankhorst <[EMAIL PROTECTED]>
> Date: Mon, 28 Jul 2008 18:18:06 -0700
> Subject: [PATCH] quartz: Add tests for Video Mixing Renderer 9
>
> ---
> dlls/quartz/tes
> It's not very clean to store -1 into unsigned variables, the previous
> code was better IMO.
ok, I'll resend
H. Verbeet wrote:
> 2008/7/30 Chris Ahrendt <[EMAIL PROTECTED]>:
>> What do you mean ?
>>
> The code doesn't actually do what you say it does.
its a patch to finish out
IWineD3DDeviceImpl_SetRenderState and verifies against the direct x 9
definitions...
Chris
2008/7/30 Chris Ahrendt <[EMAIL PROTECTED]>:
> What do you mean ?
>
The code doesn't actually do what you say it does.
H. Verbeet wrote:
> 2008/7/30 Chris Ahrendt <[EMAIL PROTECTED]>:
>> I thought of moving the if statement which is at the bottom of the function
>> to the begining as I am not sure why you would want to reassign the same
>> value then check to see if it was the same..
>>
>> Why are you doing it that
On Wed, Jul 30, 2008 at 4:53 AM, Francois Gouget <[EMAIL PROTECTED]> wrote:
>
> On http://www.winehq.org/ we have the following news items:
>
> July 13, 2008: Wine Weekly News Issue 349
>
> WWN Issue 349 was released today.
>
> June 18, 2008: Wine Weekly News Issue 348
>
> WWN Issue
Stefan Dösinger <[EMAIL PROTECTED]> writes:
> @@ -1785,16 +1785,17 @@ void gen_ffp_op(IWineD3DStateBlockImpl *stateblock,
> struct ffp_settings *setting
> };
> unsigned int i;
> DWORD ttff;
> +DWORD cop, aop, carg0, carg1, carg2, aarg0, aarg1, aarg2;
>
> for(i = 0; i < G
Am Mittwoch, den 30.07.2008, 15:03 +0400 schrieb Victor:
> > You also have to expand types properly, i.e. converting a
> > component from 4-bit to 8-bit isn't just a shift.
> In all places where I saw pixel format conversion before, it was _always_
> done
> by shifting components (even in MS-DOS
On Tuesday 29 July 2008 21:54:36 you wrote:
> Obviously not, 1-byte formats should be read as bytes, 2-byte format as
> WORDs, and 4-byte format as DWORDs.
This will require several nearly identical read functions, or callbacks which
means either code duplication or slowdown within Blt function,
> I ran your tests on win95 and win98 and both have at least the
> function available but as you've stated it's not implemented.
>
> Current approach for dealing with this is for example:
>
> SetLastError(0xdeadbeef);
> ret = ToUnicode(...);
> if (!ret && GetLastError() == ERROR_CALL_NOT_IMPLEMEN
Andre Wisplinghoff wrote:
> Nikolay Sivov wrote:
>> You should use dynamic linking here (GetProcAddress).
>>
>>
> Is this necessary even though the function is there on 9x - returning
> unimplemented - as Paul wrote? I think you would need to do this if
> the function weren't there at all on some
Nikolay Sivov wrote:
> You should use dynamic linking here (GetProcAddress).
>
>
Is this necessary even though the function is there on 9x - returning
unimplemented - as Paul wrote? I think you would need to do this if the
function weren't there at all on some systems.
Best Regards
-- Andre Wisp
Andre Wisplinghoff wrote:
> Hello,
>
> I think my patch [1] shouldn't be applied, because I didn't think about
> older versions of Windows. According to MSDN, ToUnicode has NT 3.1 as a
> minimum, meaning we should test if the function is unimplemented and
> skip the test in this case (Win9x Syst
Andre Wisplinghoff wrote:
> Hello,
>
> I think my patch [1] shouldn't be applied, because I didn't think about
> older versions of Windows. According to MSDN, ToUnicode has NT 3.1 as a
> minimum, meaning we should test if the function is unimplemented and
> skip the test in this case (Win9x Sys
Hello,
I think my patch [1] shouldn't be applied, because I didn't think about
older versions of Windows. According to MSDN, ToUnicode has NT 3.1 as a
minimum, meaning we should test if the function is unimplemented and
skip the test in this case (Win9x Systems). Unfortunately I don't have a
W
2008/7/30 David Adam <[EMAIL PROTECTED]>:
> I forgot to add a change recommended by Henri.
> Now, everything should be fine.
>
Oops, missed that myself as well :-)
Looks ok to me.
On http://www.winehq.org/ we have the following news items:
July 13, 2008: Wine Weekly News Issue 349
WWN Issue 349 was released today.
June 18, 2008: Wine Weekly News Issue 348
WWN Issue 348 was released today.
That's pretty lame. Should either have a 2 or 3 sentence s
John Reiser <[EMAIL PROTECTED]> writes:
> Thus it seems to me that both the offset and the segment are OK
> in the patched code, including when the stack is in a 16-bit segment.
> If this analysis has errors, then I wish to learn.
You cannot assume that the context you have to restore is identica
I just looked the patch over quickly since you mentioned d3d9, but
here are a few things I noticed:
> +hr = IDirect3DSurface9_LockRect(info->lpSurf, &lock, NULL,
> D3DLOCK_DISCARD);
> +assert(hr == S_OK);
...
> +hr = IDirect3DDevice9_Clear(This->d3d9_dev, 0, NULL, D3DCLEAR_TARGET,
>
2008/7/30 Chris Ahrendt <[EMAIL PROTECTED]>:
> I thought of moving the if statement which is at the bottom of the function
> to the begining as I am not sure why you would want to reassign the same
> value then check to see if it was the same..
>
> Why are you doing it that way?
>
Please be more ca
Looks good in principle, but I've still got a few comments:
> +if ( praydirection->x >= 0.0f )
> +{
> + tmin = ( pmin->x - prayposition->x ) / praydirection->x;
> + tmax = ( pmax->x - prayposition->x ) / praydirection->x;
> +}
...
> +if ( tmax < 0.0f ) return FALSE;
This w
Hi Maarten,
NT4 doesn't have CreateToolhelp32Snapshot so none of the quartz tests will run
on NT4 currently.
Should I just create a patch that checks for the existence of this function and
skip some tests?
Or do we have another way to get the number of threads? We could use
NtQuerySystemInfor
Howdy,
>> +const GUID invalid_id = {0x, 0x, 0x,
>> +{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}};
>
> You can use GUID_NULL and eliminate this local.
After looking at other tests in wine I decided to use DEFINE_GUID to
declare my own GUID_NULL for the test. T
63 matches
Mail list logo
