2008/7/28 Stefan Dösinger <[EMAIL PROTECTED]>:
>> This enables the replacement pretty much unconditionally... do we want
>> that?
> I'd say so, unless we have evidence that it's a bad idea to do enable it
> somewhere, and the drawback isn't fixable.
>
I don't mind having it on by default, but I thi
2008/7/28 Stefan Dösinger <[EMAIL PROTECTED]>:
> Mostly because I've written this code before you mentioned them to me. I
> think it can't hurt to ask Alexandre if bitfields are ok to use in Wine.
> How's the support among compilers(older gcc versions? Non-gcc compilers like
> icc and msvc?)
>
Afai
While sitting on the airplane I reworked and rethought the set render
states routine I sent last night and have figured out a more efficient
way for it to run...
Logically thinking it through
208 of the 240 states passed into this routine do nothing and have no
real type checking other than to m
"Colin Finck" <[EMAIL PROTECTED]> wrote:
> -INT CDECL MSVCRT_wctomb( char *dst, MSVCRT_wchar_t ch )
> +INT CDECL MSVCRT_wctomb(char *mbchar, MSVCRT_wchar_t wchar)
What's the point of the above change?
> {
> - return WideCharToMultiByte( CP_ACP, 0, &ch, 1, dst, 6, NULL, NULL );
> +BOOL bUse
Hans Leidekker wrote:
> On Friday 25 July 2008 22:13:18 Zac Brown wrote:
>
>> +#include
>>
>> #include
>> #include
>> +#include
>
> You shouldn't need these.
>
> -Hans
>
Thank you, scratch this patch AJ, I'll send another.
> This enables the replacement pretty much unconditionally... do we want
> that?
I'd say so, unless we have evidence that it's a bad idea to do enable it
somewhere, and the drawback isn't fixable.
> It also might make sense to give this its own file.
It shares some code with the shader implementat
> Is there any particular reason you're not simply using the compiler's
> support for bit-fields?
Mostly because I've written this code before you mentioned them to me. I
think it can't hurt to ask Alexandre if bitfields are ok to use in Wine.
How's the support among compilers(older gcc versions? N
Chris Ahrendt schrieb:
[...]
> h... I do know without the patch EQ2 doesn't run and with it it
> then gets into the start of the game.. so it might be another one of
> the if's... I can add the fog to the break with no if's...let me try
> that. Right now I am running just the git 1.1.2+ tr
2008/7/27 Stefan Dösinger <[EMAIL PROTECTED]>:
> Unfortunately, even despite the preparations in the last patches, this patch
> is still kinda huge because I have to replace all the fragment processing at
> once.
>
This enables the replacement pretty much unconditionally... do we want
that? It also
Colin Finck wrote:
> Remove todo_wine from two tests, which now pass under Wine after the
> changes in my previous patches.
You have to do that in the patch that fixes the test. Each patch have to be
autonomous and have all tests pass before and after it.
Vitaliy.
Is there any particular reason you're not simply using the compiler's
support for bit-fields?
Stefan Dösinger wrote:
>> so valid values would be max =
>> ALPHA(FF)RED(FF)GREEN(FF)BLUE(FF)
> Which is the whole range of a DWORD. A DWORD is between 0 and 0x. So
> the if check will never evaluate to true. (Also checking a DWORD for <0 is
> redundant because a DWORD is unsigned,
On Fr, 2008-07-25 at 11:28 -0700, Juan Lang wrote:
> +/* Create a file with just the .cab header 'MSCF' */
> +file = CreateFileW(
CreateFileW is not supported on win9x.
(returned NULL with ERROR_CALL_NOT_IMPLEMENTED)
I have a Patch ready for the other use of CreateFileW
in dlls/crypt32/te
> so valid values would be max =
> ALPHA(FF)RED(FF)GREEN(FF)BLUE(FF)
Which is the whole range of a DWORD. A DWORD is between 0 and 0x. So
the if check will never evaluate to true. (Also checking a DWORD for <0 is
redundant because a DWORD is unsigned, thus never < 0)
> I can chang
Stefan Dösinger wrote:
>> + case WINED3DRS_FOGCOLOR:
>> + /* Valid Values are between 0 and (4 bytes alpha, red,
>> green, and blue)) */
>> + if ((Value >= 0) ||
>> + (Value <= 0x)) break;
> Humm, this does not sound right to me. The fog color used to be
H. Verbeet wrote:
> 2008/7/27 Chris Ahrendt <[EMAIL PROTECTED]>:
>> Oh I also forgot... I believe that set render state is primarily called
>> at the init of the app so should not overly effect the performance of
>> the application.
> Well, no, it pretty much gets called all the time.
>
>> +
I sent the patch at
http://www.winehq.org/pipermail/wine-patches/2008-July/058460.html but
got neither it applied nor any other comment. As far as I can tell, I
complied with all the guidelines at
http://www.winehq.org/site/sending_patches.
Is it the editing of comments not strictly part of the ne
> + case WINED3DRS_FOGCOLOR:
> + /* Valid Values are between 0 and (4 bytes alpha, red,
> green, and blue)) */
> + if ((Value >= 0) ||
> + (Value <= 0x)) break;
Humm, this does not sound right to me. The fog color used to be A8R8G8B8,
thus equal values ar
On Thu, Jul 24, 2008 at 08:14:40PM +0400, Victor Eremin wrote:
> Supports conversion between most of "unsigned color" argb/xrgb
> surface formats (D3DFMT_A8R8G8B8, D3DFMT_A8R3G3B2, etc), and
> "luminosity" color formats (D3DFMT_L8, etc),
> excluding D3DFMT_A16R16G16B16, D3DFMT_A8P8, D3DFMT_P8 and D
2008/7/27 Chris Ahrendt <[EMAIL PROTECTED]>:
> Oh I also forgot... I believe that set render state is primarily called
> at the init of the app so should not overly effect the performance of
> the application.
Well, no, it pretty much gets called all the time.
> + /* Valid Values are betw
Stefan Dösinger wrote:
>> /*
>> * Get / Set Render States
>> * TODO: Verify against dx9 definitions
>> *
> As Henri said, this needs a test case. So far we have not found any Set*
> function that returns an error. For SetTexture, SetSamplerState, ..., if the
> sampler index is out of boun
Stefan Dösinger wrote:
>> /*
>> * Get / Set Render States
>> * TODO: Verify against dx9 definitions
>> *
> As Henri said, this needs a test case. So far we have not found any Set*
> function that returns an error. For SetTexture, SetSamplerState, ..., if the
> sampler index is out of boun
Well, the last attempt (with added big-endian support) was submitted several
days ago, and again - no feedback, and patch still isn't accepted.
What's wrong with patch now?
---
Victor Eremin
signature.asc
Description: This is a digitally signed message part.
Stefan Dösinger wrote:
>> What if we created a standard for passing some sort of wine-specific
>> metadata in an MSI file? Windows would ignore it, but application
>> developers could use it to include some helpful Linux-specific Wine
>> instructions like what windows version to use, a custom .des
On Sun, Jul 27, 2008 at 7:59 AM, Chris Ahrendt <[EMAIL PROTECTED]> wrote:
> I removed the documentation I just put it in there for this so people can
> understand what was done... it is removed
>
Documentation is a good thing. You just can't use the exact same
wording from a copyrighted source (M
> What if we created a standard for passing some sort of wine-specific
> metadata in an MSI file? Windows would ignore it, but application
> developers could use it to include some helpful Linux-specific Wine
> instructions like what windows version to use, a custom .desktop file,
> or even instru
> /*
> * Get / Set Render States
> * TODO: Verify against dx9 definitions
> *
As Henri said, this needs a test case. So far we have not found any Set*
function that returns an error. For SetTexture, SetSamplerState, ..., if the
sampler index is out of bounds, the native implementation hap
2008/7/26 <[EMAIL PROTECTED]>:
> fix a bad return value for DefaultHandler_SetExtent implemented in
> defaulthandler.c
>
> ChangeLog entry:
> * real name : François DORIN
> * email : [EMAIL PROTECTED]
> * description : when the server is running, the return value must be the
> value of the deleg
2008/7/26 <[EMAIL PROTECTED]>:
> It's my first patch. So, if something is wrong, don't hesitate to notify me !
>
> ChangeLog entry :
> * real name : François DORIN
> * email : [EMAIL PROTECTED]
> * description : offsets can be negative. It is necessary to treat them as
> signed numbers to
Chris Ahrendt wrote:
> H. Verbeet wrote:
>
>> 2008/7/27 Chris Ahrendt <[EMAIL PROTECTED]>:
>>
>>> I did not copy and paste from MSDN.. I used the rules defined in the
>>> statelemt.. I can remove the comment if that is what you are talking
>>> about? But the code itself I did myself...
>>>
H. Verbeet wrote:
> 2008/7/27 Chris Ahrendt <[EMAIL PROTECTED]>:
>> I did not copy and paste from MSDN.. I used the rules defined in the
>> statelemt.. I can remove the comment if that is what you are talking
>> about? But the code itself I did myself...
>>
> Documentation is copyrighted.
I removed
2008/7/27 Scott Ritchie <[EMAIL PROTECTED]>:
> Just a crazy thought, but...
>
> What if we created a standard for passing some sort of wine-specific
> metadata in an MSI file? Windows would ignore it, but application
> developers could use it to include some helpful Linux-specific Wine
> instructi
Am 27.07.2008 um 10:39 schrieb Scott Ritchie:
> This way, a single .msi file could be a true universal installer for
> both Windows machines and Linux machines.
This is a good idea. However, if developers intentionally develop for
Wine they can easily go a step further and build a native Linux
2008/7/27 Chris Ahrendt <[EMAIL PROTECTED]>:
> I did not copy and paste from MSDN.. I used the rules defined in the
> statelemt.. I can remove the comment if that is what you are talking
> about? But the code itself I did myself...
>
Documentation is copyrighted.
> --- device_old.c2008-07-25 11:42:25.0 -0400
> +++ device.c2008-07-26 21:07:45.0 -0400
Unrelated to the patch, but if you intend to work on Wine, I'd
strongly recommend you setup git first.
> +#define D3DBLEND_INVSRCCOLOR 4
You shouldn't use d3d8 or d3d9 definitions in win
Just a crazy thought, but...
What if we created a standard for passing some sort of wine-specific
metadata in an MSI file? Windows would ignore it, but application
developers could use it to include some helpful Linux-specific Wine
instructions like what windows version to use, a custom .desktop
f.dorin at free.fr wrote:
> It's my first patch. So, if something is wrong, don't hesitate to notify me !
> ...
> + if (*(const WORD*)pFormat) pointer_desc = pFormat + *(const SHORT*)pFormat;
Hi François!
A few quick notes:
1) it's helpful if you can say what app each patch fixes, and what the
sy
37 matches
Mail list logo
