Re: ntoskrnl tests - where to write them?

On Fri, Jul 18, 2008 at 11:15 PM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: >> I have been looking at writing a couple of tests for ntoskrl functions >> but I have had difficulty locating a suitable place. It sort of looks >> like ntdll/tests is the place but it is not clear. Is there a guide

Re: kernel32/tests: Run the tests again on Win9x (TimerQueue)

On Fri, Jul 18, 2008 at 09:27:49PM +0200, Detlef Riekenberg wrote: > Some functions are not present on win98: > CreateTimerQueue > CreateTimerQueueTimer > DeleteTimerQueueEx > > > Changelog: > kernel32/tests: Run the tests again on Win9x (TimerQueue) > > > > ???Dan, when you are finished with

RE: ntoskrnl tests - where to write them?

> I have been looking at writing a couple of tests for ntoskrl functions > but I have had difficulty locating a suitable place. It sort of looks > like ntdll/tests is the place but it is not clear. Is there a guide > for locating this one? I think the problem with ntoskrnl tests is that they ha

Errors on Run of winetricks dotnet11.

It looks like something is crashing when running the .NET 1.1 installer. Is there an existent bug for this problem? If not, would it be worthwhile to create an issue for this? System: MacBook OS Version: 10.5.3 X11: 2.1.1 (I don't think this is what is causing the crash.) XCode is not install

ntoskrnl tests - where to write them?

I have been looking at writing a couple of tests for ntoskrl functions but I have had difficulty locating a suitable place. It sort of looks like ntdll/tests is the place but it is not clear. Is there a guide for locating this one? Jeff

Re: [2/6] winhttp: Allow winhttp to use wininet.h with winhttp.h

On Friday 18 July 2008 16:11:37 Dan Kegel wrote: > Building winhttp on top of wininet lets us develop on trunk and > is probably the fastest path to making a bunch of applications > happy, isn't it? That's the way I'm leaning, anyway. True, but that's been tried already: http://www.mail-archi

valgrind progress: down to 164 errors in 52 tests

This morning a whole bunch of warnings in directx, dde, gdiplus, and winmm were fixed; see http://kegel.com/wine/valgrind/logs/2008-07-18-07.39-summary.txt This brings us down from yesterday's 187 errors in 67 tests to 164 errors in 52 tests. That's a nice way to start the day.

Re: [1/2] server: fix async read on mailslot

Hi Ambroz, - FILE_SYNCHRONOUS_IO_NONALERT ); +read_timeout ? 0 : FILE_SYNCHRONOUS_IO_NONALERT ); This looks incorrect. You probably want to compare to -1, not zero. Zero means reads must not block at all, an

Re: [2/6] winhttp: Allow winhttp to use wininet.h with winhttp.h

James Hawkins wrote: > On Fri, Jul 18, 2008 at 9:11 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> James wrote: >>> I thought the idea was to implement winhttp and then >>> implement wininet on top of winhttp. Why are you importing wininet? >> As of January, Hans was still talking about implementing

Re: Re[2]: advapi32: "RegGetValue" fails with some correct combinations of "dwFlags"

2008/7/18 Mathias Kosch <[EMAIL PROTECTED]>: > Alexandre Julliard wrote: > >> Patches should be generated from the top-level directory. > Sorry for that, I fixed it. Please read [1] to find out how to properly send patches in Wine. You need to send one patch per email. [1] http://www.winehq.org/

Re: [2/6] winhttp: Allow winhttp to use wininet.h with winhttp.h

On Fri, Jul 18, 2008 at 9:11 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > James wrote: >> I thought the idea was to implement winhttp and then >> implement wininet on top of winhttp. Why are you importing wininet? > > As of January, Hans was still talking about implementing > winhttp on top of winin

Re: ntdll: Remove byte reversed U+3000 (CJK space) from being checked in RtlIsTextUnicode.

Dan Kegel wrote: > Hang on, if you don't check U+3000 in the big endian > case, you probably shouldn't check it in the little endian > case, either, right? > > Well the problem is 0x0030 maps to a regular ASCII space. In order to really check this particular character in byte-reversed form it w

re: [2/6] winhttp: Allow winhttp to use wininet.h with winhttp.h

James wrote: > I thought the idea was to implement winhttp and then > implement wininet on top of winhttp. Why are you importing wininet? As of January, Hans was still talking about implementing winhttp on top of wininet ( http://www.winehq.org/pipermail/wine-devel/2008-January/062172.html http:/

re: ntdll: Remove byte reversed U+3000 (CJK space) from being checked in RtlIsTextUnicode.

Hang on, if you don't check U+3000 in the big endian case, you probably shouldn't check it in the little endian case, either, right?

Re: fix async read on mailslots

2008/7/18 Ambroz Bizjak <[EMAIL PROTECTED]>: > Hi, > In Wine creating a mailslot (CreateMailslot) with non-zero timeout > (argument 3 to CreateMailslot) and then attempting an asynchronous read on > it will cause a synchronous read to be performed - ReadFile will block > instead of failing with ERR

Re: [2/6] winhttp: Allow winhttp to use wininet.h with winhttp.h

On Friday 18 July 2008 05:45:15 James Hawkins wrote: > I thought the idea was to implement winhttp and then implement wininet > on top of winhttp. Why are you importing wininet? wininet on top of winhttp is the most promising option but I don't think a consensus has been reached yet. A technica

Re: advapi32: "RegGetValue" fails with some correct combinations of "dwFlags"

Mathias Kosch <[EMAIL PROTECTED]> writes: > --- old/registry.c2008-07-11 17:55:55.0 +0200 > +++ registry.c2008-07-18 01:39:21.0 +0200 > @@ -1466,6 +1466,8 @@ Patches should be generated from the top-level directory. -- Alexandre Julliard [EMAIL PROTECTED]

Re: kernel32 [1/2]: Don't try to convert a possibly uninitialized out param on error

"James Hawkins" <[EMAIL PROTECTED]> writes: > Changelog: > * Don't try to convert a possibly uninitialized out param on error. There are several ways to fix that one, it will need test cases to find out which one is right. -- Alexandre Julliard [EMAIL PROTECTED]