Re: dlls/ws2_32/tests/sock.c: Wait on thread handles before closing sockets

Diff doesn't look in line with the description (I can't see any waits in the diff :) 2008/7/15 Jon Griffiths <[EMAIL PROTECTED]>: > Hi, > > In the socket tests, avoid a race by waiting for the read threads to finish > before closing the sockets (found during TransmitFile testing). > > Cheers > Jo

Re: advpack: Sign-compare warnings fix (Resend)

Am Montag, den 14.07.2008, 23:33 +0100 schrieb Andrew Talbot: > >> (The reason I say > >> "decimal zero" is because decimal constants are signed, whereas > >> hexadecimal constants are unsigned[!] Thus, ~0x0 would be a viable > >> alternative.) > > In fact, I have just tried both ~0 and ~0x0 and ne

RE: CUDA wrapper

Am Montag, den 14.07.2008, 23:18 -0500 schrieb Stefan Dösinger: > WINEDEBUG=+trace doesn't really do anything. using WINEDEBUG=trace+all > (or just +all) will enable *lots* of debug output. Right. > However, what you want to do is to add something like this to your > cuda wrapper: > At the beginni

RE: Compile error in wine-1.1.1

George Dunlap [mailto:[EMAIL PROTECTED] wrote: > Downloaded wine-1.1.1.tar.bz2, and after unzipping, running > configure (which included adding some -dev libraries to make > it happy) and 'make depend', it ran for several minutes > before stopping here: > > --snip-- > make[2]: Leaving director

RE: [1/8] [d3d8] validate pool type in CreateVolumeTexture

> +if ((DWORD)(Pool) >= 4) { > +ERR("(%p) Called with invalid pool type\n", This); > +return D3DERR_INVALIDCALL; > +} You could use if(Pool != D3DPOOL_DEFAULT && Pool != MANAGED ...) instead of comparing to the arbitary value "4". The compiler should figure that out and gen

RE: [5/8] [wined3d] correctly set lockable boolean in IWineD3DDeviceImpl_CreateVolume

> +if (Usage & WINED3DUSAGE_DYNAMIC) > +object->lockable = ((WINED3DPOOL_DEFAULT == Pool) || > (WINED3DPOOL_SYSTEMMEM > == Pool)) ? TRUE : > FALSE; The pool check here is somewhat redundant because a DYNAMIC texture of a non-default / non-systemmem pool w

RE: CUDA wrapper

WINEDEBUG=+trace doesn't really do anything. using WINEDEBUG=trace+all (or just +all) will enable *lots* of debug output. However, what you want to do is to add something like this to your cuda wrapper: At the beginning of the file, after the includes: WINE_DEFAULT_DEBUG_CHANNEL(cuda);

Re: CUDA wrapper

We have tried to get the trace, many different ways, but to no avail. I've read through everything on running a trace of it and I've tried it with different files and it works fine but when we try it with the folding client we don't get any trace. The cudart.dll.so which is placed in the /usr/local

Re: Compile error in wine-1.1.1

Am 15.07.2008 um 01:13 schrieb George Dunlap: > Downloaded wine-1.1.1.tar.bz2, and after unzipping, running configure > (which included adding some -dev libraries to make it happy) [...] You need really a lot of packages: If it still doesn't work,

Compile error in wine-1.1.1

Downloaded wine-1.1.1.tar.bz2, and after unzipping, running configure (which included adding some -dev libraries to make it happy) and 'make depend', it ran for several minutes before stopping here: --snip-- make[2]: Leaving directory `/home/dunlapg/src/wine-1.1.1/dlls/mswsock' make[2]: Entering d

Re: advpack: Sign-compare warnings fix (Resend)

Andrew Talbot wrote: > Andrew Talbot wrote: > >> (The reason I say >> "decimal zero" is because decimal constants are signed, whereas >> hexadecimal constants are unsigned[!] Thus, ~0x0 would be a viable >> alternative.) >> > > In fact, I have just tried both ~0 and ~0x0 and neither worked. (I

Re: [PATCH 1/2] user32: Add more tests for SetWindowPos.

On Fri, Jul 11, 2008 at 6:28 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > The fix looks good now, but you should really test the message sequences > instead of just counting a single message. We have already all the > necessary mechanisms for this. > > -- > Alexandre Julliard > [EMAIL PROTEC

Re: advpack: Sign-compare warnings fix (Resend)

Andrew Talbot wrote: > (The reason I say > "decimal zero" is because decimal constants are signed, whereas > hexadecimal constants are unsigned[!] Thus, ~0x0 would be a viable > alternative.) > In fact, I have just tried both ~0 and ~0x0 and neither worked. (I can't figure out why the latter fa

Re: [WineHQ][WWN] WWN 349

On Mon, Jul 14, 2008 at 5:05 PM, Bryan DeGrendel <[EMAIL PROTECTED]> wrote: > On Mon, Jul 14, 2008 at 7:20 AM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: >> On Sun, Jul 13, 2008 at 11:41 PM, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: Zachary Goldberg wrote: >>> >>> ... but did not spell check :

Re: [WineHQ][WWN] WWN 349

On Mon, Jul 14, 2008 at 7:20 AM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > On Sun, Jul 13, 2008 at 11:41 PM, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: >>> Zachary Goldberg wrote: >> >> ... but did not spell check :) >> Granted, the movie quote is pretty funny, even if isn't spelled right. >> >>

Re: advpack: Sign-compare warnings fix (Resend)

Hi Michael, Michael Stefaniuc wrote: > Andrew Talbot wrote: >> -if (!szConvertedList || dwFileCount == -1) >> +if (!szConvertedList || (LONG)dwFileCount == -1) > This one could be replaced by a comparison with either "-1u" or "~0". > > bye > michael The first of these would work

RE: wined3d: Enable filtering for D3DFMT_A4R4G4B4.

Looks ok to me > -Original Message- > From: [EMAIL PROTECTED] [mailto:wine-patches- > [EMAIL PROTECTED] On Behalf Of Philip Nilsson > Sent: Monday, July 14, 2008 11:20 AM > To: [EMAIL PROTECTED] > Subject: wined3d: Enable filtering for D3DFMT_A4R4G4B4. > > This patch enables texture filte

Re: advpack: Sign-compare warnings fix (Resend)

Andrew Talbot wrote: > Is there anything wrong with this patch, please? If I might venture a guess it's probably because of the casts. Casts are evil if not really needed and using casts to get rid of the sign comparison warnings is debatable at best. > --- > Changelog: > advpack: Sign-compa

new valgrind warnings in IWineD3DImpl_CreateDevice, IDirectDrawImpl_CreateSurface

Lots of tests are showing new valgrind warnings involving IWineD3DImpl_CreateDevice, e.g. http://kegel.com/wine/valgrind/logs/2008-07-14-06.13/vg-ddraw_dsurface-diff.txt + Invalid free() / delete / delete[] +at notify_free (heap.c:199) +by RtlFreeHeap (heap.c:1284) +by compile_state

Re: wined3d: universal surface convertor function for unsigned integer color formats

On Monday 14 July 2008 18:21:19 Stefan Dösinger wrote: > There's a pixelformat table that describes bitmasks and sizes in utils.c, > you can access it with a function that is next to it. I think you can infer > the shifting information from this table, if not please add it there > instead of creati

Re: wined3d: universal surface convertor function for unsigned integer color formats

On Mon, Jul 14, 2008 at 02:51:42AM +0400, Victor Eremin wrote: > > Converter function supports conversion between most of > "unsigned color" argb/xrgb surface formats (like D3DFMT_A8R8G8B8, > D3DFMT_A8R3G3B2, and so on), and between "luminosity" color formats > (D3DFMT_L8, etc), excluding D3DFMT_

Re: [4/8] [d3d9] handle invalid usage/pool combinations in CreateVolumeTexture

2008/7/14 Stefan Dösinger <[EMAIL PROTECTED]>: >> As you note in your comment, most of this should go into wined3d. I >> also think this should for the most part use the same code that is >> used for CheckDeviceFormat in dlls/wined3d/directx.c. Roderick would >> probably be able to help you best th

RE: [4/8] [d3d9] handle invalid usage/pool combinations in CreateVolumeTexture

> As you note in your comment, most of this should go into wined3d. I > also think this should for the most part use the same code that is > used for CheckDeviceFormat in dlls/wined3d/directx.c. Roderick would > probably be able to help you best there, but he's currently away. I am not sure, ddraw

RE: wined3d: universal surface convertor function for unsigned integer color formats

There's a pixelformat table that describes bitmasks and sizes in utils.c, you can access it with a function that is next to it. I think you can infer the shifting information from this table, if not please add it there instead of creating your own table. Also please do not use C++ comments("//"

Re: [4/8] [d3d9] handle invalid usage/pool combinations in CreateVolumeTexture

2008/7/14 Tobias Jakobi <[EMAIL PROTECTED]>: > Hi there, > > this patchset fixes conformance of volumes/volumetextures creation (plus > locking) in d3d8 and d3d9. Currently creating volumes/volumetextures > always succeeds regardless of the usage and pool type specified. > > A testcase for both d3d

Re: Allow running conformance tests in parallel

On Sun, Jul 13, 2008 at 9:59 PM, Scott Ritchie <[EMAIL PROTECTED]> wrote: >> About the same number of tests fail regardless of -j value. > > "About" -- shouldn't it be exactly? Yes, but our tests are flaky.

re: Illegal attachment in bug 14461

Vitaliy wrote: > Bugzilla admin(s) please remove the illegal attachment from the > http://bugs.winehq.org/show_bug.cgi?id=14461 Deleted.

RE: [PATCH2+TEST] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

> > ==> > > > # Patch> > > > ==> > > > --- wine-1.1.1-orig/dlls/user32/win.c 2008-07-12 01:55:55.0 > > +1000> > +++ wine-1.1.1/dlls/us

Re: [PATCH2+TEST] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008/7/14 Hongbo Ni <[EMAIL PROTECTED]>: > > Now I have fixed the problem, or corrected to window behaviour. Included is > the Patch, Test and Debug (play with windows). Can anyone please test or > comment ? > > Regards > Hongbo Ni > > ==

Re: [WineHQ][WWN] WWN 349

On Sun, Jul 13, 2008 at 11:41 PM, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: >> Zachary Goldberg wrote: > > ... but did not spell check :) > Granted, the movie quote is pretty funny, even if isn't spelled right. > > Ivan > What is spelled wrong? -Zach

Re: iPod patches

On Mon, Jun 9, 2008 at 12:12 PM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Hello Austin, > > 2008/6/9 Austin English <[EMAIL PROTECTED]>: >> Howdy Maarten, >> >> I'm trying to do some dogfood testing with iTunes, and am building a >> wine build with a few hacks to get around the ddraw blacking

Re: configure: add ip_icmp.h for getICMPStats on FreeBSD

EA Durbin <[EMAIL PROTECTED]> writes: > diff --git a/configure.ac b/configure.ac > index bd764a3..500cae1 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -274,6 +274,7 @@ AC_CHECK_HEADERS(\ > mntent.h \ > ncurses.h \ > netdb.h \ > +netinet/ip_icmp.h \ > netine

[PATCH2+TEST] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

Hello, Now I have fixed the problem, or corrected to window behaviour. Included is the Patch, Test and Debug (play with windows). Can anyone please test or comment ? Regards Hongbo Ni == # Patch ==