RE: CUDA wrapper

Wine links against cudart.dll.so from /usr/lib/ or wherever it is. You don't have to put it in C:\windows\... . You can put a TRACE or ERR into the cudaMalloc(or whatever) function implementation in your code to write a message to check if the functions are properly called. I suspect they are,

Re: gdiplus: Add a trailing '\n' to Wine traces.

> @@ -327,7 +327,7 @@ GpStatus WINGDIPAPI > GdipGetFontHeightGivenDPI(GDIPCONST GpFont *font, REAL dpi, > { > if (!(font && height)) return InvalidParameter; > > -FIXME("%p (%s), %f, %p\n)", font, > +FIXME("%p (%s), %f, %p\n)\n", font, The first \n in the fixme should be removed. Bes

Re: gdiplus: Add a trailing '\n' to Wine traces.

Francois Gouget wrote: > --- > > I believe it's independent from the spelling fixes patch. I'll > resubmit if not. > > dlls/gdiplus/font.c |2 +- > dlls/gdiplus/image.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) I think you should just remove a bracket here: -FIXME("%

Re: Crashes in winetest under wine

2008/7/10 Alexandre Julliard <[EMAIL PROTECTED]>: > "Austin Lund" <[EMAIL PROTECTED]> writes: > >> 2008/7/7 Austin Lund <[EMAIL PROTECTED]>: >>> 2008/7/3 Austin Lund <[EMAIL PROTECTED]>: I get a crash all the time in winetest since 1.0. Seems there is not a problem with any of the tests

Re: CUDA wrapper

Well at least it compiled, but it isn't working. We are still getting the message that the function isn't implemented. Initializing Nvidia gpu library cudaMalloc CUDAStream::Allocate failed feature is not yet implemented Now both cudamalloc and all four cuda stream's, cudaStreamCreate, Destroy,

Re: Revert "winemp3: Don't keep unused data buffered."

On Wednesday 09 July 2008 04:18:50 pm Maarten Lankhorst wrote: > Try any mp3 in windows media player 10 with and without your patch, it > makes mp3 playback there completely broken. As mentioned in the bug The problem is either the lack of error prop

Re: Feedback for "Regedit: Implement deleting multiple values"

På Onsdag 09 juli 2008 , 13:36:19 skrev Andre Wisplinghoff: > Hallo, > > my patch [1] wasn't applied. Can anyone give me a hint what wasn't OK with > it? > Thanks for your time. > You could use standard MessageBox() instead of making messagebox() non-static. Alexander N. Sørnes > Best Regards >

Re: Revert "winemp3: Don't keep unused data buffered."

Hi Chris, 2008/7/9 Chris Robinson <[EMAIL PROTECTED]>: > On Wednesday 09 July 2008 11:44:17 am Maarten Lankhorst wrote: >> This reverts commit 8f46a5119249562aceabff6d120948cbfacb6423. >> The data isn't unused, mp3's can set up 'bit buckets', so while the >> bit rate is constant, some data is need

Re: [dplayx 02/29] Tests for DirectPlayCreate

Am Mittwoch, den 09.07.2008, 20:15 +0300 schrieb Ismael Barros: > Thanks for the review :) No problem. > On 7/9/08, Michael Karcher <[EMAIL PROTECTED]> wrote: > > I dislike the order of the parameters and the name. You would write > Because _okHR compares HRESULT codes, but there's also _ok to co

Re: Feedback for "Regedit: Implement deleting multiple values"

On Wed, Jul 9, 2008 at 6:36 AM, Andre Wisplinghoff <[EMAIL PROTECTED]> wrote: > Hallo, > > my patch [1] wasn't applied. Can anyone give me a hint what wasn't OK with > it? > Thanks for your time. > Couple non code things: 1) Real name in the patch. 2) No html email --John Klehm

Re: Revert "winemp3: Don't keep unused data buffered."

On Wednesday 09 July 2008 11:44:17 am Maarten Lankhorst wrote: > This reverts commit 8f46a5119249562aceabff6d120948cbfacb6423. > The data isn't unused, mp3's can set up 'bit buckets', so while the > bit rate is constant, some data is needed anyway for later playback. > --- I don't believe revertin

Re: mshtml.dll:Add implementation of HTMLDocument_(Get|Set)Title

В сообщении от Friday 04 July 2008 19:23:32 вы написали: > Ivan Sinitsin wrote: > > Changelog: > > mshtml.dll:Add implementation of HTMLDocument_(Get|Set)Title > > First of all it would be nice if you could add a test case for these. > Hi, I make test for HTMLDocument_(Get|Set)Title. What do

Feedback for "Regedit: Implement deleting multiple values"

Hallo, my patch [1] wasn't applied. Can anyone give me a hint what wasn't OK with it? Thanks for your time. Best Regards - Andre Wisplinghoff [1] http://www.winehq.org/pipermail/wine-patches/2008-July/057227.html

Re: [dplayx 02/29] Tests for DirectPlayCreate

On Wednesday 09 July 2008 19:15:34 Ismael Barros wrote: > > >> +heap = HeapCreate( 0, 0, 0 ); > > > > Do you have any reason to create your own heap? Each windows process > > already comes equipped with a standard heap you can obtain using the API > That's what I used in the begining, but I've

Re: Crashes in winetest under wine

"Austin Lund" <[EMAIL PROTECTED]> writes: > 2008/7/7 Austin Lund <[EMAIL PROTECTED]>: >> 2008/7/3 Austin Lund <[EMAIL PROTECTED]>: >>> I get a crash all the time in winetest since 1.0. Seems there is not >>> a problem with any of the tests themselves (i.e. running make test). >>> >>> The last few

Re: [dplayx 02/29] Tests for DirectPlayCreate

Thanks for the review :) On 7/9/08, Michael Karcher <[EMAIL PROTECTED]> wrote: > Hello Ismael, > > reviewing this patch shows some issues. > > > +#define _okHR(expected, result) \ >> +ok( (expected) == (result), \ >> +"expected=%d(%s) go

Re: [dplayx 02/29] Tests for DirectPlayCreate

On Wed, Jul 9, 2008 at 11:21 AM, Michael Karcher <[EMAIL PROTECTED]> wrote: > Hello Ismael, > > reviewing this patch shows some issues. > > > +#define _okHR(expected, result) \ >> +ok( (expected) == (result), \ >> +"expected=%d(%s) got=%d

Re: CUDA wrapper

> [EMAIL PROTECTED]:~/wine/patches/cuda$ make > winegcc -shared cuda.dll.spec -mno-cygwin -o cuda.dll.so cudart.o > /usr/local/cuda/lib/libcudart.so.2.0 -lodbc32 -lole32 -loleaut32 -lwinspool > -luuid -lcudart > gcc: /usr/local/cuda/lib/libcudart.so.2.0: linker input file unused because > linking

Re: [dplayx 02/29] Tests for DirectPlayCreate

Hello Ismael, reviewing this patch shows some issues. > +#define _okHR(expected, result) \ > +ok( (expected) == (result), \ > +"expected=%d(%s) got=%d(%s)\n", \ > +HRESULT_CODE(expected), dpResult2str(expected),

Re: [Gdiplus 11/15] Implement GdipCreateRegionRect

On Wed, Jul 09, 2008 at 10:56:48AM -0400, Adam Petaccia wrote: > I didn't mean to imply that I ignored the region.c header, but I didn't > use any of its information for the bounds tests yet, so I didn't add > them to the struct (and I've learned to add things as needed). The bounds checks are rea

Re: [Gdiplus 11/15] Implement GdipCreateRegionRect

I was just about to reply to your first mail when I found this pop up. Anyway, To quote MSDN: "The Region class describes an area of the display surface. The area can be any shape. In other words, the boundary of the area can be a combination of curved and straight lines. Regions can also be c

Re: [Gdiplus 11/15] Implement GdipCreateRegionRect

On Wed, Jul 09, 2008 at 11:58:23AM +0100, Huw Davies wrote: > This doesn't look right. See the GdipGetRegionData tests (and extend > them to add paths), these are supposed to help understanding how > regions are stored. It looks to me that a region is stored as a > sequence of rects and paths tha

user32: Problem using SetClassLongW to subclass built-in control (Edit)

Hi, Summary: SetClassLongW(hEdit, GCL_WNDPROC,(DWORD)NewEditWndProc) in Wine differs from Windows. Background: when a standard built-in window class (such as Edit for example) is registered initially, the window system register the class with two Procedures (procA and ProcW) and assign a

Re: [Gdiplus 11/15] Implement GdipCreateRegionRect

On Wed, Jul 09, 2008 at 03:34:01AM -0400, Adam Petaccia wrote: > --- > dlls/gdiplus/region.c | 28 > dlls/gdiplus/tests/region.c |8 > 2 files changed, 28 insertions(+), 8 deletions(-) > > diff --git a/dlls/gdiplus/region.c b/dlls/gdiplus/region.c

Re: msvcrt: Fix printf exponent with tests (resend/update)

Jon Griffiths <[EMAIL PROTECTED]> writes: > diff --git a/dlls/msvcrt/wcs.c b/dlls/msvcrt/wcs.c > index 14daf90..bbbc3f1 100644 > --- a/dlls/msvcrt/wcs.c > +++ b/dlls/msvcrt/wcs.c > @@ -481,6 +481,44 @@ static void pf_integer_conv( char *buf, int buf_len, > pf_flags *flags, > return; > } >

Re: [PATCH 2/2] user32: Set WM_NOSIZE for windows smaller than SM_CXMINTRACK/SM_CYMINTRACK.

"Lei Zhang" <[EMAIL PROTECTED]> writes: > I'm trying to make the test in patch 1/2 pass. > > - I want DEFWND_HandleWindowPosChanged to see SWP_NOCLIENTSIZE = 1. > - SWP_NOCLIENTSIZE gets set to 0 in SWP_DoNCCalcSize because the > client size has changed. > - the client size has changed because the

Re: [Gdiplus 07/15] Stub GdipFillRegion

On Wed, Jul 09, 2008 at 03:33:47AM -0400, Adam Petaccia wrote: > --- > dlls/gdiplus/gdiplus.spec |2 +- > dlls/gdiplus/region.c | 11 +++ > 2 files changed, 12 insertions(+), 1 deletions(-) > > diff --git a/dlls/gdiplus/region.c b/dlls/gdiplus/region.c > index 3d95723..717119f 1

Re: [1/2] richedit: Prevented cursor flicker while moving over selection bar

"Dylan Smith" <[EMAIL PROTECTED]> writes: > diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c > index 7e90096..96ab4aa 100644 > --- a/dlls/riched20/editor.c > +++ b/dlls/riched20/editor.c > @@ -1663,10 +1663,13 @@ static int ME_CalculateClickCount(HWND hWnd, UINT > msg, WPARAM wParam,

Re: bug 14361: co-operate with valgrind at execv

John Reiser <[EMAIL PROTECTED]> writes: > Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14361 > co-operate with valgrind at execv You shouldn't need anything like that, running the whole thing including the preloader under valgrind should work fine. At worst some reservations w

Re: wininet: tests/http.c: Improve HttpOpenRequest test

Zac Brown <[EMAIL PROTECTED]> writes: > +SetLastError(0xdeadbeef); > ret = HttpSendRequest(request, NULL, 0, NULL, 0); > ok(ret, "HttpSendRequest failed: %u\n", GetLastError()); > +ok(GetLastError() == ERROR_FILE_NOT_FOUND || > + GetLastError() == ERROR_SUCCESS, > + "

Re: [PATCH] user32: Add test for GetDC

Ilya Shpigor <[EMAIL PROTECTED]> writes: > Add test for GetDC. This test check is WM_PAINT message send by GetDC > function. There isn't even a GetDC call in that test. Most likely all you are seeing is that expose events generate WM_PAINT, which is as it should be. What are you trying to test?

Re: Alexandre Julliard : dinput: Don' t depend on the dxerr8 static library in the tests.

Vitaliy Margolen <[EMAIL PROTECTED]> writes: > Any particular reason for this patch? It makes it that much more complicated > to decipher what the error code is. It's necessary to allow make crosstest to work with the Wine libraries instead of the broken mingw ones. -- Alexandre Julliard [EMAI