Re: Some Questions From The Bugzilla Project

2008-06-24 Thread Max Kanat-Alexander
Hey guys! I really appreciate all the feedback, but could you work it all out together and then have one person send me all the answers to the questions that I sent? I'm surveying about 25 organizations, it's hard to keep track of things if there's a lot of separate emails from each one.

Re: Some Questions From The Bugzilla Project

2008-06-24 Thread Max Kanat-Alexander
On Tue, 24 Jun 2008 11:18:25 -0500 "James Hawkins" <[EMAIL PROTECTED]> wrote: > Can we do this in an open forum like wine-devel instead of having one > point of contact? I think we all have particular issues with bugzilla > that we don't necessarily communicate to the project. Having said > that,

Re: secur32: Allow loading external schannel.dll.

2008-06-24 Thread Austin Lund
I cannot get this to work with googletalk.exe. I get the following messages: trace:secur32:SECUR32_initializeProviders trace:secur32:_tryLoadProvider loaded L"schannel.dll", InitSecurityInterfaceA is 0x7ec2fae0, InitSecurityInterfaceW is 0x7ec2fb00 trace:secur32:_tryLoadProvider L"schannel.dll" h

Re: Some Questions From The Bugzilla Project

2008-06-24 Thread James Hawkins
On Tue, Jun 24, 2008 at 1:32 PM, Austin English <[EMAIL PROTECTED]> wrote: > On Tue, Jun 24, 2008 at 1:34 AM, Max Kanat-Alexander > <[EMAIL PROTECTED]> wrote: >>Hey there Wine Bugzilla folks. I've been funded by the Mozilla >> Foundation to do a survey of the major Bugzilla-using organizati

Re: [1/2] gdi32: defines for CreateFontIndirectEx (try3)

2008-06-24 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > --- a/include/wingdi.h > +++ b/include/wingdi.h > @@ -573,8 +573,8 @@ DECL_WINELIB_TYPE_AW(LPLOGFONT) > typedef struct > { > LOGFONTA elfLogFont; > - BYTE elfFullName[LF_FULLFACESIZE]; > - BYTE elfStyle[LF_FACESIZE]; > + CHAR elfF

Re: ntdll: Add timestamp channel to log output.

2008-06-24 Thread Dmitry Timoshkov
"Peter Urbanec" <[EMAIL PROTECTED]> wrote: > @@ -164,8 +166,16 @@ static int NTDLL_dbg_vlog( enum __wine_debug_class cls, > struct __wine_debug_chan > /* only print header if we are at the beginning of the line */ > if (info->out_pos == info->output || info->out_pos[-1] == '\n') > { >

Re: Some Questions From The Bugzilla Project

2008-06-24 Thread Dmitry Timoshkov
"Max Kanat-Alexander" <[EMAIL PROTECTED]> wrote: > Hey there Wine Bugzilla folks. I've been funded by the Mozilla > Foundation to do a survey of the major Bugzilla-using organizations in > the world, to find out what people like and don't like about Bugzilla, > what we could improve, what changes

Re: sorry forgot to cut and paste some code =)

2008-06-24 Thread James Hawkins
On Tue, Jun 24, 2008 at 8:45 PM, <[EMAIL PROTECTED]> wrote: > the code is in : > > wine-1.0/dlls/wined3d/context.c > > > here is the changed code : > diff is your friend. -- James Hawkins

sorry forgot to cut and paste some code =)

2008-06-24 Thread celticht32
the code is in : wine-1.0/dlls/wined3d/context.c here is the changed code : /* This function takes care of WineD3D pixel format selection. */ static int WineD3D_ChoosePixelFormat(IWineD3DDeviceImpl *This, HDC hdc, WINED3DFORMAT ColorFormat, WINED3DFORMAT DepthStencilFormat, BOOL auxBuffers,

RE: Code Review and findings in d3d while working on figuring out why...

2008-06-24 Thread Stefan Dösinger
Hi, It is helpful if you can provide a bit of code context next to the line numbers you refer to, or at least specify the wine version / git HEAD to which the numbers refer to. Otherwise it is pretty hard to find out which line you're refering to

Re: "remote" start/stop of relay/snoop output

2008-06-24 Thread Massimo
Austin English ha scritto: > On Mon, Jun 23, 2008 at 5:57 PM, <[EMAIL PROTECTED]> wrote: >> I asked that question some years ago, and IIRC then it was not possible, >> so I resorted to add an external filter app in order to start/stop >> relays on an already running app. >> Filter app solved parti

Revert "winspool.drv: Make sure the printer driver registry entry exists.

2008-06-24 Thread Detlef Riekenberg
On Di, 2008-06-24 at 10:25 -0700, Dan Kegel wrote: > Today I started getting a heap corruption and crash in localspl: > ... > Anyone know what's up with that? That was introduced by Huw (added a circular dependance). Changelog: Revert "winspool.drv: Make sure the printer driver registry entry e

Re: rasapi32: return an error for invalid paramaters

2008-06-24 Thread Austin English
On Tue, Jun 24, 2008 at 3:55 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Tue, Jun 24, 2008 at 3:47 PM, Austin English <[EMAIL PROTECTED]> wrote: >> > > Changes like these are so simple that you really should go the extra 5 > feet and write simple tests for them. > > -- > James Hawkins > I ha

Re: rasapi32: return an error for invalid paramaters

2008-06-24 Thread James Hawkins
On Tue, Jun 24, 2008 at 3:47 PM, Austin English <[EMAIL PROTECTED]> wrote: > Changes like these are so simple that you really should go the extra 5 feet and write simple tests for them. -- James Hawkins

Re: quartz: Have thread safety in memallocator

2008-06-24 Thread Rob Shearman
2008/6/23 Maarten Lankhorst <[EMAIL PROTECTED]>: > @@ -286,19 +287,24 @@ static HRESULT WINAPI > BaseMemAllocator_GetBuffer(IMemAllocator * iface, IMediaSa > > *pSample = NULL; > > -if (!This->bCommitted) > -return VFW_E_NOT_COMMITTED; > +EnterCriticalSection(This->pCritSect);

Code Review and findings in d3d while working on figuring out why...

2008-06-24 Thread celticht32
Ok I have been wandering around the code in context.c and have found a few things that I have opened a bug on (14000) but in further looking in context.c if I comment out the lines between 237 and 245 wine seems to continue working better infact? (I no longer get no iPixel errors using win

Re: Some Questions From The Bugzilla Project

2008-06-24 Thread Austin English
On Tue, Jun 24, 2008 at 1:34 AM, Max Kanat-Alexander <[EMAIL PROTECTED]> wrote: >Hey there Wine Bugzilla folks. I've been funded by the Mozilla > Foundation to do a survey of the major Bugzilla-using organizations in > the world, to find out what people like and don't like about Bugzilla, >

Re: New scroll test, help in figuring out Win9x (Was: Re: new failing tests)

2008-06-24 Thread James Hawkins
On Tue, Jun 24, 2008 at 12:28 PM, Alex Villací­s Lasso <[EMAIL PROTECTED]> wrote: > James Hawkins escribió: >> >> Hi Alex, >> >> The following commit introduces several windows test failures across >> the board in riched20: >> >> commit 0e9ed5c10e3ac6b253712037f0b30046a5656239 >> Author: Alex Villa

Re: Some Questions From The Bugzilla Project

2008-06-24 Thread Zachary Goldberg
On Tue, Jun 24, 2008 at 12:18 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Tue, Jun 24, 2008 at 1:34 AM, Max Kanat-Alexander > <[EMAIL PROTECTED]> wrote: >>Hey there Wine Bugzilla folks. I've been funded by the Mozilla >> Foundation to do a survey of the major Bugzilla-using organizati

New scroll test, help in figuring out Win9x (Was: Re: new failing tests)

2008-06-24 Thread Alex Villací­s Lasso
James Hawkins escribió: Hi Alex, The following commit introduces several windows test failures across the board in riched20: commit 0e9ed5c10e3ac6b253712037f0b30046a5656239 Author: Alex Villacís Lasso <[EMAIL PROTECTED]> Date: Sun May 11 09:54:58 2008 -0500 richedit: Empty text should re

Crash in localspl test?

2008-06-24 Thread Dan Kegel
Today I started getting a heap corruption and crash in localspl: [EMAIL PROTECTED]:~/wine-git/dlls/localspl/tests$ ../../../tools/runtest -P wine -M localspl.dll -T ../../.. -p localspl_test.exe.so localmon.c err:heap:HEAP_ValidateInUseArena Heap 0x11: bad size 001232a0 for in-use arena 0x1231

Re: "remote" start/stop of relay/snoop output

2008-06-24 Thread Austin English
On Mon, Jun 23, 2008 at 5:57 PM, <[EMAIL PROTECTED]> wrote: > I asked that question some years ago, and IIRC then it was not possible, > so I resorted to add an external filter app in order to start/stop > relays on an already running app. > Filter app solved partially the problem : I could get th

Re: ntdll: Add time stamps to log output.

2008-06-24 Thread Peter Urbanec
Dmitry Timoshkov wrote: > "Peter Urbanec" <[EMAIL PROTECTED]> wrote: > >> This patch will prefix every line of log output with a time stamp. > > At the very least this should be a separate debug channel, if it ever gets > included at all. I am about to resubmit the patch which uses a separate cha

Re: Some Questions From The Bugzilla Project

2008-06-24 Thread James Hawkins
On Tue, Jun 24, 2008 at 1:34 AM, Max Kanat-Alexander <[EMAIL PROTECTED]> wrote: >Hey there Wine Bugzilla folks. I've been funded by the Mozilla > Foundation to do a survey of the major Bugzilla-using organizations in > the world, to find out what people like and don't like about Bugzilla, >

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Huang, Zhangrong
2008/6/24 Dmitry Timoshkov <[EMAIL PROTECTED]>: > > That definitely will break any charset specified in the font (like > symbol, russian, etc.) in CJK locale. Most likely what happens is > a font linking/substituting for ANSI_CHARSET. > I think it doesn't. If users create font with ANSI_CHARSET or

[PATCH] WM_IME_SETCONTEXT is sent when a window is activated

2008-06-24 Thread Christopher GAUTIER
Hello, Following up on http://www.winehq.org/pipermail/wine-patches/2008-May/055400.html >> Description: >> The WM_IME_SETCONTEXT message should be sent when a window is >> (de)activated >> (source: >> http://msdn.microsoft.com/en-us/library/ms776117(VS.85).aspx) >> The value for lParam w

Some Questions From The Bugzilla Project

2008-06-24 Thread Max Kanat-Alexander
Hey there Wine Bugzilla folks. I've been funded by the Mozilla Foundation to do a survey of the major Bugzilla-using organizations in the world, to find out what people like and don't like about Bugzilla, what we could improve, what changes you'd like to see in Bugzilla, etc., and you guys

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Dmitry Timoshkov
"Huang, Zhangrong" <[EMAIL PROTECTED]> wrote: > I mean fix GdiGetCodePage like: > > if (charset == ANSI_CHARSET || charset == DEFAULT_CHARSET) > { > cp = GetACP(); > if (cp == 936 || cp == 950 || cp == .) > return cp; > >else (TranslateCharsetInfo()) > >

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Huang, Zhangrong
2008/6/24 Dmitry Timoshkov <[EMAIL PROTECTED]>: > >> And could we hardcode CJK codepages to fix GdiGetCodePage? > > What do you mean? I mean fix GdiGetCodePage like: if (charset == ANSI_CHARSET || charset == DEFAULT_CHARSET) { cp = GetACP(); if (cp == 936 || cp == 950 || cp == .)

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Dmitry Timoshkov
"Huang, Zhangrong" <[EMAIL PROTECTED]> wrote: > Sorry, I didn't get that. These tests will pass on Windows > 2000/XP/Vista in different languages except Wine, there are no failing > tests. Should I mark these as todo_wine? If todo_wine doesn't mangle the test too much that's of cause more preferr

RE: ddraw: Stop crash when dd7 isnt installed

2008-06-24 Thread Stefan Dösinger
> Changelog: > ddraw: Stop crash when dd7 isnt installed Do you really think it is worth polluting the code for this case? I haven't seen a windows box without dx7 since a LONG time. If you want to prevent a crash I think it is better to add some santiy checks at the beginning of the test and

Re: ntdll: Add time stamps to log output.

2008-06-24 Thread Dmitry Timoshkov
"Peter Urbanec" <[EMAIL PROTECTED]> wrote: > This patch will prefix every line of log output with a time stamp. > > The time stamps are formatted as [seconds.microseconds] and measured as > elapsed time from the first time a message is output. This helps with > tracking down time sensitive bugs

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Huang, Zhangrong
Sorry, I didn't get that. These tests will pass on Windows 2000/XP/Vista in different languages except Wine, there are no failing tests. Should I mark these as todo_wine? And could we hardcode CJK codepages to fix GdiGetCodePage? Thanks. 2008/6/24 Dmitry Timoshkov <[EMAIL PROTECTED]>: > In the bu

Re: secur32: Allow loading external schannel.dll.

2008-06-24 Thread Huang, Zhangrong
Hi, Which app did you tried? I tried googletalk.exe, it worked as excepted. 2008/6/24 Kai Blin <[EMAIL PROTECTED]>: > The patch doesn't load for me (it looks empty). Could someone bounce it to me > off-list? > -- $ apt-get moo (__) (oo) /--\/ / | || * /\---/\ ~~ ~~ "Have you mooed

Re: secur32: Allow loading external schannel.dll.

2008-06-24 Thread Huang, Zhangrong
Hi, Thanks for mentioning that, I'll update and resend it. 2008/6/24 Juan Lang <[EMAIL PROTECTED]>: > Hi Zhangrong, > > your patch looks fine, but I'd appreciate it if you could update the > comment for SECUR32_addProvider in secur32_priv.h to reflect your > changes. > --Juan > -- $ apt-get mo

Re: user32:tests:msg.c Remove TODO flag from a test.

2008-06-24 Thread Anatoly Lyutin
Alexandre Julliard wrote: > Yes it does: > > ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p > user32_test.exe.so msg.c && touch msg.ok > msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0046 > was expected, but got msg 0x0086 instead > msg.c:4334: Test failed:

Re: user32:tests:msg.c Remove TODO flag from a test.

2008-06-24 Thread Alexandre Julliard
Anatoly Lyutin <[EMAIL PROTECTED]> writes: > The test does not falls at the current Wine. Yes it does: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0046 was expecte

Re: [2/2] gdi32: implementation of CreateFontIndirectEx (fixfor13064)(resent)

2008-06-24 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > Next question is when I'm trying to initialize other fields of > ENUMLOGFONTEXA I see some compiler warnings > about "differ in signedness". It means that already defined ENUMLOGFONT > and ENUMLOGFONTEX > (in wingdi.h) use BYTE as type for elfFullName

Re: [2/2] gdi32: implementation of CreateFontIndirectEx (fix for13064)(resent)

2008-06-24 Thread Nikolay Sivov
Dmitry Timoshkov wrote: > "Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > >>> You neither removed the 'if(!plf)' check, nor added a test or an >>> explanation >>> for this. >> Here I don't follow you. If I want to access elfEnumLogfontEx field >> through pointer, >> so should I check this pointer fi

Re: [2/2] gdi32: implementation of CreateFontIndirectEx (fix for13064)(resent)

2008-06-24 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: >> You neither removed the 'if(!plf)' check, nor added a test or an >> explanation >> for this. > Here I don't follow you. If I want to access elfEnumLogfontEx field > through pointer, > so should I check this pointer first? I thought it's obvious or ma

Re: [2/2] gdi32: implementation of CreateFontIndirectEx (fix for13064) (resent)

2008-06-24 Thread Nikolay Sivov
Dmitry Timoshkov wrote: > "Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > >> +/*** >> >> + * CreateFontIndirectExA (GDI32.@) >> + */ >> +HFONT WINAPI CreateFontIndirectExA( const ENUMLOGFONTEXDVA *plf ) >> +{ >> +if(!

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Dmitry Timoshkov
"Huang, Zhangrong" <[EMAIL PROTECTED]> wrote: > As discussed in Bug 4065 (http://bugs.winehq.org/show_bug.cgi?id=4065) In the bug 4065 I suggested to comment out the failing tests before sending it to wine-patches. -- Dmitry.

Re: [2/2] gdi32: implementation of CreateFontIndirectEx (fix for13064) (resent)

2008-06-24 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > +/*** > + * CreateFontIndirectExA (GDI32.@) > + */ > +HFONT WINAPI CreateFontIndirectExA( const ENUMLOGFONTEXDVA *plf ) > +{ > +if(!plf) return NULL; > + > +return