Re: secur32: Allow loading external schannel.dll.

2008-06-23 Thread Kai Blin
On Monday 23 June 2008 21:41:08 Juan Lang wrote: > Hi Zhangrong, > > your patch looks fine, but I'd appreciate it if you could update the > comment for SECUR32_addProvider in secur32_priv.h to reflect your > changes. The patch doesn't load for me (it looks empty). Could someone bounce it to me of

Re: [PATCH 5/7] widl: Fix type_memsize to follow aliases so that the correct size is calculated.

2008-06-23 Thread Rob Shearman
2008/6/24 Dan Hipschman <[EMAIL PROTECTED]>: > On Mon, Jun 23, 2008 at 10:29:11PM +0100, Rob Shearman wrote: >> diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c >> index 1f8695a..84115fd 100644 >> --- a/tools/widl/typegen.c >> +++ b/tools/widl/typegen.c >> @@ -809,7 +809,9 @@ size_t type_me

Re: [2/8] gdi32: Implementation of CreateFontIndirectEx with test(fixes bug 13064)

2008-06-23 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > +/*** > + * CreateFontIndirectExA (GDI32.@) > + */ > +HFONT WINAPI CreateFontIndirectExA( const ENUMLOGFONTEXDVA *plf ) > +{ > +if(!plf) return NULL; > + > +return

Re: richedit: Ensure caret is seen if moved past end of view over trailing spaces

2008-06-23 Thread Dylan Smith
You can ignore this patch, I will resend it as a series with just what is dependant on it. Sorry about sending such a such a large series of patches before (44 of them) that seemed to be dependant on each other. They actually didn't contain many dependencies on each other. I'll try to make the d

Re: [PATCH 5/7] widl: Fix type_memsize to follow aliases so that the correct size is calculated.

2008-06-23 Thread Dan Hipschman
On Mon, Jun 23, 2008 at 10:29:11PM +0100, Rob Shearman wrote: > diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c > index 1f8695a..84115fd 100644 > --- a/tools/widl/typegen.c > +++ b/tools/widl/typegen.c > @@ -809,7 +809,9 @@ size_t type_memsize(const type_t *t, unsigned int *align) > { >

"remote" start/stop of relay/snoop output

2008-06-23 Thread max
I asked that question some years ago, and IIRC then it was not possible, so I resorted to add an external filter app in order to start/stop relays on an already running app. Filter app solved partially the problem : I could get the relay part I needed, but the speed was about the same as dumping

Re: [updated] winecfg: Added Windows registration information setting

2008-06-23 Thread Alex Villací­s Lasso
Filipe Ferreira escribió: > This is a combination of both patches from my earlier submission. The > reason I made them separate was because I am unable to test other > languages besides > English. Though, if anyone could tell me how to run wine under a > different language, I would test them. >

Re: richedit: Implemented EM_STOPGROUPTYPING, fixed undo grouping (with tests)

2008-06-23 Thread Alex Villací­s Lasso
Dylan Smith escribió: > EM_STOPGROUPTYPING simply ends the undo coalescing transaction. The > remarks for this message on MSDN explains what events stops group > typing, which led me to adding the delete key to the actions that stop > group typing. > > The tests that are included with this patch v

Re: widl: The offset to the pointer layout in complex structures must be positive so add an assert and fix the format string.

2008-06-23 Thread Rob Shearman
2008/6/23 Alexandre Julliard <[EMAIL PROTECTED]>: > "Rob Shearman" <[EMAIL PROTECTED]> writes: > >> Otherwise we could generate an incorrect format string and crash in a >> weird way at runtime instead. > > Looks like the assert works ;) :-) > ../../tools/widl/widl -I. -I. -I../../include -I../..

how to run wine under a different language

2008-06-23 Thread Detlef Riekenberg
On Mo, 2008-06-23 at 02:41 -0400, Filipe Ferreira wrote: > (Anyone care to share how to run wine under a different language?) - Install the language - Select the language from "locale -a" LC_ALL=de_DE.utf8 wine winecfg LC_ALL=en_US.utf8 wine winecfg LC_ALL=it_IT.utf8 wine winecfg -- By

wine 1.0

2008-06-23 Thread Damoun D.
Hi Dan, I just want to say that Wine 1.0 is fantastic! Also, I was wondering if by any chance you have a Google Grandcentral invite you can send me. Thanks so much, Damoun

Re: dinput: Fix name clashes (Resend #2)

2008-06-23 Thread Andrew Talbot
Alexandre Julliard wrote: > Static is for variables, not for types. Types are local to the file they > are declared in, that's why you need header files when you want to share > type declarations. > Ah, yes. It seems that only objects (i.e., named regions of storage) and functions with external

Re: dinput: Fix name clashes (Resend #2)

2008-06-23 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > Not arguing, just clarifying: > > File #1: joystick_input.c has a non-static struct tag called "JoystickImpl". > File #2: joystick_linuxinput.c has a differently defined non-static tag > called "JoystickImpl". Since neither is declare static, do these no

re: secur32: Allow loading external schannel.dll.

2008-06-23 Thread Juan Lang
Hi Zhangrong, your patch looks fine, but I'd appreciate it if you could update the comment for SECUR32_addProvider in secur32_priv.h to reflect your changes. --Juan

Re: dinput: Fix name clashes (Resend #2)

2008-06-23 Thread Andrew Talbot
Alexandre Julliard wrote: > The types are local to the C file so there is no clash. If some tools > don't understand that they need to be fixed. > Not arguing, just clarifying: File #1: joystick_input.c has a non-static struct tag called "JoystickImpl". File #2: joystick_linuxinput.c has a diff

Re: widl: The offset to the pointer layout in complex structures must be positive so add an assert and fix the format string.

2008-06-23 Thread Alexandre Julliard
"Rob Shearman" <[EMAIL PROTECTED]> writes: > Otherwise we could generate an incorrect format string and crash in a > weird way at runtime instead. Looks like the assert works ;) ../../tools/widl/widl -I. -I. -I../../include -I../../include -D__WINESRC__ -D_OLEAUT32_ -DCOM_NO_WINDOWS_H -p -P o

Re: dinput: Fix name clashes (Resend #2)

2008-06-23 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > Is there anything wrong with this patch? (Having two "JoystickImpl" types in > the same dll confounds some static analyisis programs.) The types are local to the C file so there is no clash. If some tools don't understand that they need to be fixed. --

Re: richedit: (9/8) EM_POSFROMCHAR tests

2008-06-23 Thread Alexandre Julliard
Alex Villací­s Lasso <[EMAIL PROTECTED]> writes: > Was there something wrong with this patch? It doesn't apply, please resend. -- Alexandre Julliard [EMAIL PROTECTED]

Re: richedit: (9/8) EM_POSFROMCHAR tests

2008-06-23 Thread Alex Villací­s Lasso
Alex Villací­s Lasso escribió: > Found while debugging #13864 . While it does not solve the bug, it is > worthwhile to get this out of the way. > > EM_POSFROMCHAR can return the position of the requested character > through either a pointer to a POINTL through wParam, or through the > result val

Re: new failing tests

2008-06-23 Thread Alex Villací­s Lasso
James Hawkins escribió: > Hi Alex, > > The following commit introduces several windows test failures across > the board in riched20: > > commit 0e9ed5c10e3ac6b253712037f0b30046a5656239 > Author: Alex Villacís Lasso <[EMAIL PROTECTED]> > Date: Sun May 11 09:54:58 2008 -0500 > > richedit: Empty

Re: oleaut32/tests: initialize pointer before sending it over the wire??

2008-06-23 Thread Dan Kegel
On Mon, Jun 23, 2008 at 12:12 AM, Rob Shearman <[EMAIL PROTECTED]> wrote: > I think it's getting close to the time to reimplement the typelib > marshaller on top of NDR functions so that we don't have to implement > these subtleties twice, would improve performance and would reduce the > amount of

Missed Patches

2008-06-23 Thread Alistair Leslie-Hughes
Hi, Any wrong with my patches gdi32: stop crash in font tests mapi32: stop crash under win98 secur32: fix crash under win98 shell32: Stop crash when an error occurs msxml3: Added xml Input Callbacks to support loading files from a Wine windows drive Best Regards Alistair Leslie-Hughes

Re: [PATCH] comctl32: Use ms sans serif in ip controls.

2008-06-23 Thread Alexandre Julliard
"Lei Zhang" <[EMAIL PROTECTED]> writes: > @@ -191,6 +194,10 @@ static LRESULT IPADDRESS_Create (HWND hwnd, const > CREATESTRUCTA *lpCreate) > infoPtr->Enabled = TRUE; > infoPtr->Notify = lpCreate->hwndParent; > > +SystemParametersInfoW(SPI_GETICONTITLELOGFONT, 0, &logFont, 0); > +

Re: Development plans

2008-06-23 Thread Michael Stefaniuc
Francois Gouget wrote: > On Wed, 18 Jun 2008, Michael Stefaniuc wrote: > [...] >> What about patches that have no associated bug report but can and >> probably should be cherry picked into stable? Translation patches come >> to mind as a class of patches that would fall under this. > > Note that

Re: avifil32: The importlib has the name vfw32

2008-06-23 Thread Alexandre Julliard
Detlef Riekenberg <[EMAIL PROTECTED]> writes: > avifil32: The importlib has the name vfw32 Not really, vfw32 is a common import lib for several dlls, not just avifil32. This will require some work to fix properly. -- Alexandre Julliard [EMAIL PROTECTED]

Re: [3/3] riched20: Implement ITextDocument_fnGetSelection.

2008-06-23 Thread Alexandre Julliard
Dan Hipschman <[EMAIL PROTECTED]> writes: > @@ -532,6 +538,709 @@ static const ITextDocumentVtbl tdvt = { > ITextDocument_fnRangeFromPoint > }; > > +/*** IUnknown methods ***/ > +static HRESULT WINAPI ITextSelection_fnQueryInterface( > +ITextSelection *me, > +REFIID riid, > +vo

Re: winecfg: Added Windows registration information setting

2008-06-23 Thread Dmitry Timoshkov
"Filipe Ferreira" <[EMAIL PROTECTED]> wrote: > Added english controls to winecfg About tab for registration info in En.rc > Added code for retrieving and setting registration info in main.c > Added textbox identifiers in resource.h Please add all the required changes to all .rc files, not only to

Re: kernel32: initialize hole in struct in WaitNamedPipeW to avoid Valgrind warnings, take 2 (resend)

2008-06-23 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > Back in February, I tried doing this with a real memset, > but Alexandre demurred, probably objecting to the slight overhead. > So here's a version with no overhead unless you > have the Valgrind development headers installed, > and is done with Valgrind c

Re: Development plans

2008-06-23 Thread Francois Gouget
On Wed, 18 Jun 2008, Michael Stefaniuc wrote: [...] > What about patches that have no associated bug report but can and > probably should be cherry picked into stable? Translation patches come > to mind as a class of patches that would fall under this. Note that with translations modifying the r

Re: [1/2] wined3d: Report post pixelshader blending on WINED3DFMT_A16B16G16R16F

2008-06-23 Thread Roderick Colenbrander
> 2008/6/23 Roderick Colenbrander <[EMAIL PROTECTED]>: > > Hi, > > > > I don't think we should implement it this way. For instance on GeforceFX > cards blending is performed in software. Not too long ago (before 1.0) I > also sent a patch for this e.g. by doing an extension check. I think I > check

Re: [1/2] wined3d: Report post pixelshader blending on WINED3DFMT_A16B16G16R16F

2008-06-23 Thread H. Verbeet
2008/6/23 Roderick Colenbrander <[EMAIL PROTECTED]>: > Hi, > > I don't think we should implement it this way. For instance on GeforceFX > cards blending is performed in software. Not too long ago (before 1.0) I also > sent a patch for this e.g. by doing an extension check. I think I checked for

Re: oleaut32/tests: initialize pointer before sending it over the wire??

2008-06-23 Thread Rob Shearman
2008/6/21 Dan Kegel <[EMAIL PROTECTED]>: > While looking at the valgrind warning in > http://kegel.com/wine/valgrind/logs-2008-06-20/vg-oleaut32_tmarshal.txt > > Conditional jump or move depends on uninitialised value(s) >at serialize_param (tmarshal.c:736) >by serialize_param (tmarshal.