While looking at the valgrind warning in
http://kegel.com/wine/valgrind/logs-2008-06-20/vg-oleaut32_tmarshal.txt
Conditional jump or move depends on uninitialised value(s)
at serialize_param (tmarshal.c:736)
by serialize_param (tmarshal.c:744)
by xCall (tmarshal.c:1414)
by ???
"Paolo Abeni" <[EMAIL PROTECTED]> wrote:
> Changelog:
> * add basic implementation for MsiSetExternalUIRecord
The only place where new stuff is used is package.c, why did
you add it to msi_main.c and msipriv.h?
--
Dmitry.
Our existing tests for GetPrivateProfileString were not checking to see
if strings were null terminated, and in particular, the case where
lpDefault wasn't set, the code actually *didn't* set the target buffer
to an empty string as it should. Valgrind noticed this problem, but the
unit tests di
2008/6/20 Rob Shearman <[EMAIL PROTECTED]>:
> ---
> dlls/rpcrt4/tests/server.c | 35 +--
> dlls/rpcrt4/tests/server.idl |9 +
> 2 files changed, 42 insertions(+), 2 deletions(-)
Please don't apply this patch - it contains a bug that will cause it
to
(I think this belongs into wine-devel, sorry for also posting this on
wine-patches)
Oops, sorry! I corrected the mixed indentation style (must have been the
copy&paste).
However I think the comment should stay there. I don't think the MSDN
docs are updated in the near future, at least what D3D
On Fri, Jun 20, 2008 at 9:38 AM, Maarten Lankhorst
<[EMAIL PROTECTED]> wrote:
> Have you tried with --malloc-fill=55 --free-file=aa ? It is similar to
> warn+heap, but it's valgrind compatible.
No, I'll give it a shot. Has it found anything for you?
On Fri, Jun 20, 2008 at 9:13 AM, Scott Ritchie <[EMAIL PROTECTED]> wrote:
> Do you think it appropriate to say that Valgrind-completeness should be
> a release criteria? It would be nice if Wine 1.2 didn't ship with any
> Valgrind warnings about anything (leaks included), which would, for
> instan
Hi Austin,
2008/6/11 Austin Lund <[EMAIL PROTECTED]>:
> New conformance test for windowless text services. Only tests some
> very basic operations and will need future refinement. When passing
> all the tests many of the windowless text services should work for
> Google Talk as per bug 5162.
Yo
Hi Dan,
2008/6/20 Dan Kegel <[EMAIL PROTECTED]>:
> Changes since yesterday:
> - Added two patches by Huw, one by Roy
> - Removed one by Roy that's now in git
>
> This plus other improvements in git get us down to 115,
> rather a stunning improvement from a few days ago.
>
> Please join the party!
Dan Kegel wrote:
> Changes since yesterday:
> - Added two patches by Huw, one by Roy
> - Removed one by Roy that's now in git
>
> This plus other improvements in git get us down to 115,
> rather a stunning improvement from a few days ago.
>
> Please join the party! We can use all the help we can
Hello,
2008/6/19 Leslie Viljoen <[EMAIL PROTECTED]> schreef:
> On 6/19/08, Vitaliy Margolen <[EMAIL PROTECTED]> wrote:
>> First of all this is developer's mailing list not user's.
>
> Ah, I will look for the other list and sign up there too. I am a user
> but I hope to
> be a developer too when I
Hi Mikołaj,
your commit seems to have an uninitialized variable; see
http://kegel.com/wine/valgrind/logs-2008-06-20/vg-comdlg32_filedlg-diff.txt
One of the errors:
Conditional jump or move depends on uninitialised value(s)
at strlenW (unicode.h:212)
by lstrlenW (string.c:384)
by G
Hello Zac,
> Does anyone have feedback on whether they believe the tests for normal
> control characters vs reversed control characters should be mutually
> exlusive?
I took a look at the documentation. My read is that the tests are not
mutually exclusive.
Given your current version and my read
On Fri, Jun 20, 2008 at 9:37 AM, Vitaly Perov <[EMAIL PROTECTED]> wrote:
> Changelog:
> - shell32/tests: FOF_MULTIDESTFILES must be set when we are moving multiple
> files
>
+/* move many files into directory with FOF_MULTIDESTFILES */
+shfo.fFlags |= FOF_MULTIDESTFILES;
set_curr_dir_
Alexandre Julliard wrote:
> Zac Brown <[EMAIL PROTECTED]> writes:
>
>> Could anyone give me some feedback on this patch?
>>
>> Talked to AJ about it pre-1.0 and he seemed to think its fine, maybe he'd
>> chime
>> in and let me know what he thought was wrong with it this time around?
>
> ../../.
Changes since yesterday:
- Added two patches by Huw, one by Roy
- Removed one by Roy that's now in git
This plus other improvements in git get us down to 115,
rather a stunning improvement from a few days ago.
Please join the party! We can use all the help we can get
getting rid of these bugs; t
2008/6/20 Tobias Jakobi <[EMAIL PROTECTED]>:
> Patch fixes a problem with the IDirect3DDevice8::CreateImageSurface
> implementation (wrong pool type of the returned surface object). This fixes
> savegame screenshot bugs (black images instead of game scenes) in both Max
> Payne and Max Payne 2.
>
>
On Fri, Jun 20, 2008 at 12:23 AM, Rolf Kalbermatter
<[EMAIL PROTECTED]> wrote:
> But personally I feel about the use
> of a switch statement in such a case a bit "overdone". It's not so much
> a selection of operations based on a variable as much more a clear
> conditional expression
I was going f
Zac Brown <[EMAIL PROTECTED]> writes:
> Could anyone give me some feedback on this patch?
>
> Talked to AJ about it pre-1.0 and he seemed to think its fine, maybe he'd
> chime
> in and let me know what he thought was wrong with it this time around?
../../../tools/runtest -q -P wine -M advapi32.
Zac Brown [mailto:[EMAIL PROTECTED]
> Rolf Kalbermatter wrote:
> > Dan Kegel [mailto:[EMAIL PROTECTED]
> >
> >> e.g.
> >>
> >> if (flags & IS_TEXT_UNICODE_CONTROLS)
> >>for (i = 0; i < len; i++)
> >> switch (s[i]) {
> >>case '\t':
> >>case '\n':
> >>
Hi,
> should be:
> @ stdcall SymEnumerateSymbols64(long double ptr ptr)
Thanks, I missed that long long changed to double a while ago. I've re-sent the
patch.
Cheers,
Jon
Hi,
I'm planning to do some work on setupapi. Most of the tests we are having
produce either rubbish or fail on win9x.
How much effort should I make to have win9x tests? It appears that every single
test I'm touching is totally different when we compare win9x to the rest (NT+).
Making sure we
22 matches
Mail list logo
