Alistair Leslie-Hughes wrote:
> Hi,
> I just added a check for a null pointer since we deference it.
>
> Changelog:
> mapi32: stop crash under win98
>
> Best Regards
> Alistair Leslie-Hughes
>
>
>
>
>
>
+if(l
"Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote:
> -if (!*font_name && font_charset == DEFAULT_CHARSET) /* do it only once */
> +/* EnumFontFamilies with the NULL parameter crashes win98 */
> +if (pGetGlyphIndicesW && !*font_name && font_charset == DEFAULT_CHARSET)
> /* do it only
Zac Brown wrote:
> Implement setting of IS_TEXT_UNICODE_CONTROLS and
> IS_TEXT_UNICODE_REVERSE_CONTROLS when control characters are present
> in RtlIsTextUnicode.
>
>
>
>
> ---
> dlls/ntdll/rtlstr.c | 54
> ++
On Wed, Jun 18, 2008 at 7:41 PM, Steven Edwards <[EMAIL PROTECTED]> wrote:
> I think the person that submits the patch should take the effort to
> make sure the fix applies to 1.0.x if they care about it and post a
> patch for that to the bug also. If there is backporting work involved
> in getting
On Wed, Jun 18, 2008 at 3:31 PM, Eric Pouech <[EMAIL PROTECTED]> wrote:
> how to you plan to handle patches that don't commit cleanly ?
> do you, by design of the process, intend to drop them (id est: drop
> every bug fixes that come after a functional change in the same area of
> code), or do you
On Wed, Jun 18, 2008 at 5:10 PM, Zac Brown <[EMAIL PROTECTED]> wrote:
> Implement setting of IS_TEXT_UNICODE_CONTROLS and
> IS_TEXT_UNICODE_REVERSE_CONTROLS when control characters are present
> in RtlIsTextUnicode.
>
You've mixed tabs and spaces in this patch.
--
James Hawkins
Alistair Leslie-Hughes wrote:
> Hi,
>use a unicode mapped function to stop a test from running under win98
>
> Changelog:
> gdi32: stop font tests crashing under win98
>
> Best Regards
> Alistair Leslie-Hughes
>
>
> --
Hello Alexandre,
good job on 1.0. Hopefully now the time of boring commit messages is over ;)
Alexandre Julliard wrote:
> The process I suggest for the 1.0.1 release is as follows:
>
> - all bugs should be fixed in the master branch first
> - once a bug fix has been committed to master, the corr
Alistair Leslie-Hughes wrote:
> Hi,
>
> Changelog:
> msxml3: Improved checking of failed case
>
> Best Regards
> Alistair Leslie-Hughes
>
>
>
>
>
-/* Win98 returns ERROR_URL_NOT_FOUND */
-ok(hr == S_OK || h
Alexandre Julliard wrote:
> Hi folks,
>
> Again, congrats to everybody for the 1.0 release!
>
> Now that I'm starting to recover from the shock of having actually
> shipped 1.0, here are a few notes on future development:
>
> 1) Code freeze is over, patches are accepted again. If you sent patche
2008/6/18 Vitaly Perov <[EMAIL PROTECTED]>:
> If FOF_MULTIDESTFILES flag is set it's not olny mean that pTo contains
> multiple destination files, it also can contain one folder.
>
> Changelog:
> - shell32: SHFileOperation can move several files into one directory
>
The move operation can already
> 3) There is now a git "stable" branch, where only important bug fixes
> will be committed. The 1.0.x maintenance releases will be made from that
> branch whenever enough changes have accumulated to justify a release.
>
> The process I suggest for the 1.0.1 release is as follows:
>
> - all bugs s
> The move operation can already do this. Why is this patch necessary?
> The test you sent in already passes, so this 'fix' is not being tested
> at all.
I've checked my test again. It fails!
$ wine shell32_test.exe.so shlfileop
So, the result is:
shlfileop.c:171: Test failed: SHGetFileInfoA(c:
Thanks for the code thus far! Wine has helped me many times throughout
the years.
--
Peter Bortas
Changes since yesterday:
- added suppression for one more load order memory leak
- added one patch by Lei, one by Andrew Tablot, and one by me
This gets us down from 205 to 142. The huge reduction was due to
http://kegel.com/wine/valgrind/logs-2008-06-17-patches/dank/dsound-primary-getvolume.patc
Dmitry Timoshkov <[EMAIL PROTECTED]> writes:
> Changelog:
> gdi32: Add a test for outline text metrics.
This doesn't work for me:
../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so
font.c && touch font.ok
font.c:248: Test failed: expected scale_x 1, scale_y 1, g
On Wed, Jun 18, 2008 at 10:29 AM, Vitaly Perov <[EMAIL PROTECTED]> wrote:
>> The move operation can already do this. Why is this patch necessary?
>> The test you sent in already passes, so this 'fix' is not being tested
>> at all.
>
> I've checked my test again. It fails!
>
> $ wine shell32_test.e
> - /* Win98 returns ERROR_URL_NOT_FOUND */> - ok(hr == S_OK || hr ==
> ERROR_URL_NOT_FOUND, "Expected S_OK, got 0x%08x\n", hr);> + ok(hr == S_OK,
> "Expected S_OK, got 0x%08x\n", hr);> > But this means the test will fail on
> Win98, is that on purpose?> No, I'll resend.
Thanks for the catch.
Sure, we keep a webalizer graph for such a thing.
You can see the hit stats here, and it is an amazing jump in traffic.
WineHQ was already a busy site to begin with.
http://www.winehq.org/webalizer/usage_200806.html
Hin-Tak Leung wrote:
> Just for "geek value", is it possible to have a graph of
Alex Villacís Lasso <[EMAIL PROTECTED]> writes:
> --
> perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
>
> From: Alex Villacís Lasso <[EMAIL PROTECTED]>
> Subject: richedit: fix misreporting of match offset for EM_FINDTEXT and
> EM_FINDTEXTEX
> To: [EMAIL PROTECTED]
> D
2008/6/18 Alexandre Julliard <[EMAIL PROTECTED]>:
> Again, congrats to everybody for the 1.0 release!
Yes, congratulations everyone, especially those who fixed bugs during
the code freeze.
> Now that I'm starting to recover from the shock of having actually
> shipped 1.0, here are a few notes on
"Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote:
> -if (!*font_name && font_charset == DEFAULT_CHARSET) /* do it only once */
> +/* EnumFontFamilies with the NULL parameter crashes win98 */
> +if (pGetCharABCWidthsW && !*font_name && font_charset ==
> DEFAULT_CHARSET) /* do it only
Sure:
http://www.winehq.org/webalizer
-Brian
On Tue, Jun 17, 2008 at 8:27 PM, Hin-Tak Leung <[EMAIL PROTECTED]>
wrote:
> Just for "geek value", is it possible to have a graph of how the slashdot
> effect look like? I mean a graph of the hourly web hit statistics or
> something.
>
> Be very glad
Thanks, I didn't know where that constant was coming from.
I am attaching the updated patch. The same description applies to it:
Checks were added for hexidecimal values that did not have valid
characters, and for EOF received before the final closing brace of the
rich text stream. The error va
2008/6/18 Vitaly Perov <[EMAIL PROTECTED]>:
> Changelog:
> - shell32: test added. It check whether SHFileOperation could correctly work
> with input files mask '*.*'
>
Couple problems:
--- a/dlls/shell32/tests/shlfileop.c
+++ b/dlls/shell32/tests/shlfileop.c
@@ -120,6 +120,7 @@ static void init_
What basis is there for it being proportional to the width/height of the
scollbar? Is there a test I can run, or a use case that I can follow to
observe this behaviour?
The way it was implemented before was not consistent with Windows either. I
tried with horizontal and vertical scrollbars of va
> The move operation can already do this. Why is this patch necessary?
> The test you sent in already passes, so this 'fix' is not being tested
> at all.
Really? I'm sorry! I was testing at old version of wine.
Thank you very much! I'll test it again!
--
Best wishes,
Vitaly Perov
Russia, Saint-
Hi folks,
Again, congrats to everybody for the 1.0 release!
Now that I'm starting to recover from the shock of having actually
shipped 1.0, here are a few notes on future development:
1) Code freeze is over, patches are accepted again. If you sent patches
and they didn't get applied during code
> You're using fileDest when it hasn't been initialized (as the warning
> says). Second, the tests fail:
Thank you! I forgot insert a line when I was rewriting it for the patch.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
Dylan Smith wrote:
> + if (!inStream.editstream->dwError && parser.stackTop > 0)
> +inStream.editstream->dwError = -2147024858;
This should be HRESULT_FROM_WIN32(ERROR_HANDLE_EOF).
--
Rob Shearman
Dylan Smith wrote:
> + /* Distance beside or past the ends the scrollbar for the mouse can be
> dragged
> + * away from scrollbar and still be considered in the scrollbar. */
> +#define SCROLL_DRAG_ZONE_PADDING_BESIDE138
> +#define SCROLL_DRAG_ZONE_PADDING_PAST_END 34
This should be a pro
31 matches
Mail list logo