Re: ddraw: Fix Setmaterial with a test

2008-06-10 Thread Vitaliy Margolen
David Adam wrote: >>David Adam wrote: >>>/ The test succeded in my windows XP box. > />>/ > />You have only ddraw test and no d3d test. >> >>Vitaliy. > > Giving a NULL value to SetMaterial in d3d9 or d3d8 makes Windows crashes. > > It is a forbidden value (see bug 13646). So, no test can be per

Re: user32: Allow a NULL foreground window in the tests

2008-06-10 Thread Dmitry Timoshkov
"James Hawkins" <[EMAIL PROTECTED]> wrote: > I've debugged this a bit more, and when running the user32:win test > within the winetest.exe program, all checked calls to > GetForegroundWindow return NULL. When running the user32:win test by > itself from the command line, only 7 tests fail the > G

Re: user32: Allow a NULL foreground window in the tests

2008-06-10 Thread James Hawkins
On Tue, Jun 10, 2008 at 7:15 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Thu, May 29, 2008 at 8:24 PM, Dmitry Timoshkov > <[EMAIL PROTECTED]> wrote: >> "James Hawkins" <[EMAIL PROTECTED]> wrote: >> >>> Passing 0 for the foreground window essentially disables the test, >>> whereas allowing a N

Re: user32: Allow a NULL foreground window in the tests

2008-06-10 Thread James Hawkins
On Thu, May 29, 2008 at 8:24 PM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "James Hawkins" <[EMAIL PROTECTED]> wrote: > >> Passing 0 for the foreground window essentially disables the test, >> whereas allowing a NULL window is testing another variation of what >> can happen with the foreground

Re: wininet: Make sure URL is terminated in InternetCrackUrlA.

2008-06-10 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > Why not? It's a bug fix and four places to fix sounds quite reasonable > (>100 may not be). Maybe it's just me but I didn't feel like 1.0 would > entail a deep deep freeze period where only critical/security bugs would > be fixed. At this point the

ddraw: Fix Setmaterial with a test

2008-06-10 Thread David Adam
>David Adam wrote: >>* The test succeded in my windows XP box. *>>* *>You have only ddraw test and no d3d test. > >Vitaliy. Giving a NULL value to SetMaterial in d3d9 or d3d8 makes Windows crashes. It is a forbidden value (see bug 13646). So, no test can be performed for d3d8 and d3d9. I sent a p

Re: wininet: Make sure URL is terminated in InternetCrackUrlA.

2008-06-10 Thread Francois Gouget
On Tue, 10 Jun 2008, Hans Leidekker wrote: > On Monday 09 June 2008 17:09:52 Alexandre Julliard wrote: > > > The bug is in InternetCrackUrlW, it shouldn't require the string to be > > null-terminated. > > Right, but I guess fixing that is no 1.0 material since there's at least > 4 places where i

Re: Trying to build rc4 for MacOS, having problems with libpng, libjpeg, etc.

2008-06-10 Thread Timothy Normand Miller
I've made some progress, with the help of Thomas Kho, but now I'm having another issue. Every time I start WINE, it spends about a minute going through some font stuff, then when the app finally comes up, there is no text. Dan says that I'm missing a dependency on the RENDER extension. I definit

Re: gdi32: stop gdi font test crashing under win98

2008-06-10 Thread Dmitry Timoshkov
"Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote: > if (!*font_name && font_charset == DEFAULT_CHARSET) /* do it only once */ > { > +LOGFONT lf; > +memset(&lf, 0, sizeof(LOGFONT)); > + > efd.total = 0; > SetLastError(0xdeadbeef); > ret = En

Re: winex11.drv: Do not crash if UploadGlyph failed

2008-06-10 Thread Alexandre Julliard
Dmitry Timoshkov <[EMAIL PROTECTED]> writes: > this patch fixes the Firefox crashes reported in the bugs 4762 and 12307. > > Changelog: > winex11.drv: Do not crash if UploadGlyph failed. I don't think that's correct, it should still display the valid glyphs and use a replacement char for the

Re: [ole32/tests 2/2] Fix crash on NT4 and below

2008-06-10 Thread Rob Shearman
2008/6/10 Paul Vriens <[EMAIL PROTECTED]>: > This 'fixes' the crash on win9x and NT4. > > @@ -1130,11 +1130,15 @@ static void test_data_cache(void) > hr = IOleCache_Uncache(pOleCache, 0xdeadbeef); > ok(hr == OLE_E_NOCONNECTION, "IOleCache_Uncache with invalid value > should return OLE_E_

Re: Stop shlfileop tests crashing under win98

2008-06-10 Thread Dan Kegel
On Tue, Jun 10, 2008 at 5:50 AM, James Hawkins <[EMAIL PROTECTED]> wrote: > No, the test is exactly what the comment says: invalid list (empty) > with one NULL terminator. I'm fine with it being if-def'ed out if it > crashes in win98. I guess I was fooled by the line ok(file_exists("test1.txt"),

Re: Stop shlfileop tests crashing under win98

2008-06-10 Thread James Hawkins
On Tue, Jun 10, 2008 at 7:13 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Alistair wrote: >>-/* try an invalid list, only one null terminator */ >>-init_shfo_tests(); >>-shfo.pFrom = ""; >>-shfo.wFunc = FO_DELETE; >>-ret = SHFileOperation(&shfo); >>-ok(ret == ERROR_ACCESS_DENI

Re: ddraw: modify Direct3D device name

2008-06-10 Thread Jeff Zaroyko
On Tue, Jun 10, 2008 at 8:49 PM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: >> Descent FreeSpace: The Great War and Descent FreeSpace 2 fail to detect >> hardware acceleration through Direct3D when enumerating devices, they >> expect the device name string to begin with "Direct3D - " >> >> This pat

Re: ddraw: Fix Setmaterial with a test

2008-06-10 Thread Vitaliy Margolen
David Adam wrote: > The test succeded in my windows XP box. > You have only ddraw test and no d3d test. Vitaliy.

Re: Stop shlfileop tests crashing under win98

2008-06-10 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > Perhaps you could leave it enabled if you fixed it like the > ones I fixed. (Or tried to fix; sadly, Alexandre hasn't > committed it yet. Why?) Because your patch was also making unrelated and incorrect changes to the code. If you resubmit just the test

Re: [ole32/tests 2/2] Fix crash on NT4 and below

2008-06-10 Thread Paul Vriens
Rob Shearman wrote: > 2008/6/10 Paul Vriens <[EMAIL PROTECTED]>: >> This 'fixes' the crash on win9x and NT4. >> >> @@ -1130,11 +1130,15 @@ static void test_data_cache(void) >> hr = IOleCache_Uncache(pOleCache, 0xdeadbeef); >> ok(hr == OLE_E_NOCONNECTION, "IOleCache_Uncache with invalid va

re: Stop shlfileop tests crashing under win98

2008-06-10 Thread Dan Kegel
Alistair wrote: >-/* try an invalid list, only one null terminator */ >-init_shfo_tests(); >-shfo.pFrom = ""; >-shfo.wFunc = FO_DELETE; >-ret = SHFileOperation(&shfo); >-ok(ret == ERROR_ACCESS_DENIED, "Expected ERROR_ACCESS_DENIED, got %d\n", >ret); >-ok(file_exists("te

Re: gdi32: Use 0xffff as a default character as Vista does

2008-06-10 Thread Reece Dunn
2008/6/10 Dmitry Timoshkov <[EMAIL PROTECTED]>: > Hello, > > this patch fixes the problem reported in the bug 12305. In Wine Tahoma > character ':' is mapped to glyph index 0x1f, and that seems to be confusing > Firefox. > +TM.tmDefaultChar = pOS2->usDefaultChar ? pOS2->usDefaultChar : >

RE: ddraw: modify Direct3D device name

2008-06-10 Thread Stefan Dösinger
> Descent FreeSpace: The Great War and Descent FreeSpace 2 fail to detect > hardware acceleration through Direct3D when enumerating devices, they > expect the device name string to begin with "Direct3D - " > > This patch enables the Direct3D mode to be used. I am not entirely sure about this. I th

Re: shell32: stop shlfolder tests crashing under win98

2008-06-10 Thread Paul Vriens
Alistair Leslie-Hughes wrote: > Hi, > Moved the null pointer checker to before it's first used. > > Changelog: > shell32: stop shlfolder tests crashing under win98 > > Best Regards > Alistair Leslie-Hughes > > > >

Re: wininet: Make sure URL is terminated in InternetCrackUrlA.

2008-06-10 Thread Hans Leidekker
On Monday 09 June 2008 17:09:52 Alexandre Julliard wrote: > The bug is in InternetCrackUrlW, it shouldn't require the string to be > null-terminated. Right, but I guess fixing that is no 1.0 material since there's at least 4 places where it assumes a null-terminated string, including a call to In

Re: gdi32: Use 0xffff as a default character as Vista does

2008-06-10 Thread Dmitry Timoshkov
"Reece Dunn" <[EMAIL PROTECTED]> wrote: >> +TM.tmDefaultChar = pOS2->usDefaultChar ? pOS2->usDefaultChar : >> 0x; > > There is a UNICODE_NOCHAR constant for this. UNICODE_NOCHAR is defined in winuser.h, we can't use it in gdi32. -- Dmitry.

Re: Wine + Fedora

2008-06-10 Thread Maarten Lankhorst
Hello Louis, 2008/6/9 Louis Lenders <[EMAIL PROTECTED]>: > Hi, just thought dropping a note here so you'd know: the troubles reported for > wine+fedora 9, now also affect fedora 8. Last saturday i did a 'yum update', > and > after that about all wine-applications froze my computer. Only a hard re