Re: mshtml: Added FIXME about QUERY_USES_HISTORYFOLDER in aboutprotocol.

2008-06-06 Thread Dmitry Timoshkov
"Jacek Caban" <[EMAIL PROTECTED]> wrote: >> return E_NOTIMPL; >> +case QUERY_USES_HISTORYFOLDER: >> +FIXME("Unsupported option QUERY_USES_HISTORYFOLDER\n"); >> default: >> return E_FAIL; >> } >> >> shouldn't there be a "return E_NOTIMPL" after the FIXME as w

RE: d3d8: Fix the null condition in ApplyStateBlock

2008-06-06 Thread Stefan Dösinger
What would be interesting to know is which effect this has on the states, but not in this patch I'd say, and not before the 1.0 release. In the long run it might be an idea to port the d3d9:stateblock test to d3d8 and see how d3d8 behaves

French translation only partial?

2008-06-06 Thread Frans Kool
Hi, I just had a look at the French translation of the dlls/kernel32/nls/winerr_fra.mc file. I noticed only the first 54 messages have been translated, whereas the other 1876 are still the English originals. Was this on purpose? Or was this a partial translation which needs to be finalized (the r

Re: urlmon: Fix a few failing tests in win2k3

2008-06-06 Thread Jacek Caban
James Hawkins wrote: > Do you want to send a better patch or should I resend? Please resend it. > There are some other failures as well that I think you would know how to fix > more correctly. > Most failures are due to differences between IE6 and IE7. I occasionally fix them and change Win

Re: Remove unused variable in dlls/mlang/tests/mlang.c

2008-06-06 Thread Gerald Pfeifer
On Thu, 5 Jun 2008, James Hawkins wrote: > http://winehq.org/pipermail/wine-cvs/2008-June/044013.html I'm getting old and slow, I guess. :-/ Gerald

Re: urlmon: Fix a few failing tests in win2k3

2008-06-06 Thread James Hawkins
On Fri, Jun 6, 2008 at 2:08 PM, Jacek Caban <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> >> On Fri, Jun 6, 2008 at 1:25 PM, Jacek Caban <[EMAIL PROTECTED]> wrote: >> >>> >>> James Hawkins wrote: >>> Hi, Changelog: * Fix a few failing tests in win2k3. >>> >>> Yo

Re: urlmon: Fix a few failing tests in win2k3

2008-06-06 Thread Jacek Caban
James Hawkins wrote: > On Fri, Jun 6, 2008 at 1:25 PM, Jacek Caban <[EMAIL PROTECTED]> wrote: > >> James Hawkins wrote: >> >>> Hi, >>> >>> Changelog: >>> * Fix a few failing tests in win2k3. >>> >> You've fixed tests on IE7, not only win2k3. It would be better to change >> Wine to be

Re: mshtml: Added FIXME about QUERY_USES_HISTORYFOLDER in about protocol.

2008-06-06 Thread Jacek Caban
Hi Paul, Paul Vriens wrote: > Hi Jacek, > > > return E_NOTIMPL; > +case QUERY_USES_HISTORYFOLDER: > +FIXME("Unsupported option QUERY_USES_HISTORYFOLDER\n"); > default: > return E_FAIL; > } > > shouldn't there be a "return E_NOTIMPL" after the FIXME as we do

Re: urlmon: Fix a few failing tests in win2k3

2008-06-06 Thread James Hawkins
On Fri, Jun 6, 2008 at 1:25 PM, Jacek Caban <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> Hi, >> >> Changelog: >> * Fix a few failing tests in win2k3. > > You've fixed tests on IE7, not only win2k3. It would be better to change > Wine to behave like IE7. Also your patch lefts some variables

Re: mshtml: Added FIXME about QUERY_USES_HISTORYFOLDER in about protocol.

2008-06-06 Thread Paul Vriens
Jacek Caban wrote: > --- > dlls/mshtml/protocol.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > Hi Jacek, return E_NOTIMPL; +case QUERY_USES_HISTORYFOLDER: +FIXME("Unsupp

Re: urlmon: Fix a few failing tests in win2k3

2008-06-06 Thread Jacek Caban
James Hawkins wrote: > Hi, > > Changelog: > * Fix a few failing tests in win2k3. You've fixed tests on IE7, not only win2k3. It would be better to change Wine to behave like IE7. Also your patch lefts some variables in wrong state. I will send patches to fix it. Jacek

Re: [urlmon/tests 2/2] Fix test on IE7 (Resend)

2008-06-06 Thread Jacek Caban
Hi Paul, Paul Vriens wrote: > Hi, > > This (together with number 1 of course) fixes the tests on IE7 boxes. > > Not sure if a patch for urlmon/protocol.c is needed as well. Let me > know and > I'll sent one. > > Changelog > Fix test on IE7 While fixing such tests it's good to add FIXME in code

Re: Compile wine on Red Hat 9

2008-06-06 Thread Michael Stefaniuc
Wen Huang wrote: > Thanks a lot Michael. > > I tried and it worked! Just curious that whether this is going to > affect many programs run through wine. I use wine to run WinBUGS, it > worked fine. It will affect all those programs that use the Windows XML DLLs. You could try to upgrade the lib

Re: Compile wine on Red Hat 9

2008-06-06 Thread Wen Huang
Thanks a lot Michael. I tried and it worked! Just curious that whether this is going to affect many programs run through wine. I use wine to run WinBUGS, it worked fine. Thanks, Wen On Jun 6, 2008, at 3:42 AM, Michael Stefaniuc wrote: > Hello! > > Wen Huang wrote: >> I was trying to compile

AW: Wine in the news

2008-06-06 Thread Stefan Dösinger
FYI, this is my first Outlook dogfooding mail. Please holler if there's anything wrong, like HTML or strange attachments. > Overall it seems like Vienna is looking for reasons to back out of the > Linux migration, perhaps in exchange for some goodies some big > companies would donate in that case

Bad free error involving shdocvw and COM?

2008-06-06 Thread Dan Kegel
In shdocvw/tests/webbrowser.c, at the end of test_WebBrowser, the call IUnknown_Release(unk) results in the following Valgrind error: Invalid free() / delete / delete[] at notify_free (heap.c:199) by RtlFreeHeap (heap.c:1284) by SysFreeString (oleaut.c:196) by DocHost_Release

Re: Wine in the news

2008-06-06 Thread Kai Blin
On Friday 06 June 2008 16:07:05 Dan Kegel wrote: > You'd be surprised. I've visited the Limux guys in > Munich, and although they did test and use Wine, > they had very little time to devote to it. I helped > them file Wine bugs, don't know if they would have > without help. I don't know much

Re: Wine in the news

2008-06-06 Thread Jochen
Kai Blin schrieb: > On Friday 06 June 2008 15:11:34 Dan Kegel wrote: > >> http://news.zdnet.co.uk/software/0,100121,39429910,00.htm >> http://economyaustria.at/Text/?id=3363378 >> Vienna migrates some Linux workstations to Vista because >> a single app, Schlaumäuse, crashes under Wine. >> Look

Re: [PATCH] GetUrlCacheEntryInfo*: Handle null dest pointer when length is given

2008-06-06 Thread Jon Griffiths
> Internal functions should return an error code instead of > calling SetLastError. Perhaps in a general sense, but URLCache_CopyEntry already did SetLastError(ERROR_INSUFFICIENT_BUFFER): setting it there means the 4 places that call it don't need to the logic to set the 2 different errors thems

Re: Wine in the news

2008-06-06 Thread Dan Kegel
Kai wrote: >Given that they didn't even bother to file a bug report >or add an appdb entry, that sounds pretty fishy. > I know that there's been a couple of bug reports >and requested changes to Samba when Munich >migrated to Windows. I don't see why any real user > of Wine wouldn't at least file a

Re: Wine in the news

2008-06-06 Thread Kai Blin
On Friday 06 June 2008 15:11:34 Dan Kegel wrote: > http://news.zdnet.co.uk/software/0,100121,39429910,00.htm > http://economyaustria.at/Text/?id=3363378 > Vienna migrates some Linux workstations to Vista because > a single app, Schlaumäuse, crashes under Wine. > Looks like they send the softwa

Wine in the news

2008-06-06 Thread Dan Kegel
http://www.australianit.news.com.au/story/0,24897,23797416-24169,00.html The new president of Red Hat, when asked about desktop linux, said: "My simple answer is until Apple's iTunes runs on consumer Linux desktops, it's not going to take off. I know you can run Wine, which runs Windows application

Re: [PATCH] GetUrlCacheEntryInfo*: Handle null dest pointer when length is given

2008-06-06 Thread Rob Shearman
2008/6/6 Jon Griffiths <[EMAIL PROTECTED]>: > -if (dwRequiredSize > *lpdwBufferSize) > -{ > -*lpdwBufferSize = dwRequiredSize; > +ret = dwRequiredSize > *lpdwBufferSize? FALSE : TRUE; > +*lpdwBufferSize = dwRequiredSize; > + > +if (!ret) > SetLastError(ERROR_INS

Re: [website] Fix typo in Spanish translation of home.template

2008-06-06 Thread Ángel Guzmán Maeso
I am still awaiting a response. -- Shakaran

Re: Compile wine on Red Hat 9

2008-06-06 Thread Michael Stefaniuc
Hello! Wen Huang wrote: > I was trying to compile a winehq on Red Hat 9 and I downloaded the > source 0.9.60 from sourceforge. Do you really mean Red Hat Linux 9? Or Fedora 9? Red Hat Linux 9 is really old and unsupported for years now. > When I tried to compile by > > ./configure > make depe

Compile wine on Red Hat 9

2008-06-06 Thread Wen Huang
Hi everybody, I was trying to compile a winehq on Red Hat 9 and I downloaded the source 0.9.60 from sourceforge. When I tried to compile by ./configure make depend make during the make step, it gave an error . gcc -c -I. -I. -I../../include -I../../include -I/usr/include/ libxml2 -I/u

Re: Double free error involving dsound and winealsa.drv

2008-06-06 Thread Maarten Lankhorst
Hi Dan, 2008/6/6 Dan Kegel <[EMAIL PROTECTED]>: > Hmm, freeing a buffer that's already been freed is bad, > is it showstopper bad? If it was created with USESYSTEMMEMORY, then dsound created the buffer, if not, alsa owns it. Cheers, Maarten.