re: [PATCH] oleaut32: Fix valgrind warnings in vatype.c test

2008-06-04 Thread Dan Kegel
Hi Jon, I guess http://www.winehq.org/pipermail/wine-patches/2008-May/055352.html must have been too scary to commit. I independently sent in a fix for the easy part, and it was committed as http://winehq.org/pipermail/wine-cvs/2008-June/043999.html The last part of your patch, having to do with S

Re: [AppDB] Allow admins to remove their admin rights

2008-06-04 Thread Chris Morgan
On Wed, Jun 4, 2008 at 11:56 AM, Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> wrote: > På Onsdag 04 juni 2008 , 17:37:15 skrev Chris Morgan: >> On Wed, Jun 4, 2008 at 4:15 AM, Alexander Nicolaysen Sørnes >> >> <[EMAIL PROTECTED]> wrote: >> > På Onsdag 04 juni 2008 , 01:24:07 skrev Chris Morgan:

RE: Fixing crashes in Tests (OS version check)

2008-06-04 Thread Rolf Kalbermatter
Juan Lang wrote: > So, in my opinion, the general principle is this: > if the behavior is very different on different Windows > versions, and if the behavior on some Windows version is to > crash, it seems reasonable to remove the test, as: 1) we want > our tests to reflect Windows behavior t

Re: [AppDB] Allow admins to remove their admin rights

2008-06-04 Thread Alexander Nicolaysen Sørnes
På Onsdag 04 juni 2008 , 17:37:15 skrev Chris Morgan: > On Wed, Jun 4, 2008 at 4:15 AM, Alexander Nicolaysen Sørnes > > <[EMAIL PROTECTED]> wrote: > > På Onsdag 04 juni 2008 , 01:24:07 skrev Chris Morgan: > >> What new policy on dissidents? ;-) > >> > >> How does this patch enable admins to remove

Re: [AppDB] Allow admins to remove their admin rights

2008-06-04 Thread Chris Morgan
On Wed, Jun 4, 2008 at 4:15 AM, Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> wrote: > På Onsdag 04 juni 2008 , 01:24:07 skrev Chris Morgan: >> What new policy on dissidents? ;-) >> >> How does this patch enable admins to remove themselves? I'm afraid I >> can't see how this change lets an admin

Re: Time to revert bad commits?

2008-06-04 Thread Maarten Lankhorst
Hello Vitaliy, 2008/6/2 Vitaliy Margolen <[EMAIL PROTECTED]>: > I'm afraid we are out of time to fix bugs that introduces major d3d > regressions. I've yet to see a single patch that addressed those issues. > > It's time to start reverting bad commits and testing the results. > > The bugs I'm talk

Re: mmio: Do not zero current file position whenever mmioSetBuffer is called

2008-06-04 Thread Christoph Frick
On Tue, Jun 03, 2008 at 07:57:00PM -0700, Matthew D'Asaro wrote: > Instead I set wm->info.lBufOffset to wm->info.lDiskOffset because the > buffer is flushed at the beginning of a call to mmioSetBuffer so > wm->info.lDiskOffset is synchronized with wm->info.lBufOffset and so > wm->info.lDiskOffset

Re: [AppDB] Allow admins to remove their admin rights

2008-06-04 Thread Alexander Nicolaysen Sørnes
På Onsdag 04 juni 2008 , 01:24:07 skrev Chris Morgan: > What new policy on dissidents? ;-) > > How does this patch enable admins to remove themselves? I'm afraid I > can't see how this change lets an admin remove their own admin status. > > Chris > > Yea, that particular piece of code isn't very c