Re: urlmon: Fix a test that fails on all platforms

2008-06-03 Thread James Hawkins
On Tue, Jun 3, 2008 at 8:52 PM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "James Hawkins" <[EMAIL PROTECTED]> wrote: > >> -ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed >> here\n"); >> + >> +if(bindf & BINDF_ASYNCHRONOUS) { >> +ok(IBindCtx_Release(bctx) =

Re: advpack: fix a test failure on 9x

2008-06-03 Thread James Hawkins
On Tue, Jun 3, 2008 at 7:17 PM, Austin English <[EMAIL PROTECTED]> wrote: > This isn't the right fix. The RegisterOCX command doesn't work in win9x, so it needs to be changed to another command. -- James Hawkins

Re: kernel32: avoid thread-unsafe function gmtime()

2008-06-03 Thread Dmitry Timoshkov
"Dan Kegel" <[EMAIL PROTECTED]> wrote: > Using gmtime() in a multithreaded program could > result in invalid results. So use the safer alternative > gmtime_r() if it's available. Most likely gmtime_r() should be used without #ifdefs and a replacement put in libs/port. -- Dmitry.

Re: urlmon: Fix a test that fails on all platforms

2008-06-03 Thread Dmitry Timoshkov
"James Hawkins" <[EMAIL PROTECTED]> wrote: > -ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed here\n"); > + > +if(bindf & BINDF_ASYNCHRONOUS) { > +ok(IBindCtx_Release(bctx) == 1, "bctx should not be destroyed > here\n"); > +IBindCtx_Release(bctx);

Re: [programs/winetest] Put up a warning message before running

2008-06-03 Thread Dmitry Timoshkov
"Paul Vriens" <[EMAIL PROTECTED]> wrote: > I totally agree that we should make winetest as robust as possible. But > please > have a look at http://bugs.winehq.org/show_bug.cgi?id=13608 and tell me if > you > agree this bug is closed. We tell to Linux users with kernel bugs to go and file a b

Valgrind note

2008-06-03 Thread Dan Kegel
For those of you using valgrind with --track-origins, make sure you're using a tree with vex rev >= 1854; Julian Seward says there was a problem that could cause segfaults. If in doubt, grab a fresh valgrind tree from svn.

Re: msi:MsiSourceListEnumMediaDisksW: free original string, not substring

2008-06-03 Thread Steven Edwards
On Tue, Jun 3, 2008 at 9:29 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Found via valgrind: > > Invalid free() / delete / delete[] >by msi_free (msipriv.h:965) >by MsiSourceListEnumMediaDisksW (source.c:324) > Address 0x7f01b2ac is 12 bytes inside a block of size 54 alloc'd >by msi_all

userenv: tests/userenv.c: fix buffer overrun

2008-06-03 Thread Dan Kegel
Found via valgrind. Fixes Use of uninitialised value of size 4 at wine_cp_mbstowcs (mbtowc.c:79) by MultiByteToWideChar (locale.c:1846) by CompareStringA (locale.c:2722) by get_env (userenv.c:140) by func_userenv (userenv.c:218) Uninitialised value was created by a stack al

Re: Trip & Conference Report Linux Tag 2008

2008-06-03 Thread Stefan Dösinger
Hi, A few corrections(I know it's too late, so just for the sake of it): *) DirectDraw is Software emulated, and via OpenGL. Although the OpenGL implementation still has some way to go and will never be able to handle all corner cases *) GameGuard does not work. It's one of the things that will

Re: [programs/winetest] Put up a warning message before running

2008-06-03 Thread James Hawkins
On Tue, Jun 3, 2008 at 10:59 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> >> On Tue, Jun 3, 2008 at 8:27 AM, Paul Vriens <[EMAIL PROTECTED]> >> wrote: >>> >>> Hi, >>> >>> Due to the fact that we have several ordinary users trying out winetest I >>> think >>> it makes sense t

Re: [programs/winetest] Put up a warning message before running

2008-06-03 Thread Paul Vriens
James Hawkins wrote: > On Tue, Jun 3, 2008 at 8:27 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: >> Hi, >> >> Due to the fact that we have several ordinary users trying out winetest I >> think >> it makes sense to put up this message. >> >> The message will not be shown in quiet mode and not in expert

Re: [programs/winetest] Put up a warning message before running

2008-06-03 Thread James Hawkins
On Tue, Jun 3, 2008 at 8:27 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Hi, > > Due to the fact that we have several ordinary users trying out winetest I > think > it makes sense to put up this message. > > The message will not be shown in quiet mode and not in expert mode (new one > '-x'). > > Ch

Trip & Conference Report Linux Tag 2008

2008-06-03 Thread Marcus Meissner
Hi, I was at LinuxTag 2008, which is the largest Linux User fair in Germany. The fair was from Wednesday to Saturday, however I was only there Saturday. Saturday was openSUSE day and we (openSUSE) had a conference track over the whole day. One of those talks in this track was my talk on "Wine -

Re: Time to revert bad commits?

2008-06-03 Thread Stefan Dösinger
Am Dienstag, 3. Juni 2008 13:01:11 schrieb Fabian Bieler: > I did some testing using the Half-Life 2 intro and outro (dxlevel 81). > Attached is a spreadsheet with the instruction and register counts of the > compiled shaders (aquired via __GL_WriteProgramObjectAssembly). The > difference is not as

Re: Time to revert bad commits?

2008-06-03 Thread Fabian Bieler
On Tuesday 03 June 2008 10:42:39 you wrote: > Am Dienstag, 3. Juni 2008 10:02:26 schrieb Fabian Bieler: > > The shader compiler can also do better optimization with hard-coded > > constants (particularly if the constants are 0 or 1). I've seen the > > nvidia-compiler remove entire code paths becaus

Re: Revert "wined3d: Preload target in ActivateContext() for ORM_BACKBUFFER/ORM_PBUFFER."

2008-06-03 Thread Alexandre Julliard
Stefan Dösinger <[EMAIL PROTECTED]> writes: > Am Montag, 2. Juni 2008 06:50:15 schrieb Vitaliy Margolen: >> This reverts commit 2d0016c5bc872afb562727278cfd341cea182600. >> Partially fixes bug 11584. > I think we can revert that patch(ie, apply this patch). I haven't had time to > look over the c

Re: ddraw: Don't release ddraw if a surface is still using it.

2008-06-03 Thread Stefan Dösinger
Am Sonntag, 1. Juni 2008 16:22:08 schrieb Jens Albretsen: > You're right, if we expect every program to behave. > I guess we need a hook for wined3d (if we not already have it) to restore > the state back at process termination, if there is stuff not freed, > changed video modes and such. Nope, tha

Re: Time to revert bad commits?

2008-06-03 Thread Stefan Dösinger
Am Dienstag, 3. Juni 2008 10:02:26 schrieb Fabian Bieler: > The shader compiler can also do better optimization with hard-coded > constants (particularly if the constants are 0 or 1). I've seen the > nvidia-compiler remove entire code paths because of this in a hl2-shader. Really? Do you have any e

Re: Time to revert bad commits?

2008-06-03 Thread Fabian Bieler
On Monday 02 June 2008 12:04:54 Stefan Dösinger wrote: > Am Montag, 2. Juni 2008 11:57:21 schrieb Ivan Gyurdiev: > > The patch being reverted seems interesting - it basically undoes a prior > > effort to get local constants into the same namespace as global ones due > > to relative addressing. I as