Failing tests: now what?

2008-06-02 Thread Juan Lang
Following through with Francois's suggestion, I extracted the user32 tests. They still fail for me: 81 failures in menu.c, all having to do with the expected width of menu items [1], which is precisely what I wanted to address. So I'm stymied how I'm going to convince Alexandre that my little me

Re: Keep swapchain while its backbuffer is in use.

2008-06-02 Thread Michael Karcher
Am Montag, den 02.06.2008, 22:51 +0200 schrieb Michael Karcher: > This fixes the warn+heap errors/crashes of d3d9:stateblock, and should > close the bug about differences with warn+heap enabled. Thats #12246, one of the 1.0 targeted bugs. I was offline while writing the patch email, so I could not

Re: user32: Fix input tests failing on WinXP+ (resend)

2008-06-02 Thread Vitaliy
Vitaliy Margolen wrote: > --- > dlls/user32/tests/input.c | 29 + > 1 files changed, 17 insertions(+), 12 deletions(-) >

[website] Fix typo in Spanish translation of home.template

2008-06-02 Thread Ángel Guzmán Maeso
Fix several typos -- Shakaran diff --git a/templates/es/home_about.template b/templates/es/home_about.template index 961a0ea..2a05cad 100644 --- a/templates/es/home_about.template +++ b/templates/es/home_about.template @@ -1,11 +1,11 @@ {$screenshot} Wine es una implementación de códido abie

Re: winedbg: Fix 'winedbg --auto' so it does just one backtrace.

2008-06-02 Thread Alexandre Julliard
Eric Pouech <[EMAIL PROTECTED]> writes: > Alexandre Julliard a écrit : >> Actually there are cases where it doesn't, which is why I added >> this. It's better to have two backtraces than none. >> >> > can you reproduce those cases ? it may be even better to fix those > cases instead of having t

Re: [2/2] Wineshader: Hardcode local constants with glUniform4fvARB

2008-06-02 Thread Stefan Dösinger
Am Montag, 2. Juni 2008 21:45:07 schrieb Stefan Dösinger: Erm, the proper library is wined3d, not wineshader. "wineshader" is my current in-development HLSL compiler lib...

Re: [2/2] wined3d: Set the surface location to SFLAG_INSYSMEM for depth stencils on Reset

2008-06-02 Thread H. Verbeet
2008/6/2 Stefan Dösinger <[EMAIL PROTECTED]>: > Am Montag, 2. Juni 2008 21:12:54 schrieb H. Verbeet: >> This fixes a rather major regression when using FBOs for offscreen >> rendering. Since we destroy the GL texture associated with the >> surface, and INDRAWABLE and INTEXTURE are the same for offs

Re: [2/2] wined3d: Set the surface location to SFLAG_INSYSMEM for depth stencils on Reset

2008-06-02 Thread Stefan Dösinger
Am Montag, 2. Juni 2008 21:12:54 schrieb H. Verbeet: > This fixes a rather major regression when using FBOs for offscreen > rendering. Since we destroy the GL texture associated with the > surface, and INDRAWABLE and INTEXTURE are the same for offscreen > targets when using FBO ORM, the texture wou

Re: Invalid '...' in resources

2008-06-02 Thread Fatih Aşıcı
02 Haz 2008 Pts tarihinde, Francois Gouget şunları yazmıştı: > The files below contain ' . . .' instead of '...'. This is invalid=20 > typographically in at least English, French and Russian. Could someone=20 > check if it is valid for the relevant languages: > >    Danish >    Dutch >    Hungaria

How to handle lack of internet connection in conformance tests

2008-06-02 Thread Austin English
For curiousity's sake, I tested my work XP box today, first as usual, then after a reboot and disabling the network connection: http://test.winehq.org/data/b4bf3553c4071a2a6979f1df08ae75aadde94b4b/#group_XP http://test.winehq.org/data/b4bf3553c4071a2a6979f1df08ae75aadde94b4b/xp_aenglish-xp-sp2/re

Re: winedbg: Fix 'winedbg --auto' so it does just one backtrace.

2008-06-02 Thread Eric Pouech
Alexandre Julliard a écrit : > Francois Gouget <[EMAIL PROTECTED]> writes: > > >> 'winedbg --auto' already prints a backtrace before the modules list. So >> there is no need to print another one after everything else. >> > > Actually there are cases where it doesn't, which is why I added >

Re: Crash in test d3d9:stateblock with warn+heap is a wine bug

2008-06-02 Thread Stefan Dösinger
With textures, the surface and the texture(the container) share one reference count. In the case of swapchains the swapchain is the container, so a GetBackBuffer would increment the swapchain's refcount to 2. So the swapchain wouldn't be destroyed before the backbuffer was released. I am not su

Re: Winetest grrr...

2008-06-02 Thread Paul Vriens
Stefan Dösinger wrote: > Am Freitag, 30. Mai 2008 16:51:08 schrieb Juan Lang: >> I know some video drivers are so broken we don't want to run on them. >> I have an ATI Radeon Mobility 250. I thought this was a fairly common >> card. Is locking up the machine really acceptable here? > All we could

Re: winex11.drv: Add support for AlphaBlend with non-opaque SourceConstantAlpha values.

2008-06-02 Thread Peter Urbanec
Ángel Guzmán Maeso wrote: > A small change: > > +int x,y; > +for (x = 0; x < widthSrc; x++, tmpBits += 4) > +for(y=0;y<4;y++) > +tmpBits[y] = tmpBits[y] * blendfn.SourceConstantAlpha / 255; I'm not fussed one way or the other, but I can see at least two advantages in keeping the orig

Re: Invalid '...' in resources

2008-06-02 Thread Tijl Coosemans
On Monday 02 June 2008 16:57:40 Francois Gouget wrote: > The files below contain ' . . .' instead of '...'. This is invalid > typographically in at least English, French and Russian. Could someone > check if it is valid for the relevant languages: >Dutch No.

Invalid '...' in resources

2008-06-02 Thread Francois Gouget
The files below contain ' . . .' instead of '...'. This is invalid typographically in at least English, French and Russian. Could someone check if it is valid for the relevant languages: Danish Dutch Hungarian Korean Norwegian Turkish ./programs/winefile/No.rc ./programs/ole

Re: snmpapi: Stop tests from crashing on win98

2008-06-02 Thread Juan Lang
> If not running is preferable shouldn't we just if(0) them and add some > comments? Yes, I believe that's the preferred method of removing crashing tests. --Juan

Re: Crash in test d3d9:stateblock with warn+heap is a wine bug

2008-06-02 Thread Michael Karcher
Am Montag, den 02.06.2008, 06:23 -0400 schrieb Ivan Gyurdiev: > Ivan Gyurdiev wrote: > > Michael Karcher wrote: > >> Does anyone knows whether the test has this been written buggy on > >> purpose (some app does this), or it is by accident? > >> > I guess the reason why switching the render target w

Re: snmpapi: Stop tests from crashing on win98

2008-06-02 Thread Paul Vriens
Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > snmpapi: Stop tests from crashing on win98 > > Best Regards > Alistair Leslie-Hughes > > > > > > > I still don't think they should be removed but that's my opin

Re: [PATCH] winealsa: Raise ALSA minimum period size to sane value

2008-06-02 Thread John Klehm
On Sun, Jun 1, 2008 at 6:58 PM, Zephiris <[EMAIL PROTECTED]> wrote: > The ALSA period size can be set to rather odd values, and querying the > minimum period size isn't always guaranteed to be sane. Use a safety net > value. This fixes bug 13458. > > --- > > dlls/winealsa.drv/dsoutput.c |5 +++

Re: winedbg: Fix 'winedbg --auto' so it does just one backtrace.

2008-06-02 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > 'winedbg --auto' already prints a backtrace before the modules list. So > there is no need to print another one after everything else. Actually there are cases where it doesn't, which is why I added this. It's better to have two backtraces than none.

Re: Crash in test d3d9:stateblock with warn+heap is a wine bug

2008-06-02 Thread Ivan Gyurdiev
Ivan Gyurdiev wrote: > Michael Karcher wrote: >> Does anyone knows whether the test has this been written buggy on >> purpose (some app does this), or it is by accident? >> >> > Probably the first one - I wrote the test with rather limited > understanding of how rendertargets work. > I don't th

Re: Crash in test d3d9:stateblock with warn+heap is a wine bug

2008-06-02 Thread Ivan Gyurdiev
Michael Karcher wrote: > Does anyone knows whether the test has this been written buggy on > purpose (some app does this), or it is by accident? > > Probably the first one - I wrote the test with rather limited understanding of how rendertargets work. I don't think there was a specific applicat

Re: Time to revert bad commits?

2008-06-02 Thread Stefan Dösinger
Am Montag, 2. Juni 2008 11:57:21 schrieb Ivan Gyurdiev: > The patch being reverted seems interesting - it basically undoes a prior > effort to get local constants into the same namespace as global ones due > to relative addressing. I assume this is done for performance reasons, > is this correct ?

Re: Time to revert bad commits?

2008-06-02 Thread Ivan Gyurdiev
Stefan Dösinger wrote: > Am Montag, 2. Juni 2008 08:11:13 schrieb Roderick Colenbrander: > >>> The bugs I'm talking about: >>> Bug 10580 >>> > Sorry that I did not have time yet to look into that, but instead of ranting > you could also look at the GLSL docs and make a patch. I did see

Re: iexplore/gecko problems with recent builds

2008-06-02 Thread Steven Edwards
On Sun, Jun 1, 2008 at 4:39 PM, Steven Edwards <[EMAIL PROTECTED]> wrote: > I did not find anything about this in bugzilla. Is anyone else having > problems using builtin IE with gecko? I keep getting this error with > the tip > > err:mshtml:before_async_open GetWineURL returned NULL This issue se

Crash in test d3d9:stateblock with warn+heap is a wine bug

2008-06-02 Thread Michael Karcher
Hello developers (mostly direct3d hackers), the infamous crash in d3d9:stateblock [1] is caused by a call sequence that is forbidden according to the DirectX SDK documentation. The switch_rendertarget test makes a new swap chain, and sets its backbuffer as new rendering target, and then releases t

Re: Revert "wined3d: Preload target in ActivateContext() for ORM_BACKBUFFER/ORM_PBUFFER."

2008-06-02 Thread Stefan Dösinger
Am Montag, 2. Juni 2008 06:50:15 schrieb Vitaliy Margolen: > This reverts commit 2d0016c5bc872afb562727278cfd341cea182600. > Partially fixes bug 11584. I think we can revert that patch(ie, apply this patch). I haven't had time to look over the code yet, but I can't think of any problems this would

Re: Time to revert bad commits?

2008-06-02 Thread Stefan Dösinger
Am Montag, 2. Juni 2008 08:11:13 schrieb Roderick Colenbrander: > > The bugs I'm talking about: > > Bug 10580 Sorry that I did not have time yet to look into that, but instead of ranting you could also look at the GLSL docs and make a patch. Renaming the local constants from LC to LVC for vertex