Re: Revert "wined3d: Put implicit surfaces into drawable on unload."

2008-06-01 Thread H. Verbeet
2008/6/2 Vitaliy Margolen <[EMAIL PROTECTED]>: > This reverts commit 0de167db9e2ef6c62ba48b050bc3d0ba2638467f. > Fixes bug 12794 and probably others related to the black screen with enabled > FBO. > --- > dlls/wined3d/surface.c | 11 ++- > 1 files changed, 2 insertions(+), 9 deletions(-)

Re: [try 4] user32: Use correct buffer header for cursor inCURSORICON_LoadFromFile

2008-06-01 Thread Dmitry Timoshkov
"Sergey Khodych" <[EMAIL PROTECTED]> wrote: > CreateIconFromResourceEx expects POINT16 at beginning of input buffer( > for cursors ). > Fixes bug #5031. Please follow the indentation/braces style of the file you are changing. -- Dmitry.

Re: Time to revert bad commits?

2008-06-01 Thread Roderick Colenbrander
> I'm afraid we are out of time to fix bugs that introduces major d3d > regressions. I've yet to see a single patch that addressed those issues. > > It's time to start reverting bad commits and testing the results. > > The bugs I'm talking about: > Bug 10580 > Bug 11584 > Bug 12794 > Bug 13101 >

Re: [1/3] ddraw/tests: Detach surface if attaching worked by surprise (or refrast)

2008-06-01 Thread Michael Karcher
Am Sonntag, den 01.06.2008, 18:19 -0500 schrieb James Hawkins: > On Sun, Jun 1, 2008 at 5:47 PM, Michael Karcher > <[EMAIL PROTECTED]> wrote: > > --- > > dlls/ddraw/tests/dsurface.c |3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > Patch already sent: > http://winehq.org/piper

Re: [2/3] ddraw/tests: Add another refrast exception

2008-06-01 Thread Michael Karcher
Am Sonntag, den 01.06.2008, 18:23 -0500 schrieb James Hawkins: > On Sun, Jun 1, 2008 at 5:48 PM, Michael Karcher > <[EMAIL PROTECTED]> wrote: > > --- > > dlls/ddraw/tests/dsurface.c |5 - > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > I've gone through all the latest test resul

Time to revert bad commits?

2008-06-01 Thread Vitaliy Margolen
I'm afraid we are out of time to fix bugs that introduces major d3d regressions. I've yet to see a single patch that addressed those issues. It's time to start reverting bad commits and testing the results. The bugs I'm talking about: Bug 10580 Bug 11584 Bug 12794 Bug 13101 Vitaliy.

Re: Fixing crashes in Tests (OS version check)

2008-06-01 Thread Juan Lang
> The thing is that this evolves with time. Back in 2000 nobody would have > called SnmpUtilOidToA with a NULL parameter as it would have meant > crashing on a lot of the Windows install base. Nowadays every ISV > expects you to have at least Windows XP and wouldn't care one bit if > that call mean

Re: Winetest grrr...

2008-06-01 Thread Juan Lang
> here's a workaround for 'extracting' the test executables > from Paul Millar's exe. Start winetest, wait until the first test > starts, and then kill winetest.exe (or close the winetest window). Then > you can find the test binaries in c:\Windows\Temp\wct (or possibly > c:\Documents and Settings\

Re: [2/3] ddraw/tests: Add another refrast exception

2008-06-01 Thread James Hawkins
On Sun, Jun 1, 2008 at 5:48 PM, Michael Karcher <[EMAIL PROTECTED]> wrote: > --- > dlls/ddraw/tests/dsurface.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > I've gone through all the latest test results, and this failure isn't happening anywhere that I've seen. Please link t

Re: [1/3] ddraw/tests: Detach surface if attaching worked by surprise (or refrast)

2008-06-01 Thread James Hawkins
On Sun, Jun 1, 2008 at 5:47 PM, Michael Karcher <[EMAIL PROTECTED]> wrote: > --- > dlls/ddraw/tests/dsurface.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > Patch already sent: http://winehq.org/pipermail/wine-patches/2008-May/055424.html -- James Hawkins

Re: How long does it take you to compile wine?

2008-06-01 Thread Evil Jay
real5m22.625s user17m16.993s sys 1m1.336s This is on Kubuntu 8.04 w/GCC 4.2.3. The system uses a Q6600 overclocked to 2.9Ghz, 4GB of DDR2 [EMAIL PROTECTED], and a 9600GT video card. I had Amarok and some other stuff going in the background, but nothing that would make a huge diff. -

iexplore/gecko problems with recent builds

2008-06-01 Thread Steven Edwards
Hi, I did not find anything about this in bugzilla. Is anyone else having problems using builtin IE with gecko? I keep getting this error with the tip err:mshtml:before_async_open GetWineURL returned NULL -- Steven Edwards "There is one thing stronger than all the armies in the world, and that

Re: advapi32: RegEnumKeyEx() should return "ERROR_INVALID_PARAMETER" if name_len is NULL

2008-06-01 Thread James Hawkins
On Sun, Jun 1, 2008 at 11:28 AM, Andrew Talbot <[EMAIL PROTECTED]> wrote: > Like native. > > -- Andy. > --- > Changelog: >advapi32: RegEnumKeyEx() should return "ERROR_INVALID_PARAMETER" if > name_len is NULL. > > diff --git a/dlls/advapi32/registry.c b/dlls/advapi32/registry.c > index 9ce3da0

Re: How long does it take you to compile wine?

2008-06-01 Thread Steven Edwards
On Sun, Jun 1, 2008 at 10:20 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> make -j5, Q6600 @ 2.4GHz for comparison I have an older 2.4 ghz quad CPU single core build box with gcc 4.1.x and Fiesty. make -j4 real16m34.006s user56m54.569s sys 3m26.561s -- Steven Edwards "There is one th

Re: How long does it take you to compile wine?

2008-06-01 Thread Eric Pouech
> I'm using same version. > > What graphics card, btw? ATI Radeon HD 2600 XT A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: ddraw: Don't release ddraw if a surface is still using it.

2008-06-01 Thread Jens Albretsen
> Am Samstag, 31. Mai 2008 17:03:13 schrieb Michael Karcher: >> > Anyway it makes wine stop crashing when programs tries to do something >> > crazy like this. Stefan Dösinger asked me to put a HeapAlloc all >> memory >> > between the two Release's to check if the memory of ddraw object would >> be

Re: How long does it take you to compile wine?

2008-06-01 Thread Dan Kegel
On Sun, Jun 1, 2008 at 4:50 AM, Eric Pouech <[EMAIL PROTECTED]> wrote: > I used to compiled it over 30minutes... > now I barely wait... 6mn26s > > make -j5, Q6600 @ 2.4GHz Ouch! I almost chose a Q6600 for this machine! Well, I suppose I should test it with the motherboard graphics turned off, tha

Re: Fixing crashes in Tests (OS version check)

2008-06-01 Thread Francois Gouget
On Sat, 31 May 2008, Juan Lang wrote: [...] > > An example of one that fails is > > ret = SnmpUtilOidToA(NULL); > > Under win98, this function is valid to call, but will crash if you call > > it will a NULL parameter. I don't think removing this test a good idea, > > since we are setting XP as a

Re: Winetest grrr...

2008-06-01 Thread Francois Gouget
On Fri, 30 May 2008, Juan Lang wrote: [...] > I thought I'd run winetest.exe from Paul Millar's site, just > in case the compilation environment had something to do with it. [...] > How the ^$*@ am I supposed to produce a test when the existing ones > fail/crash/burn for me? Grrr... I'm not sayin

Re: How long does it take you to compile wine?

2008-06-01 Thread Hans Leidekker
On Sunday 01 June 2008 10:16:19 Dan Kegel wrote: > I suppose my e7200 is a budget performance system; a dual Xeon back then > was pretty special. Probably have to compare it to something > heftier today? It's 4m55s on a 2 way dual core Xeon machine (4 cores, 2 Ghz, 4MB cache each). This is on a

Re: How long does it take you to compile wine?

2008-06-01 Thread Eric Pouech
Dan Kegel a écrit : > Way back five years ago, we all compared notes on how > long it took to build Wine on our systems. > http://www.winehq.org/site/?issue=149#Compile%20Time%20Comparisons%20/%20Tips > > Today I measured it on a new computer (with a spiffy > new Intel dual core e7200 processor wit

Re: [2/2] ddraw: Rename IDirectDraw functions (try 2)

2008-06-01 Thread Christian Costa
Stefan Dösinger a écrit : > Am Sonntag, 1. Juni 2008 00:13:22 schrieb Christian Costa: > >> Hi Michael, >> >> I think it would be better to fix function names in IDirectDraw7. >> > The IDirectDraw7 functions are without a version number because they're the > common implementation for all d

Re: How long does it take you to compile wine?

2008-06-01 Thread Vít Hrachový
Hi Dan, it's 31 minutes on AMD Athlon(tm) 64 Processor 3700+, 2GB RAM. Cheers Vit Dan Kegel wrote: > Way back five years ago, we all compared notes on how > long it took to build Wine on our systems. > http://www.winehq.org/site/?issue=149#Compile%20Time%20Comparisons%20/%20Tips > > Today I meas

Re: How long does it take you to compile wine?

2008-06-01 Thread Reece Dunn
2008/6/1 Dan Kegel <[EMAIL PROTECTED]>: > Way back five years ago, we all compared notes on how > long it took to build Wine on our systems. > http://www.winehq.org/site/?issue=149#Compile%20Time%20Comparisons%20/%20Tips > > Today I measured it on a new computer (with a spiffy > new Intel dual core

Re: [2/2] ddraw: Rename IDirectDraw functions (try 2)

2008-06-01 Thread Michael Karcher
Am Sonntag, den 01.06.2008, 00:47 +0200 schrieb Stefan Dösinger: > Am Sonntag, 1. Juni 2008 00:13:22 schrieb Christian Costa: > > Hi Michael, > > > > I think it would be better to fix function names in IDirectDraw7. > The IDirectDraw7 functions are without a version number because they're the > co

Re: How long does it take you to compile wine?

2008-06-01 Thread Dan Kegel
On Sun, Jun 1, 2008 at 12:47 AM, James Hawkins <[EMAIL PROTECTED]> wrote: >> Today I measured it on a new computer (with a spiffy >> new Intel dual core e7200 processor with 2GB of RAM, >> http://kegel.com/new-computer-2008.html ). >> >> Result: ... it takes me a bit longer today on this machine (1

Re: How long does it take you to compile wine?

2008-06-01 Thread James Hawkins
On Sun, Jun 1, 2008 at 2:44 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Way back five years ago, we all compared notes on how > long it took to build Wine on our systems. > http://www.winehq.org/site/?issue=149#Compile%20Time%20Comparisons%20/%20Tips > > Today I measured it on a new computer (with a

How long does it take you to compile wine?

2008-06-01 Thread Dan Kegel
Way back five years ago, we all compared notes on how long it took to build Wine on our systems. http://www.winehq.org/site/?issue=149#Compile%20Time%20Comparisons%20/%20Tips Today I measured it on a new computer (with a spiffy new Intel dual core e7200 processor with 2GB of RAM, http://kegel.com/

Two quick press mentions about Microsoft and Wine (the other one)

2008-06-01 Thread Dan Kegel
Microsoft Wine (Sept '07): http://www.sommelierindia.com/blog/2007/10/changing_the_world_with_a_micr.html Microsoft bans searches for Wine in France (today): http://www.sbpost.ie/post/pages/p/story.aspx-qqqt=MEDIA+AND+MARKETING-qqqs=mediaandmarketing-qqqid=33312-qqqx=1.asp Not sinister, just funn

Re: try 2: shell32: fix SHFileOperation copying to an empty file list

2008-06-01 Thread James Hawkins
On Sun, Jun 1, 2008 at 1:35 AM, Vincent Povirk <[EMAIL PROTECTED]> wrote: > This partially fixex bug 13394. > > Apparently there are two separate issues involved in that bug, one > with empty destination lists (which Windows seems to treat as a list > containing one 0-length string), and one involv