Re: comctl32: Fix statusbar text alignment bug #12693

2008-05-13 Thread James Hawkins
On Tue, May 13, 2008 at 8:35 PM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > > "James Hawkins" <[EMAIL PROTECTED]> wrote: > > > > On Tue, May 13, 2008 at 7:59 PM, Igor Tarasov <[EMAIL PROTECTED]> > wrote: > > > > > MSDN regarding statusbar text alignment says that "By default, text is > > > left

Re: comctl32: Fix statusbar text alignment bug #12693

2008-05-13 Thread Dmitry Timoshkov
"James Hawkins" <[EMAIL PROTECTED]> wrote: > On Tue, May 13, 2008 at 7:59 PM, Igor Tarasov <[EMAIL PROTECTED]> wrote: >> MSDN regarding statusbar text alignment says that "By default, text is >> left-aligned <...> Text to the right of a single tab character is >> centered, and text to the right

Re: comctl32: Fix statusbar text alignment bug #12693

2008-05-13 Thread James Hawkins
On Tue, May 13, 2008 at 7:59 PM, Igor Tarasov <[EMAIL PROTECTED]> wrote: > MSDN regarding statusbar text alignment says that "By default, text is > left-aligned <...> Text to the right of a single tab character is > centered, and text to the right of a second tab character is > right-aligned.".

Re: [PATCH] [cmd]: use correct codepage when outputing unicode text to an ANSI stream

2008-05-13 Thread Kirill K. Smirnov
>> This doesn't look right. What if it's wineconsole with user backend >> (default) and OEM CP (which is different then UNIXCP)? Should probably hack >> GetConsoleOutputCP() instead. >> >this code is only used when no wineconsole is attached, so unixcp is the >right choice No, this is used in

Re: Lots of regressions in games in last few versions

2008-05-13 Thread Austin English
On Sun, May 11, 2008 at 11:31 PM, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: > > Austin English wrote: > > > 13120 - I'll run the test tomorrow if I can reproduce/no one has by then. > > 13110 - no one requested a regression test. I've requested it now. > > 13101 - not a regression > > 13086 - not

Re: [PATCH] [cmd]: use correct codepage when outputing unicode text to an ANSI stream

2008-05-13 Thread Eric Pouech
Vitaliy Margolen a écrit : > Eric Pouech wrote: > >> @@ -1437,7 +1437,7 @@ static void WCMD_output_asis_len(const WCHAR *message, >> int len, HANDLE device) { >> } >> >> /* Convert to OEM, then output */ >> -convertedChars = WideCharToMultiByte(GetConsoleOutputCP(),

Re: richedit: empty text should result in a scroll range of 0. Tests for this behavior.

2008-05-13 Thread Eric Pouech
Alex Villací­s Lasso a écrit : > Even though the code freeze is still in effect, I post this so that it > will be reviewed. For more information, see bug #12311. > > Changelog: > * richedit: empty text should result in a scroll range of 0. > * Tests for this behavior. > > -

Re: Lots of regressions in games in last few versions

2008-05-13 Thread Vitaliy Margolen
Austin English wrote: > On Sun, May 11, 2008 at 11:31 PM, Vitaliy Margolen > <[EMAIL PROTECTED]> wrote: >> Austin English wrote: >> >>> 13120 - I'll run the test tomorrow if I can reproduce/no one has by then. >>> 13110 - no one requested a regression test. I've requested it now. >>> 13101 - not a

Re: wine.inf: add a fake dll for sensapi.dll

2008-05-13 Thread Austin English
Anything wrong with this patch? http://www.winehq.org/pipermail/wine-patches/2008-May/054794.html

Re: [PATCH] [cmd]: use correct codepage when outputing unicode text to an ANSI stream

2008-05-13 Thread Vitaliy Margolen
Eric Pouech wrote: > @@ -1437,7 +1437,7 @@ static void WCMD_output_asis_len(const WCHAR *message, > int len, HANDLE device) { > } > > /* Convert to OEM, then output */ > -convertedChars = WideCharToMultiByte(GetConsoleOutputCP(), 0, > message, > +convertedChars

Re: [PATCH] Cache localised number chars

2008-05-13 Thread Michael Karcher
Am Dienstag, den 13.05.2008, 18:57 +0100 schrieb Robert Shearman: > Michael Karcher wrote: > > UDATE *lpUdate) > > static void VARIANT_GetLocalisedNumberChars(VARIANT_NUMBER_CHARS *lpChars, > > LCID lcid, DWORD dwFlags) > > { > >static const VARIANT_NUMBER_CHARS defaultChars = { > > '-','+

Re: [PATCH] Cache localised number chars

2008-05-13 Thread Robert Shearman
Michael Karcher wrote: > UDATE *lpUdate) > static void VARIANT_GetLocalisedNumberChars(VARIANT_NUMBER_CHARS *lpChars, > LCID lcid, DWORD dwFlags) > { >static const VARIANT_NUMBER_CHARS defaultChars = { > '-','+','.',',','$',0,'.',',' }; > + static VARIANT_NUMBER_CHARS lastChars; > + stati

Re: includes: Add vmr9 header

2008-05-13 Thread Maarten Lankhorst
Hello Rob, 2008/5/13 Robert Shearman <[EMAIL PROTECTED]>: > Maarten Lankhorst wrote: > > > @@ -0,0 +1,525 @@ > > > > +#include "unknwn.idl" > > > > You should use import here, not #include. Yeah, I noticed it while I was trying to include it and got multiple definitions errors, I'll send a f

Re: Lots of regressions in games in last few versions

2008-05-13 Thread Jeremy White
>> Relax the code freeze a bit and stay in RC phase for as many releases as >> the beta phase..? > > That's like saying "don't do the 1.0 release yet, just keep doing > 0.9.62, etc..." > Not going to happen. Wine needs a release. All good open source > projects need to release (not just make sn

Re: [d3d9] shademode_test: increase slop in color comparison

2008-05-13 Thread Stefan Dösinger
Am Montag, 12. Mai 2008 22:54:18 schrieb Dan Kegel: > The test allowed for a slop of (-1,0) in the colors, > but on my machine, > nVidia Corporation NV17 [GeForce4 440 Go 64M] > the colors were off by +1. So change the code > to allow for a slop of +-1, and switch to a more readable > way of compa

Re: includes: Add vmr9 header

2008-05-13 Thread Robert Shearman
Maarten Lankhorst wrote: > @@ -0,0 +1,525 @@ > +/* > + * Copyright 2008 Maarten Lankhorst > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > +

Re: winex11: Create a dummy parent window for composite child windows to avoid using the root.

2008-05-13 Thread Alexandre Julliard
Chris Robinson <[EMAIL PROTECTED]> writes: > Alexandre Julliard wrote: >> -attrib.override_redirect = True; >> attrib.colormap = data->colormap; >> XInstallColormap(gdi_display, attrib.colormap); >> >> if(data->gl_drawable) XDestroyWindow(gdi_display, > data->gl