Fixing wintab window messaging, bug 11846. Requesting review

2008-05-08 Thread John Klehm
Hey, Well I'm trying to nail down why sai paint tool isn't doing its pressure stuff and I think this is starting down the right track but I wanted to get some input from those more familiar with wine messaging and x11 events. Without the first patch sai can't find an x11 window to attach too and

Re: [1/3] gdiplus: GdipGetImageFlags (bug 12144)

2008-05-08 Thread Maarten Lankhorst
Hello Nikolay, 2008/5/8 Nikolay Sivov <[EMAIL PROTECTED]>: > Maarten Lankhorst wrote: >> >> Hello Nikolay, >> >> 2008/5/8 Nikolay Sivov <[EMAIL PROTECTED]>: >> >>> >>> Changelog: >>> - simple implementation of GdipGetImageFlags >>> >>> --- >>> dlls/gdiplus/gdiplus.spec |2 +- >>> dlls/

Re: [3/3] gdiplus: GdipCreateFromHWNDICM (bug 12185)

2008-05-08 Thread Juan Lang
You appear to have sent the wrong patch for this one. --Juan

Re: [1/3] gdiplus: GdipGetImageFlags (bug 12144)

2008-05-08 Thread Maarten Lankhorst
Hello Nikolay, 2008/5/8 Nikolay Sivov <[EMAIL PROTECTED]>: > Changelog: >- simple implementation of GdipGetImageFlags > > --- > dlls/gdiplus/gdiplus.spec |2 +- > dlls/gdiplus/gdiplus_private.h |1 + > dlls/gdiplus/image.c | 11 +++ > include/gdiplusenums.h

Re: Wine t-shirts?

2008-05-08 Thread Maarten Lankhorst
2008/5/8 Maarten Lankhorst <[EMAIL PROTECTED]>: > 2008/5/8 Jon Parshall <[EMAIL PROTECTED]>: >> I've messed around with Wine Bottles for our installer artwork, and I have >> this version that I could gussy up for the shirts if you'd like. > I like the most left bottle, can you make one in the redd

Re: Wine t-shirts?

2008-05-08 Thread Maarten Lankhorst
Hello Jon, 2008/5/8 Jon Parshall <[EMAIL PROTECTED]>: > I've messed around with Wine Bottles for our installer artwork, and I have > this version that I could gussy up for the shirts if you'd like. I like the most left bottle, can you make one in the reddish color wine uses? And put the label I c

Re: Deprecated sound functions

2008-05-08 Thread Michael Stefaniuc
TheBlunderbuss wrote: > During the day's compile, I noticed some functions were declared > deprecated, mainly in sound components. > I logged more context, if anyone needs it. This is known. But the ALSA functions were only recently deprecated, e.g. Fedora 8 doesn't show them but F9 does. > alsa.

Re: inetmib1(0/15)

2008-05-08 Thread Juan Lang
Hi Maarten, > I don't see any testcases? With the code freeze I think it is best to > add them since it will have more chance of getting accepted. I don't > know if it's a good idea otherwise to add code at this point in code > freeze. I know about the freeze, and I'll resend if I have to. It di

Re: inetmib1(0/15)

2008-05-08 Thread Maarten Lankhorst
Hello Juan, 2008/5/8 Juan Lang <[EMAIL PROTECTED]>: > This series of patches implements the inetmib1 dll, mainly to fix bug 13004. I don't see any testcases? With the code freeze I think it is best to add them since it will have more chance of getting accepted. I don't know if it's a good idea ot

Re: Wine t-shirts?

2008-05-08 Thread Maarten Lankhorst
Hi all, 2008/5/2 Jeremy Newman <[EMAIL PROTECTED]>: > ftp://wine.codeweavers.com/pub/wine/logos/ > > Maarten Lankhorst wrote: >> >> Hello Jeremy, >> >> 2008/5/1 Jeremy Newman <[EMAIL PROTECTED]>: >>> >>> Sure, I will put up an archive of our Penguin EPS files later today >>> somewhere. Probably on

Re: ntdll: Fix RtlIntegerToUnicodeString so it won't overflow

2008-05-08 Thread Alexandre Julliard
"Maarten Lankhorst" <[EMAIL PROTECTED]> writes: > It copies str->Length + sizeof(WCHAR) to the destination buffer > according to james' testcases. So it definitely looks like a bug to me > if it would copy data beyond MaximumLength, since only up to > MaximumLength is guaranteed to be allocated. O

Re: ntdll: Fix RtlIntegerToUnicodeString so it won't overflow

2008-05-08 Thread James Hawkins
On Thu, May 8, 2008 at 1:41 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > James wrote: >> > It copies str->Length + sizeof(WCHAR) to the destination buffer >> > according to james' testcases. >> >> No, the length is indeterminate. > > Oh, is that the test that checks whether not double-null terminatin

re: ntdll: Fix RtlIntegerToUnicodeString so it won't overflow

2008-05-08 Thread Dan Kegel
James wrote: > > It copies str->Length + sizeof(WCHAR) to the destination buffer > > according to james' testcases. > > No, the length is indeterminate. Oh, is that the test that checks whether not double-null terminating works? I think that test needs rewriting to be determinate... e.g. by putti

RE: [PATCH] cmd.exe: MSI packages execution implemented

2008-05-08 Thread Rolf Kalbermatter
Vitaly Perov [mailto:[EMAIL PROTECTED] wrote: > I haven't found any information about how it implemented in > Windows. I use the similar *.com and *.bat way of execution > *.msi. I don't sure, that it is correct, but it works! > I'll be grateful if you have any information/links about how > it

Re: ntdll: Fix RtlIntegerToUnicodeString so it won't overflow

2008-05-08 Thread James Hawkins
On Thu, May 8, 2008 at 1:00 PM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Hello Alexandre, > > 2008/5/8 Alexandre Julliard <[EMAIL PROTECTED]>: >> "Maarten Lankhorst" <[EMAIL PROTECTED]> writes: >> >> > @@ -1970,7 +1970,7 @@ NTSTATUS WINAPI RtlIntegerToUnicodeString( >> > } while (value

Re: ntdll: Fix RtlIntegerToUnicodeString so it won't overflow

2008-05-08 Thread Maarten Lankhorst
Hello Alexandre, 2008/5/8 Alexandre Julliard <[EMAIL PROTECTED]>: > "Maarten Lankhorst" <[EMAIL PROTECTED]> writes: > > > @@ -1970,7 +1970,7 @@ NTSTATUS WINAPI RtlIntegerToUnicodeString( > > } while (value != 0L); > > > > str->Length = (&buffer[32] - pos) * sizeof(WCHAR); > > -i

Re: winetest reports shows a lot of "debugger.c:185:debugger: done debugging..."

2008-05-08 Thread Maarten Lankhorst
Hello Paul, 2008/5/8 Paul Vriens <[EMAIL PROTECTED]>: > Hi, > > On test.winehq.org one can see that both the W98 and the NT4 reports show a > lot > of the mentioned lines. > > For example : http://test.winehq.org/data/200805081000/95_W95/report > > Any idea where these are coming from? They w

Re: Review request: real async for GetAsyncKeyState (bug #5623)

2008-05-08 Thread Philip Nilsson
On Wed, May 07, 2008 at 08:49:34PM +0200, Rafał Miłecki wrote: > Hi, > > This is my first wine patch and fix for bug #5623. This was tested and > works fine however I suspect this is not clean enought for commiting > to master. > > -- > Rafał Miłecki Applying this patch causes my Wine to fail w

winetest reports shows a lot of "debugger.c:185:debugger: done debugging..."

2008-05-08 Thread Paul Vriens
Hi, On test.winehq.org one can see that both the W98 and the NT4 reports show a lot of the mentioned lines. For example : http://test.winehq.org/data/200805081000/95_W95/report Any idea where these are coming from? They weren't there before (AFAIK). -- Cheers, Paul.

Re: [PATCH] cmd.exe: MSI packages execution implemented

2008-05-08 Thread Vitaly Perov
Vitaliy Margolen wrote: > Vitaly Perov wrote: > > Changelog: cmd.exe: MSI packages execution implemented > > That doesn't look right. You sure this information is hard-coded into > cmd.exe and it's not coming from the registry CLASSES hive? > > Vitaliy I haven't found any information about how it

Re: winetricks missing MFC42

2008-05-08 Thread Mike Kronenberg
On 08.05.2008, at 01:23, Dan Kegel wrote: > On Wed, May 7, 2008 at 3:46 PM, Vitaliy Margolen > <[EMAIL PROTECTED]> wrote: >> Dan that's going way overboard. You creating another winedoors or >> worse >> winetools. >> >> Original idea of having few dlls and registry changes in one place >> - w

Re: ntdll: Fix RtlIntegerToUnicodeString so it won't overflow

2008-05-08 Thread Alexandre Julliard
"Maarten Lankhorst" <[EMAIL PROTECTED]> writes: > @@ -1970,7 +1970,7 @@ NTSTATUS WINAPI RtlIntegerToUnicodeString( > } while (value != 0L); > > str->Length = (&buffer[32] - pos) * sizeof(WCHAR); > -if (str->Length >= str->MaximumLength) { > +if (str->Length + sizeof(WCHAR) >= s