Re: [Resend] user32: Post the WM_KEY{DOWN|UP} messagewhenWM_IME_KEY{DOWN|UP} message is generated by IME.

2008-04-29 Thread Dmitry Timoshkov
"Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > In order to check posted messages, you need to do what other tests > do: run a GetMessage/TranslateMessage/DispatchMessage loop, and let > the window proc handle the messages. s/GetMessage/PeekMessage/ -- Dmitry.

Re: [Resend] user32: Post the WM_KEY{DOWN|UP} message whenWM_IME_KEY{DOWN|UP} message is generated by IME.

2008-04-29 Thread Dmitry Timoshkov
"ByeongSik Jeon" <[EMAIL PROTECTED]> wrote: > @@ -4496,6 +4551,9 @@ static void test_messages(void) > > DestroyWindow(hwnd); > flush_sequence(); > + > +/* Message sequences by WM_IME_KEYDOWN */ > +test_wm_ime_keydown(); > } test_messages() is not a proper place to add new tes

Re: [Resend] user32: Post the WM_KEY{DOWN|UP} message whenWM_IME_KEY{DOWN|UP} message is generated by IME.

2008-04-29 Thread Dmitry Timoshkov
"ByeongSik Jeon" <[EMAIL PROTECTED]> wrote: > I have added the test code. Your test doesn't confirm that the message is posted and not sent. You need to use SendMessage and examine the resulting messages, then run the message loop and see what messages got posted. -- Dmitry.

Re: wined3d: Fix for buggy programs using ortho matrix with no z range

2008-04-29 Thread Jens Albretsen
On Tuesday 29 April 2008 22:25:48 Stefan Dösinger wrote: > Am Dienstag, 29. April 2008 19:04:55 schrieb Jens Albretsen: > > Changelog: > > Fix for old games that sets a Ortho matrix with z range from 0-0 or in > > other word with no range, which does'nt make any sense but they do it > > anyway. >

Re: wined3d: Fix for buggy programs using ortho matrix with no z range

2008-04-29 Thread Jens Albretsen
On Tuesday 29 April 2008 22:25:48 Stefan Dösinger wrote: > Am Dienstag, 29. April 2008 19:04:55 schrieb Jens Albretsen: > > Changelog: > > Fix for old games that sets a Ortho matrix with z range from 0-0 or in > > other word with no range, which does'nt make any sense but they do it > > anyway. > >

Re: RFC: detecting wine drivers in the audio tests

2008-04-29 Thread Maarten Lankhorst
Hello Robert, 2008/4/29 Robert Reif <[EMAIL PROTECTED]>: > The returned result of some audio functions on windows may be inconsistent > because a driver may actually supply the returned value. > > This presents a problem for the wine regression tests because a buggy > driver may return an unexpec

Re: RFC: detecting wine drivers in the audio tests

2008-04-29 Thread Vitaliy Margolen
Robert Reif wrote: > The returned result of some audio functions on windows may be > inconsistent because a driver may actually supply the returned value. > > This presents a problem for the wine regression tests because a buggy > driver may return an unexpected result which causes the test to f

RFC: detecting wine drivers in the audio tests

2008-04-29 Thread Robert Reif
The returned result of some audio functions on windows may be inconsistent because a driver may actually supply the returned value. This presents a problem for the wine regression tests because a buggy driver may return an unexpected result which causes the test to fail. One way around this i

Re: [PATCH] usp10: Use passed hdc instead of cached one for ScriptTextOut with test to check

2008-04-29 Thread Guy Albertelli
On Tue, 2008-04-29 at 11:12 +0200, Hans Leidekker wrote: > On Tuesday 29 April 2008 06:15:23 Guy Albertelli wrote: > > > Application does most of the Script... calls under one hdc then deletes it > > prior to calling the ScriptTextOut with the original hdc. > > Out of curiosity, which app is tha

Abusing valgrind to find reference leaks

2008-04-29 Thread Maarten Lankhorst
Hi all, I've managed to abuse valgrind to show backtraces of all places where an AddRef and Release is called when there is a memory, this is superior to wading through an endless pile of logs without even guarantee it will work. I thought I should share it for the following reasons: 1. Valgrind

Re: user32: Send WM_IME_SETCONTEXT message when the window is focusedor unfocused.

2008-04-29 Thread ByeongSik Jeon
Dmitry Timoshkov wrote: > "ByeongSik Jeon" <[EMAIL PROTECTED]> wrote: > > > --- a/dlls/user32/tests/msg.c > > +++ b/dlls/user32/tests/msg.c > > @@ -10156,7 +10156,7 @@ static const struct message wm_lb_click_0[] = > > { HCBT_SETFOCUS, hook }, > > { WM_KILLFOCUS, sent|parent }, > > {

Re: wined3d: Fix for buggy programs using ortho matrix with no z range

2008-04-29 Thread Stefan Dösinger
Am Dienstag, 29. April 2008 19:04:55 schrieb Jens Albretsen: > Changelog: > Fix for old games that sets a Ortho matrix with z range from 0-0 or in > other word with no range, which does'nt make any sense but they do it > anyway. I think a test case for this would be good.

Re: widl: callback, code, comm_status and in_line are attribute names, not keywords.

2008-04-29 Thread Robert Shearman
Robert Shearman wrote: > --- > tools/widl/parser.l |8 > 1 files changed, 4 insertions(+), 4 deletions(-) Just to note, this patch depends on the patch series that I sent yesterday and that I'm about to resend now. -- Rob Shearman

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-29 Thread Steven Edwards
On Tue, Apr 29, 2008 at 2:12 PM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > That's ugly, both the environment variable hack and the global verbose > flag are really bad. There has to be a better way to do this. I am open to suggestions =) -- Steven Edwards "There is one thing stronger th

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-29 Thread Alexandre Julliard
"Steven Edwards" <[EMAIL PROTECTED]> writes: > On Tue, Apr 29, 2008 at 1:28 PM, Peter Beutner <[EMAIL PROTECTED]> wrote: >> And the msg box will pop up. > > Your right. I see unless report_missing_dll_verbose is unset then its > going to spam on every dependent dll load failure for LoadLibrary. >

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-29 Thread Steven Edwards
On Tue, Apr 29, 2008 at 1:28 PM, Peter Beutner <[EMAIL PROTECTED]> wrote: > And the msg box will pop up. Your right. I see unless report_missing_dll_verbose is unset then its going to spam on every dependent dll load failure for LoadLibrary. Here is your and my patch combined. Julliard: Can you

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-29 Thread Peter Beutner
Steven Edwards schrieb: > On Tue, Apr 29, 2008 at 10:44 AM, Paul Chitescu <[EMAIL PROTECTED]> wrote: >> Windows doesn't do that - when my application tries to load a module that >> links against a missing DLL then LoadLibrary simply fails without showing >> any message. The "ignore it if LoadLib

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-29 Thread Steven Edwards
On Tue, Apr 29, 2008 at 11:52 AM, Peter Beutner <[EMAIL PROTECTED]> wrote: > So clearing the env variable would be the correct thing. But still not > entirely > satisfying as mentioned above by Dan. > > I just tried to solve it differently, doing it entirely in ntdll. > (and probably you could

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-29 Thread Steven Edwards
On Tue, Apr 29, 2008 at 10:44 AM, Paul Chitescu <[EMAIL PROTECTED]> wrote: > Windows doesn't do that - when my application tries to load a module that > links against a missing DLL then LoadLibrary simply fails without showing > any message. The "ignore it if LoadLibrary fails" logic is common i

Re: Bad recommended package lists

2008-04-29 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > Yes. At first glance I'd say audiofile, freeglut-devel, libtiff-devel, > prelink (or maybe at the RPM package level), audiofile-devel, > libicu-devel (not used anymore), imake. prelink is needed, it's used to set the load address of system dlls. --

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-29 Thread Peter Beutner
Paul Chitescu schrieb: On Tue, 29 Apr 2008, Peter Beutner wrote: Steven Edwards schrieb: On Mon, Apr 28, 2008 at 3:51 AM, Steven Edwards <[EMAIL PROTECTED]> wrote: On Sun, Apr 27, 2008 at 9:19 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > 2. You never clear that environment variable... what happ

Re: [resend] [Try 4] [1/2] cabinet.dll -> FDICopy: Test added

2008-04-29 Thread James Hawkins
2008/4/29 Vitaly Perov <[EMAIL PROTECTED]>: > [EMAIL PROTECTED] : cabinet: Revert "cabinet: Fix for FDICopy with an > empty cabinet file." > > Hi, > > > > The test was incorrect and failed on all platforms. Vitaly, please > > ask someone to test your patches on a real windows system in the

Re: Bad recommended package lists

2008-04-29 Thread Francois Gouget
On Tue, 29 Apr 2008, Marcus Meissner wrote: [...] > > Here's a list of the suspicious or downright bad package > > recommendations I spotted: > > Quite a number of them seems just be indirect dependencies, except perhaps > isdn4k-utils. But do we care about indirect dependencies? We shouldn't ha

Re: user32: Send WM_IME_SETCONTEXT message when the window is focusedor unfocused.

2008-04-29 Thread ByeongSik Jeon
Dmitry Timoshkov wrote: > "ByeongSik Jeon" <[EMAIL PROTECTED]> wrote: > > > --- a/dlls/user32/tests/msg.c > > +++ b/dlls/user32/tests/msg.c > > @@ -10156,7 +10156,7 @@ static const struct message wm_lb_click_0[] = > > { HCBT_SETFOCUS, hook }, > > { WM_KILLFOCUS, sent|parent }, > > {

Re: Alternative for isinf (fix for bug 12008) (version 4)

2008-04-29 Thread Stefan Dösinger
Am Dienstag, 29. April 2008 16:12:54 schrieb Petr Sumbera: > version 3 was missing include/config.h.in > + * isinf function > + * > + * Copyright 1996 Alexandre Julliard > + * Is that intentional?

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-29 Thread Paul Chitescu
On Tue, 29 Apr 2008, Peter Beutner wrote: > Steven Edwards schrieb: >> On Mon, Apr 28, 2008 at 3:51 AM, Steven Edwards <[EMAIL PROTECTED]> wrote: >>> On Sun, Apr 27, 2008 at 9:19 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: >>> > 2. You never clear that environment variable... what happens >>> > when

Re: user32: Post the WM_KEY{DOWN|UP} message when WM_IME_KEY{DOWN|UP}message is generated by IME.

2008-04-29 Thread Dmitry Timoshkov
"ByeongSik Jeon" <[EMAIL PROTECTED]> wrote: > The PeekMessage, GetMessage CAN CATCH this WM_KEYDOWN message. > I think this problem don't need the test code. > This problem is very simple case and clearly. This really needs the tests. First to show that this change is really correct, second to pr

Re: user32: Send WM_IME_SETCONTEXT message when the window is focusedor unfocused.

2008-04-29 Thread Dmitry Timoshkov
"ByeongSik Jeon" <[EMAIL PROTECTED]> wrote: > --- a/dlls/user32/tests/msg.c > +++ b/dlls/user32/tests/msg.c > @@ -10156,7 +10156,7 @@ static const struct message wm_lb_click_0[] = > { HCBT_SETFOCUS, hook }, > { WM_KILLFOCUS, sent|parent }, > { WM_IME_SETCONTEXT, sent|wparam|optional

Re: widl: Add a framework for automated testing of IDL files that should succeed or fail to be parsed.

2008-04-29 Thread Robert Shearman
Dan Hipschman wrote: > On Mon, Apr 28, 2008 at 08:37:26PM +0100, Robert Shearman wrote: > >> This should aid in testing more-obscure parts of the parser that aren't >> necessarily valid when using RPC (and hence don't make sense being put >> in dlls/rpcrt4/tests/server.idl). >> > > Obviou

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-29 Thread Peter Beutner
Steven Edwards schrieb: > On Mon, Apr 28, 2008 at 3:51 AM, Steven Edwards <[EMAIL PROTECTED]> wrote: >> On Sun, Apr 27, 2008 at 9:19 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> > 2. You never clear that environment variable... what happens >> > when an app just tests for the existence of a DLL

Re: [PATCH 1/4] widl: Keep const attributes applied to pointers when writing out the type.

2008-04-29 Thread Robert Shearman
Alexandre Julliard wrote: > --- include/d3d10.h.old 2008-04-29 13:38:38.0 +0200 > +++ include/d3d10.h 2008-04-29 13:39:08.0 +0200 > @@ -3455,12 +3455,12 @@ > virtual void STDMETHODCALLTYPE VSSetConstantBuffers( > UINT StartSlot, > UINT NumBuffers, > -

Re: 3/2 WineD3D: add D3DPRASTERCAPS_MULTISAMPLE_TOGGLE support

2008-04-29 Thread Stefan Dösinger
Am Dienstag, 29. April 2008 08:21:46 schrieb Chris Robinson: > Something that has me concerned with applying all applicable flags in > wined3d and filtering them out in d3d8/9 is, what happens if a newer d3d > version has a flag with the same value as a different flag in the old > version? As far a

Re: winmm/tests: waveOutGetDevCaps called with invalid size

2008-04-29 Thread Robert Reif
Robert Reif wrote: > Peter Åstrand wrote: > >> On Mon, 28 Apr 2008, Robert Reif wrote: >> >> >> However, the waveOutGetDevCapsW fails as well on WTS, also returning MMSYSERR_INVALPARAM. >> >> >>> Let me get this straight, your company's produc

Re: winmm/tests: waveOutGetDevCaps called with invalid size

2008-04-29 Thread Robert Reif
Peter Åstrand wrote: > On Mon, 28 Apr 2008, Robert Reif wrote: > > >>> However, the waveOutGetDevCapsW fails as well on WTS, also returning >>> MMSYSERR_INVALPARAM. >>> > > >> Let me get this straight, your company's product doesn't pass this wine >> regression test so you want to rem

Re: [PATCH 1/4] widl: Keep const attributes applied to pointers when writing out the type.

2008-04-29 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > Use an attribute to store the const qualifier for the pointer and type. > > Allow multiple type-qualifiers to be applied to a type by adding a > declaration-specifier rule that encompasses type-qualifiers and types. > --- > tools/widl/header.c|

Re: Bad recommended package lists

2008-04-29 Thread Marcus Meissner
On Mon, Apr 28, 2008 at 07:53:51PM +0200, Francois Gouget wrote: > > http://wiki.winehq.org/Recommended_Packages > > The Wiki's Recommended Packages list contains a lot of incorrect > recommendations. I have already cleaned up the Debian section, but there > seems to be a lot of copy/paste that

Re: [PATCH] usp10: Use passed hdc instead of cached one for ScriptTextOut with test to check

2008-04-29 Thread Hans Leidekker
On Tuesday 29 April 2008 06:15:23 Guy Albertelli wrote: > Application does most of the Script... calls under one hdc then deletes it > prior to calling the ScriptTextOut with the original hdc. Out of curiosity, which app is that? What are the symptoms? I tested your patch on some of the apps I k