Re: winmm/tests: waveOutGetDevCaps called with invalid size

2008-04-28 Thread Peter Åstrand
On Mon, 28 Apr 2008, Robert Reif wrote: > > However, the waveOutGetDevCapsW fails as well on WTS, also returning > > MMSYSERR_INVALPARAM. > Let me get this straight, your company's product doesn't pass this wine > regression test so you want to remove the test? No. Quoting from my intial post:

Re: 3/2 WineD3D: add D3DPRASTERCAPS_MULTISAMPLE_TOGGLE support

2008-04-28 Thread Chris Robinson
On Monday 28 April 2008 11:00:13 pm Roderick Colenbrander wrote: > > IMHO adding a caps filter to dx8 is less risky than adding multisampling > > support, so I don't see a reason not to do that and avoid the dxVersion > > check > > Personally I would prefer to the filtering the proper way. With thi

Re: 3/2 WineD3D: add D3DPRASTERCAPS_MULTISAMPLE_TOGGLE support

2008-04-28 Thread Roderick Colenbrander
> > Hi, > > > > Add a missing d3d9 capability. For now add it behind a dxVersion check. > We > > should get rid of those after Wine 1.0 but right now there is no > filtering > > code in d3d8, so don't risk any regressions now. > IMHO adding a caps filter to dx8 is less risky than adding multisampli

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-28 Thread Steven Edwards
On Mon, Apr 28, 2008 at 3:51 AM, Steven Edwards <[EMAIL PROTECTED]> wrote: > On Sun, Apr 27, 2008 at 9:19 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > 2. You never clear that environment variable... what happens > > when an app just tests for the existence of a DLL by > > trying to load it?

Re: 3/2 WineD3D: add D3DPRASTERCAPS_MULTISAMPLE_TOGGLE support

2008-04-28 Thread Stefan Dösinger
Am Montag, 28. April 2008 22:08:28 schrieb Roderick Colenbrander: > Hi, > > Add a missing d3d9 capability. For now add it behind a dxVersion check. We > should get rid of those after Wine 1.0 but right now there is no filtering > code in d3d8, so don't risk any regressions now. IMHO adding a caps f

Re: Mixed-mode assembly support in Mono

2008-04-28 Thread Kornél Pál
> From: Dan Kegel >> I have recently committed required changes to Mono SVN repository as >> r102052. >> Now Mono has mixed-mode assembly support on Windows. > > Wow, congratulations! When will a windows installer be available > for a version of mono with your changes included? It would make >

Re: widl: Add a framework for automated testing of IDL files that should succeed or fail to be parsed.

2008-04-28 Thread Dan Hipschman
On Mon, Apr 28, 2008 at 08:37:26PM +0100, Robert Shearman wrote: > > This should aid in testing more-obscure parts of the parser that aren't > necessarily valid when using RPC (and hence don't make sense being put > in dlls/rpcrt4/tests/server.idl). Obviously this is a good idea. I tried doing

Bad recommended package lists

2008-04-28 Thread Francois Gouget
http://wiki.winehq.org/Recommended_Packages The Wiki's Recommended Packages list contains a lot of incorrect recommendations. I have already cleaned up the Debian section, but there seems to be a lot of copy/paste that spread the bad information to the RPM distros. So we'd need volunteers for

re: Mixed-mode assembly support in Mono

2008-04-28 Thread Dan Kegel
Kornel wrote: > I have recently committed required changes to Mono SVN repository as r102052. > Now Mono has mixed-mode assembly support on Windows. Wow, congratulations! When will a windows installer be available for a version of mono with your changes included? It would make testing much easi

Mixed-mode assembly support in Mono

2008-04-28 Thread Kornél Pál
Hi, I have recently committed required changes to Mono SVN repository as r102052. Now Mono has mixed-mode assembly support on Windows. These is no full MSVCRT support because that heavily depends on the unmanaged API of .NET Framework but programs compiled using Microsoft Visual C++ and not

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-28 Thread Dmitry Timoshkov
"Dan Kegel" <[EMAIL PROTECTED]> wrote: >> That's actually easy to implement, but the problem is that there is >> no free space in the Graphics tab of winecfg to add a preview control. >> That needs some redesigning work, I'll see how that could be done. > > All would be well if "Screen Resolut

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-28 Thread Dan Kegel
Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > That's actually easy to implement, but the problem is that there is > no free space in the Graphics tab of winecfg to add a preview control. > That needs some redesigning work, I'll see how that could be done. All would be well if "Screen Resolution

Re: ws2_32: Use WSAWaitForMultipleEvents instead ofWaitForSingleObject

2008-04-28 Thread Dmitry Timoshkov
"Kai Blin" <[EMAIL PROTECTED]> wrote: > > > -HANDLE hEvent = INVALID_HANDLE_VALUE; > > > +WSAEVENT event_array[1]; > > > > Is that change only to avoid passing &hEvent to WSAWaitForMultipleEvents? > > Nope. WSAWaitForMultipleEvents expects an array of WSAEVENTs. So this seemed > like the

Re: ws2_32: Use WSAWaitForMultipleEvents instead of WaitForSingleObject

2008-04-28 Thread Kai Blin
On Monday 28 April 2008 13:39:38 Dmitry Timoshkov wrote: > "Kai Blin" <[EMAIL PROTECTED]> wrote: > > -HANDLE hEvent = INVALID_HANDLE_VALUE; > > +WSAEVENT event_array[1]; > > Is that change only to avoid passing &hEvent to WSAWaitForMultipleEvents? Nope. WSAWaitForMultipleEvents expects an

Re: [PATCH 2/7] widl: Keep const attributes applied to pointers when writing out the type.

2008-04-28 Thread Robert Shearman
Alexandre Julliard wrote: > Robert Shearman <[EMAIL PROTECTED]> writes: > > >> Use an attribute to store the const qualifier for the pointer and type. >> >> Allow multiple type-qualifiers to be applied to a type by adding a >> declaration-specifier rule that encompasses type-qualifiers and types

Re: [PATCH] advapi32: attempt to use UuidToStringA if UuidToStringW isnot available.

2008-04-28 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > "Lei Zhang" <[EMAIL PROTECTED]> wrote: > >> This adds more checks in CRYPT_CreateMachineGuid(), and attempt to use >> UuidToStringA if UuidToStringW is not available. > > Instead of duplicating and complicating the code, IMO it would be more > strai

Re: [PATCH 2/7] widl: Keep const attributes applied to pointers when writing out the type.

2008-04-28 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > Use an attribute to store the const qualifier for the pointer and type. > > Allow multiple type-qualifiers to be applied to a type by adding a > declaration-specifier rule that encompasses type-qualifiers and types. This seems to drop the const in som

Re: ws2_32: Use WSAWaitForMultipleEvents instead of WaitForSingleObject

2008-04-28 Thread Dmitry Timoshkov
"Kai Blin" <[EMAIL PROTECTED]> wrote: > -HANDLE hEvent = INVALID_HANDLE_VALUE; > +WSAEVENT event_array[1]; Is that change only to avoid passing &hEvent to WSAWaitForMultipleEvents? -- Dmitry.

Re: winmm/tests: waveOutGetDevCaps called with invalid size

2008-04-28 Thread Robert Reif
Peter Åstrand wrote: >>> And what is the error? If you know the error code returned, Ill add it >>> to the code so we can end this discussion. >>> >> The error is MMSYSERR_INVALPARAM. >> > > I can see that this patch has now been committed: > > --- wine/dlls/winmm/tests/wave.c:1.67

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-28 Thread Dmitry Timoshkov
"Dan Kegel" <[EMAIL PROTECTED]> wrote: >> How about doing what Windows does - add a font preview to allow the user >> to see an actual size of the font he/she will get after the change? > > Yeah, that would be great. We did something like that > in the Picasa for Linux font settings tool. Nig

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-28 Thread Steven Edwards
On Sun, Apr 27, 2008 at 9:19 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > 2. You never clear that environment variable... what happens > when an app just tests for the existence of a DLL by > trying to load it? We don't want to print an error then. > (That's why I originally suggested clearing t

Re: winmm/tests: waveOutGetDevCaps called with invalid size

2008-04-28 Thread Peter Åstrand
> > And what is the error? If you know the error code returned, Ill add it > > to the code so we can end this discussion. > > The error is MMSYSERR_INVALPARAM. I can see that this patch has now been committed: --- wine/dlls/winmm/tests/wave.c:1.67 Fri Feb 29 06:18:36 2008 +++ wine/dlls/winm