Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-26 Thread Steven Edwards
On Sat, Apr 26, 2008 at 1:53 PM, Steven Edwards <[EMAIL PROTECTED]> wrote: > > * have start.exe set an environment variable saying "show graphical error > box > > on dll load failure", and clear that before calling executed apps' > WinMain() > > (easy) > > So something like start.exe.so in

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread L. Rahyen
On Sunday April 27 2008 03:23:40 Dan Kegel wrote: > But as I wrote in http://bugs.winehq.org/show_bug.cgi?id=9715 > we can probably do something that will make everybody > happy: arrange for winecfg to never let the user set > dpi so high that winecfg is bigger than the screen. Yes, I thin

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread Dan Kegel
On Sat, Apr 26, 2008 at 7:54 PM, L. Rahyen <[EMAIL PROTECTED]> wrote: > 200 DPI limit is acceptable for most users. However, what this patch > done by > setting maximum to this small value (144) doesn't seems to be acceptable. Users really are lost if they set a too-high value. They don'

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread L. Rahyen
On Saturday April 26 2008 23:22:37 Dan Kegel wrote: > On Sat, Apr 26, 2008 at 10:40 AM, Lei Zhang <[EMAIL PROTECTED]> wrote: > > > > URL: > > > > http://source.winehq.org/git/wine.git/?a=commit;h=faaccca59be08be54 > > > >7ec4e1948b6306eff3808a2 > > > > > > > > Author: Dan Kegel <[EMA

Re: Side affects from running wineprefixcreate

2008-04-26 Thread Vitaliy Margolen
Chris Robinson wrote: > On Saturday 26 April 2008 05:48:35 pm Vitaliy Margolen wrote: >> At a minimum all the created >> registry entries should not overwrite already existing ones. > > Doesn't that kind of defeat the purpose of having wineprefixcreate executed, > which is to update the registry?

Re: Side affects from running wineprefixcreate

2008-04-26 Thread Chris Robinson
On Saturday 26 April 2008 05:48:35 pm Vitaliy Margolen wrote: > At a minimum all the created > registry entries should not overwrite already existing ones. Doesn't that kind of defeat the purpose of having wineprefixcreate executed, which is to update the registry? Not that I don't agree there c

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread Chris Robinson
On Saturday 26 April 2008 04:58:53 pm John Klehm wrote: > On Sat, Apr 26, 2008 at 6:22 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > I found a few monitors out there at 200 dpi, so perhaps that would > > be a reasonable upper limit, but we'd have to check to make sure that > > the average person

Side affects from running wineprefixcreate

2008-04-26 Thread Vitaliy Margolen
So for one notable problems is some file types being reset by Wine. Looks like it comes from dlls/mshtml/mshtml.inf. At a minimum all the created registry entries should not overwrite already existing ones. Vitaliy.

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread John Klehm
On Sat, Apr 26, 2008 at 6:22 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Sat, Apr 26, 2008 at 10:40 AM, Lei Zhang <[EMAIL PROTECTED]> wrote: > > > > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=faaccca59be08be547ec4e1948b6306eff3808a2 > > > > > > > > Author: Dan Kegel <

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread Dan Kegel
On Sat, Apr 26, 2008 at 10:40 AM, Lei Zhang <[EMAIL PROTECTED]> wrote: > > > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=faaccca59be08be547ec4e1948b6306eff3808a2 > > > > > > Author: Dan Kegel <[EMAIL PROTECTED]> > > > Date: Tue Apr 22 17:56:36 2008 -0700 > > > > >

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread Christoph Frick
On Sat, Apr 26, 2008 at 12:54:14PM -0600, Vitaliy Margolen wrote: > For anyone who wants more then 150 they can change that in the registry. > Honestly I've yet to see a single device with such a high DPI! for the fun of it - i run wine at 144 it is one less than i need: 0:32 !1 [EMAIL PROTECTE

Re: [dinput] initial support for BSD's usbhid joysticks

2008-04-26 Thread Christoph Frick
On Sat, Apr 26, 2008 at 08:57:28AM -0600, Vitaliy Margolen wrote: > Please use 4 spaces indentation, no tabs. what happened to original author decides? ;) i will run the uncopied parts through indent once i find the -unreadable flag for it... > > + snprintf(buf, MAX_PATH, FMT_UHIDDEVS,

Re: [dinput] move the common joystick_map_.* methods from joystick_linuxinput.c into device.c

2008-04-26 Thread Christoph Frick
On Sat, Apr 26, 2008 at 08:39:19AM -0600, Vitaliy Margolen wrote: > Christoph Frick wrote: > > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c > > index 5f927d0..baca0b3 100644 > > --- a/dlls/dinput/device.c > > +++ b/dlls/dinput/device.c > > @@ -1400,3 +1400,54 @@ HRESULT WINAPI > > IDi

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread Benjamin M. Schwartz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Vitaliy Margolen wrote: | For anyone who wants more then 150 they can change that in the registry. | Honestly I've yet to see a single device with such a high DPI! I have ported Wine to run on the OLPC XO, which has a 200 DPI screen. I am currently r

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread Austin English
On Sat, Apr 26, 2008 at 1:54 PM, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: > Austin English wrote: > > On 4/26/08, *Lei Zhang* <[EMAIL PROTECTED] > > > > wrote: > > > > On Sat, Apr 26, 2008 at 10:37 AM, Lei Zhang <[EMAIL PROTECTED] > > >

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread Vitaliy Margolen
Austin English wrote: > On 4/26/08, *Lei Zhang* <[EMAIL PROTECTED] > > wrote: > > On Sat, Apr 26, 2008 at 10:37 AM, Lei Zhang <[EMAIL PROTECTED] > > wrote: > > > > On Wed, Apr 23, 2008 at 5:59 AM, Alexandre Julliard > <[EMA

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread Austin English
On 4/26/08, Lei Zhang <[EMAIL PROTECTED]> wrote: > > On Sat, Apr 26, 2008 at 10:37 AM, Lei Zhang <[EMAIL PROTECTED]> wrote: > > > > On Wed, Apr 23, 2008 at 5:59 AM, Alexandre Julliard <[EMAIL PROTECTED]> > wrote: > > > Module: wine > > > Branch: master > > > Commit: faaccca59be08be547ec4e1948b

Re: [PATCH 6/7] widl: Accept integer constant suffixes in the lexer.

2008-04-26 Thread Dan Hipschman
On Sat, Apr 26, 2008 at 09:51:58AM +0100, Robert Shearman wrote: > +u_suffix (l|L) > +l_suffix (u|U) I'm guessing you meant for these to be the other way around.

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-26 Thread Steven Edwards
On Fri, Apr 25, 2008 at 2:07 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > * have start.exe examine the import table of the exe and do an explicit check > (hard) Seems like too much to go in to start anyway. And I am lazy > * have start.exe set an environment variable saying "show graphical error

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread Lei Zhang
On Sat, Apr 26, 2008 at 10:37 AM, Lei Zhang <[EMAIL PROTECTED]> wrote: > > On Wed, Apr 23, 2008 at 5:59 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > Module: wine > > Branch: master > > Commit: faaccca59be08be547ec4e1948b6306eff3808a2 > > URL: > http://source.winehq.org/git/wine.

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.

2008-04-26 Thread Lei Zhang
On Wed, Apr 23, 2008 at 5:59 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > Module: wine > Branch: master > Commit: faaccca59be08be547ec4e1948b6306eff3808a2 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=faaccca59be08be547ec4e1948b6306eff3808a2 > > Author: Dan Kegel <[EMAIL

Re: [dinput] initial support for BSD's usbhid joysticks

2008-04-26 Thread Juan Lang
> No (in case buffer at least 1 byte long). Oh, right you are! Thanks, I did confuse that the strncpy. --Juan

Re: [dinput] initial support for BSD's usbhid joysticks

2008-04-26 Thread Vitaliy Margolen
Juan Lang wrote: >> snprintf always writes terminating '\0' character at the end of the string. > > Only if the buffer contains enough space for the terminating null. > No (in case buffer at least 1 byte long). From man page: The functions snprintf() and vsnprintf() write at most size bytes (in

Re: [dinput] initial support for BSD's usbhid joysticks

2008-04-26 Thread Juan Lang
> snprintf always writes terminating '\0' character at the end of the string. Only if the buffer contains enough space for the terminating null. > You don't need to explicitly do that yourself. That's probably true in this case. --Juan

Re: [dinput] initial support for BSD's usbhid joysticks

2008-04-26 Thread Vitaliy Margolen
Christoph Frick wrote: > From 7618ceb6941c0dffac9c48c1fa1aeb7e821673a2 Mon Sep 17 00:00:00 2001 > From: Christoph Frick <[EMAIL PROTECTED]> > Date: Sat, 26 Apr 2008 02:50:01 +0200 > Subject: [PATCH] Initial support for BSD's usbhid joysticks > > Please consider this a tracer bullet. I had only tim

Re: [dinput] move the common joystick_map_.* methods from joystick_linuxinput.c into device.c

2008-04-26 Thread Vitaliy Margolen
Christoph Frick wrote: > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c > index 5f927d0..baca0b3 100644 > --- a/dlls/dinput/device.c > +++ b/dlls/dinput/device.c > @@ -1400,3 +1400,54 @@ HRESULT WINAPI > IDirectInputDevice8WImpl_GetImageInfo(LPDIRECTINPUTDEVICE8W iface > Please don

Re: [Try 3] [1/2] cabinet.dll -> FDICopy: Test added

2008-04-26 Thread Vitaly Perov
Hi, > Hi, > > The test was incorrect and failed on all platforms. Vitaly, please > ask someone to test your patches on a real windows system in the > future if you don't have access to one. I have never received this message. I found it by chance in the comment of Reece Dunn. Does the probl

Re: [GSoC][RFC] Case Insensitive Filesystem

2008-04-26 Thread Marc Andre Tanner
Hi, Just wanted to let you know that i have finally found the time to set up a little page for ciopfs: http://www.brain-dump.org/projects/ciopfs/ There are certainly a few things which could be improved but it in my tests it worked quite well in it's current form. As it seems that the idea o

Re: ddraw: Remove a test that fails in VMs

2008-04-26 Thread Reece Dunn
2008/4/26 James Hawkins <[EMAIL PROTECTED]>: > > On Sat, Apr 26, 2008 at 1:11 AM, Reece Dunn <[EMAIL PROTECTED]> wrote: > > Wouldn't it be better to move the ok line to directly after the > > IDirect3D7_CreateDevice call? That way, on VM machines the test will > > not get run and on non-VM ma

Re: cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet file."

2008-04-26 Thread Reece Dunn
2008/4/26 James Hawkins <[EMAIL PROTECTED]>: > > On Sat, Apr 26, 2008 at 1:03 AM, Reece Dunn <[EMAIL PROTECTED]> wrote: > > 2008/4/26 James Hawkins <[EMAIL PROTECTED]>: > > > > > Hi, > > > > > > The test was incorrect and failed on all platforms. Vitaly, please > > > ask someone to test

Re: ddraw: Remove a test that fails in VMs

2008-04-26 Thread Reece Dunn
2008/4/26 James Hawkins <[EMAIL PROTECTED]>: > Hi, > > The tests aren't run anyway in this case. > > Changelog: > * Remove a test that fails in VMs. ... > hr = IDirect3D7_CreateDevice(Direct3D, &IID_IDirect3DRefDevice, > Surface, &Direct3DDevice); > } > } > -ok(hr

Re: cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet file."

2008-04-26 Thread Reece Dunn
2008/4/26 James Hawkins <[EMAIL PROTECTED]>: > Hi, > > The test was incorrect and failed on all platforms. Vitaly, please > ask someone to test your patches on a real windows system in the > future if you don't have access to one. Wouldn't it be better to actually fix the test case than revert