Re: ddraw: Remove a test that fails in VMs

2008-04-25 Thread James Hawkins
On Sat, Apr 26, 2008 at 1:11 AM, Reece Dunn <[EMAIL PROTECTED]> wrote: > 2008/4/26 James Hawkins <[EMAIL PROTECTED]>: > > > Hi, > > > > The tests aren't run anyway in this case. > > > > Changelog: > > * Remove a test that fails in VMs. > ... > > hr = IDirect3D7_CreateDevice(D

Re: cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet file."

2008-04-25 Thread James Hawkins
On Sat, Apr 26, 2008 at 1:03 AM, Reece Dunn <[EMAIL PROTECTED]> wrote: > 2008/4/26 James Hawkins <[EMAIL PROTECTED]>: > > > Hi, > > > > The test was incorrect and failed on all platforms. Vitaly, please > > ask someone to test your patches on a real windows system in the > > future if you d

Re: [PATCH] advapi32: attempt to use UuidToStringA if UuidToStringW isnot available.

2008-04-25 Thread Dmitry Timoshkov
"Lei Zhang" <[EMAIL PROTECTED]> wrote: > This adds more checks in CRYPT_CreateMachineGuid(), and attempt to use > UuidToStringA if UuidToStringW is not available. Instead of duplicating and complicating the code, IMO it would be more straightforward to use ansi APIs without trying unicode first.

download.template: Update Mandriva download info (try 2)

2008-04-25 Thread Austin English
Any reason this patch wasn't applied? http://www.winehq.org/pipermail/wine-patches/2008-April/053911.html

Re: Kusanagi Kouichi : winex11: Destroy the handle to the composition string after it is cancelled.

2008-04-25 Thread Kusanagi Kouichi
On Fri, Apr 25, 2008 at 02:44:00PM -0500, Aric Stewart wrote: > No, from updateCompStr > > if (old == NULL && compstr == NULL && len == 0) > return NULL; > > Otherwise it returns a compstr. So it only should return NULL if all the > incoming parameters are NULL, which i do not beli

Wine 1.0 release plan update

2008-04-25 Thread Dan Kegel
Alexandre's taking a vacation in May, and the schedule is bending slightly to fit. We're also not promising a particular release date, though the previously predicted date is still as likely as it was before. http://wiki.winehq.org/WineReleasePlan now says: --- snip --- * 0.9.61 - 2 May 2008

Re: SOC 2008 Projects Announced

2008-04-25 Thread Adam Petaccia
> Could the students come forward and say something about themself? Hello Wine world, my name is Adam Petaccia, and this summer I will be working on Wine's GDI+ implementation, so more applications can work "out of the box". I am currently a student at the University of North Carolina, Greensboro

Re: Kusanagi Kouichi : winex11: Destroy the handle to the composition string after it is cancelled.

2008-04-25 Thread Aric Stewart
No, from updateCompStr if (old == NULL && compstr == NULL && len == 0) return NULL; Otherwise it returns a compstr. So it only should return NULL if all the incoming parameters are NULL, which i do not believe should ever happen after i went through and made sure that the hCompStr

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-25 Thread Dan Kegel
On Fri, Apr 25, 2008 at 8:50 AM, Steven Edwards <[EMAIL PROTECTED]> wrote: > does not even work, let alone because if it finds the EXE there is no > error as far as CreateProcess cares. On the other had, The child > process returns an exit code such as STATUS_ENTRYPOINT_NOT_FOUND but I > don't

Re: d3d8: Fix a few test failures in win2k3

2008-04-25 Thread Stefan Dösinger
Am Freitag, 25. April 2008 03:36:04 schrieb James Hawkins: > Hi, > > Changelog: > * Fix a few test failures in win2k3. > > dlls/d3d8/tests/device.c |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions(-) Looks ok to me Somewhen we may want to move all this multiple times copypasted d

Re: ddraw: Fix tests that fail with the reference rasterizer

2008-04-25 Thread James Hawkins
On Fri, Apr 25, 2008 at 12:36 PM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Am Freitag, 25. April 2008 05:38:40 schrieb James Hawkins: > > > Hi, > > > > Changelog: > > * Fix tests that fail with the reference rasterizer. > > >if (SUCCEEDED(IDirectDrawSurface7_AddAttachedSurface(surface1,

Re: ddraw: Fix tests that fail with the reference rasterizer

2008-04-25 Thread Stefan Dösinger
Am Freitag, 25. April 2008 05:38:40 schrieb James Hawkins: > Hi, > > Changelog: > * Fix tests that fail with the reference rasterizer. >if (SUCCEEDED(IDirectDrawSurface7_AddAttachedSurface(surface1, surface4))) >refrast = TRUE; Do you take care of detaching the surface again? Did you

Re: Safedisc for 1.0+ ?

2008-04-25 Thread TheBlunderbuss
Darragh Bailey wrote: > There has been some movement in the past to split up the Safedisc bug > and deal with the individual versions separately. Would it be useful to > advance this? I'm certain that I have a number of games that listed as > apps affected by this bug that no longer have a problem.

Re: ddraw: ComputeSphereVisibility

2008-04-25 Thread Stefan Dösinger
Am Freitag, 25. April 2008 04:20:11 schrieb David Adam: > Hello, > > I am trying to debug the demo of The Sting. Now, the main is that the > screen is almost black. It is surely related to the following FIXME: > fixme:d3d7:IDirect3DDeviceImpl_7_ComputeSphereVisibility > > Unfortunately, I did not f

Re: Kusanagi Kouichi : winex11: Destroy the handle to the composition string after it is cancelled.

2008-04-25 Thread Kusanagi Kouichi
On Fri, Apr 25, 2008 at 09:36:36AM -0500, Aric Stewart wrote: > Comming in a bit late on this one, (missed the patch submission) > > I do not think this is correct as far as i know hCompStr should never be > NULL. Much of our code depends on that not being NULL. > > I would recommend using ImeCr

Re: [PATCH] user32: edit controls should ignore WM_KEYDOWN on control + enter.

2008-04-25 Thread Lei Zhang
On Fri, Apr 25, 2008 at 6:07 AM, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: > > Lei Zhang wrote: > > On Thu, Apr 24, 2008 at 10:22 PM, Lei Zhang <[EMAIL PROTECTED]> wrote: > >> Hi, > >> > >> This should be the last bit in getting control + enter working in > >> multiline edit controls. I at

Re: [2/2] [try2] user32:mdi.c Fix creating MDI child window according with test. [resend]

2008-04-25 Thread Anatoly Lyutin
Alexandre Julliard wrote: > It doesn't work: > > msg.c:3065: Test failed: Create visible MDI child window: the msg sequence is > not complete: expected - actual 0046 > msg.c:3120: Test failed: ShowWindow(SW_MAXIMIZE):invisible MDI child: the msg > 0x0047 was expected, but got msg 0x0046 inst

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-25 Thread Steven Edwards
On Thu, Apr 24, 2008 at 11:12 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > It depends which cases you are trying to catch, but for the case of > users starting an app from their desktop, you could probably do it in > start.exe. As per our discussion on IRC, start uses CreateProcess which

Re: John Klehm : winex11: Add support for IsXExtensionPointer tablet devices.

2008-04-25 Thread Michael Stefaniuc
This patch break compilation on my RHEL5 box with xorg-x11-proto-devel-7.1-9.fc6 which misses the IsXExtensionPointer define. bye michael Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 2c26ea609d6b2b8a25be20984c0014ceb202466a > URL: > http://source.winehq.org/git

Re: Kusanagi Kouichi : winex11: Destroy the handle to the composition string after it is cancelled.

2008-04-25 Thread Aric Stewart
Comming in a bit late on this one, (missed the patch submission) I do not think this is correct as far as i know hCompStr should never be NULL. Much of our code depends on that not being NULL. I would recommend using ImeCreateBlankCompStr instead. (something like below) diff --git a/dlls/winex

Re: ntoskrnl.exe: Change calling conventions [try 2]

2008-04-25 Thread Alexander Morozov
> Why didn't you fix InterlockedExchangeAdd too? Yes, this function also should be fixed. I will send new patch. Sorry. I got confused because this function worked: #include "wdm.h" #pragma code_seg("INIT") NTSTATUS DriverEntry(IN PDRIVER_OBJECT DriverObject, IN PUNICODE_STRING Registry

Re: Safedisc for 1.0+ ?

2008-04-25 Thread Darragh Bailey
On Thu, Apr 24, 2008 at 09:57:39PM -0600, Vitaliy Margolen wrote: > TheBlunderbuss wrote: > > It has just occurred to me that safedisc copy protection (bug 219!) > > wasn't put on the Wine 1.0 task list. It's a pretty major bug and covers > > a wide range of programs, with a wide range of saf

Re: [PATCH] user32: edit controls should ignore WM_KEYDOWN on control + enter.

2008-04-25 Thread Vitaliy Margolen
Lei Zhang wrote: > On Thu, Apr 24, 2008 at 10:22 PM, Lei Zhang <[EMAIL PROTECTED]> wrote: >> Hi, >> >> This should be the last bit in getting control + enter working in >> multiline edit controls. I attempted to write a test for this using >> SendInput() or SetKeyState() + SendMessage(), but I c

Re: ntoskrnl.exe: Change calling conventions [try 2]

2008-04-25 Thread Alexandre Julliard
Alexander Morozov <[EMAIL PROTECTED]> writes: > Changelog: > ntoskrnl.exe: Change calling conventions for InterlockedExchange, > InterlockedCompareExchange, InterlockedDecrement and InterlockedIncrement > > --- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec > +++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec > @@

Re: [Resend 2/5] imm32: Add the header for private imm32 function.

2008-04-25 Thread Alexandre Julliard
ByeongSik Jeon <[EMAIL PROTECTED]> writes: > Unknown function in the SDK/DDK's header. > --- > include/wine/imm_private.h | 35 +++ You don't want to add a new header for that, especially not a global one. The function is exported on Windows too, so it's OK to de

ddraw: ComputeSphereVisibility

2008-04-25 Thread David Adam
Hello, I am trying to debug the demo of The Sting. Now, the main is that the screen is almost black. It is surely related to the following FIXME: fixme:d3d7:IDirect3DDeviceImpl_7_ComputeSphereVisibility Unfortunately, I did not find any informations about this function. Does anyone know what this

Re: user32 : Temporarily disable test for _WIN64.

2008-04-25 Thread Reece Dunn
2008/4/25 Erik de Castro Lopo <[EMAIL PROTECTED]>: > Dmitry Timoshkov wrote: > > > I'll let you figure this out on your own, that's a helpful thing to learn. > > Try looking up GetWindowLongPtr in MSDN. That should be enough of a hint to help you to get the edit.c tests building properly wi

Re: user32 : Temporarily disable test for _WIN64.

2008-04-25 Thread Erik de Castro Lopo
Francois Gouget wrote: > That's ok to do in your local Git repository. > > However you have to understand that we cannot very well commit patch > that disables a test which is very useful in garanteeing there won't be > regressions in the very much used and about to go stable 32bit version > f

Re: user32 : Temporarily disable test for _WIN64.

2008-04-25 Thread Francois Gouget
On Fri, 25 Apr 2008, Erik de Castro Lopo wrote: [...] > > user32 is not required for a simple "Hello World" app, isn't it? > > I didn't disable test for user32, I disabled a single test. That > test was testing edit controls and I am 100% sure that edit controls > are not needed for a simple hello