Re: kernel32: Skip the screen buffer tests if codepage 866 is notavailable

2008-04-19 Thread James Hawkins
On Sun, Apr 20, 2008 at 1:10 AM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "James Hawkins" <[EMAIL PROTECTED]> wrote: > > > > +res = RegOpenKeyA(HKEY_LOCAL_MACHINE, > > + > "System\\CurrentControlSet\\Control\\Nls\\CodePage", &hkey); > > +if (res == ERROR_SUCCESS) > > +{ > > +

Re: kernel32: Skip the screen buffer tests if codepage 866 is notavailable

2008-04-19 Thread Dmitry Timoshkov
"James Hawkins" <[EMAIL PROTECTED]> wrote: > +res = RegOpenKeyA(HKEY_LOCAL_MACHINE, > + "System\\CurrentControlSet\\Control\\Nls\\CodePage", > &hkey); > +if (res == ERROR_SUCCESS) > +{ > +len = 20; > +res = RegQueryValueExA(HKEY_LOCAL_MACHINE, "866

Re: WINED3D: Fix a possible null dereference (try 2)

2008-04-19 Thread Stefan Dösinger
Am Samstag, 19. April 2008 19:06:07 schrieb H. Verbeet: > Try not to change the encoding of the file. > I'm not sure if we ever considered simply using UTF-8 for source > files, but it would probably prevent some issues like this. I could change my name :-) There was some consideration of UTF 8, b

Wine countdown?

2008-04-19 Thread Dan Kegel
Anybody seen the nifty countdown logo that Ubuntu is using? http://www.ubuntu.com/getubuntu/countdown Maybe we should do something similar for Wine. FWIW, here's a snippet that does something similar, but with text: Wine Release Countdown function days_between(date1, date2) { // The number o

Re: [PATCH] user32: Handle VK_RETURN KeyDown events more properly in EDIT controls.

2008-04-19 Thread Lei Zhang
On Fri, Apr 18, 2008 at 3:50 PM, El. <[EMAIL PROTECTED]> wrote: > When a ES_MULTILINE-styled EDIT responds to a VK_RETURN Key press, it should > send a WM_COMMAND to the default control of the parent window if and only if > that parent is a Dialog box. At least Microsoft's version of notepad.exe >

Re: [PATCH] user32: Handle VK_RETURN KeyDown events more properly in EDITcontrols.

2008-04-19 Thread Lei Zhang
On Sat, Apr 19, 2008 at 4:05 AM, Reece Dunn <[EMAIL PROTECTED]> wrote: > Reading the MSDN documentation for the behaviour of ES_MULTILINE, it > says "When the multiline edit control is in a dialog box, the default > response to pressing the ENTER key is to activate the default button. > To use

Re: WINED3D: Fix a possible null dereference (try 2)

2008-04-19 Thread H. Verbeet
On 19/04/2008, David Adam <[EMAIL PROTECTED]> wrote: > This time, with tests for d3d8 and d3d9. > > David Adam > Looks mostly ok, but you do need a \n at the end of these ok messages: > +ok(hr == D3DERR_INVALIDCALL, "Expected D3DERR_INVALIDCALL, got %s", > DXGetErrorString8(hr)); > +ok(h

Re: [PATCH] user32: Handle VK_RETURN KeyDown events more properly in EDITcontrols.

2008-04-19 Thread Reece Dunn
On 19/04/2008, El. <[EMAIL PROTECTED]> wrote: > > > > You need to add a test case first to confirm that the fix is correct, and > > use EDIT_IsInsideDialog to detect if the parent is dialog. > > Well I'm not sure what to test in the first place, I didn't assume that > modifying some aspect of the c

Re: [PATCH] user32: Handle VK_RETURN KeyDown events more properly in EDITcontrols.

2008-04-19 Thread Reece Dunn
On 19/04/2008, El. <[EMAIL PROTECTED]> wrote: > > "El." <[EMAIL PROTECTED]> wrote: > > > > > @@ -4606,6 +4606,10 @@ static LRESULT EDIT_WM_KeyDown(EDITSTATE *es, INT > > > key) > > > { > > >HWND hwndParent = GetParent(es->hwndSelf); > > >DWORD dw = SendMessageW( hwndParent, DM_GETDEFI

[lostwages] update LGPL url, specify version

2008-04-19 Thread Dan Kegel
Somebody on wine-users asked us to clarify this, so: diff --git a/templates/en/home_about.template b/templates/en/home_about.template index aed434a..8af3209 100644 --- a/templates/en/home_about.template +++ b/templates/en/home_about.template @@ -26,5 +26,5 @@ at the User Guide. Wine is free so

Re: [PATCH 2/2] wined3d: Prevent console spamming in drawPrimitive.

2008-04-19 Thread Stefan Dösinger
Am Samstag, 19. April 2008 07:19:17 schrieb H. Verbeet: > Oh, I'm not opposed to the patch itself, preventing the log from > getting spammed is a good thing. Just saying performance is the wrong > reason. Agreed

Re: WINED3D: Fix a possible null dereference.

2008-04-19 Thread H. Verbeet
On 19/04/2008, David Adam <[EMAIL PROTECTED]> wrote: > The Sting Demo calls the function > IDirect3DDeviceImpl_7_SetMaterial (in ddraw/device.c) with > Mat=NULL. > Then, this makes the function IWineD3DDeviceImpl_SetMaterial (in > wined3d/device.c) crashes in the line > This->updateStateBlock->mate

Re: [PATCH] user32: Handle VK_RETURN KeyDown events more properly in EDITcontrols.

2008-04-19 Thread El .
> "El." <[EMAIL PROTECTED]> wrote: > > > @@ -4606,6 +4606,10 @@ static LRESULT EDIT_WM_KeyDown(EDITSTATE *es, INT > > key) > > { > >HWND hwndParent = GetParent(es->hwndSelf); > >DWORD dw = SendMessageW( hwndParent, DM_GETDEFID, 0, 0 ); > > + > > + if (GetClassLongW(hwndParent, GCW_AT

Re: Trying to get a grip on how to handle bug reports.

2008-04-19 Thread Jan Zerebecki
On Sun, Apr 13, 2008 at 02:28:15PM -0500, James Hawkins wrote: > On behalf of the regular bugzilla moderators (of which there are very > few), I'll go over the policy we have in place to keep, or strive to > attain, a manageable bugzilla database. There are only a few > conditions that warrant aba

d3dx9: Texturing functions

2008-04-19 Thread tony . wasserka
Hi all, as it's a larger chunk of functions, I felt like proposing my design idea for the D3DXCreateTexture/Volume/CubeTextureFromFile/Resource/FileInMemory/etc... functions. I'm CC'ing it to any wine d3dx coder I have in my addressbook yet, so sorry if I forgot one :) So, the first thing I want