Re: [PATCH 14/15] wined3d: Add device->isInDraw checks in LoadLocation.

2008-04-06 Thread Alexander Dorofeyev
Oh, you are right. Must be fixed some other way then, I guess, maybe moving assignment to isInDraw lower or moving ActivateContext higher. From what I understood from Bioshock bug (http://bugs.winehq.org/show_bug.cgi?id=9973), moving ActivateContext in drawPrimitive produces bugs in other progra

Re: ntoskrnl.exe: [2/2] Implement KeQueryInterruptTime

2008-04-06 Thread Dmitry Timoshkov
"Detlef Riekenberg" <[EMAIL PROTECTED]> wrote: > +ULONGLONG WINAPI KeQueryInterruptTime( void ) > +{ > +ULONGLONG totaltime; > + > +KeQueryTickCount( (LARGE_INTEGER *) &totaltime); > +return totaltime; > +} Why not have a local variable of type LARGE_INTEGER and return li.QuadPart ?

Re: ntoskrnl.exe: [1/2] Implement KeQueryActiveProcessors

2008-04-06 Thread Dmitry Timoshkov
"Detlef Riekenberg" <[EMAIL PROTECTED]> wrote: > +KAFFINITY WINAPI KeQueryActiveProcessors( void ) > +{ > +DWORD_PTR AffinityMask; > + > +if (GetProcessAffinityMask( GetCurrentProcess(), &AffinityMask, NULL)) { > +return AffinityMask; > +} > + > +/* No Idea, what to do, w

Re: LoadStringW [1/2]

2008-04-06 Thread Dmitry Timoshkov
"Saulius Krasuckas" <[EMAIL PROTECTED]> wrote: >> If the regression can be identified by someone able to read the code and >> not by a regression test that doesn't matter. > > Could you show me appropriate code lines of LoadStringA and a logic to > follow, please? I am schocked. > > Dmitry, f

Re: appdb needs to list 0.9.47 in the pulldown, please

2008-04-06 Thread Austin English
On Sun, Apr 6, 2008 at 4:55 PM, Chris Morgan <[EMAIL PROTECTED]> wrote: > On Sun, Apr 6, 2008 at 5:05 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > On Sun, Apr 6, 2008 at 1:49 PM, Chris Morgan <[EMAIL PROTECTED]> wrote: > > > > It seems reasonable to me to include the version bundled with gutsy

Re: [PATCH 14/15] wined3d: Add device->isInDraw checks in LoadLocation.

2008-04-06 Thread Allan Tong
On Sun, Apr 6, 2008 at 5:06 PM, Alexander Dorofeyev <[EMAIL PROTECTED]> wrote: > > Prevents calling ActivateContext while holding gl lock, e.g. when > preloading texture in sampler(). There may be a problem here with drawPrimitive, which calls LoadLocation before ActivateContext while having isIn

Re: [PATCH 03/15] wined3d: In palette9_changed skip check if dxVersion <= 7.

2008-04-06 Thread Alexander Dorofeyev
Stefan Dösinger wrote: > Am Sonntag, 6. April 2008 23:05:52 schrieb Alexander Dorofeyev: >> Stops it from producing misleading messages in apps that don't use d3d8/9 >> style palettes. > Is there no other way to do this? In my opinion dxVersion checks are ugly and > dxVersion should go away Not t

Re: ntdll:Add a semi-stub for SystemExecutionState in NtPowerInformation

2008-04-06 Thread Jérôme Gardou
Le Saturday 05 April 2008 23:08:59, vous avez écrit : > This adds a semi-stub for SystemExecutionState in NtPowerInformation, > always considering that the user is acting with the computer. Please ignore this one, I sent the wrong file.

Re: appdb needs to list 0.9.47 in the pulldown, please

2008-04-06 Thread Chris Morgan
On Sun, Apr 6, 2008 at 5:05 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Sun, Apr 6, 2008 at 1:49 PM, Chris Morgan <[EMAIL PROTECTED]> wrote: > > > It seems reasonable to me to include the version bundled with gutsy, > > > even if it's getting old, because gutsy is so popular. > > > > If

Re: [PATCH 03/15] wined3d: In palette9_changed skip check if dxVersion <= 7.

2008-04-06 Thread Stefan Dösinger
Am Sonntag, 6. April 2008 23:05:52 schrieb Alexander Dorofeyev: > Stops it from producing misleading messages in apps that don't use d3d8/9 > style palettes. Is there no other way to do this? In my opinion dxVersion checks are ugly and dxVersion should go away

Re: appdb needs to list 0.9.47 in the pulldown, please

2008-04-06 Thread Dan Kegel
On Sun, Apr 6, 2008 at 1:49 PM, Chris Morgan <[EMAIL PROTECTED]> wrote: > > It seems reasonable to me to include the version bundled with gutsy, > > even if it's getting old, because gutsy is so popular. > > If we wait another 18 days can we ask users of gutsy to upgrade to hardy? ;-) Of cour

Re: appdb needs to list 0.9.47 in the pulldown, please

2008-04-06 Thread Chris Morgan
On Sun, Apr 6, 2008 at 3:02 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Sun, Apr 6, 2008 at 11:56 AM, Chris Morgan <[EMAIL PROTECTED]> wrote: > > The appdb code currently prunes the list to several of the most recent > > versions so people don't submit entries against older or obsolete > > v

Re: d3dx9: Implementation of D3DXGetShaderSize 2/3

2008-04-06 Thread H. Verbeet
On 06/04/2008, Luis Busquets <[EMAIL PROTECTED]> wrote: > The +1 of the end is because finally address points to the end token. So +1 > is the end token. This function has been tested with all shaders of > Civilization 4 and has responded successfully. > My bad, I misread that as (address-(pFunctio

d3dx9: Implementation of D3DXGetShaderSize 2/3

2008-04-06 Thread Luis Busquets
The +1 of the end is because finally address points to the end token. So +1 is the end token. This function has been tested with all shaders of Civilization 4 and has responded successfully. The attached patch has included the suggestions. H. Verbeet escribió: On 06/04/2008, Luis Busquets <[

Re: appdb needs to list 0.9.47 in the pulldown, please

2008-04-06 Thread Vitaliy Margolen
Dan Kegel wrote: > On Sun, Apr 6, 2008 at 11:56 AM, Chris Morgan <[EMAIL PROTECTED]> wrote: >> The appdb code currently prunes the list to several of the most recent >> versions so people don't submit entries against older or obsolete >> versions. > > Of course. It's just a question of the righ

Re: appdb needs to list 0.9.47 in the pulldown, please

2008-04-06 Thread Dan Kegel
On Sun, Apr 6, 2008 at 11:56 AM, Chris Morgan <[EMAIL PROTECTED]> wrote: > The appdb code currently prunes the list to several of the most recent > versions so people don't submit entries against older or obsolete > versions. Of course. It's just a question of the right cutoff. It seems reasona

Re: appdb needs to list 0.9.47 in the pulldown, please

2008-04-06 Thread Chris Morgan
The appdb code currently prunes the list to several of the most recent versions so people don't submit entries against older or obsolete versions. Is it really useful to have test results submitted such an old version when we almost always ask users to upgrade to the latest version in the #winehq

appdb needs to list 0.9.47 in the pulldown, please

2008-04-06 Thread Dan Kegel
Can somebody change the appdb to allow submitting results against 0.9.47? I think that's what Gutsy's bundled version of wine is. Somebody just submitted bogus results (with the wrong wine version) because we lack that option.

Re: d3dx8: Implementation of D3DXGetFVFVertexSize

2008-04-06 Thread Luis Busquets
Sorry, actually, the title of d3dx9 was d3dx8. Both patches patch the same file. H. Verbeet escribió: > On 06/04/2008, Luis Busquets <[EMAIL PROTECTED]> wrote: > >> Implementation of D3DXGetFVFVertexSize. It does so by calculating all the >> different publicly available posible vertex configura

Free apps bundled with msvcr70?

2008-04-06 Thread Dan Kegel
(This may sound like a repeat question, but last time I was asking about msvcr71, and thanks to the answers, that's now in winetricks.) Anybody have a good download link for an app that comes bundled with msvcr70 and msvcp70, i.e. one that was compiled with visual studio 2002?

Re: Pulse Audio -- Wine should have instructions on this web site

2008-04-06 Thread Jan Zerebecki
On Sun, Apr 06, 2008 at 12:49:53PM -0500, John Klehm wrote: > On Sun, Apr 6, 2008 at 12:04 PM, Jan Zerebecki <[EMAIL PROTECTED]> wrote: > > It results in the behaviour that the user would expect. E.g. that one > > game you start retains the same settings everytime it creates a primary > > buffer

Re: [2/6] d3d9: Remove some test trace lines

2008-04-06 Thread Stefan Dösinger
Am Sonntag, 6. April 2008 18:29:06 schrieb Allan Tong: > On Sat, Apr 5, 2008 at 5:18 PM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > I think they're not needed any more now that the test works > > For what it's worth, this test fails for me with fbos. Ya, quite sure since part of the behavior

Re: Pulse Audio -- Wine should have instructions on this web site

2008-04-06 Thread John Klehm
On Sun, Apr 6, 2008 at 12:04 PM, Jan Zerebecki <[EMAIL PROTECTED]> wrote: > It results in the behaviour that the user would expect. E.g. that one > game you start retains the same settings everytime it creates a primary > buffer (thus that it retains the settings on the next start) and the > vo

Re: Pulse Audio -- Wine should have instructions on this web site

2008-04-06 Thread Jan Zerebecki
On Sun, Apr 06, 2008 at 05:41:05PM +0200, Stefan Dösinger wrote: > Am Sonntag, 6. April 2008 12:27:51 schrieb Jan Zerebecki: > > Yes, more precicely it's about how the alsa->pulse plugin tries to > > identify different applications. It gets the real process name (the > > loader), not the one wine c

Re: 0005-d3d9-add-stream_test-with-instancing

2008-04-06 Thread Stefan Dösinger
Am Sonntag, 6. April 2008 17:11:10 schrieb Rico Schüller: > Hi, > > this is a patch, which contains a test for instancing. It proves the > behavior from these two patches: Alexandre: Note that this test needs my D3DCREATE_SOFTWARE_VERTEXPROCESSING->D3DCREATE_HARDWARE_VERTEXPROCESSING to work on W

Re: [2/6] d3d9: Remove some test trace lines

2008-04-06 Thread Allan Tong
On Sat, Apr 5, 2008 at 5:18 PM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > I think they're not needed any more now that the test works For what it's worth, this test fails for me with fbos. - Allan

Re: 0004-wined3d-improve-drawStridedInstanced

2008-04-06 Thread Stefan Dösinger
Am Sonntag, 6. April 2008 17:07:45 schrieb Rico Schüller: > Hi, > > this patch solves a rendering problem with instances. Affected games are > Crysis and Gothic3. The test for this is in > 0005-d3d9-add-stream_test-with-instancing. So apply this first, > otherwise the tests will fail on wine. I thi

Re: 0003-wined3d-Filter-invalid-stuff-in-SetStreamSourceFreq

2008-04-06 Thread Stefan Dösinger
Am Sonntag, 6. April 2008 17:03:41 schrieb Rico Schüller: > Hi, > > this patch filters out invalid parameter in SetStreamSourceFreq(). The > test for that is 0005-d3d9-add-stream_test-with-instancing. So apply > this first, otherwise the tests will fail on wine. You should write some message that t

Re: Pulse Audio -- Wine should have instructions on this web site

2008-04-06 Thread Stefan Dösinger
Am Sonntag, 6. April 2008 12:27:51 schrieb Jan Zerebecki: > Yes, more precicely it's about how the alsa->pulse plugin tries to > identify different applications. It gets the real process name (the > loader), not the one wine changed to. The plugin could use that, but it > would also be nice if the

Re: LoadStringW [1/2]

2008-04-06 Thread Saulius Krasuckas
* On Fri, 4 Apr 2008, Dmitry Timoshkov wrote: > > If the regression can be identified by someone able to read the code and > not by a regression test that doesn't matter. Could you show me appropriate code lines of LoadStringA and a logic to follow, please? I am schocked. Dmitry, for me your

Re: d3dx8: Implementation of D3DXGetFVFVertexSize

2008-04-06 Thread H. Verbeet
On 06/04/2008, Luis Busquets <[EMAIL PROTECTED]> wrote: > Implementation of D3DXGetFVFVertexSize. It does so by calculating all the > different publicly available posible vertex configuration types. > Same comments as for the d3dx9 version apply. (Why isn't the d3dx9 version a forward to d3dx8?)

Re: d3dx9: Implementation of D3DXGetFVFVertexSize

2008-04-06 Thread H. Verbeet
On 06/04/2008, Luis Busquets <[EMAIL PROTECTED]> wrote: > Implementation of D3DXGetFVFVertexSize. It does so by calculating all the > different publicly available posible vertex configuration types. > >+ switch (FVF & D3DFVF_XYZB5) { You should probably use D3DFVF_POSITION_MASK instead here. >+

Re: d3dx9: Implementation of D3DXGetShaderSize

2008-04-06 Thread H. Verbeet
On 06/04/2008, Luis Busquets <[EMAIL PROTECTED]> wrote: > This function obtains the size of a shader bytestream. It does so looking > for the End token. > >+UINT D3DXGetShaderSize(DWORD * pFunction) I would expect this to take a const pointer. Also, there's no reason to use Microsoft's (broken) na

Re: Time zone info

2008-04-06 Thread Jan Zerebecki
On Sat, Apr 05, 2008 at 02:39:07PM +0100, Ben Hodgetts wrote: > Erik de Castro Lopo wrote: > > Dmitry Timoshkov wrote: > >> Please do not use "Reply-To:" header when posting wine-devel. > > I'm sorry, but why not? Isn't that the bext way to indicate > > that I would prefer to have replies sent to

Re: re pulse issues

2008-04-06 Thread Jan Zerebecki
On Wed, Apr 02, 2008 at 11:02:54AM -0400, Susan Cragin wrote: > ALSA lib pcm.c:2106:(snd_pcm_open_conf) Cannot open shared library > /usr/lib/alsa-lib/libasound_module_pcm_pulse.so > ALSA lib pcm.c:2106:(snd_pcm_open_conf) Cannot open shared library > /usr/lib/alsa-lib/libasound_module_pcm_pulse.

Re: Pulse Audio -- Wine should have instructions on this web site

2008-04-06 Thread Jan Zerebecki
On Thu, Apr 03, 2008 at 01:46:18AM +0200, Stefan Dösinger wrote: > Am Mittwoch, 2. April 2008 17:08:06 schrieb Bryan Haskins: > > I'm more interested in a direct pulseaudio gateway for Wine... since by > > application sound control is the biggest thing here for most people > > wine is treated a

Re: Pulse Audio -- Wine should have instructions on this web site

2008-04-06 Thread Jan Zerebecki
On Thu, Apr 03, 2008 at 12:49:55PM -0400, Susan Cragin wrote: > Back to the initial question: > > Given what we have existing, right now, is there any set of instructions or > workarounds that makes WINE apps work best? > even > killall pulseaudio ?? Yes, stopping PA and using alsa directly prob

Re: Pulse Audio -- Wine should have instructions on this web site

2008-04-06 Thread Jan Zerebecki
On Wed, Apr 02, 2008 at 05:23:50PM -0400, Bryan Haskins wrote: > Sorry for the double post. But further on that point, at the sound system > neutral level, naming eahc app individually as a sound item would rock. In > such a way that each app perhaps talks to ALSA directly, which results in > self

Re: d3d9-Make-the-shader-test-more-precision-tolerant

2008-04-06 Thread Stefan Dösinger
Am Sonntag, 6. April 2008 10:46:55 schrieb Rico Schüller: > Hi, > > this patch makes the cnd_test on windows happy. > > Cheers > Rico The patches look ok to me

Re: [PATCH 1 of 2] start.exe: add /Unix switch for starting files from unix file managers

2008-04-06 Thread Hans Leidekker
On Sunday 06 April 2008 05:46:49 Vincent Povirk wrote: > -IMPORTS = shell32 user32 kernel32 > +IMPORTS = shell32 user32 kernel32 shlwapi If it's just StrCpyNW you need from shlwapi you might as well use an alternative like memcpy and avoid importing this dll. > + char multibyte