Re: user32: Add test_CreateIconFromResourceEx().

2008-03-16 Thread Dmitry Timoshkov
"Andrew Riedi" <[EMAIL PROTECTED]> wrote: > changelog: user32: Add test_CreateIconFromResourceEx(). What this patch is supposed to test? Just that CreateIconFromResourceEx returns a valid icon handle? What about the resulting icon contents? What about cases when CreateIconFromResourceEx should fa

explorer: add /startfile switch for starting files from file managers

2008-03-16 Thread Vincent Povirk
This patch adds a switch, /startfile, to explorer.exe, used as "wine explorer /startfile filename". It accepts a windows or unix path. It attempts to mimic what windows explorer does to start files and provide some visible (gui) feedback when it doesn't work. The idea is that wine.desktop can then

Re: [4/22] WineD3D: A shader backend descriptor for the ati fragment shader backend

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 17:35:25 schrieb Ivan Gyurdiev: > To me this suggests that there should be two separate shader backends, > selected differently for "fixed pipeline replacement" purposes and for > shaders. I don't like the argument that this is only an intermediate > step - if no one writ

Re: Wine Security Disclosure

2008-03-16 Thread James McKenzie
Lei Zhang wrote: > On Sun, Mar 16, 2008 at 7:01 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > >> 2) we can at least document how to use clamav with wine, >> or link to clamav and its doc, e.g. >> http://www.clamav.net/ >> https://help.ubuntu.com/community/ClamAV >> >> 3) we can warn on star

Re: Wine Security Disclosure

2008-03-16 Thread James McKenzie
Dmitry Timoshkov wrote: > "Dan Kegel" <[EMAIL PROTECTED]> wrote: > > >>> What's so special about Wine that doesn't apply to say VMWare, >>> Parallels, Win4Lin, DOSBox, and others? >>> >> With vmware, parallels, and win4lin, you can actually >> run commercial virus scanners inside those

Re: [4/22] WineD3D: A shader backend descriptor for the ati fragment shader backend

2008-03-16 Thread Ivan Gyurdiev
Stefan Dösinger wrote: > Am Sonntag, 16. März 2008 15:00:49 schrieb Ivan Gyurdiev: > >> I don't quite understand why it's necessary to write ARB, GLSL, and NONE >> shader descriptors inside the ati_shader file. >> How will this infrastructure scale to a new shader backend added a year >> from no

Re: [Tools 7/7] winetest: Add some heuristics to detect missing dlls in version 3 reports.

2008-03-16 Thread Francois Gouget
On Sun, 16 Mar 2008, Paul Vriens wrote: > Hi, > > I saw that 'gather' is not creating the index.html file at test.winehq.org > anymore. > > I had a quick look at test.winehq.org and something seem to have go wrong with > the patching of 'gather': > > [EMAIL PROTECTED]:/home/winehq/opt/winetest$

Re: Locked topics considered harmful

2008-03-16 Thread James McKenzie
Dan Kegel wrote: > wine-users is not a forum, it's a mailing list. > Topics should not be locked except in extreme circumstances; > the bounce messages are annoying, and > it's wrong for the forum to not properly show > what's going on in the mailing list. > > > +1 If a topic is also posted to t

Redirect http://forums.winehq.org -> http://forum.winehq.org.

2008-03-16 Thread Andrew Riedi
Because many other sites have forums spelled in the plural, such as http://ubuntuforums.org and http://forums.gentoo.org, many users simply assume we will too. I would like to request a redirect from http://fourms.winehq.org to http://forum.winehq.org. Note, even one of own developers made this m

Re: Improving the Wine Users Guide

2008-03-16 Thread Juan Lang
> * Section 3.1.2.1 - are there dlls besides kernel32, gdi32, user32, > and ntdll that we should never use the native one? Add warning about > downloading dlls from the web. This list may end up being rather large. Certainly not iphlpapi. Right now, not netapi32 or crypt32, either, though whet

Re: [4/22] WineD3D: A shader backend descriptor for the ati fragment shader backend

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 15:00:49 schrieb Ivan Gyurdiev: > I don't quite understand why it's necessary to write ARB, GLSL, and NONE > shader descriptors inside the ati_shader file. > How will this infrastructure scale to a new shader backend added a year > from now ? Currently I am doing that so A

Locked topics considered harmful

2008-03-16 Thread Dan Kegel
wine-users is not a forum, it's a mailing list. Topics should not be locked except in extreme circumstances; the bounce messages are annoying, and it's wrong for the forum to not properly show what's going on in the mailing list.

Re: [4/22] WineD3D: A shader backend descriptor for the ati fragment shader backend

2008-03-16 Thread Ivan Gyurdiev
I don't quite understand why it's necessary to write ARB, GLSL, and NONE shader descriptors inside the ati_shader file. How will this infrastructure scale to a new shader backend added a year from now ? For such a large patchset maybe there should be a high level design diagram that explains ho

Re: wine's very own control panel applets?

2008-03-16 Thread Juan Lang
Hi, While I think writing control panel applets for Wine may be a good idea in general, I wonder whether the specific example you propose--a locale setting control panel--might be better served by trying to infer the correct settings from the Linux locale. --Juan

Re: Improving the Wine Users Guide

2008-03-16 Thread Jeff Zaroyko
Lei Zhang google.com> writes: > > Hi, > > For our 1.0 release, we should have a polished users guide to help > people to learn to use Wine properly. I did a quick read of the Wine > Users Guide [1] and here are my comments: > > * Remove references to tools/wineinstall - does anyone use this an

Re: appdb request: "Browse Regressions"

2008-03-16 Thread Alexander Nicolaysen Sørnes
> Roderick Colenbrander <[EMAIL PROTECTED]> wrote: > > A lot of users don't know how to rate apps properly and > > even rate something as gold when half of its features > > don't work. They even rate it gold when they have to copy > > half a windows registry and tons of windows dlls. > > Agreed. W

Re: Improving the Wine Users Guide

2008-03-16 Thread Vitaliy Margolen
Stefan Dösinger wrote: > Am Sonntag, 16. März 2008 20:13:13 schrieb Jérôme Gardou: >> Le Sunday 16 March 2008 19:17:38 Lei Zhang, vous avez écrit : >>> * Section 3.1.2.1 - are there dlls besides kernel32, gdi32, user32, >>> and ntdll that we should never use the native one? Add warning about >>> do

Re: Wine Security Disclosure

2008-03-16 Thread TheBlunderbuss
"Dan Kegel" <[EMAIL PROTECTED]> wrote: It's not enough to provide Wine and throw up our hands saying "It's up to users to protect their systems" because our users are at worst quite literally clueless, and at best too busy to want to bother with virus issues. If we can guide them or ease the

Re: Improving the Wine Users Guide

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 20:13:13 schrieb Jérôme Gardou: > Le Sunday 16 March 2008 19:17:38 Lei Zhang, vous avez écrit : > > * Section 3.1.2.1 - are there dlls besides kernel32, gdi32, user32, > > and ntdll that we should never use the native one? Add warning about > > downloading dlls from the we

Re: Improving the Wine Users Guide

2008-03-16 Thread Jérôme Gardou
Le Sunday 16 March 2008 19:17:38 Lei Zhang, vous avez écrit : > * Section 3.1.2.1 - are there dlls besides kernel32, gdi32, user32, > and ntdll that we should never use the native one? Add warning about > downloading dlls from the web. Isn't ddraw a part of this ones ?

Re: wined3d: Increment reference count before returning palette

2008-03-16 Thread Cihan Altinay
Stefan Dösinger wrote: > You'll have to check the code that uses this method. As far as I can see > DDrawSurface::GetPalette doesn't release the palette it got from WineD3D, so > just changing WineD3D will cause a leak Yes, that's what Alexander Dorofeyev pointed out, too. So do not apply this p

Re: d3dx9_36: Implements D3DXGetShaderVersion

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 15:32:51 schrieb Ivan Gyurdiev: > I would suggest an automated test across [ vs: 1.0, 1.1, 2.0, 2.1, 3.0 ] > , [ ps: 1.0, 1.1, 1.2, 1.3, 1.4, 2.0, 2.1, 3.0 ] , NULL, and an invalid > token. > You can see some binary shaders in the d3d9 tests. You can't really iterate over

Re: wine --show-config option?

2008-03-16 Thread Jan Zerebecki
On Sun, Mar 16, 2008 at 10:45:43AM -0700, Lei Zhang wrote: > Would it be helpful for the wine executable to have a --show-config > option? It can show information such as: > > * what options are not compiled in > * the version of gcc, fontforge used > * whether gecko is installed > * what dlls are

Re: d3dx9_36: Implements D3DXGetShaderVersion

2008-03-16 Thread Ivan Gyurdiev
Luis C. Busquets Pérez wrote: > This functions gets the Version Token of a binary shader. This Token > is the first of the binary stream so it is as easy as picling the > pointed DWORD. This is all public information available to the public. What happens when the shader is NULL? Yours will crash

Re: Wine Security Disclosure

2008-03-16 Thread Lei Zhang
On Sun, Mar 16, 2008 at 7:01 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > 2) we can at least document how to use clamav with wine, > or link to clamav and its doc, e.g. > http://www.clamav.net/ > https://help.ubuntu.com/community/ClamAV > > 3) we can warn on startup if we detect that clamav >

Improving the Wine Users Guide

2008-03-16 Thread Lei Zhang
Hi, For our 1.0 release, we should have a polished users guide to help people to learn to use Wine properly. I did a quick read of the Wine Users Guide [1] and here are my comments: * Near the top - mention virus / security issues, warn against running Wine as root. * Remove references to tools/w

Re: Eric Pouech : riched20: Start handling OLE objects inside richedit.

2008-03-16 Thread Lei Zhang
On Fri, Mar 14, 2008 at 3:38 PM, EmpKey Administrator <[EMAIL PROTECTED]> wrote: > > > > > Hi, > > > > I am using CRichEditView class in MFC library to display RTF. The problem is > that ole objects are not displayed in-line with their surround texts. Could > you please let me know how to solve the

wine --show-config option?

2008-03-16 Thread Lei Zhang
Hi, Would it be helpful for the wine executable to have a --show-config option? It can show information such as: * what options are not compiled in * the version of gcc, fontforge used * whether gecko is installed * what dlls are set to native - Lei

Re: [RESEND] ddraw: Fix refcounting of palettes

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 17:43:52 schrieb Cihan Altinay: > Changed as suggested by Stefan Dösinger. Looks good to me

Re: wined3d: Increment reference count before returning palette

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 17:49:38 schrieb Cihan Altinay: > Cheers, > Cihan You'll have to check the code that uses this method. As far as I can see DDrawSurface::GetPalette doesn't release the palette it got from WineD3D, so just changing WineD3D will cause a leak

Re: ddraw: Fix refcounting of palettes

2008-03-16 Thread Alexander Dorofeyev
Stefan Dösinger wrote: > Am Sonntag, 16. März 2008 14:44:37 schrieb [EMAIL PROTECTED]: >> This fixes a crash in a game called "Autobahnverfolgungsjagd Total" >> (not in AppDB). > I think it would be better to set pal = NULL if there is no wined3d palette > returned a few lines above the place you'

[RESEND] ddraw: Fix refcounting of palettes

2008-03-16 Thread Cihan Altinay
Changed as suggested by Stefan Dösinger. This fixes a crash in a game called "Autobahnverfolgungsjagd Total" (not in AppDB). Cheers, Cihan >From 323eae1df7905ea7d0e187a2eebee8e7eba8 Mon Sep 17 00:00:00 2001 From: Cihan A <[EMAIL PROTECTED]> Date: Sun, 16 Mar 2008 17:40:29 +0100 Subject: ddr

wine's very own control panel applets?

2008-03-16 Thread pure_evil
Hey folks I was thinking of writing some substitutes/stubs for the windows .CPL files. I migrated to using linux as a desktop fairly recently /used it for servers for a while, though/. Adapting to the linux equivalents of the programs I use, using wine for the rest etc. Whilst "reinventing" the

Re: ddraw: Fix refcounting of palettes

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 17:22:52 schrieb Cihan Altinay: > Stefan Dösinger wrote: > > Am Sonntag, 16. März 2008 14:44:37 schrieb [EMAIL PROTECTED]: > > I think it would be better to set pal = NULL if there is no wined3d > > palette returned a few lines above the place you're changing. > > That's f

Re: ddraw: Fix refcounting of palettes

2008-03-16 Thread Cihan Altinay
Stefan Dösinger wrote: > Am Sonntag, 16. März 2008 14:44:37 schrieb [EMAIL PROTECTED]: > I think it would be better to set pal = NULL if there is no wined3d palette > returned a few lines above the place you're changing. That's fine with me but it would mean setting it to NULL in every iteration

Re: Wine Security Disclosure

2008-03-16 Thread Dan Kegel
[EMAIL PROTECTED] wrote: > Is it really necessary to require running a virus scanner from > inside of Wine? No. Hey, cool, we agree on something! > > and everybody knows that one should do that if one > > cares about viruses. > > Same sentence applies to Wine I'd assume. No, because everyb

Re: appdb request: "Browse Regressions"

2008-03-16 Thread Dan Kegel
Roderick Colenbrander <[EMAIL PROTECTED]> wrote: > A lot of users don't know how to rate apps properly and > even rate something as gold when half of its features > don't work. They even rate it gold when they have to copy > half a windows registry and tons of windows dlls. Agreed. We need to sol

Re: Wine Security Disclosure

2008-03-16 Thread Dmitry Timoshkov
"Dan Kegel" <[EMAIL PROTECTED]> wrote: >> What's so special about Wine that doesn't apply to say VMWare, >> Parallels, Win4Lin, DOSBox, and others? > > With vmware, parallels, and win4lin, you can actually > run commercial virus scanners inside those environments, Is it really necessary to req

Re: appdb request: "Browse Regressions"

2008-03-16 Thread Roderick Colenbrander
> The nice reports in recent wwn's showing changes in > appdb ratings make me want to use the appdb itself > to see which apps have recently fallen in rating. > > Following past appdb practice, one would implement > that by adding a new "Browse Regressions" menu > item on the left, below Browse Ap

Re: ddraw: Fix refcounting of palettes

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 14:44:37 schrieb [EMAIL PROTECTED]: > This fixes a crash in a game called "Autobahnverfolgungsjagd Total" > (not in AppDB). I think it would be better to set pal = NULL if there is no wined3d palette returned a few lines above the place you're changing. > While tracing t

Re: New function "SHParseDisplayName"

2008-03-16 Thread Dmitry Timoshkov
"Paul" <[EMAIL PROTECTED]> wrote: > This is my first code contribution to Wine, I have _no_ idea if this > patch is 100% correct Then it's always a good idea to write some tests. > but it /should/ work =) It can't work since you haven't added an entry to the spec file. -- Dmitry.

Re: Wine Security Disclosure

2008-03-16 Thread Dan Kegel
[EMAIL PROTECTED] wrote: > What's so special about Wine that doesn't apply to say VMWare, > Parallels, Win4Lin, DOSBox, and others? With vmware, parallels, and win4lin, you can actually run commercial virus scanners inside those environments, and everybody knows that one should do that if one ca

Re: DSound Issues

2008-03-16 Thread Lei Zhang
On Sun, Mar 16, 2008 at 2:49 AM, Artur Szymiec <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Greeetings, > > I would like to trackdown an issue with Direct Sound > on TM United (BUG http://bugs.winehq.org/show_bug.cgi?id=12058). > > How can I provide some use

Re: Wine Security Disclosure

2008-03-16 Thread Dmitry Timoshkov
"Dan Kegel" <[EMAIL PROTECTED]> wrote: > It's not enough to provide Wine and throw up our hands > saying "It's up to users to protect their systems" > because our users are at worst quite literally clueless, > and at best too busy to want to bother with virus issues. > If we can guide them or ease

Re: d3dx9_36: Implements D3DXGetShaderVersion

2008-03-16 Thread Stefan Dösinger
Am Samstag, 15. März 2008 01:01:33 schrieb Luis C. Busquets Pérez: > To implement a test would be far more complicated as it would mean to > include a binary shader. Anyway, I have tested the results with Civ4 (by > making a derivation on d3dx9_32 with this function and using the > original d3dx9_3

Re: Wine code freeze in seven weeks; volunteers needed to fix 1.0 bugs

2008-03-16 Thread Kai Blin
On Sunday 16 March 2008 00:15:06 Dan Kegel wrote: > Per http://wiki.winehq.org/WineReleasePlan, > in early May, Wine's trunk will go into code freeze, > and only small, obvious bugfixes will be accepted. Could we please come up with a good plan on how to handle Summer of Code contributions _befor

Re: Wine code freeze in seven weeks; volunteers needed to fix 1.0 bugs

2008-03-16 Thread James Hawkins
On Mar 16, 2008, at 7:13 AM, James McKenzie <[EMAIL PROTECTED]> wrote: > Lei Zhang wrote: >> On Sat, Mar 15, 2008 at 6:06 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> >>> <[EMAIL PROTECTED]> wrote: 6254 had a proposed fix from Tony Rollo, and was worked on both Lai Zhang and myself.

Re: Wine code freeze in seven weeks; volunteers needed to fix 1.0 bugs

2008-03-16 Thread Phil Krylov
Hi, > > That patch is old and crusty and doesn't apply anymore. James should > > have an updated version. One thing I can add from looking at that patch is that the comments about the deficiency of MS richedit tables handling are true only for versions <=2.0. Later versions, including msftedit,

appdb request: "Browse Regressions"

2008-03-16 Thread Dan Kegel
The nice reports in recent wwn's showing changes in appdb ratings make me want to use the appdb itself to see which apps have recently fallen in rating. Following past appdb practice, one would implement that by adding a new "Browse Regressions" menu item on the left, below Browse Apps, Browse New

Re: Wine code freeze in seven weeks; volunteers needed to fix 1.0 bugs

2008-03-16 Thread James McKenzie
Lei Zhang wrote: > On Sat, Mar 15, 2008 at 6:06 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > >> <[EMAIL PROTECTED]> wrote: >> > 6254 had a proposed fix from Tony Rollo, and was worked on both Lai >> > Zhang and myself. Can I send the proposed patch to the dev list for >> > review? The patc

Re: Wine SOC - any d3d related projects

2008-03-16 Thread Stefan Dösinger
Am Freitag, 14. März 2008 20:04:38 schrieb Artur Szymiec: > Hi, > > are there any d3d related projects for SOC 2008 ? > Who is the Mentor ? How can I join ? For any D3D(not d3dx) gsoc project Henri, Roderick or I would be the mentor. If you want to do a project this list is a good place to announc

Re: Wine Security Disclosure

2008-03-16 Thread Dan Kegel
dmitry wrote: >> if we are so compatible that we can run virii and spyware, >> then we need to document it ... otherwise there will be many people >> disappointed by unrealistic expectations. > > Again, I don't see how Wine developers could help with that, > we are developers, not a health care dep

ddraw: Fix refcounting of palettes

2008-03-16 Thread bobbyg
This fixes a crash in a game called "Autobahnverfolgungsjagd Total" (not in AppDB). While tracing this bug I noticed that IWineD3DBaseSurfaceImpl_GetPalette() does not call AddRef when returning the palette. Is that intentional? Cheers, Cihan >From ede1c99159606486f7455e5ac3d81049dc135737 Mon Se

DSound Issues

2008-03-16 Thread Artur Szymiec
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Greeetings, I would like to trackdown an issue with Direct Sound on TM United (BUG http://bugs.winehq.org/show_bug.cgi?id=12058). How can I provide some usefull data for DSound maintainers ? Best regards Artur - -- - ---

Re: [Tools 7/7] winetest: Add some heuristics to detect missing dlls in version 3 reports.

2008-03-16 Thread Paul Vriens
Hi, I saw that 'gather' is not creating the index.html file at test.winehq.org anymore. I had a quick look at test.winehq.org and something seem to have go wrong with the patching of 'gather': [EMAIL PROTECTED]:/home/winehq/opt/winetest$ perl gather Use of bare << to mean <<"" is deprecated at

RE: Wine Security Disclosure

2008-03-16 Thread Rolf Kalbermatter
Dmitry Timoshkov [mailto:[EMAIL PROTECTED] wrote: > > This level of security info is something everyone should have easy > > access to and know before starting Wine. Of course, wherever I'm not > > accurate, feel free to fill in! > > There is nothing special about Wine that doesn't apply to >

Re: Wine Security Disclosure

2008-03-16 Thread Dmitry Timoshkov
"Steven Edwards" <[EMAIL PROTECTED]> wrote: > On Sun, Mar 16, 2008 at 3:52 AM, Dmitry Timoshkov > <[EMAIL PROTECTED]> wrote: >> Again, I don't see how Wine developers could help with that, we are >> developers, >> not a health care department. > > And this is why there is a disconnect from dev

Re: Wine Security Disclosure

2008-03-16 Thread Steven Edwards
On Sun, Mar 16, 2008 at 3:52 AM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > Again, I don't see how Wine developers could help with that, we are > developers, > not a health care department. And this is why there is a disconnect from developers to users. If you don't document what are and are

Re: Wine Security Disclosure

2008-03-16 Thread Dmitry Timoshkov
"Steven Edwards" <[EMAIL PROTECTED]> wrote: >> There is nothing special about Wine that doesn't apply to common >> unix/linux/windows security practices. > > No but people come to Linux hearing that its more secure than Windows > for various reasons. I hardly see that it's a Wine problem. > W

Re: Wine Security Disclosure

2008-03-16 Thread Steven Edwards
On Sun, Mar 16, 2008 at 1:29 AM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > There is nothing special about Wine that doesn't apply to common > unix/linux/windows security practices. No but people come to Linux hearing that its more secure than Windows for various reasons. While this may or ma