Re: user32: Fix enumeration and add tests for EnumWindowStations andEnumDesktops, try X

2008-03-06 Thread Dmitry Timoshkov
"Maarten Lankhorst" <[EMAIL PROTECTED]> wrote: > Fixed, and with tests! Why not use A versions of APIs to simplify the tests? Also, though that's a matter of taste, ok(hdesk != 0) is more readable IMO than ok(!!hdesk). -- Dmitry.

Re: user32: Add a better stub for broadcastsystemmessage, try 2

2008-03-06 Thread Steven Edwards
On Thu, Mar 6, 2008 at 6:47 PM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Fixes: BroadcastSystemMessage to not hang other processes any more. +static BOOL CALLBACK broadcastsystemmessagetopwindowcallback(HWND top_window, LPARAM lp) +static BOOL CALLBACK broadcastsystemmessagewindowstationcall

Re: WGL/WINED3D: add WGL_WINE_pixel_format_passthrough

2008-03-06 Thread Chris Robinson
On Thursday 06 March 2008 02:36:41 pm Roderick Colenbrander wrote: > WGL only allows you to set the pixel format once for a HDC. This requires a > WINE-specific WGL extension which allows us to set the pixel format again. > The patch does this and it works correctly in DirectX8/9 SDK samples. I'm

Re: Google Summer of Code - Case Insensitive Filenames

2008-03-06 Thread Cesar Izurieta
Thanks for your help. I'll prepare something and post it here for suggestions soon. On Thu, Mar 6, 2008 at 12:27 PM, Marcel Partap <[EMAIL PROTECTED]> wrote: > > Is there any formal process I must go through to enter google summer > > of code for wine? > Just filing Google's application will do,

Forgot a release_obj in my broadcastsystemmessage patch.

2008-03-06 Thread Maarten Lankhorst
Hi, Please don't apply the broadcastsystemmessage patch, there is a bug in enum_top_windows that I accidentally copied from enum_desktop. I'll send a fix for the enum_desktop call and a fixed version of the patch. Cheers, Maarten.

Re: Recent valgrind regressions in msxml3

2008-03-06 Thread Alistair Leslie-Hughes
"Dan Kegel" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Hi Alistair, > I'm seeing some regressions in msxml3 in yesterday's git; see > http://kegel.com/wine/valgrind/logs-2008-03-05/vg-msxml3_domdoc-diff.txt > e.g. > + Invalid read of size 4 > +at HEAP_ValidateInUseArena (h

Re: WineHQ should discourage the use of cracks

2008-03-06 Thread Jan Zerebecki
On Tue, Mar 04, 2008 at 04:23:46PM +0100, Christoph Frick wrote: > On Tue, Mar 04, 2008 at 03:35:11PM +0100, Kai Blin wrote: > > > No argument on the US part. I'm still convinced that by EU laws, > > you're allowed to crack an app you bought in order to make it run on > > your software. As this h

Re: Google Summer of Code - Case Insensitive Filenames

2008-03-06 Thread Marcel Partap
> Is there any formal process I must go through to enter google summer > of code for wine? Just filing Google's application will do, although you may want to crash in #winehackers .. What you should do IN TIME is to get intimate with the toolchain! That was the hardest part for me - getting star

Re: slight winsock design change proposal

2008-03-06 Thread Andrey Turkin
Actually the correct way IMHO is to implement AcceptEx/GetAcceptExSockaddrs/TransmitFile in ws2_32.dll, and use WSAIoctl(SIO_GET_EXTENSION_FUNCTION_POINTER) to get function addresses in mswsock.dll. I believe this is that Windows' mswsock.dll do. Christopher Harvey wrote: Dmitry Timoshkov wro

Google Summer of Code - Case Insensitive Filenames

2008-03-06 Thread Cesar Izurieta
Hello everyone, I would like to participate in this year's google summer of code doing some work on case insensitive filenames ( http://wiki.winehq.org/CaseInsensitiveFilenames ) I have some experience working with FUSE ( see http://code.google.com/p/dejumble/ ). Is there any formal process I mu

Re: slight winsock design change proposal

2008-03-06 Thread Christopher Harvey
Dmitry Timoshkov wrote: > "Christopher Harvey" <[EMAIL PROTECTED]> wrote: > >> Juan Lang wrote: I'm giving the mswsock.c file some development time. I need to know if the winsock API has been inited. >>> >>> The question is, why do you need to know that? Can't you just

Re: slight winsock design change proposal

2008-03-06 Thread Dmitry Timoshkov
"Christopher Harvey" <[EMAIL PROTECTED]> wrote: > Juan Lang wrote: >>> I'm giving the mswsock.c file some development time. I need to know if >>> the winsock API has been inited. >>> >> >> The question is, why do you need to know that? Can't you just >> initialize it yourself? Then you'll

Re: slight winsock design change proposal

2008-03-06 Thread Juan Lang
> There are some functions that return errors if WSAStartup hasn't been > called. I think wine should do that too, rather than call it for the > application. Perhaps it should, but that should be fixed in ws2_32, not in mswsock. --Juan

Re: slight winsock design change proposal

2008-03-06 Thread Christopher Harvey
Juan Lang wrote: >> I'm giving the mswsock.c file some development time. I need to know if >> the winsock API has been inited. >> > > The question is, why do you need to know that? Can't you just > initialize it yourself? Then you'll know it has been. > --Juan > > There are some functio

Re: winequartz.drv Mac OS X UI discontinued?

2008-03-06 Thread Steven Edwards
Hi, On Thu, Mar 6, 2008 at 9:08 AM, Emmanuel Maillard <[EMAIL PROTECTED]> wrote: > I post a new quartzdrv patch for wine-0.9.56 on Darwine SF patches > page : > > http://sourceforge.net/tracker/index.php?func=detail&aid=1908759&group_id=69890&atid=526089 > > It's not fully update to wine chan

Re: slight winsock design change proposal

2008-03-06 Thread Juan Lang
> I'm giving the mswsock.c file some development time. I need to know if > the winsock API has been inited. The question is, why do you need to know that? Can't you just initialize it yourself? Then you'll know it has been. --Juan

Re: slight winsock design change proposal

2008-03-06 Thread Christopher Harvey
James Hawkins wrote: > On Wed, Mar 5, 2008 at 6:28 PM, Christopher Harvey > <[EMAIL PROTECTED]> wrote: > >> I'm giving the mswsock.c file some development time. I need to know if >> the winsock API has been inited. This has already been implemented, but >> I need to get access to the num_start

Recent valgrind regressions in msxml3

2008-03-06 Thread Dan Kegel
Hi Alistair, I'm seeing some regressions in msxml3 in yesterday's git; see http://kegel.com/wine/valgrind/logs-2008-03-05/vg-msxml3_domdoc-diff.txt e.g. + Invalid read of size 4 +at HEAP_ValidateInUseArena (heap.c:925) +by RtlFreeHeap (heap.c:1288) +by SysFreeString (oleaut.c:196) +

Re: Getting apps running under Wine

2008-03-06 Thread Juan Lang
> Having two versions of Win32 executable is IMHO not very practical, as > 99% of the code would be same for both applications. That wasn't exactly what I intended. You said in your original email, > We use DLL that depends on some Win32 drivers. My question is, could you ship a Linux version

Re: Getting apps running under Wine

2008-03-06 Thread Martin Hinner
Hi, > Please open a bug at our bugzilla (bugs.winehq.org). Attaching > screenshots of the problem would help. We discourage you from working > around Wine bugs, because if we fix the bug, we'll break your app in > the process. Better to fix Wine. I 100% agree, but I wasn't sure if wine team

Re: msi [2/3]: Fix handling of published installer properties

2008-03-06 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > The tests are in the next patch. Fixes bug 7189. > http://bugs.winehq.org/show_bug.cgi?id=7189 You need to fix the todo_wine tests in the same patch, I can't apply a patch that causes failures: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.

Re: winequartz.drv Mac OS X UI discontinued?

2008-03-06 Thread Emmanuel Maillard
Hi, I post a new quartzdrv patch for wine-0.9.56 on Darwine SF patches page : http://sourceforge.net/tracker/index.php?func=detail&aid=1908759&group_id=69890&atid=526089 It's not fully update to wine changes (SysCommandSizeMove didn't be reviewed) and don't contain all changes I initially pla

Re: [PATCH] GDI+: Implement GdipGetImageEncoders.

2008-03-06 Thread Nathan Beckmann
Don't apply this patch. The test cases crash on Windows. I was using winetricks to test and accidentally did not test under Windows. - Nathan On Wed, Mar 5, 2008 at 11:21 AM, Nathan Beckmann <[EMAIL PROTECTED]> wrote: > Implement helper GdipGetImageEncodersSize. > > Also included tests. > ---

Re: Regression tests - recent regressions

2008-03-06 Thread Alexandre Julliard
"Austin English" <[EMAIL PROTECTED]> writes: > In today's git, I've had a few regressions in make -k test: > > [EMAIL PROTECTED]:~/wine-git$ grep -i 'Test failed' > wine-0.9.56-420-g22f146f.txt > visual.c:1741: Test failed: double texbem failed: Got color > 0x00ff00ff, expected 0x0000. > syst

Re: Regression tests - recent regressions

2008-03-06 Thread Austin English
On Thu, Mar 6, 2008 at 3:36 AM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Am Donnerstag, 6. März 2008 05:08:56 schrieb Austin English: > > > visual.c:1741: Test failed: double texbem failed: Got color > > 0x00ff00ff, expected 0x0000. > Which GPU do you have? > 01:00.0 VGA compatible contr

Re: Regression tests - recent regressions

2008-03-06 Thread Stefan Dösinger
Am Donnerstag, 6. März 2008 05:08:56 schrieb Austin English: > visual.c:1741: Test failed: double texbem failed: Got color > 0x00ff00ff, expected 0x0000. Which GPU do you have?

[PATCH] GDI+: Implement GdipGetImageEncoders.

2008-03-06 Thread Nathan Beckmann
Don't apply this patch. The test cases crash on Windows. I was using winetricks to test and accidentally did not test under Windows. A "try 2" patch has been sent that fixes these issues. Sorry. - Nathan

Re: WineD3D: Implement depth copy from onscreen to offscreen surface when depth fixup is used

2008-03-06 Thread H. Verbeet
On 06/03/2008, Frank Richter <[EMAIL PROTECTED]> wrote: > This doesn't work. The problem with doing depth copy with fixed up depth stencil is that the size of the render buffer is different from the depth stencil size. Basically what needs to happen is that the render buffer contents need to be bli