Re: [PATCH] gdiplus: Fix errors in image dimensions.

2008-03-05 Thread Dmitry Timoshkov
"Nathan Beckmann" <[EMAIL PROTECTED]> wrote: > -y = (UINT)(((REAL)y) * ((REAL)GetDeviceCaps(hdcref, LOGPIXELSY)) / > - ((REAL)INCH_HIMETRIC)); > +/* this calculation can lead to truncation error */ > +y = (UINT)REAL)y) * ((REAL)GetDeviceCaps(hdcref, LOGPIXELSY)) / > +

Re: (resend) msi: Fix bug in handling of multivolume CAB files.

2008-03-05 Thread Ove Kaaven
James Hawkins skrev: > On Wed, Mar 5, 2008 at 9:15 PM, Ove Kaaven <[EMAIL PROTECTED]> wrote: >> James Hawkins skrev: >> >>> The tests that now pass with native cabinet dll are test_continuouscab >> > (which is similar to what you're trying to test). The point of >> > maxsize is so that it create

Regression tests - recent regressions

2008-03-05 Thread Austin English
In today's git, I've had a few regressions in make -k test: [EMAIL PROTECTED]:~/wine-git$ grep -i 'Test failed' wine-0.9.56-420-g22f146f.txt visual.c:1741: Test failed: double texbem failed: Got color 0x00ff00ff, expected 0x0000. systray.c:89: Test failed: ret 0x1 which is not a window systray

Re: (resend) msi: Fix bug in handling of multivolume CAB files.

2008-03-05 Thread James Hawkins
On Wed, Mar 5, 2008 at 9:15 PM, Ove Kaaven <[EMAIL PROTECTED]> wrote: > James Hawkins skrev: > > > The tests that now pass with native cabinet dll are test_continuouscab > > (which is similar to what you're trying to test). The point of > > maxsize is so that it creates continuous cabs...there's

Re: (resend) msi: Fix bug in handling of multivolume CAB files.

2008-03-05 Thread Ove Kaaven
James Hawkins skrev: The tests that now pass with native cabinet dll are test_continuouscab (which is similar to what you're trying to test). The point of maxsize is so that it creates continuous cabs...there's no other way to do it, and builtin doesn't create continuous cabs at all. No? Then

Re: user32: Fix enumeration for EnumWindowStations and EnumDesktops, try2

2008-03-05 Thread Maarten Lankhorst
Hi Dmitry, 2008/3/5, Dmitry Timoshkov <[EMAIL PROTECTED]>: > "Maarten Lankhorst" <[EMAIL PROTECTED]> wrote: > > > Oops, the other call has to be null terminated as well. > > > Do you have test cases for those changes? They look like > a noop to me. I ran into this bug when I used those functions

Re: user32: Fix enumeration for EnumWindowStations and EnumDesktops, try2

2008-03-05 Thread Dmitry Timoshkov
"Maarten Lankhorst" <[EMAIL PROTECTED]> wrote: > Oops, the other call has to be null terminated as well. Do you have test cases for those changes? They look like a noop to me. -- Dmitry.

Re: slight winsock design change proposal

2008-03-05 Thread James Hawkins
On Wed, Mar 5, 2008 at 6:28 PM, Christopher Harvey <[EMAIL PROTECTED]> wrote: > I'm giving the mswsock.c file some development time. I need to know if > the winsock API has been inited. This has already been implemented, but > I need to get access to the num_startup variable from the mswsock.c >

Re: Winecfg: Raise max screen resolution to 160 DPI

2008-03-05 Thread L. Rahyen
On Wednesday March 5 2008 02:55:34 Dmitry Timoshkov wrote: > "L. Rahyen" <[EMAIL PROTECTED]> wrote: > > This problem was already solved in this patch [1] by Nigel Liang. > > Unfortunately, it wasn't accepted and Nigel didn't tried to ask why it > > was rejected or to resend it. > > I think I will g

Re: [feature requist] Glide API support

2008-03-05 Thread Christian Costa
Roderick Colenbrander a écrit : >> Dear Wine devs, >> >> There are some games out there that were built with the Glide API. The >> Glide >> API is the graphics API of the 3dfx Voodoo cards and is basically a >> stripped >> down version of OpenGL. Could please consider adding support for the Glide >

Re: make LoadStringW pass tests (fixed merge conflict)

2008-03-05 Thread Alexandre Julliard
Christopher <[EMAIL PROTECTED]> writes: > James Hawkins wrote: >> Why don't you just name the new parameter the same name as the >> function parameter ('buffer' or some variation)? junkpointer is a >> terrible variable name. >> >> > sure, I will change it. Actually what you should do is take

Re: make LoadStringW pass tests (fixed merge conflict)

2008-03-05 Thread Christopher
James Hawkins wrote: > On Wed, Mar 5, 2008 at 11:58 AM, Christopher > <[EMAIL PROTECTED]> wrote: > >> resubmitting my patch to resolve a merge conflict with the latest GIT >> >> Christopher Berner >> >> From 47a770102acf010834899489416e92fd4f79ffd1 Mon Sep 17 00:00:00 2001 >> From: Christopher

Re: Maarten Lankhorst : oleaut32: Handle TKIND_ALIAS properly when passed as pointer.

2008-03-05 Thread Maarten Lankhorst
Hi Marcus, 2008/3/5, Marcus Meissner <[EMAIL PROTECTED]>: > On Wed, Mar 05, 2008 at 06:24:14AM -0600, Alexandre Julliard wrote: > > Module: wine > > Branch: master > > Commit: c978bbee87dd6e09e4ad836df5ad7d63506face2 > > +break; > > case TKIND_ENUM:/* confirmed

Re: make LoadStringW pass tests (fixed merge conflict)

2008-03-05 Thread James Hawkins
On Wed, Mar 5, 2008 at 11:58 AM, Christopher <[EMAIL PROTECTED]> wrote: > resubmitting my patch to resolve a merge conflict with the latest GIT > > Christopher Berner > > From 47a770102acf010834899489416e92fd4f79ffd1 Mon Sep 17 00:00:00 2001 > From: Christopher Berner <[EMAIL PROTECTED]> > Date:

Re: hal: Add a stub for HalGetBusData() to make 3DMark2001SE happy in WinNT mode.

2008-03-05 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > +typedef enum _BUS_DATA_TYPE > +{ > +ConfigurationSpaceUndefined = -1, > +Cmos, > +EisaConfiguration, > +Pos, > +CbusConfiguration, > +PCIConfiguration, > +VMEConfiguration, > +NuBusConfiguration, > +PCMCIAConfigurat

Re: ntdll/tests: Don't use 0x55/0xaa to avoid any confusion when running with +heap.

2008-03-05 Thread Francois Gouget
On Wed, 5 Mar 2008, Paul Vriens wrote: [...] > > @@ -198,13 +198,13 @@ static void test_NtAtom(void) > > ok((lstrlenW(testAtom2) * sizeof(WCHAR)) == Len, "Returned wrong > > length %d\n", Len); > > > > Len = 8; > > c-Name[0] = Name[1] = Name[2] = Name[3] = Name[4] = 0x5

Re: WineHQ should discourage the use of cracks

2008-03-05 Thread F Capela
Remco wrote: > Or how about this: > > ::Wine Compatibility:: > ( ) Doesn't work at all [Garbage] > ( ) Starts, but not very usable [Bronze] > ( ) Basically works, a few bugs [Silver] > (*) Works flawlessly [Gold] > > ::Extra Info:: > [x] Needs Wine configuration (Windows version, > sound options, r

Re: #1 gdi32: Move GetICMProfile to the driver.

2008-03-05 Thread Alexandre Julliard
Hans Leidekker <[EMAIL PROTECTED]> writes: > Changelog > Move GetICMProfile to the driver. Looks good, but the code doesn't belong in x11drv_main.c. Something like graphics.c would be more appropriate. -- Alexandre Julliard [EMAIL PROTECTED]

Re: Maarten Lankhorst : oleaut32: Handle TKIND_ALIAS properly when passed as pointer.

2008-03-05 Thread Marcus Meissner
On Wed, Mar 05, 2008 at 06:24:14AM -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: c978bbee87dd6e09e4ad836df5ad7d63506face2 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=c978bbee87dd6e09e4ad836df5ad7d63506face2 > > Author: Maarten Lankhorst <[EMAIL PROTE

Re: ntdll/tests: Don't use 0x55/0xaa to avoid any confusion when running with +heap.

2008-03-05 Thread Paul Vriens
Francois Gouget wrote: > --- > dlls/ntdll/tests/atom.c | 12 ++-- > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/ntdll/tests/atom.c b/dlls/ntdll/tests/atom.c > index 2de94a0..68f5aba 100644 > --- a/dlls/ntdll/tests/atom.c > +++ b/dlls/ntdll/tests/atom.c > @@ -1

Re: [PATCH 1/3] shell32: add xdg-user-dirs lookup code

2008-03-05 Thread Alexandre Julliard
"Lei Zhang" <[EMAIL PROTECTED]> writes: > +/* Convert $HOME to wide chars */ > +len = MultiByteToWideChar(CP_ACP, 0, home_dir, -1, NULL, 0); > +home_dirW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > +if (!home_dirW) > +{ > +hr = E_OUTOFMEMORY; > +got

Re: WineHQ should discourage the use of cracks

2008-03-05 Thread Ben Hodgetts
I like this... considering how... "unskilled" many people that fill in test reports are on the AppDB, this would help make it a little more foolproof (although the "Has legal issues" bits seem rather unnecessary at the end). Ben H. Remco wrote: > Or how about this: > > ::Wine Compatibility:: >

Re: X Error of failed request

2008-03-05 Thread Dmitry Timoshkov
"bill lam" <[EMAIL PROTECTED]> wrote: > Sometimes (about 3 or 4 times in one day) that it just crashed with this > message, > > X Error of failed request: BadWindow (invalid Window parameter) > Major opcode of failed request: 18 (X_ChangeProperty) > Resource id in failed request: 0x44

X Error of failed request

2008-03-05 Thread bill lam
Sometimes (about 3 or 4 times in one day) that it just crashed with this message, X Error of failed request: BadWindow (invalid Window parameter) Major opcode of failed request: 18 (X_ChangeProperty) Resource id in failed request: 0x443 Serial number of failed request: 1113 Cu

RE: Screen mode retrieval/trace tool for Windows

2008-03-05 Thread Matteo Italia
I think that you could just write a Windows application that listens for WM_DISPLAYCHANGE messages (that are generated when the ChangeDisplaySettingsEx succeeds) and logs the parameters recieved somewhere (keep in mind that wParam = new BPP; LOWORD(lParam) = new horizontal resolution; HIWORD(lParam