mountmgr.sys and ioctl's

2008-03-01 Thread Maarten Lankhorst
Hi Alexandre, In irc we discussed ioctl's with devices, and how ioctl's go to ntdll/cdrom.c if the drive is fd backed, and to mountmgr.sys if it isn't. For itunes it needs raw disk access, but also an ioctl from mountmgr. What if we always map access to \\.\X: is always mapped to mountmgr, and le

Re: winmm/tests: Don't use 0x55 to avoid any confusion when running with+heap.

2008-03-01 Thread Dmitry Timoshkov
"Francois Gouget" <[EMAIL PROTECTED]> wrote: > mmioSeek(hmmio, 0, SEEK_SET); > -memset(&ck, 0x55, sizeof(ck)); > +memset(&ck, 0x66, sizeof(ck)); > ret = mmioDescend(hmmio, &ck, NULL, MMIO_FINDCHUNK); > ok(ret == MMIOERR_CHUNKNOTFOUND || >ret == MMIOERR_INVALIDFILE, "mmi

Re: Any graphics card y'all like to see tests run on?

2008-03-01 Thread Austin English
On Wed, Feb 27, 2008 at 9:36 PM, James McKenzie <[EMAIL PROTECTED]> wrote: > > Stefan Dösinger wrote: > > Am Mittwoch, 27. Februar 2008 05:49:57 schrieb Austin English: > > > >> Thanks Carl, and to the rest of the list, sorry for the noise/false > >> hope to d3d/ddraw guys. > >> > > Just to a

Re: iPod synced with iTunes v7.6!

2008-03-01 Thread Juan Lang
> I got an ipod I borrowed to sync: http://www.astro.rug.nl/~lankhorst/ipod.png W00t! Well done, Maarten! --Juan

Re: msi: ACTION_RegisterProduct store all InstallProperties

2008-03-01 Thread James Hawkins
On Sat, Mar 1, 2008 at 4:33 PM, Adam Strzelecki <[EMAIL PROTECTED]> wrote: > > Which is wrong, which you'll see when I submit my next patch which > > tests your theory. > > I don't mind you pointing me out my mistakes. So I kindly waiting for > your patch. However right now I presented my argume

Re: msi: ACTION_RegisterProduct store all InstallProperties

2008-03-01 Thread Adam Strzelecki
> Which is wrong, which you'll see when I submit my next patch which > tests your theory. I don't mind you pointing me out my mistakes. So I kindly waiting for your patch. However right now I presented my arguments quoting Wine sources, but you just respond that I'm wrong without presenting yo

Re: msi: ACTION_RegisterProduct store all InstallProperties

2008-03-01 Thread James Hawkins
On Sat, Mar 1, 2008 at 4:02 PM, Adam Strzelecki <[EMAIL PROTECTED]> wrote: > Hello, > > > > I think you need to read through the implementation of > > MSI_GetProductInfo more closely and also read the MsiGetProductInfo > > tests in tests/msi.c and the test_publish:RegisterProduct tests in > > t

Re: msi: ACTION_RegisterProduct store all InstallProperties

2008-03-01 Thread Adam Strzelecki
Hello, > I think you need to read through the implementation of > MSI_GetProductInfo more closely and also read the MsiGetProductInfo > tests in tests/msi.c and the test_publish:RegisterProduct tests in > tests/install.c. I think I did, and looking at the tests I see they are testing properties

Re: kernel32 & winelib: Don't test string size in CompareStringW for null terminated strings

2008-03-01 Thread Steven Edwards
On Sat, Mar 1, 2008 at 10:55 AM, Adam Strzelecki <[EMAIL PROTECTED]> wrote: > > No, we may not have a look! And we sure as hell can't > > post copyrighted Microsoft source code on this mailing list! > Argh... I meant you may have a look if you have Visual Studio > installed, I don't intend to p

Re: kernel32 & winelib: Don't test string size in CompareStringW for null terminated strings

2008-03-01 Thread Adam Strzelecki
> No, we may not have a look! And we sure as hell can't > post copyrighted Microsoft source code on this mailing list! Argh... I meant you may have a look if you have Visual Studio installed, I don't intend to post any copyrighted code there, but I just post header copyright information from t

re: kernel32 & winelib: Don't test string size in CompareStringW for null terminated strings

2008-03-01 Thread Dan Kegel
Adam Strzelecki wrote: > Visual Studio is shipping with complete sources of C CRT so you may have a > look. > ;*** > ;strlen.asm - contains strlen() routine > ; > ; Copyright (c) Microsoft Corporation. All rights reserved. No, we may not have a look! And we sure as hell can't post copyrigh

Re: kernel32 & winelib: Don't test string size in CompareStringW for null terminated strings

2008-03-01 Thread Adam Strzelecki
Hello, > You introduce a lot of complexity into the low-level helper > routines. We don't want to put Win32 quirks, like -1 meaning "until > the null terminator" being put into the low-level functions unless > we have to. In this case, if this is the sole cause of the slowdown > then you w

Re: kernel32 & winex11: WaitForMultipleObjectsEx should ignore NULL handles

2008-03-01 Thread Adam Strzelecki
> In this case, MSI should not be calling MsgWaitForMultipleObjects > with an invalid handle and in fact that barring memory corruption, > this can't happen: You're right, my patch was incorrect, I made bad assumption. I'm still not sure why this X11DRV_MsgWaitForMultipleObjectsEx is testing

iPod synced with iTunes v7.6!

2008-03-01 Thread Maarten Lankhorst
Hi all, I got an ipod I borrowed to sync: http://www.astro.rug.nl/~lankhorst/ipod.png There are, however, 3 separate issues to work out for this to work with an unpatched version of wine, minus the patches I sent to wine-patches, and one I still need to confirm with rob. 1. I need to add detecti