Re: d3dx9: Add stubs for the ID3DXRenderToSurface functions [PATCH 8/9]

2008-02-23 Thread H. Verbeet
On 23/02/2008, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > +static HRESULT WINAPI > ID3DXRenderToSurfaceImpl_QueryInterface(LPD3DXRENDERTOSURFACE iface, REFIID > riid, LPVOID *object) > +{ > +ID3DXRenderToSurfaceImpl *This=(ID3DXRenderToSurfaceImpl*)iface; > + > +if(IsEqualGUID(ri

Re: d3dx9: Add stubs for the ID3DXFont functions [PATCH 5/9]

2008-02-23 Thread H. Verbeet
On 23/02/2008, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > +TRACE("stubn"); Shouldn't that be a \n (here and in the other patches)?

Re: gdiplus: Implement GdipLoadImageFromFile

2008-02-23 Thread Dmitry Timoshkov
"Nathan Beckmann" <[EMAIL PROTECTED]> wrote: > stat = GdipCreateBitmapFromStream(stream, bitmap); > > -if(!stat) > +if(stream) > IStream_Release(stream); The 'if' check above is not needed, GdipCreateStreamOnFile returns a status which is already checked. > +stat = Gd

Re: gdiplus: Implement GdipLoadImageFromFile

2008-02-23 Thread James Hawkins
On Sat, Feb 23, 2008 at 11:00 PM, Nathan Beckmann <[EMAIL PROTECTED]> wrote: > Hi. My name is Nathan Beckmann. I'm working on GDI+ for a class > project at UCLA (sponsored by Google). > > This patch implements GdipLoadImageFromFile. > > It includes basic tests for invalid parameters, all of whic

re: Sending updates to wine developers guide

2008-02-23 Thread Dan Kegel
> I can't find the documentation so I can edit it. Look at the bottom of http://winehq.org/site/git The command to load it into a local git repository is git cvsimport -v -k -d :pserver:[EMAIL PROTECTED]:/cvsroot/wine docs You can then send in patches.

Sending updates to wine developers guide

2008-02-23 Thread Austin English
I was looking at the website.git online, I can't find the documentation so I can edit it. http://source.winehq.org/git/website.git/?a=blob;f=templates/en/documentation.template references /docs/, but that doesn't exist on git. I'm sure a lot of the info is outdated, but I was mostly looking to fix

Re: Bugs fixed in 0.9.56

2008-02-23 Thread Dan Kegel
On Sat, Feb 23, 2008 at 5:04 PM, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: > Dan Kegel wrote: > > Here are the bugs marked fixed during the 0.9.56 cycle. > > (A few of them were fixed earlier, but not marked as such before.) > > It might be nice if the "Lots of bugfixes" line in each release ANN

Re: Bugs fixed in 0.9.56

2008-02-23 Thread Ivan Gyurdiev
Dan Kegel wrote: > Here are the bugs marked fixed during the 0.9.56 cycle. > (A few of them were fixed earlier, but not marked as such before.) > It might be nice if the "Lots of bugfixes" line in each release ANNOUNCE file would link to a list like this one. Proof there were lots of bugfixes..

Re: wined3d: ActivateContext: try to fix wrong parameter?

2008-02-23 Thread Rico Schüller
I refer to the last attachment to the bug (and the patch which was sent in the initial mail http://www.winehq.org/pipermail/wine-devel/2008-February/062835.html - it's the same). I just want to say if my patch is wrong and the other way is wrong (see bug http://bugs.winehq.org/show_bug.cgi?id=