Fun Project: Add dialogs to builtin IE

2008-02-21 Thread Steven Edwards
Hi, I submitted a proof of concept patch for this a week or so back that added a simple file->exit menu to the builtin Internet Explorer. I've spoken with Jacek a bit about it and it seems shdocvw.dll is the correct place to implement the UI layout if we are targeting IE versions less the 7. There

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Dan Kegel
On Thu, Feb 21, 2008 at 6:48 PM, Steven Edwards <[EMAIL PROTECTED]> wrote: > I think the problem is more inherit in newsgroup design. Like you can > view topics in but there is no way to have topics broken in to > categories. I guess this is historical as the traditional newsgroup > structure w

Re: msvcrt: Implemented wcscpy_s

2008-02-21 Thread Dmitry Timoshkov
"Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote: > --- a/dlls/msvcrt/msvcrt.spec > +++ b/dlls/msvcrt/msvcrt.spec > @@ -761,6 +761,7 @@ > @ cdecl wcscmp(wstr wstr) ntdll.wcscmp > @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll > @ cdecl wcscpy(ptr wstr) ntdll.wcscpy > +@ cdecl wcscpy_s(wstr long wstr)

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes

2008-02-21 Thread James McKenzie
Jeff Zaroyko wrote: > On Fri, Feb 22, 2008 at 12:57 PM, James McKenzie > <[EMAIL PROTECTED]> wrote: > >> Francois Gouget wrote: >> > On Thu, 21 Feb 2008, Jeff Zaroyko wrote: >> > [...] >> > >> >> I think this looks good, http://jeffz.name/tmp/suggestion3.png >> >> >> >> Do you still think

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes

2008-02-21 Thread Jeff Zaroyko
On Fri, Feb 22, 2008 at 12:57 PM, James McKenzie <[EMAIL PROTECTED]> wrote: > Francois Gouget wrote: > > On Thu, 21 Feb 2008, Jeff Zaroyko wrote: > > [...] > > > >> I think this looks good, http://jeffz.name/tmp/suggestion3.png > >> > >> Do you still think we need to change the green Francois

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Steven Edwards
On Thu, Feb 21, 2008 at 6:28 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > can explain what it is that makes google groups suck, > maybe I can do something about it. Send those comments > to me offlist, though. I can't think of a way to make it not suck so sending these thoughts here as they relat

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes

2008-02-21 Thread James McKenzie
Francois Gouget wrote: > On Thu, 21 Feb 2008, Jeff Zaroyko wrote: > [...] > >> I think this looks good, http://jeffz.name/tmp/suggestion3.png >> >> Do you still think we need to change the green Francois? >> > > I prefer to have the text in the colored bar because that way it matches > the

Wine and PulseAudio

2008-02-21 Thread Tomas Carnecky
This subject was discussed a few months ago (around 10/2007). But it was rather a discussion about whether to make a PA sound driver or not. I personally would love to see that happen, if not only because PA has some very nifty features, like per-app volume, transparent sink switching etc, some

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Jeremy White
> I tried to bring it up before, but anyways: drupal looks like a good way too > go. It's fast, foss, > flexible and with these modules I did some looking into this myself. Drupal looked interesting, but the solution that seemed simplest and best to me was using a phpbb and a mailman <--> php

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Marcel Partap
> (Though it sure would be nice if we had that bidirectional > gateway working. It never seems to stay up.) I tried to bring it up before, but anyways: drupal looks like a good way too go. It's fast, foss, flexible and with these modules http://drupal.org/project/mailman_manager http://drupal

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Dan Kegel
On Thu, Feb 21, 2008 at 3:11 PM, Steven Edwards <[EMAIL PROTECTED]> wrote: > So we have about 1400 people in a short period of time that like > forums and how no where else to go. I for one hate, despise, loath and > in general just don't like google groups. I like the general layout of > other

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Steven Edwards
On Thu, Feb 21, 2008 at 6:11 PM, Steven Edwards <[EMAIL PROTECTED]> wrote: > So we have about 1400 people in a short period of time that like > forums and how no where else to go. I for one hate, despise, loath and Sorry let me make that clear. 1400 people that want a forum of some type, wine-fo

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Steven Edwards
On Thu, Feb 21, 2008 at 2:30 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Thu, Feb 21, 2008 at 11:29 AM, Tom Wickline <[EMAIL PROTECTED]> wrote: > > And Google Groups has 738 subscribers :D > > > > There for a second I was feeling rather poorly about the wine-forum site. > > > > So, I supp

Re: wined3d: ActivateContext: try to fix wrong parameter?

2008-02-21 Thread Stefan Dösinger
Am Donnerstag, 21. Februar 2008 20:12:24 schrieb Roderick Colenbrander: > It is not a workaround but a patch which restores the original behavior of > the LoadLocation function. During the merge of the two codepaths I missed > this part. What happens if e.g. the current render target is an offscree

Re: dmband: Indirection levels fix

2008-02-21 Thread Andrew Talbot
Robert Shearman wrote: > This isn't correct. Judging by the surrounding code, this should be > allocating a block of memory of This->pDesc->pbMemData and then passing > pDesc->llMemLength into memcpy, possibly validating that > pDesc->llMemLength isn't greater than UINT_MAX to avoid an overflow. >

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Mitchell Mebane
Dan Kegel wrote: 2008/2/21 Tom Wickline <[EMAIL PROTECTED]>: [if] the forums at http://www.wine-forum.org/index.php were not popular enough to make this cut, may I ask how many users = popular? Well, let's see: Ubuntuforums: Threads: 685,027, Posts: 4,364,352, Members: 509,031 Linuxf

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Dan Kegel
On Thu, Feb 21, 2008 at 11:29 AM, Tom Wickline <[EMAIL PROTECTED]> wrote: > And Google Groups has 738 subscribers :D > > There for a second I was feeling rather poorly about the wine-forum site. > > So, I suppose the forums I put up are about as destructive as Goggle Groups. Nah, the usenet gro

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Tom Wickline
http://img407.imageshack.us/img407/3949/googlegroupsmozillafirejz8.png And Google Groups has 738 subscribers :D There for a second I was feeling rather poorly about the wine-forum site. So, I suppose the forums I put up are about as destructive as Goggle Groups. Actually 13 Members less destruct

Re: wined3d: ActivateContext: try to fix wrong parameter?

2008-02-21 Thread Roderick Colenbrander
> Hi, > > as suggested I send this patch for a discussion. This is a workaround > for this bug http://bugs.winehq.org/show_bug.cgi?id=11584 . > > I don't know if this patch is the right way to fix the problem. > > Could someone with more knowledge have a look at this? > > Cheers > Rico It is

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Dan Kegel
2008/2/21 Tom Wickline <[EMAIL PROTECTED]>: > [if] the forums at http://www.wine-forum.org/index.php were not > popular enough to make this cut, may I ask how many users = popular? Well, let's see: Ubuntuforums: Threads: 685,027, Posts: 4,364,352, Members: 509,031 Linuxforums: Threads: 111,640,

wined3d: ActivateContext: try to fix wrong parameter?

2008-02-21 Thread Rico Schüller
Hi, as suggested I send this patch for a discussion. This is a workaround for this bug http://bugs.winehq.org/show_bug.cgi?id=11584 . I don't know if this patch is the right way to fix the problem. Could someone with more knowledge have a look at this? Cheers Rico >From dd3877745308bde528a09

Re: website: add links to most popular active Wine forums

2008-02-21 Thread Tom Wickline
If you know of another active Wine forum - especially a non-english one - please let us know so we can add it to the list. (Email to [EMAIL PROTECTED] would do.) Русский http://www.wine-forum.org/forumdisplay.php?f=44 Tom P.S Sorry, the forums at http://www.wine-forum.org/index.php were not p

Re: [1/2] ddraw: release interfaces when exiting with error

2008-02-21 Thread Stefan Dösinger
Am Mittwoch, 20. Februar 2008 22:03:51 schrieben Sie: > --- > dlls/ddraw/texture.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Just a general comment(not specific to comments): For such cleanup work it works quite nice to use goto(!), as shown below. Your patch is OK as it is,

Re: dplayx: Fix incorrect check in DirectPlayLobbyAImpl_EnumLocalApplications and IDirectPlayLobbyAImpl_EnumAddressTypes.

2008-02-21 Thread Marcus Meissner
On Thu, Feb 21, 2008 at 04:44:34PM +, Robert Shearman wrote: > > Dereferencing a function pointer and checking it against NULL doesn't make > any sense, so remove the checks. > - if( !lpEnumAddressTypeCallback || !*lpEnumAddressTypeCallback ) > + if( !lpEnumAddressTypeCallback ) It looks

Re: Do we need a forum?

2008-02-21 Thread Tom Wickline
On Mon, Feb 18, 2008 at 8:19 PM, L. Rahyen <[EMAIL PROTECTED]> wrote: > > > > Tom is committed to doing this with > > wine-forum. If there is something you don't like, such as the > > registration, advertisements, etc I am sure he is willing to adjust > > the user experience. > > OK, th

Re: dmband: Indirection levels fix

2008-02-21 Thread Robert Shearman
Andrew Talbot wrote: > diff --git a/dlls/dmband/band.c b/dlls/dmband/band.c > index 891fb5a..8b89573 100644 > --- a/dlls/dmband/band.c > +++ b/dlls/dmband/band.c > @@ -173,7 +173,7 @@ static HRESULT WINAPI > IDirectMusicBandImpl_IDirectMusicObject_SetDescriptor (LPD > This->pDesc->ft

Re: James Hawkins : itircl: Add a stub implementation of itircl.dll.

2008-02-21 Thread Detlef Riekenberg
On Sa, 2008-02-16 at 09:57 -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 58b0686e951364686c3b5b55c18566df0960fd96 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=58b0686e951364686c3b5b55c18566df0960fd96 > > Author: James Hawkins <[EMAIL PROTECTED]> > Date:

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes

2008-02-21 Thread Francois Gouget
On Thu, 21 Feb 2008, Jeff Zaroyko wrote: [...] > I think this looks good, http://jeffz.name/tmp/suggestion3.png > > Do you still think we need to change the green Francois? I prefer to have the text in the colored bar because that way it matches the title at the top (Known bugs in suggestion.png

Re: slc: Added stub for SLGetWindowsInformationDWORD

2008-02-21 Thread Alistair Leslie-Hughes
Gee, you guys are quick. Submitted again without the comments. Best Regards Alistair Leslie-Hughes

Re: slc: Added stub for SLGetWindowsInformationDWORD

2008-02-21 Thread James Hawkins
On Thu, Feb 21, 2008 at 3:38 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > > On Thu, Feb 21, 2008 at 10:20 AM, Alistair Leslie-Hughes > <[EMAIL PROTECTED]> wrote: > > Hi, > > > > Changelog: > > slc: Added stub for SLGetWindowsInformationDWORD > > > > Best Regards > > Alistair Les

Re: slc: Added stub for SLGetWindowsInformationDWORD

2008-02-21 Thread Paul Vriens
On Thu, Feb 21, 2008 at 10:20 AM, Alistair Leslie-Hughes <[EMAIL PROTECTED]> wrote: > Hi, > > Changelog: > slc: Added stub for SLGetWindowsInformationDWORD > > Best Regards > Alistair Leslie-Hughes > Hi Alistair, I know that function descriptions should always be your own words but I g