Re: Alsa spitting out warnings every time Wine runs.

2008-02-12 Thread Paul Vriens
Peter Dons Tychsen wrote: > Hi Maarten & Devs. > > Great to see that audio is so much better in Wine now. > > But > On fedora core 6 and 8 i get this every time i start Wine: > > ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 > ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unkno

Re: Congratulation!!!

2008-02-12 Thread Tom Wickline
Now send them £10,000 and your £1,000,000.00 will be on its way. Don't delay this is your chance for riches. LOL. :D Tom On Feb 12, 2008 10:04 PM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Hooray! I won the Microsoft e-mail award! > > And I thought my wine efforts would go unnoticed,

Re: Fixing the last failing tests

2008-02-12 Thread Dmitry Timoshkov
"Maarten Lankhorst" <[EMAIL PROTECTED]> wrote: > An example is IsWindowUnicode. It always returns TRUE on XP, That's not true. > but it > won't do that on 9x. That would mean something like: > ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?"); We need to skip the tests that rely

Fwd: Congratulation!!!

2008-02-12 Thread Maarten Lankhorst
Hooray! I won the Microsoft e-mail award! And I thought my wine efforts would go unnoticed, but here I am winning the grand prize! -- Forwarded message -- From: [EMAIL PROTECTED] <[EMAIL PROTECTED]> Date: 12 feb. 2008 18:33 Subject: Congratulation!!! To: undisclosed-recipients M

Re: Fixing the last failing tests

2008-02-12 Thread James Hawkins
On Feb 12, 2008 8:16 PM, Peter Dons Tychsen <[EMAIL PROTECTED]> wrote: > Hello M. > > What is wrong with detecting the version, and branching the test code > accordingly? Other tests do that IIRC. I think that is a better > solution, if the version selector in winecfg is still going to be > meaning

re: Fixing the last failing tests

2008-02-12 Thread Dan Kegel
Maarten wrote: > An example is IsWindowUnicode. It always returns TRUE on XP, but it > won't do that on 9x. That would mean something like: > ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?"); Maybe you can do something like if (CreateWindowExW doesn't work) { /* win95 withou

Re: Fixing the last failing tests

2008-02-12 Thread Peter Dons Tychsen
Hello M. What is wrong with detecting the version, and branching the test code accordingly? Other tests do that IIRC. I think that is a better solution, if the version selector in winecfg is still going to be meaningful (registry). How about fixing the functions as well (like IsWindowUnicode), so

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests

2008-02-12 Thread Peter Dons Tychsen
Eh, this does not seem like a proper way to get a unit test to pass. Sleep()... that leads to the dark side! :-) Why does it need a Sleep()? If its failing on Wine, then shouldn't it be fixed in the libs? And if its on orig-winxp-vista then there must be a better way to wait? Or no? The string "

Fixing the last failing tests

2008-02-12 Thread Maarten Lankhorst
Hi all, I'm very close to passing the whole wine conformance suite on my pc. The only tests failing are in user32. These tests are failing in any version of windows though. How do I make them pass on at least 1 version of windows and wine? Would patches to make it run on xp and wine be accepted?

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests

2008-02-12 Thread Stefan Dösinger
Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst: > This makes the tests pass on my pc. d3d8 might need it as well

Alsa spitting out warnings every time Wine runs.

2008-02-12 Thread Peter Dons Tychsen
Hi Maarten & Devs. Great to see that audio is so much better in Wine now. But On fedora core 6 and 8 i get this every time i start Wine: ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unknown PCM default:0 ALSA lib conf.c:3949:(snd_c

Re: ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.

2008-02-12 Thread Peter Dons Tychsen
Hi Stefan. OK thanks for the fast, precise and well-cut review (and probably correct). I will fix the 3 issues and re-submit. /p On Wed, 2008-02-13 at 00:50 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 00:39:52 schrieb Peter Dons Tychsen: > > Hi Devs. > > > > I had this patch s

Re: ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.

2008-02-12 Thread Stefan Dösinger
Am Mittwoch, 13. Februar 2008 00:39:52 schrieb Peter Dons Tychsen: > Hi Devs. > > I had this patch silently rejected. > Can anybody spot what is wrong with this patch? My first thought was that filtering the modes like this is kinda ugly, but given that ddraw uses wined3d and wined3d uses the d3d9

ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.

2008-02-12 Thread Peter Dons Tychsen
Hi Devs. I had this patch silently rejected. Can anybody spot what is wrong with this patch? It is really needed for some older games like Grand Theft Auto, and other oldies (but goodies!). /pedro --- Begin Message --- Implement correct behavior for the DDEDM_REFRESHRATES flag, as the old implem

Re: dbghelp/dwarf.c: new valgrind warnings?

2008-02-12 Thread Eric Pouech
Dan Kegel a écrit : > I'm now seeing some new valgrind warnings when > wine is doing stack dumps after crashes: > > + Conditional jump or move depends on uninitialised value(s) > +at dwarf2_load_one_entry (dwarf.c:983) > +by dwarf2_lookup_type (dwarf.c:858) > +by dwarf2_load_one_entr

Re: [winetest] Would it be worthwhile to send zipped version of the reports?

2008-02-12 Thread Paul Vriens
Reece Dunn wrote: > On 12/02/2008, Paul Vriens <[EMAIL PROTECTED]> wrote: >> Hi, >> >> As more and more tests are developed I think it could make sense to zip the >> report files before sending. >> >> It will of course put a small extra burden on the winehq server but as the >> reports are text onl

Re: [winetest] Would it be worthwhile to send zipped version of the reports?

2008-02-12 Thread Reece Dunn
On 12/02/2008, Paul Vriens <[EMAIL PROTECTED]> wrote: > Hi, > > As more and more tests are developed I think it could make sense to zip the > report files before sending. > > It will of course put a small extra burden on the winehq server but as the > reports are text only we gain a 90% or so per r

Re: [advapi32/tests] Only use functions if they are implemented

2008-02-12 Thread Paul Vriens
James Hawkins wrote: > On Feb 12, 2008 10:34 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: >> Hi, >> >> Added some verbosity to the GetProcAddress stuff. The skips prevent the >> crash(es) I'm seeing on win95. >> > > What is the point of this 'verbosity'? You already add the skips, so > if a functio

Re: [advapi32/tests] Only use functions if they are implemented

2008-02-12 Thread James Hawkins
On Feb 12, 2008 10:34 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Hi, > > Added some verbosity to the GetProcAddress stuff. The skips prevent the > crash(es) I'm seeing on win95. > What is the point of this 'verbosity'? You already add the skips, so if a function isn't available for a test, you'

[winetest] Would it be worthwhile to send zipped version of the reports?

2008-02-12 Thread Paul Vriens
Hi, As more and more tests are developed I think it could make sense to zip the report files before sending. It will of course put a small extra burden on the winehq server but as the reports are text only we gain a 90% or so per report. Thoughts? -- Cheers, Paul.

Re: browseui: Add undocumented Component Category Cache Daemon class

2008-02-12 Thread Dmitry Timoshkov
"Maarten Lankhorst" <[EMAIL PROTECTED]> wrote: > --- /dev/null > +++ b/dlls/browseui/compcatcachedaemon.c > @@ -0,0 +1,159 @@ > +/* > + * Progress dialog > + * > + * Copyright 2007 Mikolaj Zalewski Is the above information correct? -- Dmitry.

Re: Oleview: Added Dutch translations

2008-02-12 Thread Dmitry Timoshkov
"Frans Kool" <[EMAIL PROTECTED]> wrote: > From 2e5bda68273038f924f8f0d1b325a2a4c71f17ae Mon Sep 17 00:00:00 2001 > From: Frans Kool <[EMAIL PROTECTED]> > Date: Tue, 12 Feb 2008 12:04:56 +0100 > Subject: Oleview: Added Dutch translations This your patch as well as a previous one are wrapped. --