Re: Regesstion Tests

Alistair Leslie-Hughes wrote: > Hi, >If I have Msxml3 with SP7 installed all the msxml tests pass without > issue, but if I have Msxml3 SP3 installed, some fail. > > Should I improve the tests so that they can handle both cases? > > Best Regards > Alistair Leslie-Hughes > > > > > Hi,

Regular bugzilla hygeine

When we do a release, all the bugs in RESOLVED FIXED state can be closed (since they were only waiting on a release to be closed). We haven't been doing that, and as a result, lots and lots of bugs stacked up in RESOLVED FIXED state. But I don't see any reason we shouldn't start doing it, so I'm ab

Re: comctl32: Fixed listview bug, when client sends bogus SETITEMSTATE request

On Tue, 2008-02-12 at 03:28 +0100, Peter Dons Tychsen wrote: > Fixed listview bug, when client sends bogus SETITEMSTATE request, > requesting all items to be focused. Looks good, tnx! -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.

Regesstion Tests

Hi, If I have Msxml3 with SP7 installed all the msxml tests pass without issue, but if I have Msxml3 SP3 installed, some fail. Should I improve the tests so that they can handle both cases? Best Regards Alistair Leslie-Hughes

gecko valgrind errors show up better now

The new version of valgrind shows better stack dumps for gecko valgrind errors. For instance, Invalid read of size 4 at (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) b

dbghelp/dwarf.c: new valgrind warnings?

I'm now seeing some new valgrind warnings when wine is doing stack dumps after crashes: + Conditional jump or move depends on uninitialised value(s) +at dwarf2_load_one_entry (dwarf.c:983) +by dwarf2_lookup_type (dwarf.c:858) +by dwarf2_load_one_entry (dwarf.c:1020) +by dwarf2_

Re: Resend patch from Norbert

Am Montag, 11. Februar 2008 19:39:27 schrieb Rico Schüller: > Vitaliy Margolen wrote: > > Rico Schüller wrote: > >> Hi, > >> > >> I only resend a patch because it isn't in the todays git and the author > >> didn't answer for a while. > >> > >> Cheers > >> Rico > >> > >> > >> ---

Re: Resend patch from Norbert

Vitaliy Margolen wrote: > Rico Schüller wrote: >> Hi, >> >> I only resend a patch because it isn't in the todays git and the author >> didn't answer for a while. >> >> Cheers >> Rico >> >> >> >> >> >> -memcpy(pRect, &This

Re: IStream interface for domdoc and terminate call

Also note you should test the behavior when call QueryInterface for IStream multiple times whether a new wrapper or the same wrapper is returned and whether the tree is cleared on QueryInterface. And I forgot to mention that calling Release on the IStream interface is the correct way of disposin

Re: IStream interface for domdoc and terminate call

OK, sorry I didn't realized that you try to modify the Wine implementation. I think that delaying pasing for the fist time you call a method of the DOMDocument object would be a good solution. This way you will not perform any unnecessary parings. I don't know the exact details of MS implementa

Re: IStream interface for domdoc and terminate call

Hi, If you mean passing an IStream interface to DOMDocument.save method: As far as I know save method is synchronous (if I'm wrong you still can set the async property to FALSE). So when the save method returns you know that the entire document has been passed to the IStream. If you want to do

IStream interface for domdoc and terminate call

Hi, I try make IStream write interface for domdoc (msxml3). Problem is that microsoft doesn't have terminate string for write call and libxml have proble with it (more at http://mail.gnome.org/archives/xml/2008-February/msg00052.html ). Does anyone has any idea how solve it? (test in each dom c

Re: pdh[3:3]: remove unnecessary tests doneinPdhLookupPerfNameByIndexW

"Jeff Latimer" <[EMAIL PROTECTED]> wrote: > I think it will be better to pass > machine in this case. Yes, it just needs to be converted to unicode first. -- Dmitry.

Re: pdh[3:3]: remove unnecessary tests doneinPdhLookupPerfNameByIndexW

Dmitry Timoshkov wrote: > That's true for index, but not for machine. You are correct. I will resubmit. I think it will be better to pass machine in this case. Jeff

Re: pdh[3:3]: remove unnecessary tests doneinPdhLookupPerfNameByIndexW

"Jeff Latimer" <[EMAIL PROTECTED]> wrote: > My understanding of your question is: if I am removing the tests in one > place then they should not be be necessary in the other. This is not > the case. A call to PdhLookupPerfNameByIndexA will call > PdhLookupPerfNameByIndexW and thus execute the

Re: pdh[3:3]: remove unnecessary tests done inPdhLookupPerfNameByIndexW

Dmitry Timoshkov wrote: > "Jeff Latimer" <[EMAIL PROTECTED]> wrote: > -if (machine) -{ -FIXME("remote machine not supported\n"); -return PDH_CSTATUS_NO_MACHINE; -} - if (!buffer || !size) return PDH_INVALID_ARGUMENT; -if (!

Re: [1/9] WineD3D: Add a test for the vFace register

On 11/02/2008, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > /* TODO: vFace (ps_3_0) */ You should probably remove that one :-)