Patch tracking system - again...

2008-02-07 Thread Steven Edwards
Hi, I'm not sure if this would even really be of use with most of the development being done on git anyway, but after re-reading the governance thread when the point of patch tracking was brought up, It got me thinking. last time around it got shelved as normal due to not wanting to disrupt Alexand

Re: Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-07 Thread Dmitry Timoshkov
"Bang Jun-young" <[EMAIL PROTECTED]> wrote: >> People prefer to follow Alexandre's tree but nobody forces them to use it. > > If winehq.org is Alexandre's own property, this is something > fundametally wrong again. You may try to learn how things work in the Wine project by reading the following

re: Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-07 Thread Dan Kegel
Bang Jun-young wrote: >In fact, this is a well known mistake many newbie Win32 developers >make (and fix in minutes). It shouldn't have been in the tree in the >first place if he actually have read the patch. There are a lot of >easily catchable bugs in the tree, for example, potential security >ho

Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-07 Thread Bang Jun-young
On 2/7/08, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > Bang Jun-young wrote: > > On 2/7/08, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > >> "Bang Jun-young" <[EMAIL PROTECTED]> writes: > >> > >>> 18 hours passed, and it looks like Alexandre decided to ignore this...why? > >>> > >>> This fix i

Re: comctl32: Fix invalid syntax.

2008-02-07 Thread Michael Stefaniuc
Bang Jun-young wrote: > On 2/7/08, Alexandre Julliard <[EMAIL PROTECTED]> wrote: >> "Bang Jun-young" <[EMAIL PROTECTED]> writes: >> >>> 18 hours passed, and it looks like Alexandre decided to ignore this...why? >>> >>> This fix is required for Wine to be built with VC2005/2008 (although >>> Alexand

Re: comctl32: Fix invalid syntax.

2008-02-07 Thread Bang Jun-young
On 2/7/08, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "Bang Jun-young" <[EMAIL PROTECTED]> writes: > > > 18 hours passed, and it looks like Alexandre decided to ignore this...why? > > > > This fix is required for Wine to be built with VC2005/2008 (although > > Alexandre doesn't seem to care ab

Re: gdi32: correct the test message in font.c that was out of sync with the test. [RESEND]

2008-02-07 Thread Reece Dunn
On 07/02/2008, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "Reece Dunn" <[EMAIL PROTECTED]> writes: > > > diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c > > index 7e560d2..bfdb0af 100644 > > --- a/dlls/gdi32/tests/font.c > > +++ b/dlls/gdi32/tests/font.c > > @@ -604,7 +604,7 @@

Re: user32: make the listbox tests pass in directories other than dlls/user32/tests. [RESEND]

2008-02-07 Thread Alexandre Julliard
"Reece Dunn" <[EMAIL PROTECTED]> writes: > diff --git a/dlls/user32/tests/listbox.c b/dlls/user32/tests/listbox.c > index 3645190..f1a7b2b 100644 > --- a/dlls/user32/tests/listbox.c > +++ b/dlls/user32/tests/listbox.c > @@ -560,6 +560,8 @@ static void test_listbox_LB_DIR() > char * p; >

Re: gdi32: correct the test message in font.c that was out of sync with the test. [RESEND]

2008-02-07 Thread Alexandre Julliard
"Reece Dunn" <[EMAIL PROTECTED]> writes: > diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c > index 7e560d2..bfdb0af 100644 > --- a/dlls/gdi32/tests/font.c > +++ b/dlls/gdi32/tests/font.c > @@ -604,7 +604,7 @@ static void test_GetGlyphIndices(void) > flags |= GGI_MARK_NONEXISTIN

Re: shell32: Fix security issue in SHELL_execute.

2008-02-07 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > execfunc should not be called on files which aren't supposed to be > executable. This doesn't work: ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so shlexec.c && touch shlexec.ok shlexec.c:971: Test failed: ShellEx

Re: msi 2: Handle carriage returns in MsiDatabaseImport

2008-02-07 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > Hi, > > Fixes bug 11479. http://bugs.winehq.org/show_bug.cgi?id=11479 This doesn't work: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so automation.c && touch automation.ok automation.c:276: Test failed: Expected ERROR_S

Re: 2/2 start.exe: Handle the process title argument (try3)

2008-02-07 Thread Alexandre Julliard
Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes: > + vi.dwOSVersionInfoSize = sizeof(vi); > + GetVersionExW(&vi); > + > + /* On Windows 9x start does not have the process title argument. > +It works such that if the first parameter begins with a double quote > ("), > +

Re: systray[3/4]: Better validate icon owner

2008-02-07 Thread Robert Shearman
Reece Dunn wrote: > On 06/02/2008, Robert Shearman <[EMAIL PROTECTED]> wrote: > >> PostMessage should correctly >> handle the case where icon->owner has been destroyed and adding a call >> to IsWindow just introduces a race condition. >> > > Is there a test case in the PostMessage tests to

Re: systray[3/4]: Better validate icon owner

2008-02-07 Thread Robert Shearman
Kirill K. Smirnov wrote: >> I don't get why you need this change. PostMessage should correctly >> handle the case where icon->owner has been destroyed and adding a call >> to IsWindow just introduces a race condition. >> > > Just a testcase: > 1) run any wine app (to be sure that explorer is r

Re: x11drv: implement X11DRV_AlphaRender for non bitmap sources

2008-02-07 Thread Alexandre Julliard
Aric Stewart <[EMAIL PROTECTED]> writes: > @@ -1569,12 +1570,14 @@ BOOL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT > xDst, INT yDst, INT widthDst, > > if (!devSrc->bitmap || GetObjectW( devSrc->bitmap->hbitmap, sizeof(dib), > &dib ) != sizeof(dib)) > { > -FIXME("not a dibs

Re: [PATCH] dinput: Skip old mouse movement evenets.

2008-02-07 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > @@ -280,6 +281,9 @@ static void dinput_mouse_hook( LPDIRECTINPUTDEVICE8A > iface, WPARAM wparam, LPARA > { > POINT pt, pt1; > > +/* Skip old movement events */ > +if (This->last_event_time > hook->time)

Re: regression in worms2

2008-02-07 Thread Olaf Leidinger
Hello! > The same bug happens in Patrician3.exe > If you apply the attached patch if should be ok. > > Please let me know, if that worked also for you. I already tried this work-around and it makes the game work. Alexandre Julliard also proposed a patch which works fine, please have a look at b

Re: regression in worms2

2008-02-07 Thread Dmitry Timoshkov
<[EMAIL PROTECTED]> wrote: > The same bug happens in Patrician3.exe > If you apply the attached patch if should be ok. That bug should be fixed in git. This is not an appropriate place to report the bugs, use bugzilla instead. -- Dmitry.

regression in worms2

2008-02-07 Thread luis . busquets
The same bug happens in Patrician3.exe If you apply the attached patch if should be ok. Please let me know, if that worked also for you. b60b43c523aff32358b143672e59d5952587da39.diff Description: Binary data

Re: comctl32: Fix invalid syntax.

2008-02-07 Thread Alexandre Julliard
"Bang Jun-young" <[EMAIL PROTECTED]> writes: > 18 hours passed, and it looks like Alexandre decided to ignore this...why? > > This fix is required for Wine to be built with VC2005/2008 (although > Alexandre doesn't seem to care about it). There's no need to count the hours, or to ask every day, e