Re: comctl32: Fix invalid syntax.

2008-02-06 Thread Bang Jun-young
18 hours passed, and it looks like Alexandre decided to ignore this...why? This fix is required for Wine to be built with VC2005/2008 (although Alexandre doesn't seem to care about it). On 2/6/08, Bang Jun-young <[EMAIL PROTECTED]> wrote: > Any reason why this hasn't been committed? >

Re: systray[3/4]: Better validate icon owner

2008-02-06 Thread Reece Dunn
On 06/02/2008, Robert Shearman <[EMAIL PROTECTED]> wrote: > Kirill K. Smirnov wrote: > > @@ -131,15 +130,18 @@ static LRESULT WINAPI adaptor_wndproc(HW > > case WM_LBUTTONDBLCLK: > > case WM_RBUTTONDBLCLK: > > case WM_MBUTTONDBLCLK: > > -/* notify the owner hw

Re: systray[2/4]: correctly handle icon addition/deletion

2008-02-06 Thread James Hawkins
On Feb 6, 2008 6:24 PM, Kirill K. Smirnov <[EMAIL PROTECTED]> wrote: > В сообщении от Thursday 07 February 2008 02:58:42 вы написали: > > > Kirill K. Smirnov wrote: > > > @@ -71,6 +71,12 @@ struct icon > > > static struct tray tray; > > > static BOOL hide_systray; > > > > > > +static BOOL add_ico

Re: systray[3/4]: Better validate icon owner

2008-02-06 Thread Kirill K. Smirnov
> I don't get why you need this change. PostMessage should correctly > handle the case where icon->owner has been destroyed and adding a call > to IsWindow just introduces a race condition. Just a testcase: 1) run any wine app (to be sure that explorer is running), e.g winecfg 2) run taskmgr 3) s

Re: systray[2/4]: correctly handle icon addition/deletion

2008-02-06 Thread Kirill K. Smirnov
В сообщении от Thursday 07 February 2008 02:58:42 вы написали: > Kirill K. Smirnov wrote: > > @@ -71,6 +71,12 @@ struct icon > > static struct tray tray; > > static BOOL hide_systray; > > > > +static BOOL add_icon(NOTIFYICONDATAW *nid); > > +static BOOL modify_icon(NOTIFYICONDATAW *nid); > > +sta

Re: systray[1/4]: rewrite tooltips support

2008-02-06 Thread Kirill K. Smirnov
> Please explain better what you are doing, "rewrite tooltips support" > doesn't say what is changing or why the change is needed (and "rewrite" > is an exaggeration, you are mostly just moving code around). The main issue this patch fixes is an "attempt to set/modify a tooltip to a nonexistent

Re: systray[2/4]: correctly handle icon addition/deletion

2008-02-06 Thread Robert Shearman
Kirill K. Smirnov wrote: > @@ -71,6 +71,12 @@ struct icon > static struct tray tray; > static BOOL hide_systray; > > +static BOOL add_icon(NOTIFYICONDATAW *nid); > +static BOOL modify_icon(NOTIFYICONDATAW *nid); > +static BOOL delete_icon(const NOTIFYICONDATAW *nid); > +static BOOL delete_icon_

Re: systray[3/4]: Better validate icon owner

2008-02-06 Thread Robert Shearman
Kirill K. Smirnov wrote: > @@ -131,15 +130,18 @@ static LRESULT WINAPI adaptor_wndproc(HW > case WM_LBUTTONDBLCLK: > case WM_RBUTTONDBLCLK: > case WM_MBUTTONDBLCLK: > -/* notify the owner hwnd of the message */ > -WINE_TRACE("relaying 0x%x\n", msg)

Re: systray[1/4]: rewrite tooltips support

2008-02-06 Thread Alexandre Julliard
"Kirill K. Smirnov" <[EMAIL PROTECTED]> writes: > diff --git a/programs/explorer/systray.c b/programs/explorer/systray.c Please explain better what you are doing, "rewrite tooltips support" doesn't say what is changing or why the change is needed (and "rewrite" is an exaggeration, you are mostly

Re: Building tests with Visual Studio 2005 Express

2008-02-06 Thread Detlef Riekenberg
On Mi, 2008-02-06 at 07:28 +, Reece Dunn wrote: > On 06/02/2008, Dan Kegel <[EMAIL PROTECTED]> wrote: > > I tried Visual Studio 2005. > > Do you know where the Express download is for this, as I can only find > VS 2008 Express? Download Page for "Visual * 2005 Express Edition": http://www.mic

Re: added wgl_bind_to_texture_depth_nv to ConvertAttribWGLtoGLX

2008-02-06 Thread Chris Robinson
On Wednesday 06 February 2008 11:44:58 am you wrote: > Chris Robinson wrote: > > I don't think it's correct to add this since it's not supported (the > > extension string isn't exported and it can't be easilly emulated). If an > > app is trying to set that attribute without the extension being > >

Re: Stupid new winetricks: added a trivial GUI

2008-02-06 Thread Dan Kegel
On Feb 6, 2008 4:53 AM, Steven Edwards <[EMAIL PROTECTED]> wrote: > Its actually kind of nice to have a gui for this. Would it be much > trouble to add support for a description field and a default geometry > like the Bordeaux winetricks manager? > > http://bp3.blogger.com/_PpaJ8vsrkzo/R5-1PHBCUrI/

Re: RegOverridePredefKey stub - Take 2

2008-02-06 Thread Dmitry Timoshkov
"Jens Nestler" <[EMAIL PROTECTED]> wrote: > Stub implementation for RegOverridePredefKey. > The added prototype in the winreg.h is now in alphabetical order. Please review yuor patches before sending, this one contains not related changes. -- Dmitry.

Re: [5/8] WineD3D: Add infrastructure for faking driver versions

2008-02-06 Thread Stefan Dösinger
Am Mittwoch, 6. Februar 2008 14:23:02 schrieb Roderick Colenbrander: > > Stefan Dösinger <[EMAIL PROTECTED]> writes: > > > Am Mittwoch, 6. Februar 2008 12:47:37 schrieb Alexandre Julliard: > > >> I don't see the point of going through all that trouble to return the > > >> real driver version on som

Re: [5/8] WineD3D: Add infrastructure for faking driver versions

2008-02-06 Thread Roderick Colenbrander
> Stefan Dösinger <[EMAIL PROTECTED]> writes: > > > Am Mittwoch, 6. Februar 2008 12:47:37 schrieb Alexandre Julliard: > >> I don't see the point of going through all that trouble to return the > >> real driver version on some platforms but not others. Since we have the > >> infrastructure to fake

Re: uxtheme: fix the system tests so they pass on Vista. [try 2] [RESEND]

2008-02-06 Thread Alexandre Julliard
"Reece Dunn" <[EMAIL PROTECTED]> writes: > The Vista return code is what wine is returning, so remove the todo > block as well. Not for me: ../../../tools/runtest -q -P wine -M uxtheme.dll -T ../../.. -p uxtheme_test.exe.so system.c && touch system.ok system.c:420: Test failed: Expected E_POINT

Re: Building tests with Visual Studio 2005 Express

2008-02-06 Thread Reece Dunn
On 06/02/2008, Steven Edwards <[EMAIL PROTECTED]> wrote: > On Feb 6, 2008 2:32 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > On Feb 5, 2008 11:28 PM, Reece Dunn <[EMAIL PROTECTED]> wrote: > > > Do you know where the Express download is for this, as I can only find > > > VS 2008 Express? > > > > Nope

Re: regression in worms2

2008-02-06 Thread José Salavert Torres
Happens the same in "Warcraft 3 : The Frozen Throne", you have to start the application directly from "war3.exe", "Frozen\ Throne.exe" ceased to work. El mar, 05-02-2008 a las 22:14 +0100, Olaf Leidinger escribió: > Hello! > > I noticed that the game "worms 2" broke between wine-0.9.53 and wine-0

Re: Building tests with Visual Studio 2005 Express

2008-02-06 Thread Reece Dunn
On 06/02/2008, Dan Kegel <[EMAIL PROTECTED]> wrote: > After giving up for the moment on building with Visual C 6, > I tried Visual Studio 2005. Do you know where the Express download is for this, as I can only find VS 2008 Express? These links (as well as the Platform SDK stuff) would be useful a

Re: Stupid new winetricks: added a trivial GUI

2008-02-06 Thread Steven Edwards
On Feb 6, 2008 4:38 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Some users freak at the thought of a commandline, > so I threw together a trivial GUI using whatever > gui-from-shell tool is appropriate for the current desktop. > > Unfortunately, that means the default action is to put > up a gui, no

Re: [5/8] WineD3D: Add infrastructure for faking driver versions

2008-02-06 Thread Alexandre Julliard
Stefan Dösinger <[EMAIL PROTECTED]> writes: > Am Mittwoch, 6. Februar 2008 12:47:37 schrieb Alexandre Julliard: >> I don't see the point of going through all that trouble to return the >> real driver version on some platforms but not others. Since we have the >> infrastructure to fake it why not a

Re: [5/8] WineD3D: Add infrastructure for faking driver versions

2008-02-06 Thread Stefan Dösinger
Am Mittwoch, 6. Februar 2008 12:47:37 schrieb Alexandre Julliard: > I don't see the point of going through all that trouble to return the > real driver version on some platforms but not others. Since we have the > infrastructure to fake it why not always use that? We'll have to keep > it up to dat

Re: [5/8] WineD3D: Add infrastructure for faking driver versions

2008-02-06 Thread Alexandre Julliard
Stefan Dösinger <[EMAIL PROTECTED]> writes: > Am Mittwoch, 6. Februar 2008 11:56:40 schrieb Alexandre Julliard: >> The world is not limited to Mac and Linux, this sort of thing can't >> scale. > Official drivers by Nvidia and ATI are limited to Mac, Linux and Windows. > Nvidia has Solaris and Fre

Re: [5/8] WineD3D: Add infrastructure for faking driver versions

2008-02-06 Thread Stefan Dösinger
Am Mittwoch, 6. Februar 2008 11:56:40 schrieb Alexandre Julliard: > The world is not limited to Mac and Linux, this sort of thing can't > scale. Official drivers by Nvidia and ATI are limited to Mac, Linux and Windows. Nvidia has Solaris and FreeBSD drivers drivers as well, so maybe the Linux nam

Re: winedbg - using pdb from Visual Studio 2005

2008-02-06 Thread Francois Gouget
On Tue, 5 Feb 2008, Eric Pouech wrote: [...] > that's to be looked at and is the cause of your problems > can you send me your mydll.pdb file ? (off mailing list) On a somewhat related subject, do you know if the performance issues related to our handling of the PDBs hashtables has been fixed? T

Re: dlls/gdi32/font.c warning removal (RESEND)

2008-02-06 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > The reason is that we have > > #define HDPTOLP(y) ((y<0)? \ > (-abs(INTERNAL_YDSTOWS(dc, (y: \ > (abs(INTERNAL_YDSTOWS(dc, (y) > > which is overly complicated fo

Re: [5/8] WineD3D: Add infrastructure for faking driver versions

2008-02-06 Thread Alexandre Julliard
Stefan Dösinger <[EMAIL PROTECTED]> writes: > +/* Certain applications(Steam) complain if we report an outdated driver > version. In general, > + * reporting a driver version is moot because we are not the Windows driver, > and we have different > + * bugs, features, etc. > + * > + * Some driver

Re: [winetest] Add a new utility to simply running + submitting tests via winetest when run from the Wine tree.

2008-02-06 Thread Alexandre Julliard
Jeremy White <[EMAIL PROTECTED]> writes: > +date +%Y%m%d >build.id > +gcc --version >build.nfo > +uname -a >>build.nfo > +/lib/libc.so.6 >>build.nfo > +echo N/A >tests.url > +make dist > +make > +export WINEPREFIX=`mktemp -d` > +wineprefixcreate > + > +type winetricks >/dev/null 2>&1 > +if [ $? -e

Stupid new winetricks: added a trivial GUI

2008-02-06 Thread Dan Kegel
Some users freak at the thought of a commandline, so I threw together a trivial GUI using whatever gui-from-shell tool is appropriate for the current desktop. Unfortunately, that means the default action is to put up a gui, not show help. You have to say winetricks -h or the like to get help. It

Re: Building tests with Visual Studio 2005 Express

2008-02-06 Thread Steven Edwards
On Feb 6, 2008 2:32 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Feb 5, 2008 11:28 PM, Reece Dunn <[EMAIL PROTECTED]> wrote: > > Do you know where the Express download is for this, as I can only find > > VS 2008 Express? > > Nope. I just happen to have an old copy. My copy of 2008 or 2009 cannot

Re: Bug in patch winex11.drv: Don't create a win_data structure for the desktop window, except in the process that owns it.

2008-02-06 Thread luis . busquets
It is the smae bug as 11340. The game executes binkplayer.exe and both processes become stuck. If you kill one of them, the other executes correctly (binkplayer.exe=plays a movie and stops, Patrician3.exe=begins the game) If you apply the patch that I have mentioned in the bug, the problem is solve