Re: Resend patch from Norbert

2008-02-02 Thread Vitaliy Margolen
Rico Schüller wrote: > Hi, > > I only resend a patch because it isn't in the todays git and the author > didn't answer for a while. > > Cheers > Rico > > > > > > -memcpy(pRect, &This->updateStateBlock->scissorRect,

Re: winex11.drv: Use bitwise NOT not logical NOT

2008-02-02 Thread Andrew Talbot
Vitaliy Margolen wrote: > Marcus Meissner wrote: >> On Sat, Feb 02, 2008 at 05:43:27PM +, Andrew Talbot wrote: > Correct. What all that meant, is if app asks for something, but the value > is > 0, switch to default mode. > Yes. I wrongly mistook it to be a case of setting one group of fla

Re: winex11.drv: Use bitwise NOT not logical NOT

2008-02-02 Thread Andrew Talbot
Marcus Meissner wrote: > I do not think this is right, def_mode is a boolean and we actually check > for not-0-being of various struct members. > > Ciao, Marcus Hi Marcus, You are correct. I should have studied the code more carefully. Thanks, -- Andy.

Re: winex11.drv: Use bitwise NOT not logical NOT

2008-02-02 Thread Vitaliy Margolen
Marcus Meissner wrote: > On Sat, Feb 02, 2008 at 05:43:27PM +, Andrew Talbot wrote: >> Changelog: >> winex11.drv: Use bitwise NOT not logical NOT. >> >> diff --git a/dlls/winex11.drv/settings.c b/dlls/winex11.drv/settings.c >> index d68b674..2cd36c7 100644 >> --- a/dlls/winex11.drv/settings

Re: winex11.drv: Use bitwise NOT not logical NOT

2008-02-02 Thread Marcus Meissner
On Sat, Feb 02, 2008 at 05:43:27PM +, Andrew Talbot wrote: > Changelog: > winex11.drv: Use bitwise NOT not logical NOT. > > diff --git a/dlls/winex11.drv/settings.c b/dlls/winex11.drv/settings.c > index d68b674..2cd36c7 100644 > --- a/dlls/winex11.drv/settings.c > +++ b/dlls/winex11.drv/se