Re: Add GdipSetStringFormatFlags stub

2008-01-29 Thread Dmitry Timoshkov
"Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote: > +GpStatus WINGDIPAPI GdipSetStringFormatFlags(GDIPCONST GpStringFormat > *format, INT flags) > +{ > +FIXME("format (%d) flags (%d)\n", (int)(format), flags); Please try to avoid the casts in traces, especially casting a pointer to an int,

Re: 2/2 start.exe: Handle the process title argument (try3)

2008-01-29 Thread Dmitry Timoshkov
"Alexander Nicolaysen Sørnes" <[EMAIL PROTECTED]> wrote: > try 2 (thanks to Dmitry & Detlef) > > - Use GlobalFree instead of LocalFree > - Fix indentation > - Remove part of a comment > > try 3 > - Use LocalFree, fixing CommandLineToargvW first The following question from my original review stil

Re: start.exe: Handle the process title argument (try2)

2008-01-29 Thread Alexander Nicolaysen Sørnes
On Tuesday 29 January 2008 04:10:34 Dmitry Timoshkov wrote: > "Alexander Nicolaysen Sørnes" <[EMAIL PROTECTED]> wrote: > > - Use GlobalFree instead of LocalFree > > According to MSDN LocalFree is the correct one, as I asked before > you need to fix Wine implementation of CommandLineToArgvW. Sorry

Re: d3dx: A few last questions...

2008-01-29 Thread Luis C. Busquets Pérez
I have submitted a patch for this function and it is easily convertable to the 13 different functions. Anyway, propose another patch for it and let it be implemented. [EMAIL PROTECTED] escribió: The function D3DXCheckVersion must not be forwarded from each d3dx9_xx file to the 36 because D3DX_

Re: shell32:shlfileop - interactive dialogs on Windows Vista

2008-01-29 Thread Reece Dunn
On 27/01/2008, Reece Dunn <[EMAIL PROTECTED]> wrote: > Hi, > > One of the new features of Windows Vista is to bring up dialogs > whenever you are copying files, moving files, etc. to ask the user > what behaviour they want (e.g. move and replace; don't move; move, but > keep both files). > > This m

Re: user32: understanding the HiliteMenuItem failures (all platforms)... call for help

2008-01-29 Thread Reece Dunn
On 26/01/2008, Reece Dunn <[EMAIL PROTECTED]> wrote: > Hi, > > I am currently looking at the user32: menu (HiliteMenuItem) test failures: > > menu.c:1884: Test failed: HiliteMenuItem: Item 1 is not hilited > menu.c:1891: Test failed: HiliteMenuItem: Item 3 is not hilited > > 1. These are failing c

Re: ddraw: ddrawmodes test failures (all platforms)

2008-01-29 Thread Reece Dunn
On 26/01/2008, Paul Vriens <[EMAIL PROTECTED]> wrote: > Stefan Dösinger wrote: > > Am Samstag, 26. Januar 2008 13:20:44 schrieb Henning Gerhardt: > >> Am 01/26/2008 12:50 PM schrieb Stefan Dösinger: > >>> Am Samstag, 26. Januar 2008 12:05:09 schrieb Reece Dunn: > Hi, > > Looking at t

Re: ddraw: ddrawmodes test failures (all platforms)

2008-01-29 Thread Stefan Dösinger
Am Dienstag, 29. Januar 2008 19:16:38 schrieb Reece Dunn: > On 26/01/2008, Paul Vriens <[EMAIL PROTECTED]> wrote: > > Stefan Dösinger wrote: > > > Am Samstag, 26. Januar 2008 13:20:44 schrieb Henning Gerhardt: > > >> Am 01/26/2008 12:50 PM schrieb Stefan Dösinger: > > >>> Am Samstag, 26. Januar 200

RE: d3dx: A few last questions...

2008-01-29 Thread tony . wasserka
> The function D3DXCheckVersion must not be forwarded from each d3dx9_xx file > to the 36 because D3DX_SDK_VERSION changes for each file. Thanks for your comment, though I don't know if this is needed: Comment from the d3dx9core.h of the DX SDK: > ///

Re: Wine Wiki spam users

2008-01-29 Thread Michael Stefaniuc
Vitaliy Margolen wrote: > Does anyone have a power to block / remove those users that spam Wine wiki? > It seems just 2-3 users keep creating more and more spam. Can't we just > remove them and permanently block an IP range? I wonder if we should enable moderation of account creations and spread

Re: Mail flood from the uncoordinated bugzilla cleanup

2008-01-29 Thread Dan Kegel
On Jan 29, 2008 8:36 AM, Detlef Riekenberg <[EMAIL PROTECTED]> wrote: > The flood was to fast to stop Mail-delivery in wine-bugs. > After i stopped Mail-delivery in wine-bugs, the sending queue was still > so full, that my Mailbox got flood again and the bounce rate reached the > limit and mailman

RE: d3dx: A few last questions...

2008-01-29 Thread Luis C. Busquets Pérez
The function D3DXCheckVersion must not be forwarded from each d3dx9_xx file to the 36 because D3DX_SDK_VERSION changes for each file.

Mail flood from the uncoordinated bugzilla cleanup

2008-01-29 Thread Detlef Riekenberg
Grrr. Please remember, that some Free Mail accounts have a limit in the numbers of Mails. The flood was to fast to stop Mail-delivery in wine-bugs. After i stopped Mail-delivery in wine-bugs, the sending queue was still so full, that my Mailbox got flood again and the bounce rate reached the limi

re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING

2008-01-29 Thread Dan Kegel
James McKenzie wrote: > Please submit a git diff not a UNIX diff. Now, hang on there. Jens submitted a perfectly good unified diff patch taken from the right directory. There is no reason to turn up our noses at it. It will apply using patch in exactly the same way as a diff generated by git. Je

Re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING

2008-01-29 Thread James McKenzie
Jens Nestler wrote: > Am Dienstag, 29. Januar 2008 09:07:16 schrieb Rolf Kalbermatter: > >> Jens Nestler wrote: >> >>> [Patch for Bug 8551] MoveFileWithProgressW >>> unconditional fails fordirectories with flag MOVEFILE_REPLACE_EXISTING >>> >>> http://bugs.winehq.org/show_bug.cgi?id=8551 >>

Re: RegOverridePredefKey stub

2008-01-29 Thread Dmitry Timoshkov
"Jens Nestler" <[EMAIL PROTECTED]> wrote: > Sorry, I haven't seen it. > Can you please change it, or should I deliver a changed patch ? Please resend and updated patch with a 'Take 2' in the subject and an explanation in the body what's changed. -- Dmitry.

comctl32 failures on Win95, Win98, NT4 asnd Win2K

2008-01-29 Thread Reece Dunn
These tests are all failing consistently with identical failures on these platforms: combobox - 21 failures; all identical across the platforms. datetime - 2 failures; all identical across the platforms. The rebar tests have 146 failures on some (Win95 and NT4) and 545 failures on others (

Re: RegOverridePredefKey stub

2008-01-29 Thread Jens Nestler
Am Dienstag, 29. Januar 2008 07:07:26 schrieb Dmitry Timoshkov: > "Jens Nestler" <[EMAIL PROTECTED]> wrote: > > diff -urN wine-0.9.54_org/include/winreg.h wine-0.9.54/include/winreg.h > > --- wine-0.9.54_org/include/winreg.h 2008-01-25 17:05:38.0 +0100 > > +++ wine-0.9.54/include/winreg.h 2

Re: comctl32 failures on Win95, Win98, NT4 asnd Win2K

2008-01-29 Thread Paul Vriens
Reece Dunn wrote: > These tests are all failing consistently with identical failures on > these platforms: > combobox - 21 failures; all identical across the platforms. > datetime - 2 failures; all identical across the platforms. > > The rebar tests have 146 failures on some (Win95 and NT4

Wine BOF at Scale 6X in Los Angeles, Feb 8th

2008-01-29 Thread Dan Kegel
Anyone going to Scale in Los Angeles? I've scheduled a Wine BOF at 7pm on Friday, Feb 8th; see http://www.socallinuxexpo.org/scale6x/conference-info/social-events/birds-of-a-feather/ For those who don't know, SCALE is the brightest spot in Los Angeles' open source / free software scene. They've be

Re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING

2008-01-29 Thread Jens Nestler
Am Dienstag, 29. Januar 2008 09:07:16 schrieb Rolf Kalbermatter: > Jens Nestler wrote: > > [Patch for Bug 8551] MoveFileWithProgressW > > unconditional fails fordirectories with flag MOVEFILE_REPLACE_EXISTING > > > > http://bugs.winehq.org/show_bug.cgi?id=8551 > > > > Hello, > > > > please find att

Re: No new winetest?

2008-01-29 Thread Reece Dunn
On 26/01/2008, Francois Gouget <[EMAIL PROTECTED]> wrote: > On Fri, 25 Jan 2008, Paul Millar wrote: > [...] > > The front-end machine had stopped responding to network traffic. > [...] > > So, sorry, winetest will be off-line until Monday at the earliest. > > Thanks for the status update. Is there

RE: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails fordirectories with flag MOVEFILE_REPLACE_EXISTING

2008-01-29 Thread Rolf Kalbermatter
Jens Nestler wrote: > [Patch for Bug 8551] MoveFileWithProgressW > unconditional fails fordirectories with flag MOVEFILE_REPLACE_EXISTING > > http://bugs.winehq.org/show_bug.cgi?id=8551 > > Hello, > > please find attached the patch for the bug mentioned above. Hi Jens, Please diff your patch

Re: RegOverridePredefKey stub

2008-01-29 Thread Dmitry Timoshkov
"Jens Nestler" <[EMAIL PROTECTED]> wrote: > diff -urN wine-0.9.54_org/include/winreg.h wine-0.9.54/include/winreg.h > --- wine-0.9.54_org/include/winreg.h 2008-01-25 17:05:38.0 +0100 > +++ wine-0.9.54/include/winreg.h 2008-01-28 22:07:55.0 +0100 > @@ -131,6 +131,7 @@ > WINADVAPI L

Re: Bugzilla: Remove obsolete components

2008-01-29 Thread James Hawkins
On Jan 28, 2008 1:12 PM, Austin English <[EMAIL PROTECTED]> wrote: > Howdy, > > I just finished moving over the last of the obsolete components. > _obsolete_binary, _obsolete_directx, and _obsolete_gui can all be > removed now. > Also, can you please make the following changes: rename: wineps-dr

Re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING

2008-01-29 Thread James Hawkins
On Jan 28, 2008 4:05 PM, Jens Nestler <[EMAIL PROTECTED]> wrote: > http://bugs.winehq.org/show_bug.cgi?id=8551 > > Hello, > > please find attached the patch for the bug mentioned above. > Please submit a test case for this change as well. -- James Hawkins

Wine Wiki spam users

2008-01-29 Thread Vitaliy Margolen
Does anyone have a power to block / remove those users that spam Wine wiki? It seems just 2-3 users keep creating more and more spam. Can't we just remove them and permanently block an IP range? Vitaliy.

Re: [PATCH 1/1] winecoreaudio: Make sure Port_SendToMessageThread is non-NULL in CoreAudio_WaveRelease.

2008-01-29 Thread Ken Thomases
On Jan 28, 2008, at 8:06 AM, Misha Koshelev wrote: I have started playing with wine on MacOS in VMWare. wineprefixcreate page faults on my MacOS "system" and I tracked it to Port_SendToMessageThread staying NULL because of: err:wave:CoreAudio_WaveInit AudioHardwareGetProperty: CoreAudio_Def

Re: start.exe: Handle the process title argument (try2)

2008-01-29 Thread Dmitry Timoshkov
"Alexander Nicolaysen Sørnes" <[EMAIL PROTECTED]> wrote: > - Use GlobalFree instead of LocalFree According to MSDN LocalFree is the correct one, as I asked before you need to fix Wine implementation of CommandLineToArgvW. -- Dmitry.