Re: system tray icon regression

2008-01-24 Thread Lei Zhang
On Jan 24, 2008 10:05 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Lei wrote: > > With today's wine-git, tray icons no longer work ... > > http://bugs.winehq.org/attachment.cgi?id=9725 > > What bug number is that associated with, btw? > > > That's from bug 10843. This url will show you what bug it's

re: system tray icon regression

2008-01-24 Thread Dan Kegel
Lei wrote: > With today's wine-git, tray icons no longer work ... > http://bugs.winehq.org/attachment.cgi?id=9725 What bug number is that associated with, btw?

Re: gitignore: ignore files generated by the Visual C++ compiler.

2008-01-24 Thread Francois Gouget
On Thu, 24 Jan 2008, Reece Dunn wrote: [...] > and when everything is ok: > > git add . && git status > git commit -m "user32: fixed edit for ." > > which won't work in this case, as the files that cl generates will be > added into the local repository. Then just specify which files to c

Re: user32: make the edit tests pass on Vista.

2008-01-24 Thread Reece Dunn
On 24/01/2008, Reece Dunn <[EMAIL PROTECTED]> wrote: > This adds a return code value returned by Vista in one of the test > cases to fix the uxtheme tests. > > - Reece Ignore this (sent the wrong patch). - Reece

system tray icon regression

2008-01-24 Thread Lei Zhang
Hi, With today's wine-git, tray icons no longer work. There's a spot in the system tray where the icon should be, but nothing is displayed there and I can't interact with it. This occurred on both KDE and Gnome. I found this with Picasa, but you can also see the problem with this sample program:

Re: Assorted spelling fixes

2008-01-24 Thread Kai Blin
On Thursday 24 January 2008 23:25:53 Dan Kegel wrote: > On Jan 24, 2008 2:20 PM, Austin English <[EMAIL PROTECTED]> wrote: > > > I never thought about it before, but "centred" is perfectly fine > > > English, at least in England. > > > Guess I need to add that to stop.txt. > > > > I've never seen i

Re: Assorted spelling fixes

2008-01-24 Thread Austin English
On Jan 24, 2008 4:25 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Jan 24, 2008 2:20 PM, Austin English <[EMAIL PROTECTED]> wrote: > > > I never thought about it before, but "centred" is perfectly fine > > > English, at least in England. > > > Guess I need to add that to stop.txt. > > > > I've neve

Re: [PATCH] fixed potential double free

2008-01-24 Thread Marcus Meissner
On Thu, Jan 24, 2008 at 11:33:46AM +0100, Alexandre Julliard wrote: > Marcus Meissner <[EMAIL PROTECTED]> writes: > > > Coverity spotted that set_window_pos() could call > > free_region() on the same pointer twice. > > > > (CID 671 and 672) > > > > Check that they are different before freeing them

Re: Assorted spelling fixes

2008-01-24 Thread Dan Kegel
On Jan 24, 2008 2:20 PM, Austin English <[EMAIL PROTECTED]> wrote: > > I never thought about it before, but "centred" is perfectly fine > > English, at least in England. > > Guess I need to add that to stop.txt. > > I've never seen it used personally. My test for whether a word is commonly used is

Re: Assorted spelling fixes

2008-01-24 Thread Austin English
On Jan 24, 2008 1:37 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Austin wrote: > >-/* centred vertically and in the right side of the password edit > control */ > >+/* centered vertically and in the right side of the password > edit control */ > > I never thought about it before, but "centre

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-24 Thread Eric Pouech
Jason Green a écrit : > On Jan 23, 2008 3:38 PM, Eric Pouech <[EMAIL PROTECTED]> wrote: > >> Jason Green a écrit : >> thanks for the sample files >> how does this patch solve the issue ? >> A+ >> >> diff --git a/include/wine/mscvpdb.h b/include/wine/mscvpdb.h >> index 58627c0..8a22dfd 100644 >>

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-24 Thread Jason Green
On Jan 23, 2008 3:38 PM, Eric Pouech <[EMAIL PROTECTED]> wrote: > Jason Green a écrit : > thanks for the sample files > how does this patch solve the issue ? > A+ > > diff --git a/include/wine/mscvpdb.h b/include/wine/mscvpdb.h > index 58627c0..8a22dfd 100644 > --- a/include/wine/mscvpdb.h > +++ b/

re: Assorted spelling fixes

2008-01-24 Thread Dan Kegel
Austin wrote: >-/* centred vertically and in the right side of the password edit control */ >+/* centered vertically and in the right side of the password edit control */ I never thought about it before, but "centred" is perfectly fine English, at least in England. Guess I need to add that

Re: gitignore: ignore files generated by the Visual C++ compiler.

2008-01-24 Thread Alexandre Julliard
"Reece Dunn" <[EMAIL PROTECTED]> writes: > and when everything is ok: > > git add . && git status > git commit -m "user32: fixed edit for ." > > which won't work in this case, as the files that cl generates will be > added into the local repository. You should add them to your global .git

What is the commit status of my test fixes?

2008-01-24 Thread Reece Dunn
Hi, what is the status of my recent patches sent to the wine-patches list: ‎user32: make the class tests pass on Vista. [0001-user32-make-the-class-tests-pass-on-Vista.patch] 23 Jan user32: make the clipboard tests pass on Vista. [0001-user32-make-the-clipboard-tests-pass-on-Vista.patch]

Re: gitignore: ignore files generated by the Visual C++ compiler.

2008-01-24 Thread Reece Dunn
On 24/01/2008, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Reece Dunn" <[EMAIL PROTECTED]> wrote: > > > This patch ignores any files generated by the Visual C++ compiler to > > make it easier to generate patches when using the VCExpress family of > > compilers on Windows. > > There is no point i

Re: gitignore: ignore files generated by the Visual C++ compiler.

2008-01-24 Thread Uwe Bonnes
> "Dmitry" == Dmitry Timoshkov <[EMAIL PROTECTED]> writes: Dmitry> "Reece Dunn" <[EMAIL PROTECTED]> wrote: >> This patch ignores any files generated by the Visual C++ compiler to >> make it easier to generate patches when using the VCExpress family of >> compilers on Windows.

wpkg.org, taskkill, reg

2008-01-24 Thread Dan Kegel
I just noticed http://wpkg.org, which has a big library of silent install scripts for many windows apps. Groovy! But the first one I looked at, http://wpkg.org/Picasa, requires the taskkill and reg utilities (part of Windows XP Professional), e.g. taskkill /F /IM "Picasa2.exe" reg delete "HKEY_LOC

Re: gitignore: ignore files generated by the Visual C++ compiler.

2008-01-24 Thread Dmitry Timoshkov
"Reece Dunn" <[EMAIL PROTECTED]> wrote: > This patch ignores any files generated by the Visual C++ compiler to > make it easier to generate patches when using the VCExpress family of > compilers on Windows. There is no point in that, patches should be generated after testing in Wine under a suppo

Re: Basis to accept someone as a maintainer

2008-01-24 Thread Alexander Nicolaysen Sørnes
On Thursday 24 January 2008 03:21:45 Jeff Zaroyko wrote: > Vitaliy Margolen kievinfo.com> writes: > > Recently I've noticed number of random people being accepted as > > maintainers of few apps I'm being a super-maintainer for. First, can the > > appDB send notifications that some one became a mai

Re: user32: make the edit tests pass on Vista.

2008-01-24 Thread Paul Vriens
Reece Dunn wrote: > The EM_CHARFROMPOS calls return different results on Vista. This patch > adds the values returned by Vista as expected results. > > - Reece > > > > > If you change the test for multiple correct answers

RE: shell32: Support getting the shell folder path for users other than the current user and the default user [resend]

2008-01-24 Thread Ge van Geldorp
> From: Alexandre Julliard [mailto:[EMAIL PROTECTED] > > "Ge van Geldorp" <[EMAIL PROTECTED]> writes: > > > +if (! CopySid(SidSize, Sid, UserInfo->User.Sid)) > > +{ > > +HeapFree(GetProcessHeap(), 0, Sid); > > +Sid = NULL; > > +} > > You should return a string direct

Re: gitignore: added the missing include/devenum.h generated file.

2008-01-24 Thread Reece Dunn
On 23/01/2008, Reece Dunn <[EMAIL PROTECTED]> wrote: > The include/devenum.idl file does not have an entry in .gitignore to > prevent the generated file include/devenum.h from being included. This > patch fixes this issue. Please ignore this patch. - Reece

Re: Basis to accept someone as a maintainer

2008-01-24 Thread Jeff Zaroyko
Vitaliy Margolen kievinfo.com> writes: > > Recently I've noticed number of random people being accepted as maintainers > of few apps I'm being a super-maintainer for. First, can the appDB send > notifications that some one became a maintainer? Second, what are the basis > that appDB admins ac

user32: listbox failures

2008-01-24 Thread Reece Dunn
Running the listbox tests from dlls/user32/tests, I don't get any test failures on Vista. Can anyone else confirm this? Also, the LB_DIR failures on http://test.winehq.org/ are due to it looking for files in dlls/user32/tests as part of its test run. Since these are not available when running it a

Re: shell32: Support getting the shell folder path for users other than the current user and the default user [resend]

2008-01-24 Thread Alexandre Julliard
"Ge van Geldorp" <[EMAIL PROTECTED]> writes: >> From: Alexandre Julliard [mailto:[EMAIL PROTECTED] >> You should return a string directly, there's no reason to >> make a copy of the SID. > > There's no way for the caller to free the memory if I return > UserInfo->User.Sid directly. Of course, t

Re: PATCH - makedep, open in binary mode, move the end of file marker

2008-01-24 Thread Alexandre Julliard
"Steven Edwards" <[EMAIL PROTECTED]> writes: > As Julliard did not comment on this, I am assuming either it hit is > garbage filter because it was bad or because it was diffed from cvs. > Resending to hit the garbage filter for bad hacks...As discussed on > wine-devel, if its still not accepted th

Re: shell32: Support getting the shell folder path for users other than the current user and the default user [resend]

2008-01-24 Thread Alexandre Julliard
"Ge van Geldorp" <[EMAIL PROTECTED]> writes: > +static PSID _GetUserFromToken(HANDLE Token) > +{ > +char InfoBuffer[64]; > +PTOKEN_USER UserInfo; > +DWORD InfoSize; > +PSID Sid; > +DWORD SidSize; > + > +UserInfo = (PTOKEN_USER) InfoBuffer; > +if (! GetTokenInformation(T

Re: [PATCH] fixed potential double free

2008-01-24 Thread Alexandre Julliard
Marcus Meissner <[EMAIL PROTECTED]> writes: > Coverity spotted that set_window_pos() could call > free_region() on the same pointer twice. > > (CID 671 and 672) > > Check that they are different before freeing them twice. This can't happen, Coverity is confused. -- Alexandre Julliard [EMAIL PRO

Re: winex11.drv: try work around a crash

2008-01-24 Thread Marcus Meissner
On Thu, Jan 24, 2008 at 10:44:43AM +0100, Marcus Meissner wrote: > On Thu, Jan 24, 2008 at 09:00:32AM +, Louis. Lenders wrote: > > > > Hi, basically this is a resend of a patch i sent very long time ago ( > > http://www.winehq.org/pipermail/wine-patches/2007-April/037733.html ) > > > > It's

Re: winex11.drv: try work around a crash

2008-01-24 Thread Marcus Meissner
On Thu, Jan 24, 2008 at 09:00:32AM +, Louis. Lenders wrote: > > Hi, basically this is a resend of a patch i sent very long time ago ( > http://www.winehq.org/pipermail/wine-patches/2007-April/037733.html ) > > It's a fix for bug http://bugs.winehq.org/show_bug.cgi?id=7380#c29 > > As explain

Re: user32: Test destroying the cursor of a parent process.

2008-01-24 Thread Dmitry Timoshkov
"Andrew Riedi" <[EMAIL PROTECTED]> wrote: >I made some changes from the last time I talked to AJ - mainly exit code > stuff. > > changelog: user32: Test destroying the cursor of a parent process. Also there was a complaint that ok() call ersults in the child process are not included in the final