Re: [PATCH] check for array index overflows

2008-01-14 Thread Marcus Meissner
On Mon, Jan 14, 2008 at 11:57:39PM +0100, H. Verbeet wrote: > On 14/01/2008, Marcus Meissner <[EMAIL PROTECTED]> wrote: > > Hi, > > > > This checks for overflowing the fixed size arrays. > > > > spotted by Coverity. > > > > (Submitted some months ago already, but left in my queue.) > > > > Ciao, Ma

Re: [PATCH] check for array index overflows

2008-01-14 Thread H. Verbeet
On 14/01/2008, Marcus Meissner <[EMAIL PROTECTED]> wrote: > Hi, > > This checks for overflowing the fixed size arrays. > > spotted by Coverity. > > (Submitted some months ago already, but left in my queue.) > > Ciao, Marcus > --- IIRC last time we tested this it was allowed on Windows, and simply c

Re: [hlink] Skip tests if hlink couldn't be created

2008-01-14 Thread Robert Shearman
Dan Kegel wrote: > This makes the test slightly more robust to operator error. > If we're striving to get zero test failures then converting a crash to some failures isn't really much of an improvement. -- Rob Shearman

Re: GDI32.dll.NamedEscape

2008-01-14 Thread Juan Lang
> It appears to be undocumented. Are you using some native DLLs by any chance? I've noticed it's called by some Adobe DLLs, e.g. atmlib.dll, so the same crash can be triggered by installing an app with no native overrides. --Juan

Re: [hlink] Skip tests if hlink couldn't be created

2008-01-14 Thread Dan Kegel
On Jan 14, 2008 1:50 PM, Robert Shearman <[EMAIL PROTECTED]> wrote: > Dan Kegel wrote: > > This makes the test slightly more robust to operator error. > > If we're striving to get zero test failures then converting a crash to > some failures isn't really much of an improvement. The crash was in te

Re: GDI32.dll.NamedEscape

2008-01-14 Thread Robert Shearman
Luis C. Busquets Pérez wrote: > I am having problems with a bunch of three games that came together in > the same pack. They all abort qhen asking for installation with the > following line > > wine: Call from 0x73ba1895 to unimplemented function > GDI32.dll.NamedEscape, aborting > > Does anybod

GDI32.dll.NamedEscape

2008-01-14 Thread Luis C. Busquets Pérez
I am having problems with a bunch of three games that came together in the same pack. They all abort qhen asking for installation with the following line wine: Call from 0x73ba1895 to unimplemented function GDI32.dll.NamedEscape, aborting Does anybody know what GDI32.dll.NamedEscape does? Doe

Re: [PATCH] check for This->frame

2008-01-14 Thread Jacek Caban
Hi Marcus, Marcus Meissner wrote: > Hi, > > Coverity 645 spotted missing This->frame > checks. > > Ciao, Marcus > --- > dlls/mshtml/olecmd.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c > index 326b0b0..02b5e83 10064

Re: Improving Default Serial Port Configuration

2008-01-14 Thread Hans Leidekker
On Monday 14 January 2008 18:46:36 James Hawkins wrote: > > Is there a time frame for the mountmgr.sys changes? Do I need to wait > > until Alexandre makes those changes or could I start working on this > > fix elsewhere and just move it later. I'm not really sure where to > > start and would love

Re: Towards Zero Test Suite Failures

2008-01-14 Thread Stefan Dösinger
Am Montag, 14. Januar 2008 14:41:35 schrieb Reece Dunn: > But if you fix a test failure in Wine that is failing on Windows, then > you are introducing a bug in Wine. Not necessarily. Some tests are too strict in what they expect, and sometimes the Windows behavior is "wrong", in the way that some

WineD3D Spelling Fixes

2008-01-14 Thread Austin English
Any reason this patch wasn't applied? I didn't see any feedback on wine-patches. http://www.winehq.org/pipermail/wine-patches/2008-January/048933.html -Austin

Re: Improving Default Serial Port Configuration

2008-01-14 Thread James Hawkins
On Jan 14, 2008 9:17 AM, Forrest Samuels <[EMAIL PROTECTED]> wrote: > > On Jan 13, 2008 8:39 AM, Hans Leidekker <[EMAIL PROTECTED]> wrote: > > On Sunday 13 January 2008 06:19:06 Forrest Samuels wrote: > > > > > Does anyone have any insight on where I should start looking to > > > implement this? Im

Re: Towards Zero Test Suite Failures

2008-01-14 Thread Reece Dunn
On 14/01/2008, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Jan 13, 2008 8:30 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > > > On my machine, we've been hovering between > > > five and ten test suite failures for some time > > > (see http://bugs.winehq.org/show_bug.cgi?id=9916 ) > > > ... > > > H

Re: Fix texture coordinate calculation in surface_blt_to_drawable

2008-01-14 Thread Roderick Colenbrander
I just wanted to confirm that this patch is correct. Stefan and I talked about it and it should be right. Before the surface rewrite there were two codepaths like this and one of them used integers and the other texture one used floats. During the rewrite they were merged and the combined one us

Re: Towards Zero Test Suite Failures

2008-01-14 Thread Zachary Goldberg
On Jan 14, 2008 11:13 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Jan 14, 2008 5:41 AM, Reece Dunn <[EMAIL PROTECTED]> wrote: > > > But I was only referring to the tests that fail on Wine; there, > > > we have control over both the test and the code, so if > > > we can't get those tests passing,

Overriding comctl32

2008-01-14 Thread Dan Kegel
For future reference: It turns out that installing a native comctl32 and setting overrides for comctl32, as sh winetricks cc580 does, is no longer enough to override comctl32. You also have to remove Wine's sxs manifest for comctl32, too, e.g. rm -rf ~/.wine/drive_c/windows/winsxs/manifests/x86

Good source for msvcr71?

2008-01-14 Thread Dan Kegel
I finally ran into an app that wanted msvcr71 but didn't bundle it (supercopyright). After a few minutes of looking, I couldn't find it anywhere on microsoft.com. The best source I could find was the installer for spambayes 1.1, but that's inconvenient. Anyone know a better source, preferably at

Re: Towards Zero Test Suite Failures

2008-01-14 Thread Dan Kegel
On Jan 14, 2008 5:41 AM, Reece Dunn <[EMAIL PROTECTED]> wrote: > > But I was only referring to the tests that fail on Wine; there, > > we have control over both the test and the code, so if > > we can't get those tests passing, we're pretty weak :-) > > But if you fix a test failure in Wine that is

Re: [PATCH] [DbgHelp]: A couple of enhancements for writing minidumps

2008-01-14 Thread Alexandre Julliard
Eric Pouech <[EMAIL PROTECTED]> writes: > - returning (instead of passing a pointer to) the size of the blocks pointed > by the directories > - now storing the PE version information in module blocks > - fixed an un-initialized field in minidump header > - fixed the suspend count value in thread

Re: Improving Default Serial Port Configuration

2008-01-14 Thread Forrest Samuels
On Jan 13, 2008 8:39 AM, Hans Leidekker <[EMAIL PROTECTED]> wrote: > On Sunday 13 January 2008 06:19:06 Forrest Samuels wrote: > > > Does anyone have any insight on where I should start looking to > > implement this? Implementation suggestions? In the bug, Juan Lang made > > the suggestion that "Ex

Re: Towards Zero Test Suite Failures

2008-01-14 Thread Kuba Ober
[snipsnipsnip] > >>> On my machine, we've been hovering between > >>> five and ten test suite failures for some time > >>> (see http://bugs.winehq.org/show_bug.cgi?id=9916 ) > >>> ... > >>> How 'bout folks spend some time tracking > >>> the current six odd failures down and cleaning them up? > >> >

How to fix bug #11114?

2008-01-14 Thread Markus
Hi, regarding bug #4, can anyone knowledgable in the area tell me how difficult it would be to resolve the issue? As far as I can see, the game World in Conflict is using dxdiag.dll to determine whether a system is capable of running the game. Is there an implementation for this dll at all

Re: dlls/d3d9/tests/visual.c -- address five compiler warnings (RESEND)

2008-01-14 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > @@ -4348,12 +4349,12 @@ static void vshader_version_varying_test > "vs_3_0 returned color 0x%08x, expected 0x00203366\n", color); > color = getPixelColor(device, 160, 360); > ok((color & 0x00ff) >= 0x003c && (color & 0x00ff

Re: entry to add in wine registry

2008-01-14 Thread Stefan Dösinger
Am Montag, 14. Januar 2008 00:29:39 schrieb Jacques Noé: > Hello, > > this is not a patch, but a new entry to add to > http://wiki.winehq.org/UsefulRegistryKeys I have seen that the page is > maintained by > RoderickColenBrander, but I do not know > how to contact him. This is a wiki, you can just

Re: Translation of shell32_Ru.rc (Sorry, last message may be without attach)

2008-01-14 Thread Anatoly Lyutin
Andrey Esin wrote: > Russian translation of untranslated strings: > FCIDM_SHVIEW_OPEN > IDS_OVERWRITEFILE_TEXT > IDS_OVERWRITEFOLDER_TEXT > > Correcting translation of IDS_DELETEMULTIPLE_TEXT (Need need a > closing bracket) > > > Author: Andrey Esin <[EMAIL PROTECTED]> > > ---

Re: autorun perhaps dangerous (Was: Wine release 0.9.53)

2008-01-14 Thread L. Rahyen
On Monday January 14 2008 00:17:53 James McKenzie wrote: > I have found that I CANNOT contribute code to this project. However, > this does not stop me from contributing my USD .02. > > Regedit serves a single purpose, editing the registry. msconfig serves > the purpose of editing the configurati