Re: user32: Add SetProcessDPIAware stub

2008-01-09 Thread Alistair Leslie-Hughes
"Alexandre Julliard" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Alistair Leslie-Hughes <[EMAIL PROTECTED]> writes: > >> diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c >> index 75cb286..ec3a620 100644 >> --- a/dlls/user32/winstation.c >> +++ b/dlls/user32/winst

RE: Advapi32: Service Control RPC

2008-01-09 Thread Rolf Kalbermatter
Robert Shearman [mailto:[EMAIL PROTECTED] wrote: >> The current service control API directly accesses the registry for >> most things. >> In native those fucntions are simple wrappers around RPC calls to the >> actual service.exe application. Mikolaj Zalewski offered about 3 >> months ago a pos

Re: d3dx9: Implement the different dlls

2008-01-09 Thread Maciej Kowalczyk
Hi, As it was in David Adam's patch case, here also you are forwarding d3dx8.D3DXVec3Normalize as D3DXVec2Normalize. I think it's a typo and strikes me so much because it's a first line of the specfile. I'm new to Wine, so please correct me if I'm wrong. Maciej

Fwd: [Bug 114025] Re: Problem with wine preloader: Warning: failed to reserve range 00000000-60000000

2008-01-09 Thread Dan Kegel
Looks like there's a linux platform issue interfering with our preallocations again...? See https://bugs.launchpad.net/bugs/114025 -- Forwarded message -- From: Kees Cook <[EMAIL PROTECTED]> Date: Jan 9, 2008 5:21 PM Subject: [Bug 114025] Re: Problem with wine preloader: Warning: f

Re: Dmitry Timoshkov : gdi32: Add support for scaling font metrics.

2008-01-09 Thread Alistair Leslie-Hughes
> There's already a bug [1] filed for it and Dmitry is in the process of > fixing it. You should give his latest patch [2] a try. This patch does fix the issue. Thanks for point it out. Best Regards Alistair Leslie-Hughes

Re: Dmitry Timoshkov : gdi32: Add support for scaling font metrics.

2008-01-09 Thread Lei Zhang
On Jan 9, 2008 4:19 PM, Alistair Leslie-Hughes <[EMAIL PROTECTED]> wrote: > "Alexandre Julliard" <[EMAIL PROTECTED]> wrote in message > news:[EMAIL PROTECTED] > > Module: wine > > Branch: master > > Commit: 535053b92769ce5f020bb6c5516385cf69da5bf4 > > URL: > > http://source.winehq.org/git/wine.git/

Re: Dmitry Timoshkov : gdi32: Add support for scaling font metrics.

2008-01-09 Thread Alistair Leslie-Hughes
"Alexandre Julliard" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Module: wine > Branch: master > Commit: 535053b92769ce5f020bb6c5516385cf69da5bf4 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=535053b92769ce5f020bb6c5516385cf69da5bf4 > > Author: Dmitry Timoshkov <[EM

Re: Please change Bugzilla email settings for wine-bugs

2008-01-09 Thread Dan Kegel
On Jan 9, 2008 2:28 PM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > If I recall correctly, it was changed to globalwatcher because wine-bugs > wouldn't receive a copy of bug changes any more if the bug wasn't > assigned to him and you didn't explictly add him to cc. Ah. OK, can we put in some

Re: Please change Bugzilla email settings for wine-bugs

2008-01-09 Thread Maarten Lankhorst
Jeremy Newman schreef: > Not easily. Mr. Bugs is set as a globalwatcher in the main prefs. > > 'globalwatchers' > A comma-separated list of users who should receive a copy of every > notification mail the system sends. > > One way I see fixing this is to remove Mr. Bugs from the globalwatcher

Re: shell32: Check if token references the current user

2008-01-09 Thread Juan Lang
Hi Ge, sorry I missed this. I have some stylistic quibbles with your patch: +static PSID GetUserFromToken(HANDLE Token) shellpath.c uses the _ prefix for static functions. It's not pretty, perhaps, but please be consistent. @@ -1371,6 +1417,9 @@ static HRESULT _SHGetUserProfilePath(HANDLE hTok

Re: Please change Bugzilla email settings for wine-bugs

2008-01-09 Thread Jeremy Newman
Not easily. Mr. Bugs is set as a globalwatcher in the main prefs. 'globalwatchers' A comma-separated list of users who should receive a copy of every notification mail the system sends. One way I see fixing this is to remove Mr. Bugs from the globalwatchers and log in as him and check all

Re: Spelling fixes - round 6

2008-01-09 Thread Kuba Ober
On Tuesday 08 January 2008, Dan Kegel wrote: > A few issues: > > 1. > * DPMI_xalloc > - * special virtualalloc, allocates lineary monoton growing memory. > + * special virtualalloc, allocates linear monoton growing memory. > > Um... Probably should be 'linearly'. > But if you're opening

Please change Bugzilla email settings for wine-bugs

2008-01-09 Thread Dan Kegel
Say, could we set Mr. Bugs' email preferences in Bugzilla so that mail is never sent to wine-bugs if the CC field changes? I'm getting mighty tired of clicking on something in the wine-bugs archive and seeing only Jaime Rave changed: What|Removed |Added --

re: shell32: Check if token references the current user

2008-01-09 Thread Dan Kegel
Ge is looking for feedback on this patch, could somebody familiar with the innards of SHGetFolderPath() comment? http://bugs.winehq.org/show_bug.cgi?id=10905#c6 / http://www.winehq.org/pipermail/wine-patches/2007-December/048437.html Thanks, Dan

Re: Advapi32: Service Control RPC

2008-01-09 Thread Robert Shearman
Rolf Kalbermatter wrote: > The current service control API directly accesses the registry for most > things. > In native those fucntions are simple wrappers around RPC calls to the actual > service.exe application. Mikolaj Zalewski offered about 3 months ago a > possible > aproach to implement the

Advapi32: Service Control RPC

2008-01-09 Thread Rolf Kalbermatter
The current service control API directly accesses the registry for most things. In native those fucntions are simple wrappers around RPC calls to the actual service.exe application. Mikolaj Zalewski offered about 3 months ago a possible aproach to implement the service.exe program. In there the pr

RE: Spelling fixes round 6 - resend - don't apply first patch

2008-01-09 Thread Rolf Kalbermatter
James McKenzie: > I am a long time programmer and expect the include to be next > to the # sign. However, you are correct in that it does not > break code, and if it is not broken, why fix? Is it possible > to indent the entire line by two spaces (I think it is not)? Probably not. I know the

Re: [PATCH] wineboot: fix installation of SFP protected files

2008-01-09 Thread Andrey Turkin
Dmitry Timoshkov wrote: > "Andrey Turkin" <[EMAIL PROTECTED]> wrote: > >> +dllcache_wildcard = HeapAlloc(GetProcessHeap(), 0, strlenW( >> dllcache )*sizeof(WCHAR) * sizeof(wildcardW)); > > Aren't there too much of multiplications? > Whoops, second one should be plus instead. Thanks for catchin

Re: [PATCH] wineboot: fix installation of SFP protected files

2008-01-09 Thread Dmitry Timoshkov
"Andrey Turkin" <[EMAIL PROTECTED]> wrote: > +dllcache_wildcard = HeapAlloc(GetProcessHeap(), 0, strlenW( dllcache > )*sizeof(WCHAR) * sizeof(wildcardW)); Aren't there too much of multiplications? -- Dmitry.

Re: d3dx9: Implement the different dlls

2008-01-09 Thread Marcus Meissner
On Wed, Jan 09, 2008 at 03:23:32PM +0100, [EMAIL PROTECTED] wrote: > Oh okay, I resent a fixed patch. > Why isn't it possible to forward the functions of the other dlls to the d3dx8 > ones? > Or is this just for keeping the code clean so that we don't have mixed d3dx8 > and d3dx9_36 forwardings?

Re: d3dx9: Implement the different dlls

2008-01-09 Thread tony . wasserka
Oh okay, I resent a fixed patch. Why isn't it possible to forward the functions of the other dlls to the d3dx8 ones? Or is this just for keeping the code clean so that we don't have mixed d3dx8 and d3dx9_36 forwardings?

Re: gdi32: Fix the regression caused by the scaling font metrics patch

2008-01-09 Thread Alexandre Julliard
Dmitry Timoshkov <[EMAIL PROTECTED]> writes: > Changelog: > gdi32: Fix the regression caused by the scaling font metrics patch. This breaks the tests: ../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.exe.so editor.c && touch editor.ok editor.c:309: Test failed:

Re: user32: Add SetProcessDPIAware stub

2008-01-09 Thread Alexandre Julliard
Alistair Leslie-Hughes <[EMAIL PROTECTED]> writes: > diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c > index 75cb286..ec3a620 100644 > --- a/dlls/user32/winstation.c > +++ b/dlls/user32/winstation.c > @@ -613,3 +613,13 @@ BOOL WINAPI SetUserObjectSecurity( HANDLE handle, > PSECUR

Re: server/token.c -- -Wtype-limits changes

2008-01-09 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > diff -u -3 -p -r1.60 token.c > --- server/token.c6 Dec 2007 14:27:53 - 1.60 > +++ server/token.c7 Jan 2008 13:57:28 - > @@ -515,8 +515,7 @@ struct token *token_duplicate( struct to > struct privilege *privilege; > struct