Re: [PATCH] ddraw: Return a nullpointer as lpSurface in Lock() if the rect is invalid.

Am Mittwoch, 26. Dezember 2007 22:35:16 schrieb Günther Brammer: > +memset(&locked_desc, 1, sizeof(locked_desc)); > +locked_desc.dwSize = sizeof(locked_desc); > + > hr = IDirectDrawSurface_Lock(surface, rect, &locked_desc, > DDLOCK_WAIT, NULL); ok(hr == DDERR_IN

Re: dlls/user32/edit.c -- remove superflous check (RESEND)

On Wed, 26 Dec 2007, Alexandre Julliard wrote: >> dwBufLen already indictes that this variable is of type DWORD and >> thus always positive. I also looked at the implementation of >> ImmGetCompositionStringW() and we do not seem to return a negative >> value (such as -1). > Maybe the implementati

Re: wined3d: dirtify colorkey state in IWineD3DDeviceImpl_SetTexture

Oops, too bad I didn't notice it's supposed to happen in sampler. Why that isn't called - I think it's because that check at line 2415 is inside if(stateblock->textures[sampler]) { block. Since the app is setting texture to NULL, it's not entering. Taking the colorkey part out of this block he

Re: wined3d: dirtify colorkey state in IWineD3DDeviceImpl_SetTexture

Am Donnerstag, 27. Dezember 2007 07:27:21 schrieb Alexander Dorofeyev: > Hi. > > Colorkey emulation by alpha test should be disabled when game sets no > texture (or texture without colorkey) and reenabled when needed. Dirtifying > a state here, so that state_alpha will be called, fixes the problem.

Compile info patch

I've been checking recently, haven't seen any further discussion on this patch, or seen it be committed. Any thoughts on why? I'm curious because I think its useful, and because I wrote a WWN article on it -- which of course only makes sense if the patch is applied :). -- Zachary Goldberg Compu

Re: dlls/d3dx8/math.c -- simple fixup (RESEND)

Gerald Pfeifer <[EMAIL PROTECTED]> writes: > Not a biggie, but still in my queue. If you aren't going to take this > (admittedly) minor patch, please let me know and I'll remove it locally. There's no need to worry about the scope of variables in such a small function. -- Alexandre Julliard [E

Re: dlls/user32/edit.c -- remove superflous check (RESEND)

Gerald Pfeifer <[EMAIL PROTECTED]> writes: > dwBufLen already indictes that this variable is of type DWORD and > thus always positive. I also looked at the implementation of > ImmGetCompositionStringW() and we do not seem to return a negative > value (such as -1). Maybe the implementation doesn

Re: include: added the new Vista theme part and state headers.

On 26/12/2007, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "Reece Dunn" <[EMAIL PROTECTED]> writes: > > > In the SDK, vssym32.h includes vsstyle.h (as is done here). However, > > the SDK has obsoleted tmschema.h, and duplicates the entries > > throughout vsstyle.h and vssym32.h. > > > > Since i

Re: include: added the new Vista theme part and state headers.

"Reece Dunn" <[EMAIL PROTECTED]> writes: > In the SDK, vssym32.h includes vsstyle.h (as is done here). However, > the SDK has obsoleted tmschema.h, and duplicates the entries > throughout vsstyle.h and vssym32.h. > > Since it does not make sense to duplicate the entries (even if > tmschema.h uses

Re: include: added the new Vista messages.

On 26/12/2007, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Reece Dunn" <[EMAIL PROTECTED]> wrote: > > > #define WM_SYSDEADCHAR 0x0107 > > +#define WM_UNICHAR 0x0109 > > #define WM_KEYFIRST WM_KEYDOWN > > -#define WM_KEYLAST 0x0108 > > +#define WM_KEYLAST

Re: include: added the new Vista messages.

"Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > "Reece Dunn" <[EMAIL PROTECTED]> wrote: > >> #define WM_SYSDEADCHAR 0x0107 >> +#define WM_UNICHAR 0x0109 >> #define WM_KEYFIRST WM_KEYDOWN >> -#define WM_KEYLAST 0x0108 >> +#define WM_KEYLAST 0x0109 > > Ple

Re: include: added the new Vista messages.

"Reece Dunn" <[EMAIL PROTECTED]> wrote: > #define WM_SYSDEADCHAR 0x0107 > +#define WM_UNICHAR 0x0109 > #define WM_KEYFIRST WM_KEYDOWN > -#define WM_KEYLAST 0x0108 > +#define WM_KEYLAST 0x0109 Please keep the entries sorted by value. -- Dmitry.