Re: [PATCH] dinput: mouse.c: extracted the warping code into a function, got rid from goto's in alloc_device, and made the code more readable. (no change in functionality)

2007-12-14 Thread Vitaliy Margolen
There is nothing to maintain in that warping code. It needs to be removed you right. But you can do that only after x11drv can properly warp mouse itself (and keep it from leaving Wine window). And for format only changes - read that link. It explains what type of changes you should not send.

Re: ENTER_GL and ActivateContext question

2007-12-14 Thread Alexander Dorofeyev
Hi. Here's preliminary version of a changes to BltOverride/Clear, with Clear subroutine approach discussed previously. Please look through it if you can. Basically everything except a check for error condition and deciding the target surface moved from Clear to subroutine. Another thing I did

Re: [5/5] gdi: Test bitmap depths

2007-12-14 Thread Stefan Dösinger
Am Samstag, 15. Dezember 2007 01:19:05 schrieb Francois Gouget: > On Wed, 12 Dec 2007, Stefan Dösinger wrote: > [...] > > > It is the intention of this patch, and coming ones, to clean up the 24/32 > > bpp mess, also with regard to 15/16 bpp confusion, although I am missing > > hardware capable of

re: winex11.drv:clipboard.c: Adds zero to the end of string.

2007-12-14 Thread Dan Kegel
Anatoly wrote: > We do it to make sure that the strings will terminate by zero. What bug does this fix? Can you add a conformance test? - Dan

Re: [5/5] gdi: Test bitmap depths

2007-12-14 Thread Francois Gouget
On Wed, 12 Dec 2007, Stefan Dösinger wrote: [...] > It is the intention of this patch, and coming ones, to clean up the 24/32 bpp > mess, also with regard to 15/16 bpp confusion, although I am missing hardware > capable of running X at depth 15 for testing, so it will be mainly about the > 24/32

Re: [PATCH] dinput: mouse.c: extracted the warping code into a function, got rid from goto's in alloc_device, and made the code more readable. (no change in functionality)

2007-12-14 Thread Juan Lang
Please bottom-post on this list. > Why are you against changing the format and fixing the mixed using of > tabs and white spaces? That's a rule here. Leaving in extraneous patches will get the patch rejected. If you insist on changing whitespace, do it in a separate patch (which, by the way, wi

Re: [PATCH] dinput: mouse.c: extracted the warping code into a function, got rid from goto's in alloc_device, and made the code more readable. (no change in functionality)

2007-12-14 Thread Adam Rimon
Using gotos is ok, when it's really needed. There is no need to use gotos here - it doesn't save source lines. Why are you against changing the format and fixing the mixed using of tabs and white spaces? Anyway, extracting the warping code into a function makes the warping code more maintainable

Re: Tracking down missing controls (drawn)

2007-12-14 Thread Alistair Leslie-Hughes
"Robert Shearman" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] >> Where can I start to look to workout how to get this control(s) to >> display >> correctly? >> > > It looks like a webpage to me, so mshtml is probably being used. > >From what I have observed it is. Thanks for the

Re: msi: Fix an off-by-one error

2007-12-14 Thread James Hawkins
On Dec 14, 2007 3:18 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > Hi, > > Changelog: > * Fix an off-by-one error. > Please ignore this patch. This whole function needs to be rewritten. -- James Hawkins

Re: [PATCH] dinput: mouse.c: extracted the warping code into a function, got rid from goto's in alloc_device, and made the code more readable. (no change in functionality)

2007-12-14 Thread Vitaliy Margolen
First of all your patch is wrapped. Second, do not send white space changes only. Same for formatting - do not change formatting only. If you can't read it, reformat for yourself, or get used to reading some one else's code. What's wrong with gotos? If you don't like it doesn't mean everyone els

Re: msi valgrind regression around Dec 4th

2007-12-14 Thread James Hawkins
On Dec 14, 2007 1:25 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > This error > Conditional jump or move depends on uninitialised value(s) > at ACTION_AppSearchSigName (appsearch.c:435) > by ITERATE_CCPSearch (appsearch.c:916) > by MSI_IterateRecords (msiquery.c:190) > by ACTION_C

msi valgrind regression around Dec 4th

2007-12-14 Thread Dan Kegel
This error Conditional jump or move depends on uninitialised value(s) at ACTION_AppSearchSigName (appsearch.c:435) by ITERATE_CCPSearch (appsearch.c:916) by MSI_IterateRecords (msiquery.c:190) by ACTION_CCPSearch (appsearch.c:943) by ACTION_HandleStandardAction (action.c:9

docu - broken links

2007-12-14 Thread Rico Schüller
Hi, while I was looking in the docu (html) I found some links that are broken. In some cases these are typos, in other I don't know. Here is a list width broken links, I've found. I would like to fix this. But I don't know which one are typos and which one are broken because the function which is

Re: user32: add tests for handling exposed regions created by other threads

2007-12-14 Thread Clinton Stimpson
Anything wrong with this patch? I'm guessing its the Sleep(). Any other way to force X server to put expose events in the queue, if any? This is for bug #9875. Clinton Stimpson diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 49fe766..0d369c8 100644 --- a/dlls/user32/tests

Re: Undocumented behaviour in ReqQueryValueEx when 'count' and 'type'point to the same address

2007-12-14 Thread Juan Lang
> > +size = 4; > > +ret = RegQueryValueExA(hkey_main, "BIN32", NULL, &size, buffer, &size); > > +ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); > > What this test is supposed to test? It tests the order in which type and count are checked. When type and count are (

Re: Undocumented behaviour in ReqQueryValueEx when 'count' and'type'point to the same address

2007-12-14 Thread Juan Lang
> Shouldn't the test also check for returned values in size and buffer? Yes, I expect so. --Juan

Re: Undocumented behaviour in ReqQueryValueEx when 'count' and'type'point to the same address

2007-12-14 Thread Dmitry Timoshkov
"Juan Lang" <[EMAIL PROTECTED]> wrote: >> > +size = 4; >> > +ret = RegQueryValueExA(hkey_main, "BIN32", NULL, &size, buffer, >> > &size); >> > +ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); >> >> What this test is supposed to test? > > It tests the order in which

Re: dinput - mouse warping -games that needs it?

2007-12-14 Thread Vitaliy Margolen
Adam Rimon wrote: > Hi, > > I'm trying to get rid of the warping patch, or at least to change it to > something that won't make the mouse > stuck in the middle of the screen in some games (Next Life for instance). > > Can you give me names of games that need this warping? > (I had found in the a

Re: [PATCH] use a better size to lstrcpynW

2007-12-14 Thread Alexandre Julliard
Marcus Meissner <[EMAIL PROTECTED]> writes: > -lstrcpynW( num, begin + 1, end - begin ); > -begin += end - begin + 1; > + > +xcnt = end - begin; > +if (xcnt > sizeof(num)/sizeof(WCHAR)) > +xcnt = sizeof(num)/sizeof(WCHAR); > +lstrcpynW( num, beg

Create a 'take bug' option in bugzilla?

2007-12-14 Thread Maarten Lankhorst
Hi all, I'm getting tired of having to do 3 changes to take a bug. First I have to set the status to 'assigned', this makes the bug assigned to wine-bugs. Now that it is assigned, I can set the assignee to my own email address, that automatically changes the status to 'new', and I have to set th

Re: [PATCH 3/4] quartz: make test_aggregation non-static

2007-12-14 Thread Alexandre Julliard
"Lei Zhang" <[EMAIL PROTECTED]> writes: > Hi, > > This lets us call test_aggregation() from other files. In general it's better to avoid sharing functions across tests, it makes it hard to grab a single test and quickly build it on Windows. In this case you could test all the interfaces in the sa

Re: winex11.drv: style changes can change a managed window to unmanaged

2007-12-14 Thread Alexandre Julliard
Ken Thomases <[EMAIL PROTECTED]> writes: > This fixes an issue with Internet Explorer's tooltips. On the Mac, at least, > they steal focus from the main window, disrupting user interaction. This won't work with many window managers; the only way would be to destroy the window and create a brand

Re: ENTER_GL and ActivateContext question

2007-12-14 Thread Stefan Dösinger
Am Freitag, 14. Dezember 2007 10:55:10 schrieb Michael Stefaniuc: > I don't know what you mean with proper inline. It's true that "inline" > is only a hint to the compiler but normally the compiler knows anyway > better what to inline and what not. > > If you really want to force an inline you have

Re: ENTER_GL and ActivateContext question

2007-12-14 Thread Michael Stefaniuc
Stefan Dösinger wrote: > Am Freitag, 14. Dezember 2007 02:46:42 schrieb Ivan Gyurdiev: >> As for the "object oriented programmer" - I would hope every programmer >> thinks in terms of objects, even when writing C code. >> The GLSL backend wouldn't be available today if the shader compiler was >> st

Re: dinput - mouse warping -games that needs it?

2007-12-14 Thread Stefan Dösinger
Am Freitag, 14. Dezember 2007 09:45:48 schrieb Adam Rimon: > Hi, > > I'm trying to get rid of the warping patch, or at least to change it to > something that won't make the mouse > stuck in the middle of the screen in some games (Next Life for instance). > > Can you give me names of games that need

Re: ENTER_GL and ActivateContext question

2007-12-14 Thread Stefan Dösinger
Am Freitag, 14. Dezember 2007 02:46:42 schrieb Ivan Gyurdiev: > Your codebase is constantly getting more complex, and now you're having > threading issues, which will only get more important with multi-core and > other such things becoming standard. Meanwhile graphics cards are > getting a lot mor

Re: dinput - mouse warping -games that needs it?

2007-12-14 Thread Tom Wickline
swat 4 ? On Dec 14, 2007 3:45 AM, Adam Rimon <[EMAIL PROTECTED]> wrote: > Hi, > > I'm trying to get rid of the warping patch, or at least to change it to > something that won't make the mouse > stuck in the middle of the screen in some games (Next Life for instance). > > Can you give me names of g

dinput - mouse warping -games that needs it?

2007-12-14 Thread Adam Rimon
Hi, I'm trying to get rid of the warping patch, or at least to change it to something that won't make the mouse stuck in the middle of the screen in some games (Next Life for instance). Can you give me names of games that need this warping? (I had found in the archives a mention of Quake II, but

Re: Undocumented behaviour in ReqQueryValueEx when 'count' and 'type'point to the same address

2007-12-14 Thread Dmitry Timoshkov
"Sam Dennis" <[EMAIL PROTECTED]> wrote: > +size = 4; > +ret = RegQueryValueExA(hkey_main, "BIN32", NULL, &size, buffer, &size); > +ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); What this test is supposed to test? -- Dmitry.

Re: Tracking down missing controls (drawn)

2007-12-14 Thread Robert Shearman
Alistair Leslie-Hughes wrote: > Hi, > I've manage to get MS Money 2008 loading there sample file, (with some > help from Juan). > Nice work. > The next issue is trying to get the information to display correctly. > > The first image is the one currently running in WINE, and the second is >