Tracking down missing controls (drawn)

2007-12-13 Thread Alistair Leslie-Hughes
Hi, I've manage to get MS Money 2008 loading there sample file, (with some help from Juan). The next issue is trying to get the information to display correctly. The first image is the one currently running in WINE, and the second is within WinXP http://members.dodo.com.au/~lesliehughes/MS_Mo

Re: ENTER_GL and ActivateContext question

2007-12-13 Thread Ivan Gyurdiev
> A lot of code in WineD3D avoids the getters and setters, and just accesses > the > implementation structure. While any object oriented programmer screams when > doing that, we need it for performance reasons. Currently we spend 10 to 20 > per cent of the CPU time spent in WineD3D just in sur

Re: ENTER_GL and ActivateContext question

2007-12-13 Thread Stefan Dösinger
Hi, You are right, there is some problem here. I think that the code originates from times when this codepath in colorfill was only entered when iface == device->render_targets[0], or when Clear didn't set any draw buffer itself. But you have spotted correctly, if iface is the device's front b

Re: ENTER_GL and ActivateContext question

2007-12-13 Thread Alexander Dorofeyev
Hello. I've spent some time trying to get into this stuff and what can be improved in IWineD3DSurfaceImpl_BltOverride. Code that does glDrawBuffer in the Colorfill path and possibly elsewhere indeed appears to be redundant to ActivateContext and probably should go. That's in theory :), in pract

Re: GDI32: GetSystemPaletteEntries should fill with default palette in non-palette video mode (with tests)

2007-12-13 Thread Alex Villací­s Lasso
Alex Villací­s Lasso escribió: > Patches originally by Alexander Dorofeyev <[EMAIL PROTECTED]>. > > This patch tries to fix bug #201 (igowin shows black squares instead > of proper transparency). It was sent back in October, but there was no > feedback back then. So I am resending a rediff agains

Re: Alexandre Julliard : hhctrl.ocx: Store a copy of the string pointers to enable freeing them without casting away const .

2007-12-13 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > Alexandre Julliard wrote: >> hhctrl.ocx: Store a copy of the string pointers to enable freeing them >> without casting away const. > > I've noticed that there is a trend of doing more and more of this type > of fix. Is it really worth the performance

Re: Alexandre Julliard : hhctrl.ocx: Store a copy of the string pointers to enable freeing them without casting away const .

2007-12-13 Thread Robert Shearman
Alexandre Julliard wrote: > hhctrl.ocx: Store a copy of the string pointers to enable freeing them > without casting away const. I've noticed that there is a trend of doing more and more of this type of fix. Is it really worth the performance penalty of doing this instead of adding in an approp

Re: urlmon #1: Fixed handling MIME type in Binding object.

2007-12-13 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > --- > dlls/urlmon/binding.c | 97 > +++- This breaks the tests for me: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmldoc.c && touch htmldoc.ok htmldoc.c:3069: Test fai

Re: shlwapi:ordinal:Add comment to a function. [resend]

2007-12-13 Thread Alexandre Julliard
Anatoly Lyutin <[EMAIL PROTECTED]> writes: > Changelog: > Add comment to a function SHCreateShellPalette(). There's no point in resending doc patches that have clearly been written by looking at the MSDN docs, they won't be applied. -- Alexandre Julliard [EMAIL PROTECTED]

Re: ntoskrnl.exe: DPRINTF -> TRACE.

2007-12-13 Thread Robert Shearman
Andrew Riedi wrote: > -if (TRACE_ON(relay)) > -DPRINTF( "%04x:Call driver dispatch %p (device=%p,irp=%p)\n", > - GetCurrentThreadId(), dispatch, device, &irp ); > +TRACE_(relay)( "%04x:Call driver dispatch %p (device=%p,irp=%p)\n", > + GetCurrentThr

Re: user32: DPRINTF -> TRACE.

2007-12-13 Thread Alexandre Julliard
"Andrew Riedi" <[EMAIL PROTECTED]> writes: > LRESULT ret; > > -if (TRACE_ON(relay)) > -DPRINTF( "%04x:Call hook proc %p > (id=%s,code=%x,wp=%08lx,lp=%08lx)\n", > - GetCurrentThreadId(), proc, hook_names[id-WH_MINHOOK], > code, wparam, lparam ); > +TRACE_(re

Re: Patch for process title on FreeBSD

2007-12-13 Thread Alexandre Julliard
Kris Moore <[EMAIL PROTECTED]> writes: > --- dlls/kernel32/process.c.orig 2007-12-12 12:34:45.0 -0500 > +++ dlls/kernel32/process.c 2007-12-12 12:35:17.0 -0500 > @@ -853,6 +853,11 @@ > */ > static void set_process_name( int argc, char *argv[] ) > { > + > +#if defined(__F

Re: includes: Update oleacc with new constants and iaccessible interface

2007-12-13 Thread Alexandre Julliard
Maarten Lankhorst <[EMAIL PROTECTED]> writes: > +cpp_quote("#define ROLE_SYSTEM_ALERT 8") > +cpp_quote("#define ROLE_SYSTEM_ANIMATION 54") > +cpp_quote("#define ROLE_SYSTEM_APPLICATION 14") > +cpp_quote("#define ROLE_SYSTEM_BORDER 19") > +cpp_quote("#define ROLE_SYSTEM_BUTTONDROPDOWN 56") > +cpp_

Re: [3/4] WineX11: Ignore the alpha if all pixels are 0x00

2007-12-13 Thread Stefan Dösinger
Am Donnerstag, 13. Dezember 2007 05:18:29 schrieb Juan Lang: > Hi Stefan, a few minor nits: > > For the first for loop, you probably want something like (for y = 0; > alpha_zero && y < ymax... > Also, the whitespace around the if is a bit funny. Ah right, it won't drop out of the outer loop of cour