Re: programs/explorer/desktop.c: Add error checking

2007-12-02 Thread Frank Richter
On 01.12.2007 16:20, Vitaly Lipatov wrote: > UuidToStringW from legacy (DCOM95) rpcrt4.dll returns RPC_S_CANNOT_SUPPORT, > works only ANSI version. > > Changelog: > Add return codes checking for UuidCreate and UuidToStringW Do users still commonly install that legacy DCOM? If so, it may be bette

Re: kernel32:add ReadFileScatter

2007-12-02 Thread James Hawkins
On Dec 2, 2007 9:31 PM, Vijay Kiran Kamuju <[EMAIL PROTECTED]> wrote: > > On Dec 3, 2007 5:02 AM, James Hawkins <[EMAIL PROTECTED]> wrote: > > > > On Dec 2, 2007 5:22 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > > Hey Louis, > > > Focht is using a pseudonym, and I believe it's Wine policy to > > >

Re: kernel32:add ReadFileScatter

2007-12-02 Thread Vijay Kiran Kamuju
On Dec 3, 2007 5:02 AM, James Hawkins <[EMAIL PROTECTED]> wrote: > > On Dec 2, 2007 5:22 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > Hey Louis, > > Focht is using a pseudonym, and I believe it's Wine policy to > > not accept patches without real names. > > His patches should be used as guides only

Re: uninstaller: iterate keys in HKEY_CURRENT_USER also as some programs install their uninstall information there

2007-12-02 Thread James Hawkins
On Dec 2, 2007 9:07 PM, Aric Stewart <[EMAIL PROTECTED]> wrote: > --- > programs/uninstaller/main.c | 34 +++--- > 1 files changed, 23 insertions(+), 11 deletions(-) > I'm not saying that this patch shouldn't be accepted, but I want to remark that at some point, al

Re: Remove four useless checks in dlls/gdi32/enhmetafile.c (RESEND)

2007-12-02 Thread Gerald Pfeifer
On Sun, 2 Dec 2007, Alexandre Julliard wrote: > I'm aware of that, but the purpose of having these warnings is to spot > bugs, and when you find a bug you have to fix it. Yes, the checks > currently don't work, so they should be made to work, not removed. As > the comment says, you have to check th

Re: kernel32:add ReadFileScatter

2007-12-02 Thread James Hawkins
On Dec 2, 2007 5:22 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Hey Louis, > Focht is using a pseudonym, and I believe it's Wine policy to > not accept patches without real names. > His patches should be used as guides only, > and should not be reposted to wine-patches, > until such time as he declo

re: kernel32:add ReadFileScatter

2007-12-02 Thread Dan Kegel
Hey Louis, Focht is using a pseudonym, and I believe it's Wine policy to not accept patches without real names. His patches should be used as guides only, and should not be reposted to wine-patches, until such time as he decloaks. If he doesn't want to decloak, I think we can't use his patches. I

Re: Why must the user be the owner of the WINEPREFIX dir?

2007-12-02 Thread Alexandre Julliard
Gabriel Sailer <[EMAIL PROTECTED]> writes: > I used the same WinXX Application with wine for a few people (not > parallel but serialized) in the same group and gave the WINEPREFIX dir > (and all subdirectories and files) to this group. > > Is it really nesseccary to use this protection? Did i get

Re: Remove four useless checks in dlls/gdi32/enhmetafile.c (RESEND)

2007-12-02 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > If we want to add some input checking, I assume you would like to > check that these values are not too large? (They cannot be negative, > so the only range checking we can do is on the upper end.) How should > this look like? Any specific upper bou

Re: Remove four useless checks in dlls/gdi32/enhmetafile.c (RESEND)

2007-12-02 Thread Gerald Pfeifer
On Mon, 19 Nov 2007, Alexandre Julliard wrote: >> I had expected this comment for a different patch of mine. In >> dlls/gdi32/enhmetafile.c we are just reading existing records, >> so I'm not sure what you have in mind here? > The records usually come from an external file, so they have to be > v

Why must the user be the owner of the WINEPREFIX dir?

2007-12-02 Thread Gabriel Sailer
Hello, after an update of wine on my Debian etch i got the error: libwine: Refuse to use a WINEPREFIX dir owned by a different user. I found that there is a patch in Wine release 0.9.49 but i did not found why this patch is needed. Are the linux access rights not secure enough? I have the full a

Re: xdg_user_dirs patches

2007-12-02 Thread Steven Edwards
On Dec 2, 2007 9:16 AM, Francois Gouget <[EMAIL PROTECTED]> wrote: > How does Gnome/KDE know which WINEPREFIX to use for foo.lnk? Why should > it be '~/.wine' rather than '~/.wine-steam', '~/.wine-office' or > something else? Maybe rather than storying the information in memory and creating it at

Re: xdg_user_dirs patches

2007-12-02 Thread Francois Gouget
On Sat, 1 Dec 2007, Steven Edwards wrote: [...] > What this means is that on logon or logoff the WM would call our > function and generate these fake Shortcuts for the *.lnk files by > running a copy of winepath after calling the Wine shelllink processor. > The results of winepath would translate '

Re: PATCH: fix out of range array access in dlls/kernel32/relay16.c (fwd)

2007-12-02 Thread Gerald Pfeifer
On Thu, 29 Nov 2007, Alexandre Julliard wrote: >> I checked again and if we don't address this we'll get two new warnings >> issues in a default build with GCC 4.3. How does the patch below >> look? > Not good, it adds noise to the code for no good reason. Why would gcc > complain about that one?

Re: Error while compiling the wine-0.9.49 in RedHat Linux

2007-12-02 Thread Marcus Meissner
On Sun, Dec 02, 2007 at 01:01:04PM +0100, Pavel Troller wrote: > > James McKenzie wrote: > > > Please also be aware that Wine will NOT build properly with any version > > > of gcc 4.0 > > > > > > > Can you elaborate? I have been building wine with gcc-4.* since forever > > and never had any probl

Re: Error while compiling the wine-0.9.49 in RedHat Linux

2007-12-02 Thread Pavel Troller
> James McKenzie wrote: > > Please also be aware that Wine will NOT build properly with any version > > of gcc 4.0 > > > > Can you elaborate? I have been building wine with gcc-4.* since forever > and never had any problems with that. Currently I'm using gcc 4.2.2 > (Gentoo 4.2.2 p1.0). > > tom

Re: Error while compiling the wine-0.9.49 in RedHat Linux

2007-12-02 Thread Tomas Carnecky
James McKenzie wrote: > Please also be aware that Wine will NOT build properly with any version > of gcc 4.0 > Can you elaborate? I have been building wine with gcc-4.* since forever and never had any problems with that. Currently I'm using gcc 4.2.2 (Gentoo 4.2.2 p1.0). tom