Re: [PATCH] svchost: Implementation of svchost (revised submission)

2007-11-27 Thread Roy Shea
On Tue, Nov 27, 2007 at 03:37:50PM -0600, James Hawkins wrote: > On Nov 27, 2007 3:21 PM, Roy Shea <[EMAIL PROTECTED]> wrote: > > This is a revised and standalone version of svchost patch. Changes in > > this revision include: > > > > - Unicode based with a simple UNICODE to ASCII function used to

Re: d3dx9_xx [patch 2/2] Implementation of the different d3dx9_xx lls

2007-11-27 Thread Maciej Kowalczyk
Hi! > +@ stdcall D3DXVec2Normalize(ptr ptr) d3dx8.D3DXVec3Normalize Shouldn't it be "d3dx8.D3DXVec2Normalize"? This line is copy-pasted 13 times around the patch. -- Maciej Kowalczyk

Re: [PATCH] svchost: Implementation of svchost (revised submission)

2007-11-27 Thread James Hawkins
On Nov 27, 2007 3:21 PM, Roy Shea <[EMAIL PROTECTED]> wrote: > This is a revised and standalone version of svchost patch. Changes in > this revision include: > > - Unicode based with a simple UNICODE to ASCII function used to > convert the lpProcName passed into GetProcAddress > I think you're

Re: [keyboard] GetAsyncKeyState: request for fixing #5623

2007-11-27 Thread Rafał Miłecki
2007/11/26, Stefan Dösinger <[EMAIL PROTECTED]>: > Am Montag, 26. November 2007 12:17:07 schrieb Rafał Miłecki: > > 2007/11/7, Rafał Miłecki <[EMAIL PROTECTED]>: > > > Bug is quite well decribed in: > > > http://bugs.winehq.org/show_bug.cgi?id=5623 but if you don't > > > understand this, I can try

Re: David Adam : d3dx8: Implement D3DXQuaternionInverse.

2007-11-27 Thread David . Adam
Robert Shearman <[EMAIL PROTECTED]> a écrit : > Alexandre Julliard wrote: >> /*_D3DXQUATERNION*/ >> -D3DXQUATERNION* WINAPI D3DXQuaternionMultiply(D3DXQUATERNION * >> pout, CONST D3DXQUATERNION *pq1, CONST D3DXQUATERNION * pq2) >> +D3DXQUATERNION* WINAPI D3DXQu

Re: urlmon: Callback can be NULL

2007-11-27 Thread Alexandre Julliard
Alistair Leslie-Hughes <[EMAIL PROTECTED]> writes: > Hi, > Changelog: > urlmon: The callback parameter can be null, check pointer before using. This breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so stream.c && touch stream.ok stream.c:2

Re: d3dx8: Implementation of WINAPI D3DXAssembleShaderFromFileA

2007-11-27 Thread Michael Stefaniuc
Frank Richter wrote: > On 27.11.2007 09:28, Michael Stefaniuc wrote: >> Just go for >> if ( !pSrcFile ) >>return D3DXERR_INVALIDDATA; >> >> LPWSTR pSrcFileW = NULL; >> DWORD len; >> HRESULT ret; >> ... > > That's C++, not C, isn't it? No it is C as C99 allows to have the variable definitions i

Re: d3dx8: Implementation of WINAPI D3DXAssembleShaderFromFileA

2007-11-27 Thread Frank Richter
On 27.11.2007 09:28, Michael Stefaniuc wrote: > Just go for > if ( !pSrcFile ) >return D3DXERR_INVALIDDATA; > > LPWSTR pSrcFileW = NULL; > DWORD len; > HRESULT ret; > ... That's C++, not C, isn't it? -f.r.

Re: urlmon: Wrap heap functions.

2007-11-27 Thread Michael Stefaniuc
Alexandre Julliard wrote: > Michael Stefaniuc <[EMAIL PROTECTED]> writes: > >> I therefor propose to standardize all the internal HeapAlloc wrappers to >> a common name and form, Something along the lines of: >> walloc() >> wzalloc() >> wrealloc() >> wzrealloc() >> wfree() >> It's short and concis

Re: urlmon: Wrap heap functions.

2007-11-27 Thread Alexandre Julliard
Michael Stefaniuc <[EMAIL PROTECTED]> writes: > I therefor propose to standardize all the internal HeapAlloc wrappers to > a common name and form, Something along the lines of: > walloc() > wzalloc() > wrealloc() > wzrealloc() > wfree() > It's short and concise and doesn't conflict with the Win32

Re: user32: Fix a couple of typos

2007-11-27 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > Changelog: > user32: Fix a couple of typos. The patch is clearly correct but it causes test failures, so it looks like more work is needed here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so dde.c && touch dde.o

Re: msvcrt heap: fix _aligned_offset_realloc (move correct block of memory); add a comment to explain why. [1/2]

2007-11-27 Thread Alexandre Julliard
Lionel Debroux <[EMAIL PROTECTED]> writes: > + Therefore, "size" bytes of actual data have to be moved from the offset > + they were at in the old block (temp + old_padding) to the offset they > + have to be in the new block (temp + new_padding == memblock). > +*/ > if (new_padding != o

Re: Reading Registry Example

2007-11-27 Thread Alexander Nicolaysen Sørnes
On Tuesday 27 November 2007 04:28:07 James McKenzie wrote: > All: > I would like to work on the eventlog.c and would like pointers to an > example of reading a registry example under Wine. > > Thank you. > > James You can access the registry using the same functions that you would use on Windows

Re: USER32: win16 applications should not see long filenames returned from dialog control (try 4) (RESEND)

2007-11-27 Thread Alexandre Julliard
Alex Villací­s Lasso <[EMAIL PROTECTED]> writes: > Changelog: > * Win16 applications should not see long filenames. Change directory > listbox to return short names when called from the 16-bit wrappers. You are still calling GetShortPathName on potentially uninitialized data. You simply can't do

Re: David Adam : d3dx8: Implement D3DXQuaternionInverse.

2007-11-27 Thread Robert Shearman
Alexandre Julliard wrote: /*_D3DXQUATERNION*/ -D3DXQUATERNION* WINAPI D3DXQuaternionMultiply(D3DXQUATERNION * pout, CONST D3DXQUATERNION *pq1, CONST D3DXQUATERNION * pq2) +D3DXQUATERNION* WINAPI D3DXQuaternionInverse(D3DXQUATERNION *pout, CONST D3DXQUATERNION

Re: [dbghelp 1/11] Update some mscvpdb.h definitions and descriptions

2007-11-27 Thread Alexandre Julliard
"Jason Green" <[EMAIL PROTECTED]> writes: > The Original Author for the following set of patches is Eric van > Beurden from TransGaming, Inc. When submitting patches written by someone else please include a valid From: line in the patch header with his full name and email. -- Alexandre Julliard

Re: [dbghelp 2/11] Return TRUE in SymInitializeW if process is already initialized and add a number of TRACEs

2007-11-27 Thread Alexandre Julliard
"Jason Green" <[EMAIL PROTECTED]> writes: > @@ -216,11 +216,17 @@ static BOOL WINAPI process_invade_cb(PCSTR name, ULONG > base, ULONG size, PVOID u > chartmp[MAX_PATH]; > HANDLE hProcess = (HANDLE)user; > > -if (!GetModuleFileNameExA(hProcess, (HMODULE)base, > -

Re: d3dx8: Implementation of D3DXAssembleShaderFromFileA

2007-11-27 Thread Dmitry Timoshkov
<[EMAIL PROTECTED]> wrote: > else eliminated Did you actually compile it? If you did, did you see a warning you introduced? -- Dmitry.

Reading Registry Example

2007-11-27 Thread James McKenzie
All: I would like to work on the eventlog.c and would like pointers to an example of reading a registry example under Wine. Thank you. James

Re: modified: dlls/d3dx8/d3dx8_main.c modified: include/d3dx8core.h

2007-11-27 Thread Stefan Dösinger
Am Dienstag, 27. November 2007 10:24:55 schrieb [EMAIL PROTECTED]: > else eliminated. > > --- > dlls/d3dx8/d3dx8_main.c | 18 +- > include/d3dx8core.h |2 +- > 2 files changed, 14 insertions(+), 6 deletions(-) Wrong mailing list? signature.asc Description: This is a dig

Re: TransGaming's dpnet (DirectPlay 8)

2007-11-27 Thread Kai Blin
On Wednesday 21 November 2007 05:42:18 Gavriel State wrote: > Enclosed here is a patch to today's WineHQ git tree with our dpnet > implementation in the hopes that someone finds it useful. Beyond > ensuring that it compiles and links, it has not been tested at all with > WineHQ. That's funny, it

modified: dlls/d3dx8/d3dx8_main.c modified: include/d3dx8core.h

2007-11-27 Thread luis . busquets
else eliminated. --- dlls/d3dx8/d3dx8_main.c | 18 +- include/d3dx8core.h |2 +- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/dlls/d3dx8/d3dx8_main.c b/dlls/d3dx8/d3dx8_main.c index 9221221..81a1eca 100644 --- a/dlls/d3dx8/d3dx8_main.c +++ b/dlls/d3dx8

Re: d3dx8: Implementation of WINAPI D3DXAssembleShaderFromFileA

2007-11-27 Thread Michael Stefaniuc
[EMAIL PROTECTED] wrote: > I say that it is more readable because I understood you wanted the return > code as soon as possible, but, anyway, what would you propose as code for > this function? > > Would the following work for you? Just go for if ( !pSrcFile ) return D3DXERR_INVALIDDATA; LPWST

Re: Some thoughts about next GSoC

2007-11-27 Thread Kai Blin
On Thursday 22 November 2007 11:38:19 Kai Blin wrote: > Comments? Thanks for the comments so far. I'll just go and flesh out the wiki page some more during next week, then we can talk about the individual steps if people think they need discussion. Cheers, Kai -- Kai Blin WorldForge develope